Re: [GOLDSTAR] Re: [PATCH] Check for existence of the path before processing '..'

2013-06-17 Thread Corinna Vinschen
On Jun 17 16:37, Fedin Pavel wrote: > Hello! > How can i contact you in private ? The address specified in messages > can be used only within the list, and the server forces me to cc: to > the public. That's deliberate, of course ;) If it's something which requires privacy you can try the add

RE: [GOLDSTAR] Re: [PATCH] Check for existence of the path before processing '..'

2013-06-17 Thread Fedin Pavel
Hello! How can i contact you in private ? The address specified in messages can be used only within the list, and the server forces me to cc: to the public. > Btw., Fedin, even if I let this go in under the trivial patch rule, it > would be very nice if you could fill out the Cygwin copyright >

RE: [GOLDSTAR] Re: [PATCH] Check for existence of the path before processing '..'

2013-06-13 Thread Fedin Pavel
Hello! > FYI, I just uploaded a new 32 bit snapshot, as well as the 64 bit test > package 1.7.21-2 containing this patch. > > Please give it a try. I have tested new Cygwin64 using original case, by attempting to rebuild eglibc (ARM-Linux targeted cross-build) from scratch (make clean; make).

RE: [PATCH] Check for existence of the path before processing '..'

2013-06-12 Thread Fedin Pavel
Hello! Sorry for delayed replies, at home i'm not subscribed to Cygwin ML, and in Russia we had a holiday yesterday. > Thanks for the patch. The idea sounds good, and I think it's the right > thing to do *not* to add this to normalize_win32_path, because the .. > semantics on WINdows are so tha

Re: [GOLDSTAR] Re: [PATCH] Check for existence of the path before processing '..'

2013-06-12 Thread Andrew Schulman
> Cgf and I talked privately about this patch and we're both happy you > found such a simple solution to fix a long-standing problem. Sometimes, > when you're working long enough on some code, you just miss to see the > wood for the trees. > > Andrew, can you please polish one of the goldstar's i

Re: [GOLDSTAR] Re: [PATCH] Check for existence of the path before processing '..'

2013-06-12 Thread Corinna Vinschen
On Jun 12 19:46, Corinna Vinschen wrote: > Hi Fedin, > > On Jun 11 17:08, Fedin Pavel wrote: > > Hello! > > > > Some time ago i reported ability to access things like > > "/usr/nonexistent/..bin". I still had this problem and i tried my hands on > > fixing it. > > The patch works by checking t

[GOLDSTAR] Re: [PATCH] Check for existence of the path before processing '..'

2013-06-12 Thread Corinna Vinschen
Hi Fedin, On Jun 11 17:08, Fedin Pavel wrote: > Hello! > > Some time ago i reported ability to access things like > "/usr/nonexistent/..bin". I still had this problem and i tried my hands on > fixing it. > The patch works by checking the actual existence of the path before > removing the last

Re: [PATCH] Check for existence of the path before processing '..'

2013-06-11 Thread Corinna Vinschen
On Jun 11 11:17, Christopher Faylor wrote: > On Tue, Jun 11, 2013 at 05:04:46PM +0200, Corinna Vinschen wrote: > >On Jun 11 10:20, Christopher Faylor wrote: > >> You introduce a check_parent flag which is set every time a non-slash > >> character is found. That doesn't seem right. It seems like i

Re: [PATCH] Check for existence of the path before processing '..'

2013-06-11 Thread Corinna Vinschen
On Jun 11 11:17, Christopher Faylor wrote: > On Tue, Jun 11, 2013 at 05:04:46PM +0200, Corinna Vinschen wrote: > >I don't see how do this without calling path_conv, though. You have to > >perform the full conversion on the parent path, with symlinks and > >everything to get the right result. > >

Re: [PATCH] Check for existence of the path before processing '..'

2013-06-11 Thread Christopher Faylor
On Tue, Jun 11, 2013 at 05:04:46PM +0200, Corinna Vinschen wrote: >On Jun 11 10:20, Christopher Faylor wrote: >> On Tue, Jun 11, 2013 at 05:08:13PM +0400, Fedin Pavel wrote: >> > Hello! >> > >> > Some time ago i reported ability to access things like >> >"/usr/nonexistent/..bin". I still had this p

Re: [PATCH] Check for existence of the path before processing '..'

2013-06-11 Thread Corinna Vinschen
On Jun 11 17:04, Corinna Vinschen wrote: > On Jun 11 10:20, Christopher Faylor wrote: > > On Tue, Jun 11, 2013 at 05:08:13PM +0400, Fedin Pavel wrote: > > > Hello! > > > > > > Some time ago i reported ability to access things like > > >"/usr/nonexistent/..bin". I still had this problem and i tried

Re: [PATCH] Check for existence of the path before processing '..'

2013-06-11 Thread Corinna Vinschen
On Jun 11 10:20, Christopher Faylor wrote: > On Tue, Jun 11, 2013 at 05:08:13PM +0400, Fedin Pavel wrote: > > Hello! > > > > Some time ago i reported ability to access things like > >"/usr/nonexistent/..bin". I still had this problem and i tried my hands on > >fixing it. > > The patch works by chec

Re: [PATCH] Check for existence of the path before processing '..'

2013-06-11 Thread Christopher Faylor
On Tue, Jun 11, 2013 at 05:08:13PM +0400, Fedin Pavel wrote: > Hello! > > Some time ago i reported ability to access things like >"/usr/nonexistent/..bin". I still had this problem and i tried my hands on >fixing it. > The patch works by checking the actual existence of the path before >removing th

Re: [PATCH] Check for existence of the path before processing '..'

2013-06-11 Thread Corinna Vinschen
Hi Ferdin, On Jun 11 17:08, Fedin Pavel wrote: > Hello! > > Some time ago i reported ability to access things like > "/usr/nonexistent/..bin". I still had this problem and i tried my hands on > fixing it. > The patch works by checking the actual existence of the path before > removing the last

[PATCH] Check for existence of the path before processing '..'

2013-06-11 Thread Fedin Pavel
Hello! Some time ago i reported ability to access things like "/usr/nonexistent/..bin". I still had this problem and i tried my hands on fixing it. The patch works by checking the actual existence of the path before removing the last component from it. For performance reasons, only one check is