Re: [commit: integer-simple] master: Don't define our own list type (44dd630)

2011-09-18 Thread Ian Lynagh
On Sat, Sep 17, 2011 at 11:48:13PM +0100, Ian Lynagh wrote: > On Sat, Sep 17, 2011 at 03:28:04PM -0700, Ian Lynagh wrote: > > > > commit 44dd630632f47bec3693ea9a22a896edfad15fd7 > > I didn't intend to push these. I think I have a detached HEAD. > > So the central repo is now at 44dd63, and my lo

Re: [commit: integer-simple] master: Don't define our own list type (44dd630)

2011-09-17 Thread Ian Lynagh
On Sat, Sep 17, 2011 at 03:28:04PM -0700, Ian Lynagh wrote: > > commit 44dd630632f47bec3693ea9a22a896edfad15fd7 I didn't intend to push these. I think I have a detached HEAD. So the central repo is now at 44dd63, and my local repo is at 9d7337. What's the right way to end up with the master repo

Re: integer-simple

2011-08-06 Thread Ian Lynagh
On Tue, Aug 02, 2011 at 07:41:29AM +, Simon Peyton-Jones wrote: > > * Ian: make the code in integer-simple use simpler pattern matching. Ian, > done? Done! Thanks Ian ___ Cvs-ghc mailing list Cvs-ghc@haskell.org http://www.haskell.or

RE: integer-simple

2011-08-02 Thread Simon Peyton-Jones
So are we agreed: * Ian: make the code in integer-simple use simpler pattern matching. Ian, done? * Document the issue. Ian has done this already in http://hackage.haskell.org/trac/ghc/wiki/Commentary/Libraries. I've just added a dump of the error message, for easier grepping.

Re: integer-simple

2011-08-01 Thread Simon Marlow
On 01/08/2011 14:15, Simon Peyton-Jones wrote: It's all regrettably delicate, but I think the simplest thing to do is to write integer-simple using either case expressions direct, or function definitions that trivially desugar into case expressions. Ie not this: xorDigits None

RE: integer-simple

2011-08-01 Thread Simon Peyton-Jones
It's all regrettably delicate, but I think the simplest thing to do is to write integer-simple using either case expressions direct, or function definitions that trivially desugar into case expressions. Ie not this: xorDigits None (!ds) = ds xorDigits (!ds)

Re: integer-simple

2011-08-01 Thread Max Bolingbroke
On 1 August 2011 08:54, Max Bolingbroke wrote: > They seem to originate from using bang patterns in the definitions: I just checked and the bangs are irrelevant. It's just a general behaviour of the pattern match desugarer where it generates code for situations it could potentially see are imposs

Re: integer-simple

2011-08-01 Thread Max Bolingbroke
On 1 August 2011 08:09, Simon Peyton-Jones wrote: > I’m guessing here, but I bet I know what’s going on.  If integer-simple uses > inexhaustive pattern matching, GHC will generate calls to ‘patError’ for the > missing cases. That in turn generates a dependency on base, which is where &

patch applied (ghc): Add integer-simple as a build option

2009-07-22 Thread Ian Lynagh
Tue Jul 21 18:31:37 PDT 2009 Ian Lynagh * Add integer-simple as a build option M ./ghc.mk +10 M ./packages +1 View patch online: http://darcs.haskell.org/ghc/_darcs/patches/20090722013137-3fd76-d711d120fbc5cf9230fe0c5cd0fe1e891b36c427.gz