Re: darcs patch: Add support for interruptible FFI calls (version 2)

2010-09-08 Thread Edward Z. Yang
Excerpts from Simon Marlow's message of Wed Sep 08 04:34:05 -0400 2010: > The patch doesn't compile for me: > > compiler/hsSyn/Convert.lhs:373:22: > Not in scope: data constructor `Interruptible' This is because I have some unrecorded changes in template-haskell library. I've sent the patch.

Re: darcs patch: Add support for interruptible FFI calls (version 2)

2010-09-08 Thread Simon Marlow
The patch doesn't compile for me: compiler/hsSyn/Convert.lhs:373:22: Not in scope: data constructor `Interruptible' One idea that occurred to me for bound threads: instead of pthread_cancel(), we could try pthread_kill() with a suitable signal, which should be enough to kick the thread out

Re: darcs patch: Add support for interruptible FFI calls.

2010-09-02 Thread Edward Z. Yang
Submitted updated patch. The updated patch successfully runs the validate script with zero unexpected errors, and I have submitted a testsuite patch with two simple tests for this functionality (specifically, ensuring that it works and that the Template Haskell manipulation works.) There is one d

Re: darcs patch: Add support for interruptible FFI calls.

2010-09-02 Thread Simon Marlow
Thanks for the contribution! Patch review follows. It's almost ready to go in. The compiler parts are fine, the only difficulties I see are: On 02/09/2010 06:16, Edward Z. Yang wrote: -- data InlineSpec = inlineSpecNoPhaseIdKey, inlineSpecPhaseIdKey :: Unique hunk ./compiler/hsSyn/Conve