Re: ``Orphan instances'' should be avoided anyway.

On Tue, 12 Aug 2008 [EMAIL PROTECTED] wrote: > I just would like to point out that there is nothing inherently bad about > what GHC calls ``orphan instances''. > > From a code structuring point of view, > I frequently ``consider orphan'' instances > useful for separation of concerns. The problem

-Wall -Werror

Duncan Coutts wrote: $ head -1 time/Data/Time/Calendar/Gregorian.hs {-# OPTIONS -Wall -Werror #-} (in actual fact, we don't even build GHC/bootlibs with -Werror except when validating). Ah, so that's the culprit. I prefer this, actually, as we get to discover issues sooner rather than later

Orphan Instances

Simon Peyton-Jones wrote: > Who is responsible for the time/ library? I am. Now that orphan warnings are "proper warnings" as Duncan requested, What is an orphan instance, and why do we care about them? Since they weren't proper warnings before, I always assumed they were some weird GHC th

darcs push trouble

This is what I get: Finished applying... error: Unable to append to /srv/darcs/git/ghc/.git/logs/refs/heads/ master: Permission denied fatal: cannot update HEAD ref /srv/darcs/bin/darcs-to-git:86:in `run': Failed to run: ["git-commit", "-a", "-m", "The dph packages still contain warnings"] (R

patch applied (ghc): Use dph-{seq|par} instead of dph_{seq|par}

Mon Aug 11 19:19:39 PDT 2008 Roman Leshchinskiy <[EMAIL PROTECTED]> * Use dph-{seq|par} instead of dph_{seq|par} M ./libraries/Makefile -8 +8 View patch online: http://darcs.haskell.org/ghc/_darcs/patches/20080812021939-b2b0a-3cd42fb38107a6df10f361a57240a29036e3d0fa.gz ___

patch applied (ghc): Simplify how we build dph

Sat Aug 9 13:38:03 PDT 2008 Ian Lynagh <[EMAIL PROTECTED]> * Simplify how we build dph M ./libraries/Makefile -15 +28 View patch online: http://darcs.haskell.org/ghc/_darcs/patches/20080809203803-3fd76-7b5452d10043cb45565f64c65dffd5842fe77f18.gz __

patch applied (ghc): Generalise libraries/Makefile.local

Sat Aug 9 09:18:38 PDT 2008 Ian Lynagh <[EMAIL PROTECTED]> * Generalise libraries/Makefile.local It's now possible to build libraries in, e.g., libraries/foo/bar rather than just libraries/foo M ./libraries/Makefile.local -1 +1 A ./libraries/defineTOP.mk View patch onl

patch applied (ghc): The dph packages still contain warnings

Sat Aug 9 09:18:15 PDT 2008 Ian Lynagh <[EMAIL PROTECTED]> * The dph packages still contain warnings M ./libraries/Makefile.local -1 +1 View patch online: http://darcs.haskell.org/ghc/_darcs/patches/20080809161815-3fd76-77e4aa39269b5f99771f57d2d7dc9c73448135b0.gz

Re: [nightly] 10-Aug-2008 build of HEAD on i386-unknown-linux (cam-02-unx.europe.corp.microsoft.com)

On Tue, 2008-08-12 at 00:33 +0100, Ian Lynagh wrote: > On Mon, Aug 11, 2008 at 12:16:08PM +0100, Duncan Coutts wrote: > > > > > Who is responsible for the time/ library? > > > > I think we should not build the non-core libs with -Werror. > > We don't, but: > > $ head -1 time/Data/Time/Calendar/

Re: [nightly] 10-Aug-2008 build of HEAD on i386-unknown-linux(cam-02-unx.europe.corp.microsoft.com)

On Mon, Aug 11, 2008 at 06:53:07PM +0100, Malcolm Wallace wrote: > > To put it crudely, I don't see why the Hugs and nhc98 developers > should be forced to run a ghc validate, when the ghc developers never > run their changes through Hugs or nhc98 to check for breakage there. > > Now there is

Re: [nightly] 10-Aug-2008 build of HEAD on i386-unknown-linux (cam-02-unx.europe.corp.microsoft.com)

On Mon, Aug 11, 2008 at 12:16:08PM +0100, Duncan Coutts wrote: > > > Who is responsible for the time/ library? > > I think we should not build the non-core libs with -Werror. We don't, but: $ head -1 time/Data/Time/Calendar/Gregorian.hs {-# OPTIONS -Wall -Werror #-} (in actual fact, we don't e

Re: [nightly] 10-Aug-2008 build of HEADoni386-unknown-linux(cam-02-unx.europe.corp.microsoft.com)

ghc <-> corelibs, ghc -> extralibs hugs -> corelibs+extralibs, ??hugslibs -> hugs nhc98 -> corelibs+extralibs, ??nhclibs -> nhc98 Actually, there are several forms of dependency: - changing the libraries cannot break hugs itself, but can make it unable to load or use any libraries,

Re: [nightly] 10-Aug-2008 build of HEAD oni386-unknown-linux(cam-02-unx.europe.corp.microsoft.com)

1. whatever I check in, the _whole_ thing has to build ok 2. if _my_ changes break someone else's code, _I_ have to fix that I'd suggest to interpret GHC+corelibs as a unit, and to apply rules 1 and 2. I was thinking of a unit of concern, not of any ownership or packaging (even the name "

[nightly] 11-Aug-2008 build of HEAD on i386-unknown-linux (cam-02-unx.europe.corp.microsoft.com)

Build description = HEAD on i386-unknown-linux (cam-02-unx.europe.corp.microsoft.com) Build location= /playpen/simonmar/nightly/HEAD Build config file = /home/simonmar/nightly/site/msrc/conf-HEAD-cam-02-unx Nightly build started on cam-02-unx at Mon Aug 11 18:02:08 BST 2008. checking out

Re: [nightly] 10-Aug-2008 build of HEAD on i386-unknown-linux(cam-02-unx.europe.corp.microsoft.com)

1. whatever I check in, the _whole_ thing has to build ok 2. if _my_ changes break someone else's code, _I_ have to fix that I'd suggest to interpret GHC+corelibs as a unit, and to apply rules 1 and 2. To put it crudely, I don't see why the Hugs and nhc98 developers should be forced to

Re: [nightly] 10-Aug-2008 build of HEAD on i386-unknown-linux(cam-02-unx.europe.corp.microsoft.com)

| I think we should not build the non-core libs with -Werror. It makes | perfect sense for the core libs where the ghc team effectively maintains | them, but not for non-core ones. But time *is* a core lib. Similarly containers, pretty, filepath, directory... The full list is below. GHC is si

patch applied (testsuite): Update output

Mon Aug 11 07:49:17 PDT 2008 [EMAIL PROTECTED] * Update output M ./tests/ghc-regress/simplCore/should_run/T2486.stderr -12 +12 View patch online: http://darcs.haskell.org/testsuite/_darcs/patches/20080811144917-1287e-0d84e9b93304d6155baae6e1194597a6a856ffd7.gz

patch applied (ghc): Print tidy rules in user style, to avoid gratuitous uniques

Mon Aug 11 07:42:57 PDT 2008 [EMAIL PROTECTED] * Print tidy rules in user style, to avoid gratuitous uniques The uniques that come out in dumpStyle make it harder to compare output in the testsuite. And the rules are tidied, so uniques are not necessary. If you want the uniques, use -

patch applied (ghc): Export Depth (needed for mkUserStyle); collapse identical PrintUnqualified, QueryQualifies

Mon Aug 11 07:42:08 PDT 2008 [EMAIL PROTECTED] * Export Depth (needed for mkUserStyle); collapse identical PrintUnqualified, QueryQualifies M ./compiler/utils/Outputable.lhs -5 +3 View patch online: http://darcs.haskell.org/ghc/_darcs/patches/20080811144208-1287e-3ac80b0bd48d72788925fb4f9

patch applied (ghc): When suppressing uniques, don't print the separating underscore

Mon Aug 11 07:41:18 PDT 2008 [EMAIL PROTECTED] * When suppressing uniques, don't print the separating underscore M ./compiler/basicTypes/Name.lhs -3 +11 View patch online: http://darcs.haskell.org/ghc/_darcs/patches/20080811144118-1287e-ce1d9191e412a325f436c3f2383aaeefd0dbb323.gz

patch applied (ghc): Make -dsuppress-uniques apply regardless of -ppr-debug

Mon Aug 11 07:40:32 PDT 2008 [EMAIL PROTECTED] * Make -dsuppress-uniques apply regardless of -ppr-debug M ./compiler/basicTypes/Unique.lhs -1 +1 View patch online: http://darcs.haskell.org/ghc/_darcs/patches/20080811144032-1287e-01eee12b1b17f63cb5124e8e74000b29a832df4f.gz

patch applied (ghc): Fix Trac #2367: selectors for GADTs

Mon Aug 11 05:35:26 PDT 2008 [EMAIL PROTECTED] * Fix Trac #2367: selectors for GADTs The generation of record selectors for GADTs and the like was pretty screwed up. This patch fixes it. Note that Unify.refineType is now used only in the generation of record seletctors -- but it r

patch applied (ghc): Mostly fix Trac #2431: make empty case acceptable to (most of) GHC

Mon Aug 11 05:31:58 PDT 2008 [EMAIL PROTECTED] * Mostly fix Trac #2431: make empty case acceptable to (most of) GHC See the comments with Trac #2431. This patch makes an empty HsCase acceptable to the renamer onwards. If you want to accept empty case in Haskell source there's a little

patch applied (ghc): Fix Trac #2412: type synonyms and hs-boot recursion

Mon Aug 11 05:25:23 PDT 2008 [EMAIL PROTECTED] * Fix Trac #2412: type synonyms and hs-boot recursion Max Bolingbroke found this awkward bug, which relates to the way in which hs-boot files are handled. --> HEADS UP: interface file format change: recompile everything! When we

patch applied (testsuite): Update output

Mon Aug 11 06:28:13 PDT 2008 [EMAIL PROTECTED] * Update output M ./tests/ghc-regress/typecheck/should_compile/T2494.stderr -9 +9 View patch online: http://darcs.haskell.org/testsuite/_darcs/patches/20080811132813-1287e-b27c48463438053be941e74d904dac2ab11c8032.gz __

patch applied (testsuite): Add test for empty cases; update output for braces in HsCase printing

Mon Aug 11 05:51:47 PDT 2008 [EMAIL PROTECTED] * Add test for empty cases; update output for braces in HsCase printing All to support Trac #2431 M ./tests/ghc-regress/gadt/gadt-escape1.stderr -2 +2 M ./tests/ghc-regress/gadt/gadt7.stderr -2 +2 M ./tests/ghc-regress/indexed-t

RE: [nightly] 10-Aug-2008 build of HEAD on i386-unknown-linux (cam-02-unx.europe.corp.microsoft.com)

On Mon, 2008-08-11 at 12:27 +0100, Simon Peyton-Jones wrote: > | I think we should not build the non-core libs with -Werror. It makes > | perfect sense for the core libs where the ghc team effectively maintains > | them, but not for non-core ones. > > But time *is* a core lib. Similarly container

patch applied (testsuite): Test Trac #2494

Mon Aug 11 04:56:52 PDT 2008 [EMAIL PROTECTED] * Test Trac #2494 A ./tests/ghc-regress/typecheck/should_compile/T2494-2.hs A ./tests/ghc-regress/typecheck/should_compile/T2494.hs A ./tests/ghc-regress/typecheck/should_compile/T2494.stderr M ./tests/ghc-regress/typecheck/should_c

patch applied (testsuite): Test Trac #2506

Mon Aug 11 04:46:57 PDT 2008 [EMAIL PROTECTED] * Test Trac #2506 A ./tests/ghc-regress/rename/should_compile/T2506.hs M ./tests/ghc-regress/rename/should_compile/all.T +1 View patch online: http://darcs.haskell.org/testsuite/_darcs/patches/2008084657-1287e-7ba74655bef83f1d180c7ed8f

patch applied (testsuite): Test Trac #2486

Mon Aug 11 04:45:44 PDT 2008 [EMAIL PROTECTED] * Test Trac #2486 A ./tests/ghc-regress/simplCore/should_run/T2486.hs A ./tests/ghc-regress/simplCore/should_run/T2486.stderr M ./tests/ghc-regress/simplCore/should_run/all.T +5 View patch online: http://darcs.haskell.org/testsuite/_da

patch applied (testsuite): Make the gadt-records test work even during fast validate

Wed Aug 6 09:07:32 PDT 2008 [EMAIL PROTECTED] * Make the gadt-records test work even during fast validate M ./tests/ghc-regress/gadt/all.T +3 View patch online: http://darcs.haskell.org/testsuite/_darcs/patches/20080806160732-1287e-de1ea9d5ade7a774654b966532d5939eea7076dc.gz

patch applied (testsuite): TAG 2008-08-07

Thu Aug 7 08:47:02 PDT 2008 Ian Lynagh <[EMAIL PROTECTED]> tagged 2008-08-07 View patch online: http://darcs.haskell.org/testsuite/_darcs/patches/20080807154702-3fd76-1762b803b5757875739cf2aa40368c8d8972fd18.gz ___ Cvs-ghc mailing list Cvs-ghc@hask

RE: [nightly] 10-Aug-2008 build of HEAD on i386-unknown-linux (cam-02-unx.europe.corp.microsoft.com)

| I think we should not build the non-core libs with -Werror. It makes | perfect sense for the core libs where the ghc team effectively maintains | them, but not for non-core ones. But time *is* a core lib. Similarly containers, pretty, filepath, directory... The full list is below. GHC is sim

RE: [nightly] 10-Aug-2008 build of HEAD on i386-unknown-linux (cam-02-unx.europe.corp.microsoft.com)

On Mon, 2008-08-11 at 08:25 +0100, Simon Peyton-Jones wrote: > | Data/Time/Calendar/Gregorian.hs:73:9: > | Warning: orphan instance: instance Show Day > | > | : > | Failing due to -Werror. > | > | gmake[2]: *** [dist/build/Data/Time/Calendar/Gregorian.o] Error 1 > | gmake[2]: Leaving directory

patch applied (ghc): Fix Trac #2506: infix assert

Mon Aug 11 03:50:11 PDT 2008 [EMAIL PROTECTED] * Fix Trac #2506: infix assert M ./compiler/rename/RnExpr.lhs -26 +36 View patch online: http://darcs.haskell.org/ghc/_darcs/patches/20080811105011-1287e-fe48a6d2bf61f88ce841189eedcbfa7c31478614.gz

patch applied (ghc): Use do-notation

Mon Aug 11 03:49:49 PDT 2008 [EMAIL PROTECTED] * Use do-notation M ./compiler/rename/RnSource.lhs -7 +8 View patch online: http://darcs.haskell.org/ghc/_darcs/patches/20080811104949-1287e-ceb989b85c8e1966f97f3673f86d78448d3eb462.gz ___ Cvs-ghc m

patch applied (ghc): Fix Trac #2494: tcSimplifyRuleLhs

Mon Aug 11 03:44:38 PDT 2008 [EMAIL PROTECTED] * Fix Trac #2494: tcSimplifyRuleLhs tcSimplifyRuleLhs is a cut-down constraint simplifier, intended for use in RULE left-hand-sides. But it was written before implication constraints, and the exmaple of this bug report shows that when high

patch applied (ghc): Make comparison on equalities work right (ie look at the types)

Mon Aug 11 03:40:11 PDT 2008 [EMAIL PROTECTED] * Make comparison on equalities work right (ie look at the types) This patch makes (s1~t1) == (s2~t2) iff s1==s2, t1==t2 The comparison and equality instances for Insts are really only used in making the AvailEnv in TcSimplify, w

patch applied (ghc): Minor refactoring; no functionality change

Mon Aug 11 03:38:21 PDT 2008 [EMAIL PROTECTED] * Minor refactoring; no functionality change M ./compiler/specialise/Specialise.lhs -4 +8 View patch online: http://darcs.haskell.org/ghc/_darcs/patches/20080811103821-1287e-fb9a3fb0cd773abeeff9a91d6c4ec05737a42b4d.gz

patch applied (ghc): Fix Trac #2486: restore the specialiser to a working state

Sat Aug 9 09:31:23 PDT 2008 [EMAIL PROTECTED] * Fix Trac #2486: restore the specialiser to a working state In improving the specialiser's data reprsentaion, thus Mon Apr 28 16:57:11 GMT Daylight Time 2008 [EMAIL PROTECTED] * Fix Trac #1969: perfomance bug in the specialiser I go

Daily report for stable

Build results: tnaur PPC OSX stable 2: pass tnaur x86 Linux stable: pass x86 Windows stable: fail (failed stage1) x86 Windows stable fast: pass lost pass pass pass pass x86-64 Linux stable: fail (failed stage1) Old unexpected test failures: TyFamUndec 7 gabor stable b

RE: [nightly] 10-Aug-2008 build of HEAD on i386-unknown-linux (cam-02-unx.europe.corp.microsoft.com)

| -fgenerics -Wall -fno-warn-deprecated-flags -c Data/Time/Calendar/Gregorian.hs -o | dist/build/Data/Time/Calendar/Gregorian.o -ohi dist/build/Data/Time/Calendar/Gregorian.hi | | Data/Time/Calendar/Gregorian.hs:73:9: | Warning: orphan instance: instance Show Day | | : | Failing due to -Werr