On Sun, 28 Apr 2024 09:54:34 GMT, Viktor Klang wrote:
> Primarily offering this PR for discussion, as Throwables throwing exceptions
> on toString(), getLocalizedMessage(), or getMessage() seems like a rather
> unreasonable thing to do.
>
> Nevertheless, there is some things we can do, as witn
On Mon, 4 Dec 2023 13:56:55 GMT, Doug Lea wrote:
>> This update cascades timeouts to trim subsequent workers after the first
>> keepAlive inactive period.
>
> Doug Lea has updated the pull request with a new target base due to a merge
> or a rebase. The incremental webrev excludes the unrelate
On Fri, 12 Jan 2024 13:41:39 GMT, kerr wrote:
>> Doug Lea has updated the pull request with a new target base due to a merge
>> or a rebase. The incremental webrev excludes the unrelated changes brought
>> in by the merge/rebase. The pull request contains 10 additional com
On Mon, 4 Dec 2023 13:56:55 GMT, Doug Lea wrote:
>> This update cascades timeouts to trim subsequent workers after the first
>> keepAlive inactive period.
>
> Doug Lea has updated the pull request with a new target base due to a merge
> or a rebase. The incremental webrev excludes the unrelate
On Sat, 11 Jan 2025 07:10:53 GMT, He-Pin(kerr) wrote:
> Motivation:
> When a user passes a wrong parameter, the current implementation throws an
> IllegalArgumentException with an error message `null`, which is not helpful.
>
> Modification:
> Add detail error messages.
>
Motivation:
When a user passes a wrong parameter, the current implementation throws an
IllegalArgumentException with an error message `null`, which is not helpful.
Modification:
Add detail error messages.
Result:
Helpful messages.
-
Commit messages:
- .
- chore: add messages for
On Sat, 11 Jan 2025 07:10:53 GMT, He-Pin(kerr) wrote:
> Motivation:
> When a user passes a wrong parameter, the current implementation throws an
> IllegalArgumentException with an error message `null`, which is not helpful.
>
> Modification:
> Add detail error messages.
>
On Mon, 13 Jan 2025 16:28:52 GMT, Viktor Klang wrote:
> Seems sensible to improve this given that it can be tricky to figure out
> which parameter caused the exception to be thrown.
https://github.com/openjdk/jdk/pull/23050
There is already a pr for this:)
As I encountered this in production
On Mon, 13 Jan 2025 12:59:06 GMT, Viktor Klang wrote:
> Backport to jdk24 of https://bugs.openjdk.org/browse/JDK-8347274
Does this fix the OOM problem?
import java.util.stream.Gatherers;
import java.util.stream.IntStream;
/**
* TODO: description of this file
*
* @author 虎鸣
*/
public class
> Motivation:
> When a user passes a wrong parameter, the current implementation throws an
> IllegalArgumentException with an error message `null`, which is not helpful.
>
> Modification:
> Add detail error messages.
>
> Result:
> Helpful messages.
He-Pin(kerr) h
On Fri, 28 Mar 2025 13:19:50 GMT, Viktor Klang wrote:
>> He-Pin(kerr) has updated the pull request incrementally with two additional
>> commits since the last revision:
>>
>> - .
>> - .
>
> test/jdk/java/util/concurrent/tck/ThreadPoolExecuto
> Motivation:
> When a user passes a wrong parameter, the current implementation throws an
> IllegalArgumentException with an error message `null`, which is not helpful.
>
> Modification:
> Add detail error messages.
>
> Result:
> Helpful messages.
He-Pin(kerr) h
> Motivation:
> When a user passes a wrong parameter, the current implementation throws an
> IllegalArgumentException with an error message `null`, which is not helpful.
>
> Modification:
> Add detail error messages.
>
> Result:
> Helpful messages.
He-Pin(kerr) h
> Motivation:
> When a user passes a wrong parameter, the current implementation throws an
> IllegalArgumentException with an error message `null`, which is not helpful.
>
> Modification:
> Add detail error messages.
>
> Result:
> Helpful messages.
He-Pin(kerr) h
On Tue, 20 May 2025 10:11:03 GMT, Viktor Klang wrote:
>> It would be much nicer if you take this one:), we are on JDK 21 and want to
>> have this in the next LTS.
>
> @He-Pin Just pinging you here, in case the notification from my most recent
> comments got lost in transit.
@viktorklang-ora @l
On Sun, 8 Jun 2025 09:07:11 GMT, He-Pin(kerr) wrote:
> Rename auxilliary to auxiliary
This pull request has now been integrated.
Changeset: f07f5ce9
Author:He-Pin(kerr)
Committer: Viktor Klang
URL:
https://git.openjdk.org/jdk/commit/f07f5ce9845c59348dc785cd5ee26391dd7e36c8
St
Rename auxilliary to auxiliary
-
Commit messages:
- chore: Fix typo in DelayScheduler
Changes: https://git.openjdk.org/jdk/pull/25685/files
Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=25685&range=00
Issue: https://bugs.openjdk.org/browse/JDK-8359067
Stats: 1 line in 1 fi
On Sat, 11 Jan 2025 07:10:53 GMT, He-Pin(kerr) wrote:
> Motivation:
> When a user passes a wrong parameter, the current implementation throws an
> IllegalArgumentException with an error message `null`, which is not helpful.
>
> Modification:
> Add detail error messages.
>
18 matches
Mail list logo
