On Thu, 24 Nov 2022 12:06:44 GMT, Alan Bateman wrote:
>> Per Minborg has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Remove redundant method
>
> src/java.base/share/classes/sun/nio/ch/IOUtil.java l
ress` method, that the use of the returned
> address needs to be guarded. It can be discussed if this is preferable or not.
>
> This PR spawns several areas of responsibility and so, I expect more than one
> reviewer before promoting the PR.
Per Minborg has updated the pull request incremen
On Wed, 16 Nov 2022 16:52:50 GMT, Per Minborg wrote:
> This PR proposes to opt in for graphic rendering of the sealed hierarchy of
> the `Reference` class.
>
> Rendering capability was added via https://bugs.openjdk.org/browse/JDK-8295653
>
> Here is how it would look like
On Wed, 16 Nov 2022 16:17:01 GMT, Per Minborg wrote:
> This PR proposes to opt in for graphic rendering of the sealed hierarchy of
> the CallSite class.
>
> Rendering capability was added via https://bugs.openjdk.org/browse/JDK-8295653
>
> Here is how it would look like
On Wed, 16 Nov 2022 15:02:08 GMT, Per Minborg wrote:
> This PR proposes to opt in for graphic rendering of the sealed hierarchy of
> the ConstantDesc class.
>
> Rendering capability was added via https://bugs.openjdk.org/browse/JDK-8295653
>
>
> Here is how it would
On Thu, 24 Nov 2022 16:21:42 GMT, Per Minborg wrote:
>> This PR proposes the introduction of **guarding** of the use of
>> `DirectBuffer::address` within the JDK. With the introduction of the Foreign
>> Function and Memory access, it is possible to derive Buffer instances t
ress` method, that the use of the returned
> address needs to be guarded. It can be discussed if this is preferable or not.
>
> This PR spawns several areas of responsibility and so, I expect more than one
> reviewer before promoting the PR.
Per Minborg has updated the pull request increm
ress` method, that the use of the returned
> address needs to be guarded. It can be discussed if this is preferable or not.
>
> This PR spawns several areas of responsibility and so, I expect more than one
> reviewer before promoting the PR.
Per Minborg has updated the pull request incre
On Wed, 23 Nov 2022 17:33:06 GMT, Maurizio Cimadamore
wrote:
>> This PR contains the API and implementation changes for JEP-434 [1]. A more
>> detailed description of such changes, to avoid repetitions during the review
>> process, is included as a separate comment.
>>
>> [1] - https://openjd
On Mon, 28 Nov 2022 19:35:24 GMT, Paul Sandoz wrote:
> I prefer methods that do not expose the scope implementation so access is
> limited to just to the acquire/release methods, but i am unsure of the
> performance implications. These methods might not reliably inline, and we may
> need to en
be guarded. It can be discussed if this is preferable or not.
>
> This PR spawns several areas of responsibility and so, I expect more than one
> reviewer before promoting the PR.
Per Minborg has updated the pull request incrementally with one additional
commit since the last revision:
Rem
On Tue, 29 Nov 2022 09:40:58 GMT, Per Minborg wrote:
>> This PR proposes the introduction of **guarding** of the use of
>> `DirectBuffer::address` within the JDK. With the introduction of the Foreign
>> Function and Memory access, it is possible to derive Buffer instances t
be guarded. It can be discussed if this is preferable or not.
>
> This PR spawns several areas of responsibility and so, I expect more than one
> reviewer before promoting the PR.
Per Minborg has updated the pull request with a new target base due to a merge
or a rebase. The pull request now co
On Mon, 21 Nov 2022 10:53:07 GMT, Per Minborg wrote:
> This PR proposes the introduction of **guarding** of the use of
> `DirectBuffer::address` within the JDK. With the introduction of the Foreign
> Function and Memory access, it is possible to derive Buffer instances that
> a
This PR suggests renaming various names from "session" to "scope" in accordance
with https://openjdk.org/jeps/434
The PRs contains changes for several sub-components.
-
Commit messages:
- Rename session to scope
Changes: https://git.openjdk.org/jdk/pull/11573/files
Webrev: https:
> This PR suggests renaming various names from "session" to "scope" in
> accordance with https://openjdk.org/jeps/434
>
> The PRs contains changes for several sub-components.
Per Minborg has updated the pull request incrementally with one additional
commit si
On Wed, 7 Dec 2022 21:55:43 GMT, Per Minborg wrote:
> This PR suggests renaming various names from "session" to "scope" in
> accordance with https://openjdk.org/jeps/434
>
> The PRs contains changes for several sub-components.
This pull request has been
On Thu, 8 Dec 2022 08:17:44 GMT, Per Minborg wrote:
>> This PR suggests renaming various names from "session" to "scope" in
>> accordance with https://openjdk.org/jeps/434
>>
>> The PRs contains changes for several sub-components.
>
> Per Minbo
This PR proposes changing variable names and text from "session" to "scope".
The proposed changes are only for the FFM API and not other parts like the
Vector API and test classes.
-
Commit messages:
- Rename session to scope
Changes: https://git.openjdk.org/jdk/pull/11593/files
On Thu, 8 Dec 2022 14:36:52 GMT, Maurizio Cimadamore
wrote:
>> src/java.base/share/classes/jdk/internal/foreign/abi/Binding.java line 255:
>>
>>> 253: * the context's allocator is accessed.
>>> 254: */
>>> 255: public static Context ofScope() {
>>
>> I think `ofArena`
> This PR proposes changing variable names and text from "session" to "scope".
> The proposed changes are only for the FFM API and not other parts like the
> Vector API and test classes.
Per Minborg has updated the pull request incrementally with one additional
c
This PR proposes declaring `AArch64Architecture` and `X86_64Architecture`
`final` and creating a `private` constructor so that this redundant byte code
can be eliminated:
public jdk.internal.foreign.abi.x64.X86_64Architecture();
Code:
0: aload_0
1: invokespecial #1 // Meth
This PR proposes making a field in `RandomAccessFile` final. Also, it
modernises a switch statement.
-
Commit messages:
- Reclare field final and modernize switch
Changes: https://git.openjdk.org/jdk/pull/11632/files
Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=11632&range=00
> This PR proposes making a field in `RandomAccessFile` final. Also, it
> modernises a switch statement.
Per Minborg has updated the pull request incrementally with one additional
commit since the last revision:
Make the field rw final
-
Changes:
- all:
> This PR proposes making a field in `RandomAccessFile` final. Also, it
> modernises a switch statement.
Per Minborg has updated the pull request incrementally with one additional
commit since the last revision:
Remove redundant check
-
Changes:
- all: https://git.openj
On Mon, 12 Dec 2022 12:48:47 GMT, Per Minborg wrote:
> This PR proposes making a field in `RandomAccessFile` final. Also, it
> modernises a switch statement.
This pull request has now been integrated.
Changeset: 81f57d56
Author: Per Minborg
Committer: Roger Riggs
URL:
This PR suggests improving performance for read and write operations for the
longer primitives in `RandomAccessFile`.
These improvements would also propagate to other JDK classes relying on these
improved `RandomAccessFile` operations.
-
Commit messages:
- Perform I/O operations i
> This PR suggests improving performance for read and write operations for the
> longer primitives in `RandomAccessFile`.
>
> These improvements would also propagate to other JDK classes relying on these
> improved `RandomAccessFile` operations.
Per Minborg has updated the pull
On Mon, 12 Dec 2022 08:37:02 GMT, Per Minborg wrote:
> This PR proposes declaring `AArch64Architecture` and `X86_64Architecture`
> `final` and creating a `private` constructor so that this redundant byte code
> can be eliminated:
>
>
> public jdk.internal.foreign.abi.x64.
On Mon, 12 Dec 2022 08:37:02 GMT, Per Minborg wrote:
> This PR proposes declaring `AArch64Architecture` and `X86_64Architecture`
> `final` and creating a `private` constructor so that this redundant byte code
> can be eliminated:
>
>
> public jdk.internal.foreign.abi.x64.
On Thu, 8 Dec 2022 15:57:23 GMT, Per Minborg wrote:
>> This PR proposes changing variable names and text from "session" to "scope".
>> The proposed changes are only for the FFM API and not other parts like the
>> Vector API and test classes.
>
&
On Thu, 8 Dec 2022 14:11:29 GMT, Per Minborg wrote:
> This PR proposes changing variable names and text from "session" to "scope".
> The proposed changes are only for the FFM API and not other parts like the
> Vector API and test classes.
This pull request
This PR proposes changing variable names from `session` to `scope`. The
proposed changes are only for the FFM API and not other parts like the Vector
API and test classes.
-
Commit messages:
- Replace session with scope for FFM access
Changes: https://git.openjdk.org/jdk20/pull/29
On Wed, 14 Dec 2022 09:30:21 GMT, Per Minborg wrote:
> This PR proposes changing variable names from `session` to `scope`. The
> proposed changes are only for the FFM API and not other parts like the Vector
> API and test classes.
This pull request has now been integrated.
> This PR suggests improving performance for read and write operations for the
> longer primitives in `RandomAccessFile`.
>
> These improvements would also propagate to other JDK classes relying on these
> improved `RandomAccessFile` operations.
Per Minborg has updated t
On Thu, 15 Dec 2022 09:56:37 GMT, Per Minborg wrote:
>> This PR suggests improving performance for read and write operations for the
>> longer primitives in `RandomAccessFile`.
>>
>> These improvements would also propagate to other JDK classes relying on
>> th
On Thu, 15 Dec 2022 10:43:35 GMT, Maurizio Cimadamore
wrote:
> This patch fixes some inconsistencies in the javadoc for restricted methods:
>
> * ModuleLayer.Controller::addEnableNativeAccess has a shorted text in its
> `@throws` clause. This shorted text is now used everywhere.
> * One overlo
> This PR suggests improving performance for read and write operations for the
> longer primitives in `RandomAccessFile`.
>
> These improvements would also propagate to other JDK classes relying on these
> improved `RandomAccessFile` operations.
Per Minborg has updated t
> This PR suggests improving performance for read and write operations for the
> longer primitives in `RandomAccessFile`.
>
> These improvements would also propagate to other JDK classes relying on these
> improved `RandomAccessFile` operations.
Per Minborg has updated t
On Tue, 13 Dec 2022 09:11:10 GMT, Per Minborg wrote:
> This PR suggests improving performance for read and write operations for the
> longer primitives in `RandomAccessFile`.
>
> These improvements would also propagate to other JDK classes relying on these
> improved `R
Currently, `java.io.Bits` is using explicit logic to read/write various
primitive types to/from byte arrays. Switching to the use of `VarHandle` access
would provide better performance and less code.
Also, using a standard API for these conversions means future `VarHandle`
improvements will be
On Wed, 4 Jan 2023 08:48:56 GMT, Per Minborg wrote:
> Currently, `java.io.Bits` is using explicit logic to read/write various
> primitive types to/from byte arrays. Switching to the use of `VarHandle`
> access would provide better performance and less code.
>
> Also, using a s
ture `VarHandle`
> improvements will benefit `Bits` too.
>
> Improvements in `Bits` will propagate to `ObjectInputStream`,
> `ObjectOutputStream` and `RandomAccessFile`.
>
> Initial benchmarks and performance discussions can be found here:
> https://github.com/openjdk/panama-foreign/p
On Wed, 4 Jan 2023 09:01:06 GMT, Per Minborg wrote:
>> Currently, `java.io.Bits` is using explicit logic to read/write various
>> primitive types to/from byte arrays. Switching to the use of `VarHandle`
>> access would provide better performance and less code.
>>
&
On Wed, 4 Jan 2023 09:25:40 GMT, Uwe Schindler wrote:
> Do we need this test at all, because this code is tested to extense through
> RandomAccessFile? We had no test before, so why add a new one here?
>
> Otherwise: PR looks good.
There are overlaps of the RAF and Bits tests but the latter te
ture `VarHandle`
> improvements will benefit `Bits` too.
>
> Improvements in `Bits` will propagate to `ObjectInputStream`,
> `ObjectOutputStream` and `RandomAccessFile`.
>
> Initial benchmarks and performance discussions can be found here:
> https://github.com/openjdk/panama-foreign/p
ture `VarHandle`
> improvements will benefit `Bits` too.
>
> Improvements in `Bits` will propagate to `ObjectInputStream`,
> `ObjectOutputStream` and `RandomAccessFile`.
>
> Initial benchmarks and performance discussions can be found here:
> https://github.com/openjdk/panama-foreign/p
On Wed, 4 Jan 2023 10:49:18 GMT, Per Minborg wrote:
>> Do we need this test at all, because this code is tested to extense through
>> RandomAccessFile? We had no test before, so why add a new one here?
>>
>> Otherwise: PR looks good.
>
>> Do we need this
ture `VarHandle`
> improvements will benefit `Bits` too.
>
> Improvements in `Bits` will propagate to `ObjectInputStream`,
> `ObjectOutputStream` and `RandomAccessFile`.
>
> Initial benchmarks and performance discussions can be found here:
> https://github.com/openjdk/panama-foreign/p
Code in java.io contains many legacy constructs and semantics not recommended
including:
* C-style array declaration
* Unnecessary visibility
* Redundant keywords in interfaces (e.g. public, static)
* Non-standard naming for constants
* Javadoc typos
* Missing final declaration
These shou
ture `VarHandle`
> improvements will benefit `Bits` too.
>
> Improvements in `Bits` will propagate to `ObjectInputStream`,
> `ObjectOutputStream` and `RandomAccessFile`.
>
> Initial benchmarks and performance discussions can be found here:
> https://github.com/openjdk/panama-foreign/p
typos
> * Missing final declaration
>
> These should be fixed as a sanity effort.
Per Minborg has updated the pull request incrementally with one additional
commit since the last revision:
Rework StringWriter constructor
-
Changes:
- all: https://git.openjdk.org/jd
On Thu, 5 Jan 2023 01:42:15 GMT, Brian Burkhalter wrote:
>> I assume this is done so that "lock" is only set once during construction
>> (StringWriter is a bit unusual in that it uses the SB as the lock object). A
>> downside of the change is that it introduces casts. Another is that the
>> ex
typos
> * Missing final declaration
>
> These should be fixed as a sanity effort.
Per Minborg has updated the pull request incrementally with one additional
commit since the last revision:
Revert constructor, add (c) year and revert some doc
-
Changes:
- all: https://git
typos
> * Missing final declaration
>
> These should be fixed as a sanity effort.
Per Minborg has updated the pull request incrementally with one additional
commit since the last revision:
Add additional (c) years
-
Changes:
- all: https://git.openjdk.org/jd
ture `VarHandle`
> improvements will benefit `Bits` too.
>
> Improvements in `Bits` will propagate to `ObjectInputStream`,
> `ObjectOutputStream` and `RandomAccessFile`.
>
> Initial benchmarks and performance discussions can be found here:
> https://github.com/openjdk/panama-foreign/p
On Mon, 9 Jan 2023 08:33:09 GMT, Viktor Klang wrote:
>> Currently Set.copyOf allocates both a HashSet and a new empty array when the
>> input collection is empty.
>>
>> This patch avoids allocating anything for the case where the parameter
>> collection's isEmpty returns true.
>
> Viktor Klang
On Mon, 9 Jan 2023 18:34:57 GMT, Per Minborg wrote:
> On the note of `CHM::isEmpty`: It would be better to rewrite this method as a
> short-circuitable reduction of the many CounterCells' values. As soon as at
> least one of them are >0 then the map is not empty. In contr
`java.util.concurrent.ConcurrentHashMap` is relatively old and has not been
updated to reflect the current state of Java and can be modernized:
* Add `@Serial` annotations
* Seal classes and restrict subclassing for internal classes
* Use pattern matching for instance
* Remove redundant modif
typos
> * Missing final declaration
>
> These should be fixed as a sanity effort.
Per Minborg has updated the pull request incrementally with one additional
commit since the last revision:
Revert removal of a final keyword
-
Changes:
- all: https://git.openjdk.org/jd
On Tue, 10 Jan 2023 12:04:10 GMT, Pavel Rappo wrote:
> I'm sure others will note or have already noted elsewhere that we don't do
> direct PRs against JSR 166.
Yes. I will change the PR to a draft as we explore ways to integrate the spirit
of the proposed changes.
-
PR: https://g
This PR proposes to add null-checking for some parameter arguments in
`ZipFileStore`.
-
Commit messages:
- Check null invariants
Changes: https://git.openjdk.org/jdk/pull/11926/files
Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=11926&range=00
Issue: https://bugs.openjdk.org/
On Tue, 10 Jan 2023 14:59:35 GMT, Roger Riggs wrote:
>> Per Minborg has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Revert removal of a final keyword
>
> src/java.base/share/classes/java/io/ObjectStreamCo
typos
> * Missing final declaration
>
> These should be fixed as a sanity effort.
Per Minborg has updated the pull request incrementally with one additional
commit since the last revision:
Revert removal of static modifier in OSC
-
Changes:
- all: https://git.openjdk
> This PR proposes to add null-checking for some parameter arguments in
> `ZipFileStore`.
Per Minborg has updated the pull request incrementally with one additional
commit since the last revision:
Rename and improve NPE testing
-
Changes:
- all: https://git.openjdk.o
On Tue, 10 Jan 2023 17:29:56 GMT, Lance Andersen wrote:
> This should be OK but might suggest adding a release note
Do we need to do that for a package-private class? Maybe for internal use?
-
PR: https://git.openjdk.org/jdk/pull/11926
> This PR proposes to add null-checking for some parameter arguments in
> `ZipFileStore`.
Per Minborg has updated the pull request incrementally with one additional
commit since the last revision:
Add test method comment
-
Changes:
- all: https://git.openjdk.org/jd
> This PR proposes to add null-checking for some parameter arguments in
> `ZipFileStore`.
Per Minborg has updated the pull request incrementally with one additional
commit since the last revision:
Fix typo and add bug ref
-
Changes:
- all: https://git.openjdk.org/jd
On Tue, 10 Jan 2023 17:33:26 GMT, Roger Riggs wrote:
> The `static` declarations should be restored in ObjectStreamConstants.
This has been fixed in [a previous
commit](https://github.com/openjdk/jdk/pull/11848/commits/f231c16b9074c711ed6a417331a35a205516532a)
-
PR: https://git.op
typos
> * Missing final declaration
>
> These should be fixed as a sanity effort.
Per Minborg has updated the pull request incrementally with two additional
commits since the last revision:
- Update src/java.base/share/classes/java/io/ObjectStreamConstants.java
Co-authored
typos
> * Missing final declaration
>
> These should be fixed as a sanity effort.
Per Minborg has updated the pull request incrementally with one additional
commit since the last revision:
Revert renaming
-
Changes:
- all: https://git.openjdk.org/jdk/pull/11848/files
-
On Wed, 11 Jan 2023 09:13:27 GMT, Andrey Turbanov wrote:
>> Per Minborg has updated the pull request incrementally with two additional
>> commits since the last revision:
>>
>> - Update src/java.base/share/classes/java/io/ObjectStreamConstants.java
>>
>>
On Wed, 11 Jan 2023 02:19:26 GMT, Jorn Vernee wrote:
> A small doc clarification that also specifies where the additional
> MemorySegment parameter of a downcall method handle linked with the
> captureCallState option appears in the parameter list, on the
> CaptureCallState class.
LGTM
-
On Tue, 10 Jan 2023 15:26:05 GMT, Per Minborg wrote:
> This PR proposes to add null-checking for some parameter arguments in
> `ZipFileStore`.
This pull request has now been integrated.
Changeset: 7d3400b1
Author: Per Minborg
URL:
https://git.openjdk.org/jdk/
On Wed, 11 Jan 2023 10:36:57 GMT, Andrey Turbanov wrote:
>> Per Minborg has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Revert renaming
>
> src/java.base/share/classes/java/io/DataInputStream.java line 2:
typos
> * Missing final declaration
>
> These should be fixed as a sanity effort.
Per Minborg has updated the pull request incrementally with one additional
commit since the last revision:
Convert field to static and revert copyright year
-
Changes:
- all: https://git
On Wed, 11 Jan 2023 15:31:22 GMT, Per Minborg wrote:
>> Code in java.io contains many legacy constructs and semantics not
>> recommended including:
>>
>> * C-style array declaration
>> * Unnecessary visibility
>> * Redundant keywords in interfaces (e.g
stance
> * Remove redundant modifiers (such as some final declarations)
> * Use Objects.requireNonNull for invariant checking
> * Use diamond operators instead of explicit types
> * Simplify expressions using Math::max
Per Minborg has updated the pull request incrementally with on
On Tue, 17 Jan 2023 01:08:09 GMT, j3graham wrote:
> > Do you see any concrete examples of classes in the JDK that could benefit
> > from a "VarHandlization"?
>
> `ImageOutputStreamImpl` and `ImageInputStreamImpl` in `javax.imageio.stream`
> have some very similar code that might benefit. Also
On Wed, 4 Jan 2023 08:48:56 GMT, Per Minborg wrote:
> Currently, `java.io.Bits` is using explicit logic to read/write various
> primitive types to/from byte arrays. Switching to the use of `VarHandle`
> access would provide better performance and less code.
>
> Also, using a s
This PR proposes using a performance optimization using a new supported API for
operations similar to those found in `java.io.Bits`
-
Commit messages:
- Remove white spaces
- Remove white space
- Fix jcheck issues
- Update copyright years
- Reformat javadoc
- Prepare for review
On Wed, 18 Jan 2023 16:34:57 GMT, Per Minborg wrote:
> This PR proposes using a performance optimization using a new supported API
> for operations similar to those found in `java.io.Bits`
Performance looks promising for serialization (values in us/operation):
| Java 20 | J
On Fri, 20 Jan 2023 16:36:23 GMT, Roger Riggs wrote:
>> This PR proposes using a performance optimization using a new supported API
>> for operations similar to those found in `java.io.Bits`
>
> src/java.base/share/classes/jdk/internal/util/access/ByteArrayAccess.java
> line 26:
>
>> 24: */
>
On Fri, 20 Jan 2023 18:21:59 GMT, Roger Riggs wrote:
>> Per Minborg has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Improve doc and fix typo
>
> src/java.base/share/classes/jdk/internal/util/access/By
> This PR proposes using a performance optimization using a new supported API
> for operations similar to those found in `java.io.Bits`
Per Minborg has updated the pull request incrementally with one additional
commit since the last revision:
Improve doc and fix typo
-
C
> This PR proposes using a performance optimization using a new supported API
> for operations similar to those found in `java.io.Bits`
Per Minborg has updated the pull request incrementally with one additional
commit since the last revision:
Rename and move
-
Changes:
> This PR proposes using a performance optimization using a new supported API
> for operations similar to those found in `java.io.Bits`
Per Minborg has updated the pull request incrementally with one additional
commit since the last revision:
Add benchmark
-
Changes:
On Mon, 23 Jan 2023 08:11:15 GMT, Per Minborg wrote:
>> src/java.base/share/classes/jdk/internal/util/access/ByteArrayAccess.java
>> line 614:
>>
>>> 612: /*
>>> 613: * Methods for packing primitive values into byte arrays starting
>>> a
On Mon, 23 Jan 2023 10:15:55 GMT, Per Minborg wrote:
>> Very good question. I will take a look at it. A fixed value is inserted in
>> the original var handle so potentially it might improve performance that way
>> too.
>
> No significant performance increase:
>
&g
> This PR proposes using a performance optimization using a new supported API
> for operations similar to those found in `java.io.Bits`
Per Minborg has updated the pull request incrementally with one additional
commit since the last revision:
Remove methods with implicit zero
On Wed, 11 Jan 2023 15:31:22 GMT, Per Minborg wrote:
>> Code in java.io contains many legacy constructs and semantics not
>> recommended including:
>>
>> * C-style array declaration
>> * Unnecessary visibility
>> * Redundant keywords in interfaces (e.g
On Wed, 4 Jan 2023 15:37:23 GMT, Per Minborg wrote:
> Code in java.io contains many legacy constructs and semantics not recommended
> including:
>
> * C-style array declaration
> * Unnecessary visibility
> * Redundant keywords in interfaces (e.g. public, static)
> * No
Some variables are declared using old-style declarations. These should be
modified to conform to modern style.
This is a task derived from https://github.com/openjdk/jdk/pull/11848
-
Commit messages:
- Fix more classes
- Remove c-style declarations
Changes: https://git.openjdk.o
Some of the fields in java.io can be declared as final.
-
Commit messages:
- Revert final class declaration
- Declare fields final
Changes: https://git.openjdk.org/jdk/pull/12140/files
Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=12140&range=00
Issue: https://bugs.openjdk.or
This PR proposes declaring some internal classes in java.io as `final`,
explicitly indicating that they are not intended for sub-classing.
If you think declaring classes final is just "static noice", please see
http://minborgsjavapot.blogspot.com/2021/12/why-general-inheritance-is-flawed-and.ht
This PR fixes a couple of typos in the documentation.
-
Commit messages:
- Update copyright year
- Fix javadoc issues
Changes: https://git.openjdk.org/jdk/pull/12142/files
Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=12142&range=00
Issue: https://bugs.openjdk.org/browse/JDK-
This PR proposes to reduce the visibility for constructor and methods in
`java.io.SerialCallbackContext`.
-
Commit messages:
- Reduce visibility in j.i.SerialCallbackConext
Changes: https://git.openjdk.org/jdk/pull/12143/files
Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=12143
> This PR proposes to reduce the visibility for constructor and methods in
> `java.io.SerialCallbackContext`.
Per Minborg has updated the pull request incrementally with one additional
commit since the last revision:
Update copyright year
-
Changes:
- all:
On Mon, 23 Jan 2023 14:24:16 GMT, Per Minborg wrote:
> Some of the fields in java.io can be declared as final.
This pull request has now been integrated.
Changeset: 079255e3
Author: Per Minborg
URL:
https://git.openjdk.org/jdk/commit/079255e312a60584d748babcd320eacec99c5a02
St
On Mon, 23 Jan 2023 15:08:47 GMT, Per Minborg wrote:
> This PR proposes to reduce the visibility for constructor and methods in
> `java.io.SerialCallbackContext`.
This pull request has now been integrated.
Changeset: a7f035db
Author: Per Minborg
URL:
https://git.openjdk.o
101 - 200 of 1346 matches
Mail list logo
