This PR proposes to fix a broken link in the `MemorySegment.Scope` class.
-
Commit messages:
- Fix link to section
Changes: https://git.openjdk.org/jdk/pull/19366/files
Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=19366&range=00
Issue: https://bugs.openjdk.org/browse/JDK-833
On Thu, 23 May 2024 11:39:11 GMT, Per Minborg wrote:
> This PR proposes to fix a broken link in the `MemorySegment.Scope` class.
Seams to work after the patch:
.../api/java.base/java/lang/fore
On Thu, 23 May 2024 11:39:11 GMT, Per Minborg wrote:
> This PR proposes to fix a broken link in the `MemorySegment.Scope` class.
This pull request has now been integrated.
Changeset: 0a9d1f8c
Author: Per Minborg
URL:
https://git.openjdk.org/jdk/com
On Wed, 27 Mar 2024 17:36:28 GMT, Liam Miller-Cushon wrote:
> This change overrides mutator methods in the implementation returned by
> `Map.of().entrySet()` to throw `UnsupportedOperationException`.
src/java.base/share/classes/java/util/ImmutableCollections.java line 1323:
> 1321:
On Mon, 27 May 2024 12:40:07 GMT, Chen Liang wrote:
> @minborg Is it possible for you to review this collection bugfix?
Will do! Thanks for the heads up.
-
PR Comment: https://git.openjdk.org/jdk/pull/18141#issuecomment-2134446236
On Thu, 7 Mar 2024 05:33:16 GMT, Lei Zhu wrote:
>> When the specified key did not associated with a value, should check the
>> `key` and `value` type.
>
> Lei Zhu has updated the pull request incrementally with one additional commit
> since the last revision:
>
> Use testNG builtin functiona
On Fri, 31 May 2024 16:18:33 GMT, Maurizio Cimadamore
wrote:
>> This PR restores a var handle cache in `Utils::makeSegmentViewVarHandle`.
>> The cache was moved to `ValueLayouts::varHandle` as part of
>> [pull/19251](https://git.openjdk.org/jdk/pull/19251), on the basis that we
>> want to opt
On Wed, 29 May 2024 15:20:15 GMT, Chen Liang wrote:
>> This was something that I tried and I observed a performance regression on
>> the ARM platform that I was testing. From my understanding, `@Stable` tells
>> the compiler to trust the contents of this field which is only given when
>> the f
On Wed, 5 Jun 2024 13:37:15 GMT, Per Minborg wrote:
>> Interesting, don't know about hotspot internals so I can't diagnose the
>> exact cause of this regression.
>
> In order to be eligible for constant folding, the benchmark must declare the
> `Method ha
On Wed, 5 Jun 2024 13:41:10 GMT, Per Minborg wrote:
>> In order to be eligible for constant folding, the benchmark must declare the
>> `Method hashCodeMethod;` as `static final`.
>>
>> It is hard for me to understand why a `@Stable` annotation should have a
>>
On Fri, 7 Jun 2024 13:08:24 GMT, Claes Redestad wrote:
>> Trivially move a few private static finals to their respective source type
>> to avoid eagerly loading a few small classes.
>
> Claes Redestad has updated the pull request incrementally with one additional
> commit since the last revisio
On Mon, 10 Jun 2024 03:51:40 GMT, Glavo wrote:
>> Things have changed since https://github.com/openjdk/jdk/pull/14636 was
>> closed, so let me reopen it.
>>
>> https://github.com/openjdk/jdk/pull/15386 confirmed that `VarHandle` in BALE
>> caused a startup regression. In order to not have any
On Fri, 17 May 2024 09:31:33 GMT, Per Minborg wrote:
>> # Stable Values & Collections (Internal)
>>
>> ## Summary
>> This PR proposes to introduce an internal _Stable Values & Collections_ API,
>> which provides immutable value holders where elements are
On Tue, 16 Apr 2024 11:47:23 GMT, Per Minborg wrote:
> # Stable Values & Collections (Internal)
>
> ## Summary
> This PR proposes to introduce an internal _Stable Values & Collections_ API,
> which provides immutable value holders where elements are initialized _at
>
This PR proposes to retain the read-only state when any of the
`MemorySegment::reinterpret` methods is called.
Previously, the read-only state was lost and the returned `MemorySegment` was
always writable regardless of the original segment's read-only state.
-
Commit messages:
- M
> This PR proposes to retain the read-only state when any of the
> `MemorySegment::reinterpret` methods is called.
>
> Previously, the read-only state was lost and the returned `MemorySegment` was
> always writable regardless of the original segment's read-only state.
Per
On Mon, 10 Jun 2024 13:45:16 GMT, Maurizio Cimadamore
wrote:
> Note that `asSlice` methods also lacks a similar guarantee on read-only (but
> the impl works fine there)
Even though not mentioned in the original issue, we could add documentation for
this here as well. Or maybe via https://bugs
> This PR proposes to retain the read-only state when any of the
> `MemorySegment::reinterpret` methods is called.
>
> Previously, the read-only state was lost and the returned `MemorySegment` was
> always writable regardless of the original segment's read-only state.
Per
This PR proposes to explicitly state that returned segments form the `asSlice`
and `reinterpret` method share memory regions with `this` memory segment.
Note: The term "subset" means a true subset or the same set.
-
Commit messages:
- Add segments share the same backing store in d
On Fri, 10 Nov 2023 08:17:22 GMT, Per Minborg wrote:
>> This PR outlines a solution for making immutable maps `@ValueBased` by
>> removing cacheing of certain values in `AbstractMap`.
>>
>> By removing these caching fields in `AbstractMap`, we can make the immutable
&
On Mon, 10 Jun 2024 15:45:07 GMT, Per Minborg wrote:
> This PR proposes to explicitly state that returned segments form the
> `asSlice` and `reinterpret` method share memory regions with `this` memory
> segment.
>
> Note: The term "subset" means a true subset
> This PR proposes to explicitly state that returned segments form the
> `asSlice` and `reinterpret` method share memory regions with `this` memory
> segment.
>
> Note: The term "subset" means a true subset or the same set.
Per Minborg has updated the pull reque
On Mon, 10 Jun 2024 15:45:07 GMT, Per Minborg wrote:
> This PR proposes to explicitly state that returned segments form the
> `asSlice` and `reinterpret` method share memory regions with `this` memory
> segment.
>
> Note: The term "subset" means a true subset or
> This PR proposes to retain the read-only state when any of the
> `MemorySegment::reinterpret` methods is called.
>
> Previously, the read-only state was lost and the returned `MemorySegment` was
> always writable regardless of the original segment's read-only state.
Per
On Mon, 10 Jun 2024 13:18:43 GMT, Per Minborg wrote:
> This PR proposes to retain the read-only state when any of the
> `MemorySegment::reinterpret` methods is called.
>
> Previously, the read-only state was lost and the returned `MemorySegment` was
> always writable re
On Fri, 2 Aug 2024 07:20:39 GMT, Per Minborg wrote:
> This trivial PR proposes to add a missing parenthesis in
> `java.util.Date::toString`.
src/java.base/share/classes/java/util/Date.java line 1015:
> 1013: * {@code 59}), as two decimal digits.
> 1014: * {@cod
This trivial PR proposes to add a missing parenthesis in
`java.util.Date::toString`.
-
Commit messages:
- Update copyright year
- Add missing parenthesis in Date::toString
Changes: https://git.openjdk.org/jdk/pull/20439/files
Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=2043
On Fri, 2 Aug 2024 07:24:20 GMT, Per Minborg wrote:
>> This trivial PR proposes to add a missing parenthesis in
>> `java.util.Date::toString`.
>
> src/java.base/share/classes/java/util/Date.java line 1015:
>
>> 1013: * {@code 59}), as two decimal digits.
&g
On Fri, 2 Aug 2024 07:20:39 GMT, Per Minborg wrote:
> This trivial PR proposes to add a missing parenthesis in
> `java.util.Date::toString`.
This pull request has now been integrated.
Changeset: 219e1eb1
Author: Per Minborg
URL:
https://git.openjdk.org/jdk/
On Fri, 26 Jul 2024 21:06:31 GMT, Turkhan wrote:
> This PR fixes `java.util.Deque`'s specification to name `peekFirst()` as an
> equivalent to Stack's `peek()` method since both of them don't throw when a
> collection is empty. This is not the case with the current `getFirst()`
> method.
>
>
On Wed, 21 Aug 2024 13:24:15 GMT, Maurizio Cimadamore
wrote:
>> This PR fixes two minor issues in the `MemoryLayout` javadoc:
>> * the section describing dereference path talks about `P` and `P'` but then
>> only uses `P` in the code;
>> * the `ceilDiv` math on the `PathElement::sequenceElement
On Wed, 21 Aug 2024 13:26:58 GMT, Maurizio Cimadamore
wrote:
> When working on startup improvements, I noticed that the method handle
> returned by `MemoryLayout::offsetHandle` can overflow if the client calls the
> handle with a base offset that is too big.
>
> In other similar situations, t
The performance of the `MemorySegment::fil` can be improved by replacing the
`checkAccess()` method call with calling `checkReadOnly()` instead (as the
bounds of the segment itself do not need to be checked).
Also, smaller segments can be handled directly by Java code rather than
transitioning
ed to native code whereas
> smaller segments are handled via a switch rake.
>
> It should be noted that `Arena::allocate` is using `MemorySegment::fil`.
> Hence, this PR will also have a positive effect on memory allocation
> performance.
Per Minborg has updated the pull request incre
ed to native code whereas
> smaller segments are handled via a switch rake.
>
> It should be noted that `Arena::allocate` is using `MemorySegment::fil`.
> Hence, this PR will also have a positive effect on memory allocation
> performance.
Per Minborg has updated the pull request incre
ed to native code whereas
> smaller segments are handled via a switch rake.
>
> It should be noted that `Arena::allocate` is using `MemorySegment::fil`.
> Hence, this PR will also have a positive effect on memory allocation
> performance.
Per Minborg has updated the pull request incre
On Mon, 26 Aug 2024 11:59:44 GMT, Per Minborg wrote:
>> The performance of the `MemorySegment::fil` can be improved by replacing the
>> `checkAccess()` method call with calling `checkReadOnly()` instead (as the
>> bounds of the segment itself do not need to be checked).
&g
On Mon, 26 Aug 2024 12:50:53 GMT, Francesco Nigro wrote:
>> Per Minborg has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Fix typo
>
> src/java.base/share/classes/jdk/internal/foreign/AbstractMemorySegmentIm
On Mon, 26 Aug 2024 12:07:02 GMT, Per Minborg wrote:
>> Per Minborg has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Add a comment about the old switch type
>
> Here is what it looks like for Windows x64:
&g
On Mon, 26 Aug 2024 13:29:40 GMT, Per Minborg wrote:
>> src/java.base/share/classes/jdk/internal/foreign/AbstractMemorySegmentImpl.java
>> line 200:
>>
>>> 198: switch ((int) length) {
>>> 199: case 0 : checkReadOnly(f
On Mon, 26 Aug 2024 13:52:35 GMT, Claes Redestad wrote:
>> Noticed these on a few startup tests in code generating proxies. Desugaring
>> switch expressions reduce risk of bootstrap circularity from any future
>> changes to switch bootstrapping (which itself depends on the classfile API).
>> I
This PR proposes to add a new overload to `MemorySegment::getString` whereby it
is possible to pass in a known byte length of the content in a segment that
should be converted to a String. This is useful in case one already knows the
byte length and thereby does not need to scan for a null termi
On Mon, 26 Aug 2024 21:38:37 GMT, Maurizio Cimadamore
wrote:
>> Here is a benchmark that fills segments of various random sizes:
>>
>>
>>
>> @BenchmarkMode(Mode.AverageTime)
>> @Warmup(iterations = 5, time = 500, timeUnit = TimeUnit.MILLISECONDS)
>> @Measurement(iterations = 10, time = 500, t
ed to native code whereas
> smaller segments are handled via a switch rake.
>
> It should be noted that `Arena::allocate` is using `MemorySegment::fil`.
> Hence, this PR will also have a positive effect on memory allocation
> performance.
Per Minborg has updated the pull request with
This trivial PR proposes to fix a typo in the `MemorySegment` docs.
-
Commit messages:
- Fix typo in MemorySegment docs
Changes: https://git.openjdk.org/jdk/pull/20727/files
Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=20727&range=00
Issue: https://bugs.openjdk.org/browse/JD
On Tue, 27 Aug 2024 10:42:08 GMT, Per Minborg wrote:
> This trivial PR proposes to fix a typo in the `MemorySegment` docs.
This pull request has now been integrated.
Changeset: 2e96f159
Author: Per Minborg
URL:
https://git.openjdk.org/jdk/com
On Tue, 27 Aug 2024 14:45:37 GMT, Maurizio Cimadamore
wrote:
>> When working on startup improvements, I noticed that the method handle
>> returned by `MemoryLayout::offsetHandle` can overflow if the client calls
>> the handle with a base offset that is too big.
>>
>> In other similar situatio
On Tue, 27 Aug 2024 20:25:46 GMT, Paul Sandoz wrote:
> How fast do we need to be here given we are measuring in a few nanoseconds
> per operation?
>
> What if the goal is not to regress from say explicitly filling in a small
> sized segment or a comparable array (e.g., < 8 bytes) then maybe a
ed to native code whereas
> smaller segments are handled via a switch rake.
>
> It should be noted that `Arena::allocate` is using `MemorySegment::fil`.
> Hence, this PR will also have a positive effect on memory allocation
> performance.
Per Minborg has updated the pull request incre
ed to native code whereas
> smaller segments are handled via a switch rake.
>
> It should be noted that `Arena::allocate` is using `MemorySegment::fil`.
> Hence, this PR will also have a positive effect on memory allocation
> performance.
Per Minborg has updated the pull request incre
ed to native code whereas
> smaller segments are handled via a switch rake.
>
> It should be noted that `Arena::allocate` is using `MemorySegment::fil`.
> Hence, this PR will also have a positive effect on memory allocation
> performance.
Per Minborg has updated the pull request incre
ed to native code whereas
> smaller segments are handled via a switch rake.
>
> It should be noted that `Arena::allocate` is using `MemorySegment::fil`.
> Hence, this PR will also have a positive effect on memory allocation
> performance.
Per Minborg has updated the pull request incre
ed to native code whereas
> smaller segments are handled via a switch rake.
>
> It should be noted that `Arena::allocate` is using `MemorySegment::fil`.
> Hence, this PR will also have a positive effect on memory allocation
> performance.
Per Minborg has updated the pull request increm
On Wed, 28 Aug 2024 15:32:40 GMT, Francesco Nigro wrote:
>>> How fast do we need to be here given we are measuring in a few nanoseconds
>>> per operation?
>>>
>>> What if the goal is not to regress from say explicitly filling in a small
>>> sized segment or a comparable array (e.g., < 8 bytes)
On Fri, 30 Aug 2024 10:51:59 GMT, Per Minborg wrote:
>> The performance of the `MemorySegment::fil` can be improved by replacing the
>> `checkAccess()` method call with calling `checkReadOnly()` instead (as the
>> bounds of the segment itself do not need to be checked).
&g
On Fri, 30 Aug 2024 14:15:24 GMT, Maurizio Cimadamore
wrote:
>> src/java.base/share/classes/jdk/internal/foreign/AbstractMemorySegmentImpl.java
>> line 208:
>>
>>> 206: }
>>> 207: final long u = Byte.toUnsignedLong(value);
>>> 208: final long longValue = u <
This PR proposes to handle smaller FFM copy operations with Java code rather
than transitioning to native code. This will improve performance. In this PR,
copy operations involving zero to 63 bytes will be handled by Java code.
Here is what it looks like for Windows x64:
 {
>> return ELEM_SIZE << 56 | ELEM_SIZE << 48 | ELEM_SIZE << 40 |
>> ELEM_SIZE << 32 | ELEM_SIZE << 24 | ELEM_SIZE << 16 | ELEM_SIZE << 8 |
>> ELEM_SIZE;
>>
gated to native code whereas
> smaller segments are handled via a switch rake.
>
> It should be noted that `Arena::allocate` is using `MemorySegment::fil`.
> Hence, this PR will also have a positive effect on memory allocation
> performance.
Per Minborg has updated the pull request in
On Tue, 3 Sep 2024 08:49:58 GMT, Francesco Nigro wrote:
>> I've tried
>>
>>
>> final long longValue = Byte.toUnsignedLong(value) * 0x0101010101010101L;
>>
>>
>> But it had the same performance as explicit bit shifting on M1.
>
> @minborg the ` ELEM_SIZE` is a `Param` field right? Just to be
On Mon, 26 Aug 2024 11:47:11 GMT, Per Minborg wrote:
> The performance of the `MemorySegment::fil` can be improved by replacing the
> `checkAccess()` method call with calling `checkReadOnly()` instead (as the
> bounds of the segment itself do not need to be checked).
>
>
On Tue, 3 Sep 2024 11:32:26 GMT, Maurizio Cimadamore
wrote:
>> This PR proposes to handle smaller FFM copy operations with Java code rather
>> than transitioning to native code. This will improve performance. In this
>> PR, copy operations involving zero to 63 bytes will be handled by Java cod
On Tue, 15 Nov 2022 12:34:43 GMT, Maurizio Cimadamore
wrote:
>> This PR contains the API and implementation changes for JEP-434 [1]. A more
>> detailed description of such changes, to avoid repetitions during the review
>> process, is included as a separate comment.
>>
>> [1] - https://openjd
On Tue, 15 Nov 2022 12:34:43 GMT, Maurizio Cimadamore
wrote:
>> This PR contains the API and implementation changes for JEP-434 [1]. A more
>> detailed description of such changes, to avoid repetitions during the review
>> process, is included as a separate comment.
>>
>> [1] - https://openjd
On Tue, 15 Nov 2022 12:34:43 GMT, Maurizio Cimadamore
wrote:
>> This PR contains the API and implementation changes for JEP-434 [1]. A more
>> detailed description of such changes, to avoid repetitions during the review
>> process, is included as a separate comment.
>>
>> [1] - https://openjd
On Tue, 15 Nov 2022 14:49:30 GMT, Per Minborg wrote:
>> Maurizio Cimadamore has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Add `since` tag in Module/ModuleLayer preview methods
>
> src/java.base/s
On Tue, 15 Nov 2022 12:34:43 GMT, Maurizio Cimadamore
wrote:
>> This PR contains the API and implementation changes for JEP-434 [1]. A more
>> detailed description of such changes, to avoid repetitions during the review
>> process, is included as a separate comment.
>>
>> [1] - https://openjd
On Tue, 15 Nov 2022 12:34:43 GMT, Maurizio Cimadamore
wrote:
>> This PR contains the API and implementation changes for JEP-434 [1]. A more
>> detailed description of such changes, to avoid repetitions during the review
>> process, is included as a separate comment.
>>
>> [1] - https://openjd
On Tue, 15 Nov 2022 12:34:43 GMT, Maurizio Cimadamore
wrote:
>> This PR contains the API and implementation changes for JEP-434 [1]. A more
>> detailed description of such changes, to avoid repetitions during the review
>> process, is included as a separate comment.
>>
>> [1] - https://openjd
On Tue, 15 Nov 2022 12:34:43 GMT, Maurizio Cimadamore
wrote:
>> This PR contains the API and implementation changes for JEP-434 [1]. A more
>> detailed description of such changes, to avoid repetitions during the review
>> process, is included as a separate comment.
>>
>> [1] - https://openjd
On Tue, 15 Nov 2022 12:34:43 GMT, Maurizio Cimadamore
wrote:
>> This PR contains the API and implementation changes for JEP-434 [1]. A more
>> detailed description of such changes, to avoid repetitions during the review
>> process, is included as a separate comment.
>>
>> [1] - https://openjd
On Tue, 15 Nov 2022 12:34:43 GMT, Maurizio Cimadamore
wrote:
>> This PR contains the API and implementation changes for JEP-434 [1]. A more
>> detailed description of such changes, to avoid repetitions during the review
>> process, is included as a separate comment.
>>
>> [1] - https://openjd
This PR proposes to opt in for graphic rendering of the sealed hierarchy of the
ConstantDesc class.
Rendering capability was added via https://bugs.openjdk.org/browse/JDK-8295653
Here is how it would look like:
https://user-images.githubusercontent.com/7457876/202216017-ec996722-2956-4b0a-adb5
This PR proposes to opt in for graphic rendering of the sealed hierarchy of the
CallSite class.
Rendering capability was added via https://bugs.openjdk.org/browse/JDK-8295653
Here is how it would look like:
https://user-images.githubusercontent.com/7457876/202234105-8029ade2-4feb-456c-a010-b801
This PR proposes to opt in for graphic rendering of the sealed hierarchy of the
`Reference` class.
Rendering capability was added via https://bugs.openjdk.org/browse/JDK-8295653
Here is how it would look like:
https://user-images.githubusercontent.com/7457876/202243138-7f2a799a-dc67-4c4e-9322-c
On Wed, 16 Nov 2022 16:41:18 GMT, Joe Darcy wrote:
> Helpful improvement.
>
> Are the type names in the diagram links?
The diagram is an SVG image rendered via the DOT description language. I think,
in theory, it would be possible to add links. I did some experiments with this
but decided we
This PR proposes the introduction of **guarding** of the use of
`DirectBuffer::address` within the JDK. With the introduction of the Foreign
Function and Memory access, it is possible to derive Buffer instances that are
backed by native memory that, in turn, can be closed asynchronously by the u
On Mon, 21 Nov 2022 11:29:07 GMT, Alan Bateman wrote:
>> This PR proposes the introduction of **guarding** of the use of
>> `DirectBuffer::address` within the JDK. With the introduction of the Foreign
>> Function and Memory access, it is possible to derive Buffer instances that
>> are backed b
On Mon, 21 Nov 2022 11:32:35 GMT, Alan Bateman wrote:
>> This PR proposes the introduction of **guarding** of the use of
>> `DirectBuffer::address` within the JDK. With the introduction of the Foreign
>> Function and Memory access, it is possible to derive Buffer instances that
>> are backed b
ress` method, that the use of the returned
> address needs to be guarded. It can be discussed if this is preferable or not.
>
> This PR spawns several areas of responsibility and so, I expect more than one
> reviewer before promoting the PR.
Per Minborg has updated the pull request incrementally
ress` method, that the use of the returned
> address needs to be guarded. It can be discussed if this is preferable or not.
>
> This PR spawns several areas of responsibility and so, I expect more than one
> reviewer before promoting the PR.
Per Minborg has updated the pull request increm
On Mon, 21 Nov 2022 12:19:21 GMT, Alan Bateman wrote:
>> maybe just `bufferLock` and and just `acquireBuffer` ?
>
> Would it be possible to re-examine acquireSession returning Runnable and
> acquireSessionAsAutoCloseable returning AutoCloseable. The naming is bit
> awkward at most of the use si
ress` method, that the use of the returned
> address needs to be guarded. It can be discussed if this is preferable or not.
>
> This PR spawns several areas of responsibility and so, I expect more than one
> reviewer before promoting the PR.
Per Minborg has updated the pull request incre
ress` method, that the use of the returned
> address needs to be guarded. It can be discussed if this is preferable or not.
>
> This PR spawns several areas of responsibility and so, I expect more than one
> reviewer before promoting the PR.
Per Minborg has updated the pull request inc
On Mon, 21 Nov 2022 13:32:43 GMT, ExE Boss wrote:
>> Per Minborg has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Rename methods
>
> src/java.base/share/classes/sun/nio/ch/DirectBuffer.java line 41:
&g
ress` method, that the use of the returned
> address needs to be guarded. It can be discussed if this is preferable or not.
>
> This PR spawns several areas of responsibility and so, I expect more than one
> reviewer before promoting the PR.
Per Minborg has updated the pull request incr
ress` method, that the use of the returned
> address needs to be guarded. It can be discussed if this is preferable or not.
>
> This PR spawns several areas of responsibility and so, I expect more than one
> reviewer before promoting the PR.
Per Minborg has refreshed the contents of this p
On Mon, 21 Nov 2022 14:14:14 GMT, Alan Bateman wrote:
>> Per Minborg has updated the pull request incrementally with two additional
>> commits since the last revision:
>>
>> - Update src/java.base/share/classes/jdk/internal/access/JavaNioAccess.java
>>
ress` method, that the use of the returned
> address needs to be guarded. It can be discussed if this is preferable or not.
>
> This PR spawns several areas of responsibility and so, I expect more than one
> reviewer before promoting the PR.
Per Minborg has updated the pull request increment
On Mon, 21 Nov 2022 14:07:38 GMT, Alan Bateman wrote:
>> Per Minborg has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Rename methods
>
> src/java.base/share/classes/java/util/zip/Adler32.java line 105:
&g
ress` method, that the use of the returned
> address needs to be guarded. It can be discussed if this is preferable or not.
>
> This PR spawns several areas of responsibility and so, I expect more than one
> reviewer before promoting the PR.
Per Minborg has updated the pull request increment
On Mon, 21 Nov 2022 20:06:20 GMT, Alan Bateman wrote:
>>> > Although this looks much simpler and concise, it means "a new object is
>>> > created for each invocation"
>>>
>>> My comment was actually to see if DirectBuffer could extend AutoCloseable
>>> so that the acquire returns "this" for th
On Tue, 22 Nov 2022 09:23:40 GMT, Maurizio Cimadamore
wrote:
>> Per Minborg has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Rework Acquisition
>
> src/java.base/share/classes/com/sun/crypto/provider/Galo
ress` method, that the use of the returned
> address needs to be guarded. It can be discussed if this is preferable or not.
>
> This PR spawns several areas of responsibility and so, I expect more than one
> reviewer before promoting the PR.
Per Minborg has updated the pull request increment
ress` method, that the use of the returned
> address needs to be guarded. It can be discussed if this is preferable or not.
>
> This PR spawns several areas of responsibility and so, I expect more than one
> reviewer before promoting the PR.
Per Minborg has updated the pull request incremen
ress` method, that the use of the returned
> address needs to be guarded. It can be discussed if this is preferable or not.
>
> This PR spawns several areas of responsibility and so, I expect more than one
> reviewer before promoting the PR.
Per Minborg has updated the pull reques
On Wed, 23 Nov 2022 16:14:52 GMT, Maurizio Cimadamore
wrote:
>> Per Minborg has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Cleanup
>
> src/java.base/share/classes/jdk/internal/access/JavaNioAccess.java li
ress` method, that the use of the returned
> address needs to be guarded. It can be discussed if this is preferable or not.
>
> This PR spawns several areas of responsibility and so, I expect more than one
> reviewer before promoting the PR.
Per Minborg has updated the pull request increme
On Thu, 24 Nov 2022 11:58:12 GMT, Maurizio Cimadamore
wrote:
>> Separately, also (optional) stylistic: the indenting on this and following
>> class is a bit odd. There is a certain tendency to compress lines - e.g. to
>> reach for one-liners, when in reality the body is not that trivial. If I
1 - 100 of 1346 matches
Mail list logo
