On Fri, 31 May 2024 14:05:07 GMT, Alexey Semenyuk wrote:
> Fix MainClassTest class to use HelloApp.AppOutputVerifier class to run app
> launcher instead of raw Executor. This makes MainClassTest test run app
> launchers with retries. This change addresses the primary issue.
>
> Fix inconsisten
On Mon, 3 Jun 2024 14:38:03 GMT, Alexey Semenyuk wrote:
>> I am yet to see anything that actually explains the cause of the `dlerror`
>> crash here ???
>
> @dholmes-ora there is no fix for the cause of the `dlerror` crash in this PR.
> The PR fixes jpackage tests to rerun a launcher if it crash
On Wed, 5 Jun 2024 20:08:10 GMT, Robert Toyonaga wrote:
> ### Summary
> This change ensures we don't get undefined behavior when
> calling[`isspace`](https://pubs.opengroup.org/onlinepubs/007904975/functions/isspace.html).
> `isspace` accepts an `int` argument that "the application shall ensur
Sets the version to 24/24-ea and the copyright year to 2025.
Content changes related to the start of release (e.g. for removed options in
java.1) are handled separately.
This initial generation also picks up the unpublished changes from:
- JDK-8330807: Update Manpage for obsoletion of Scavenge
On Mon, 10 Jun 2024 07:15:51 GMT, Alan Bateman wrote:
>> Sets the version to 24/24-ea and the copyright year to 2025.
>>
>> Content changes related to the start of release (e.g. for removed options in
>> java.1) are handled separately.
>>
>> This initial generation also picks up the unpublishe
On Fri, 7 Jun 2024 06:07:17 GMT, Thomas Stuefe wrote:
> "To use these functions safely with plain chars (or signed chars), the
> argument should first be converted to unsigned char"
@tstuefe wow! Okay. That is a surprise to me. A cast to unsigned char doesn't
actually do anything. Every char i
0807: Update Manpage for obsoletion of ScavengeBeforeFullGC
> - JDK-8284500: Typo in Supported Named Extensions - BasicContraints
> - JDK-8324342: Doclet should default `@since` for a nested class to that of
> its enclosing class
>
> Thanks
David Holmes has updated the pull request with
0807: Update Manpage for obsoletion of ScavengeBeforeFullGC
> - JDK-8284500: Typo in Supported Named Extensions - BasicContraints
> - JDK-8324342: Doclet should default `@since` for a nested class to that of
> its enclosing class
>
> Thanks
David Holmes has updated the pull request in
On Mon, 10 Jun 2024 17:27:18 GMT, Iris Clark wrote:
>> David Holmes has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Regenerated after merge
>
> Marked as reviewed by iris (Reviewer).
Thanks for the revie
On Mon, 10 Jun 2024 02:31:00 GMT, David Holmes wrote:
> Sets the version to 24/24-ea and the copyright year to 2025.
>
> Content changes related to the start of release (e.g. for removed options in
> java.1) are handled separately.
>
> This initial generation also picks
On Mon, 10 Jun 2024 13:36:06 GMT, Robert Toyonaga wrote:
> But what about when an int is passed to isspace?
The current casts to int are incorrect as a negative value would be
sign-extended and then fail the range check. I think we have to cast to
unsigned char in all cases in the caller, whic
On Tue, 11 Jun 2024 18:07:10 GMT, Robert Toyonaga wrote:
>> ### Summary
>> This change ensures we don't get undefined behavior when
>> calling[`isspace`](https://pubs.opengroup.org/onlinepubs/007904975/functions/isspace.html).
>> `isspace` accepts an `int` argument that "the application shall
On Tue, 11 Jun 2024 08:17:02 GMT, Albert Mingkun Yang wrote:
> Obsolete OldSize and related code. An internal variable `OldSize` is kept to
> capture the capacity of old-gen size.
Al seems reasonable.
Thanks.
src/hotspot/share/runtime/arguments.cpp line 543:
> 541: { "UseNeon",
On Fri, 14 Jun 2024 10:19:47 GMT, Albert Mingkun Yang wrote:
>> Obsolete OldSize and related code. An internal variable `OldSize` is kept to
>> capture the capacity of old-gen size.
>
> Albert Mingkun Yang has updated the pull request with a new target base due
> to a merge or a rebase. The pul
On Sat, 15 Jun 2024 08:51:56 GMT, Albert Mingkun Yang wrote:
>> src/hotspot/share/runtime/arguments.cpp line 37:
>>
>>> 35: #include "gc/shared/gcArguments.hpp"
>>> 36: #include "gc/shared/gcConfig.hpp"
>>> 37: #include "gc/shared/genArguments.hpp"
>>
>> Why is this needed?
>
> `Arguments::set_
On Fri, 21 Jun 2024 14:05:51 GMT, Kevin Walls wrote:
> Man page update for JDK-8327793 which marked jstatd as deprecated for removal
> in JDK 24.
Sorry this got left "pending" yesterday
src/jdk.jstatd/share/man/jstatd.1 line 49:
> 47: future release.
> 48: .PP
> 49: \f[B]Note:\f[R] This comma
On Mon, 8 Jul 2024 19:09:47 GMT, Doug Simon wrote:
>> Doug Simon has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> fixed TestTranslatedException
>
> src/hotspot/share/utilities/exceptions.cpp line 208:
>
>> 206:
On Wed, 10 Jul 2024 05:46:31 GMT, David Holmes wrote:
>> src/hotspot/share/utilities/exceptions.cpp line 208:
>>
>>> 206: Handle h_loader, Handle
>>> h_protection_domain) {
>>> 207: // Check for special boot-strapping
On Wed, 10 Jul 2024 05:48:23 GMT, David Holmes wrote:
>> I'm not so sure this is in fact a bug. If we are throwing with a cause, but
>> we can't actually throw and so will do vm_exit, then the exception of
>> interest is the cause not the more generic exception that
On Tue, 9 Jul 2024 13:46:46 GMT, Doug Simon wrote:
>> This PR addresses intermittent failures in jtreg GC stress tests. The
>> failures occur under these conditions:
>> 1. Using a libgraal build with assertions enabled as the top tier JIT
>> compiler. Such a libgraal build will cause a VM exit
On Thu, 11 Jul 2024 17:30:21 GMT, Alan Bateman wrote:
> Bringover some of the changes accumulated in the loom repo to the main line,
> most of these changes are test updates and have been baking in the loom repo
> for several months. The motive is partly to reduce the large set of changes
> th
On Tue, 16 Jul 2024 03:45:36 GMT, Chen Liang wrote:
> Move fields common to Method and Field to executable
s/Field/Constructor
I was a bit confused about executable fields for a moment. :)
-
PR Comment: https://git.openjdk.org/jdk/pull/20188#issuecomment-2231889229
On Tue, 16 Jul 2024 03:45:36 GMT, Chen Liang wrote:
> Move fields common to Method and Field to executable, which simplifies
> implementation. Removed useless transient modifiers as Method and Field were
> never serializable.
Hotspot changes look good. Core-libs do too but I will leave that fo
On Wed, 17 Jul 2024 03:03:23 GMT, Chen Liang wrote:
>> Move fields common to Method and Field to executable, which simplifies
>> implementation. Removed useless transient modifiers as Method and Field were
>> never serializable.
>
> Chen Liang has updated the pull request incrementally with one
On Wed, 17 Jul 2024 02:57:51 GMT, Chen Liang wrote:
>> What would be the terminology for a final field that's set by hotspot,
>> against the regular java constrcutor rules?
>
> I have chosen the wording "all final fields are used by the VM"
I don't know of any specific terminology - we typicall
On Tue, 16 Jul 2024 08:59:20 GMT, Julian Waters wrote:
>> snprintf has been available for all officially and unofficially supported
>> compilers for Windows, Visual Studio since version 2015 and gcc since, well,
>> forever. snprintf is conforming to C99 since the start when compiling using
>>
On Mon, 15 Jul 2024 00:50:30 GMT, Axel Boldt-Christmas
wrote:
>> When inflating a monitor the `ObjectMonitor*` is written directly over the
>> `markWord` and any overwritten data is displaced into a displaced
>> `markWord`. This is problematic for concurrent GCs which needs extra care or
>> l
On Mon, 15 Jul 2024 00:50:30 GMT, Axel Boldt-Christmas
wrote:
>> When inflating a monitor the `ObjectMonitor*` is written directly over the
>> `markWord` and any overwritten data is displaced into a displaced
>> `markWord`. This is problematic for concurrent GCs which needs extra care or
>> l
On Wed, 17 Jul 2024 06:39:14 GMT, David Holmes wrote:
>> Axel Boldt-Christmas has updated the pull request incrementally with 10
>> additional commits since the last revision:
>>
>> - Remove try_read
>> - Add explicit to single parameter constructors
>> -
On Mon, 15 Jul 2024 00:50:30 GMT, Axel Boldt-Christmas
wrote:
>> When inflating a monitor the `ObjectMonitor*` is written directly over the
>> `markWord` and any overwritten data is displaced into a displaced
>> `markWord`. This is problematic for concurrent GCs which needs extra care or
>> l
On Mon, 15 Jul 2024 00:50:30 GMT, Axel Boldt-Christmas
wrote:
>> When inflating a monitor the `ObjectMonitor*` is written directly over the
>> `markWord` and any overwritten data is displaced into a displaced
>> `markWord`. This is problematic for concurrent GCs which needs extra care or
>> l
On Mon, 15 Jul 2024 00:50:30 GMT, Axel Boldt-Christmas
wrote:
>> When inflating a monitor the `ObjectMonitor*` is written directly over the
>> `markWord` and any overwritten data is displaced into a displaced
>> `markWord`. This is problematic for concurrent GCs which needs extra care or
>> l
On Wed, 17 Jul 2024 19:47:44 GMT, Chen Liang wrote:
> `Class` has 2 VM-injected fields that can be made explicit: `Object[]
> signers` and `ProtectionDomain protectionDomain`. We make the signers field
> explicit. (The ProtectionDomain can be revisited when SecurityManager is
> removed, as Sec
On Thu, 18 Jul 2024 13:48:06 GMT, Chen Liang wrote:
>> `Class` has 2 VM-injected fields that can be made explicit: `Object[]
>> signers` and `ProtectionDomain protectionDomain`. We make the signers field
>> explicit. (The ProtectionDomain can be revisited when SecurityManager is
>> removed, as
On Thu, 18 Jul 2024 13:48:06 GMT, Chen Liang wrote:
>> `Class` has 2 VM-injected fields that can be made explicit: `Object[]
>> signers` and `ProtectionDomain protectionDomain`. We make the signers field
>> explicit. (The ProtectionDomain can be revisited when SecurityManager is
>> removed, as
Before RC we need to update the man pages in the repo from their Markdown
sources. All pages at a minimum have 23-ea replaced with 23, and publication
year set to 2024 if needed.
This also picks up the unpublished changes to java.1 from:
- [JDK-8324836](https://bugs.openjdk.org/browse/JDK-83248
On Fri, 19 Jul 2024 05:47:15 GMT, David Holmes wrote:
> Before RC we need to update the man pages in the repo from their Markdown
> sources. All pages at a minimum have 23-ea replaced with 23, and publication
> year set to 2024 if needed.
>
> This also picks up the unpublished
On Fri, 19 Jul 2024 05:47:15 GMT, David Holmes wrote:
> Before RC we need to update the man pages in the repo from their Markdown
> sources. All pages at a minimum have 23-ea replaced with 23, and publication
> year set to 2024 if needed.
>
> This also picks up the unpublished
On Fri, 19 Jul 2024 08:26:51 GMT, Alan Bateman wrote:
>> Before RC we need to update the man pages in the repo from their Markdown
>> sources. All pages at a minimum have 23-ea replaced with 23, and publication
>> year set to 2024 if needed.
>>
>> This also picks up the unpublished changes to
On Mon, 12 Aug 2024 21:37:45 GMT, Doug Lea wrote:
>> src/java.base/share/classes/java/util/concurrent/locks/AbstractQueuedLongSynchronizer.java
>> line 381:
>>
>>> 379: else
>>> 380: break;
>>> 381: } catch (Error | RuntimeException ex
On Mon, 12 Aug 2024 16:11:46 GMT, Viktor Klang wrote:
>> 8336384: AbstractQueuedSynchronizer.acquire should cancel acquire when
>> failing due to a LinkageError or other errors
>
> Viktor Klang has updated the pull request incrementally with one additional
> commit since the last revision:
>
>
On Tue, 13 Aug 2024 08:02:04 GMT, Alan Bateman wrote:
> > It has been a while since I knew this code reasonably well so perhaps I
> > have just forgotten this difference between AQS and built-in monitors, but
> > it seems that a Condition.await can return by throwing an exception without
> > r
On Tue, 13 Aug 2024 16:30:12 GMT, Axel Boldt-Christmas
wrote:
>> When inflating a monitor the `ObjectMonitor*` is written directly over the
>> `markWord` and any overwritten data is displaced into a displaced
>> `markWord`. This is problematic for concurrent GCs which needs extra care or
>> l
On Mon, 12 Aug 2024 16:11:46 GMT, Viktor Klang wrote:
>> 8336384: AbstractQueuedSynchronizer.acquire should cancel acquire when
>> failing due to a LinkageError or other errors
>
> Viktor Klang has updated the pull request incrementally with one additional
> commit since the last revision:
>
>
On Wed, 14 Aug 2024 22:11:39 GMT, Pavel Rappo wrote:
>> src/java.base/share/classes/java/util/concurrent/ForkJoinTask.java line 1075:
>>
>>> 1073: /**
>>> 1074: * Tries to join this task, returning true if it completed
>>> 1075: * (possibly exceptionally) before the given timeout e
On Wed, 14 Aug 2024 20:53:33 GMT, Markus Grönlund wrote:
> Greetings,
>
> Explicitly pin a virtual thread before acquiring the JFR string pool monitor
> because migrating a carrier thread local event writer object onto another
> carrier thread is impossible.
>
> During event commit, the threa
On Thu, 15 Aug 2024 08:24:30 GMT, Pavel Rappo wrote:
>> Use "elapsed" here to match "completed".
>
> I assume you both mean I should change "elapses" to "elapsed" throughout the
> PR, not just in that particular occurrence.
No, elsewhere you don't have an existing tense to match - I only want t
On Thu, 15 Aug 2024 08:58:46 GMT, David Holmes wrote:
>> I assume you both mean I should change "elapses" to "elapsed" throughout the
>> PR, not just in that particular occurrence.
>
> No, elsewhere you don't have an existing tense to match - I only
On Thu, 15 Aug 2024 11:20:23 GMT, Markus Grönlund wrote:
>> Greetings,
>>
>> Explicitly pin a virtual thread before acquiring the JFR string pool monitor
>> because migrating a carrier thread local event writer object onto another
>> carrier thread is impossible.
>>
>> During event commit, th
On Wed, 21 Aug 2024 22:14:40 GMT, Magnus Ihse Bursie wrote:
>> As a preparation for Hermetic Java, we need to have a way to look up during
>> runtime if we are using a statically linked library or not.
>>
>> This change will be the first step needed towards compiling the object files
>> only o
On Thu, 22 Aug 2024 08:54:56 GMT, Magnus Ihse Bursie wrote:
>> Sorry but I don't understand the point of changing build-time constructs
>> using `ifdef STATIC_BUILD` into what appear to be runtime checks, but the
>> result of which is already determined at build time. These are not really
>> r
On Sat, 24 Aug 2024 05:12:42 GMT, Julian Waters wrote:
>> snprintf has been available for all officially and unofficially supported
>> compilers for Windows, Visual Studio since version 2015 and gcc since, well,
>> forever. snprintf is conforming to C99 since the start when compiling using
>>
On Wed, 21 Aug 2024 22:14:40 GMT, Magnus Ihse Bursie wrote:
>> As a preparation for Hermetic Java, we need to have a way to look up during
>> runtime if we are using a statically linked library or not.
>>
>> This change will be the first step needed towards compiling the object files
>> only o
On Thu, 29 Aug 2024 04:24:02 GMT, Ioi Lam wrote:
>> This is the 1st PR for [JEP 483: Ahead-of-Time Class Loading &
>> Linking](https://bugs.openjdk.org/browse/JDK-8315737).
>>
>> Add the following command-line options as specified in JEP 483:
>>
>>
>> - `-XX:AOTMode=off/record/create/auto/on`
On Thu, 29 Aug 2024 05:05:58 GMT, David Holmes wrote:
>> Ioi Lam has updated the pull request with a new target base due to a merge
>> or a rebase. The incremental webrev excludes the unrelated changes brought
>> in by the merge/rebase. The pull request contains five
On Thu, 29 Aug 2024 22:11:36 GMT, Ioi Lam wrote:
>> This is the 1st PR for [JEP 483: Ahead-of-Time Class Loading &
>> Linking](https://bugs.openjdk.org/browse/JDK-8315737).
>>
>> Add the following command-line options as specified in JEP 483:
>>
>>
>> - `-XX:AOTMode=off/record/create/auto/on`
This is the implementation of a new method added to the JNI specification.
>From the CSR request:
The `GetStringUTFLength` function returns the length as a `jint` (`jsize`)
value and so is limited to returning at most `Integer.MAX_VALUE`. But a Java
string can itself consist of `Integer.MAX_VAL
along with the new method entries.
>
> Testing:
> - new test added
> - tiers 1-3 sanity
>
> Thanks
David Holmes has updated the pull request incrementally with one additional
commit since the last revision:
Exclude test on 32-bit
-
Changes:
- all: https://g
On Fri, 30 Aug 2024 05:11:30 GMT, Chris Plummer wrote:
>> David Holmes has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Exclude test on 32-bit
>
> test/hotspot/jtreg/runtime/jni/checked/TestLargeUTF8Length.j
On Fri, 30 Aug 2024 10:51:30 GMT, Magnus Ihse Bursie wrote:
>> I understand the cost overhead experienced by any individual Java run may be
>> lost in the noise, but it still impacts every single Java run just to save
>> some time/resources for the handful of builders of statically linked VMs.
On Sun, 1 Sep 2024 16:30:33 GMT, Julian Waters wrote:
> This does make me wonder: What if the new method for checking if the VM was
> statically linked was inlined? Then the problem comes back yet again as the
> object files need to be recompiled once more. This is possible if Link Time
> Opti
On Fri, 30 Aug 2024 20:45:11 GMT, Chris Plummer wrote:
>> David Holmes has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Exclude test on 32-bit
>
> Overall it looks good to me, although I don't have expe
On Mon, 2 Sep 2024 09:05:17 GMT, Alan Bateman wrote:
>> David Holmes has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Exclude test on 32-bit
>
> Deprecating the existing function and introducing the new func
On Mon, 2 Sep 2024 22:32:34 GMT, Magnus Ihse Bursie wrote:
>> Matthias Baesken has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> adjust indentation in X11Color.c
>
> src/java.desktop/unix/native/libsplashscreen/splashscreen_sys.c line 744:
On Fri, 30 Aug 2024 20:45:11 GMT, Chris Plummer wrote:
>> David Holmes has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Exclude test on 32-bit
>
> Overall it looks good to me, although I don't have expe
along with the new method entries.
>
> Testing:
> - new test added
> - tiers 1-3 sanity
>
> Thanks
David Holmes has updated the pull request incrementally with one additional
commit since the last revision:
The JNI version update was incompete
-
Changes:
- all:
On Tue, 3 Sep 2024 05:52:31 GMT, Magnus Ihse Bursie wrote:
>> This code is devoid of pretty much all error handling and logging, but I
>> agree that a simple fprintf on error would be useful.
>> Also doesn't a call like this trigger the warning about ignoring a function
>> result, or have we di
On Tue, 3 Sep 2024 06:01:15 GMT, Alan Bateman wrote:
>> David Holmes has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> The JNI version update was incompete
>
> Marked as reviewed by alanb (R
On Tue, 27 Sep 2022 08:01:48 GMT, Robbin Ehn wrote:
>> David Holmes has updated the pull request with a new target base due to a
>> merge or a rebase. The pull request now contains 16 commits:
>>
>> - Merge branch 'master' into 8293592-JVM_StopThread
>
On Mon, 26 Sep 2022 18:15:17 GMT, Dmitry Samersoff
wrote:
> If the user has set LD_LIBRARY_PATH to use a particular libjvm.so, options
> from the JDK_JAVA_OPTIONS environment variable are picked up twice.
>
> If an option cannot be accepted twice (e.g., -agentlib), the application
> fails to
On Fri, 23 Sep 2022 06:17:34 GMT, David Holmes wrote:
> Now that Thread.stop has been degraded to throw
> `UnsupportedOperationException` (JDK-8299610) the only direct source of async
> exceptions is from JVMTI `StopThread`. We can remove the `JVM_StopThread`
> code, remove th
On Tue, 20 Sep 2022 10:37:41 GMT, David Holmes wrote:
>> This update is primarily about changes to the JNI Invocation API
>> specification, mainly in relation to `DestroyJavaVM`. The motivation for the
>> changes is to align with changes being made to the JLS, JVMS and
>
On Tue, 20 Sep 2022 00:55:32 GMT, David Holmes wrote:
> This update is primarily about changes to the JNI Invocation API
> specification, mainly in relation to `DestroyJavaVM`. The motivation for the
> changes is to align with changes being made to the JLS, JVMS and
> `java.
On Tue, 27 Sep 2022 16:14:43 GMT, Julian Waters wrote:
> Are any of these a part of the public JNI API?
No this is all internal-use-only
-
PR: https://git.openjdk.org/jdk/pull/9870
On Mon, 26 Sep 2022 18:15:17 GMT, Dmitry Samersoff
wrote:
> If the user has set LD_LIBRARY_PATH to use a particular libjvm.so, options
> from the JDK_JAVA_OPTIONS environment variable are picked up twice.
>
> If an option cannot be accepted twice (e.g., -agentlib), the application
> fails to
On Tue, 4 Oct 2022 01:03:25 GMT, Ioi Lam wrote:
> Please review this trivial fix. TestDockerBasic.java uses cgroups features
> so it should be tagged with `@key cgroups`.
Looks good and trivial. Thanks for the quick fix.
-
Marked as reviewed by dholmes (Reviewer).
PR: https://gi
On Fri, 30 Sep 2022 21:46:34 GMT, Stuart Marks wrote:
>> The concept of the shutdown sequence needs to be specified more clearly.
>> This PR adds text for this into the class specification of
>> `java.lang.Runtime`. Also includes adjustments to related areas in
>> `addShutdownHook`, `halt`, an
On Mon, 3 Oct 2022 13:37:38 GMT, Julian Waters wrote:
>> A large section of error reporting code in the JDK does not properly handle
>> WIN32 API errors and instead mixes them with errors originating from C.
>> Since they can be rather easily replaced and coming up with an elegant
>> solution
On Mon, 26 Sep 2022 18:15:17 GMT, Dmitry Samersoff
wrote:
> If the user has set LD_LIBRARY_PATH to use a particular libjvm.so, options
> from the JDK_JAVA_OPTIONS environment variable are picked up twice.
>
> If an option cannot be accepted twice (e.g., -agentlib), the application
> fails to
On Thu, 6 Oct 2022 12:45:08 GMT, Julian Waters wrote:
>> Please review a small patch for dumping the failure reason when the MSVCRT
>> libraries or the Java Virtual Machine fails to load on Windows, which can
>> provide invaluable insight when debugging related launcher issues.
>>
>> See https
On Sun, 9 Oct 2022 08:17:15 GMT, Julian Waters wrote:
>> The C99 snprintf is available with Visual Studio 2015 and above, alongside
>> Windows 10 and the UCRT, and is no longer identical to the outdated Windows
>> _snprintf. Since support for the Visual C++ 2017 compiler was removed a
>> while
On Sun, 9 Oct 2022 17:58:37 GMT, Kim Barrett wrote:
>> Julian Waters has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Comment formatting
>
> src/java.base/share/native/libjli/jli_util.h line 91:
>
>> 89: * https://learn.microsoft.com/en
On Mon, 10 Oct 2022 11:58:33 GMT, Julian Waters wrote:
>> src/java.base/windows/native/libjli/java_md.h line 48:
>>
>>> 46: */
>>> 47:
>>> 48: void reportWithLastWindowsError(const char* message, ...);
>>
>> Why does this need to be exported in the header file? Are you expecting
>> other cod
On Mon, 10 Oct 2022 11:59:55 GMT, Julian Waters wrote:
>> The C99 snprintf is available with Visual Studio 2015 and above, alongside
>> Windows 10 and the UCRT, and is no longer identical to the outdated Windows
>> _snprintf. Since support for the Visual C++ 2017 compiler was removed a
>> whil
On 11/10/2022 4:38 pm, Amit wrote:
Code for many Java Swing Components In One Program in case someone needs it.
We used to have a Swing demo in the JDK ... don't know what happened to it.
David
Description: The program
Examples_Of_Many_Swing_Components_In_One_Program contains examples of
man
On Mon, 10 Oct 2022 14:15:37 GMT, Julian Waters wrote:
> Some external libraries required by native code are linked via linker
> comments embedded in pragmas. Searching for which libraries are linked can
> then become frustrating and confusing since they may be included in an
> obscure place,
On Mon, 26 Sep 2022 18:15:17 GMT, Dmitry Samersoff
wrote:
> If the user has set LD_LIBRARY_PATH to use a particular libjvm.so, options
> from the JDK_JAVA_OPTIONS environment variable are picked up twice.
>
> If an option cannot be accepted twice (e.g., -agentlib), the application
> fails to
On Mon, 26 Sep 2022 18:15:17 GMT, Dmitry Samersoff
wrote:
> If the user has set LD_LIBRARY_PATH to use a particular libjvm.so, options
> from the JDK_JAVA_OPTIONS environment variable are picked up twice.
>
> If an option cannot be accepted twice (e.g., -agentlib), the application
> fails to
On Mon, 24 Oct 2022 12:16:54 GMT, Coleen Phillimore wrote:
> This change adds an option **EnableWaitForParallelLoad** to enable the legacy
> behavior where the VM will manage synchronization for multiple threads
> loading the same class using a non-parallel capable class loader that have
> rel
On Fri, 4 Nov 2022 12:21:22 GMT, Coleen Phillimore wrote:
>> src/hotspot/share/classfile/placeholders.cpp line 137:
>>
>>> 135: assert(action != PlaceholderTable::LOAD_INSTANCE || seen == NULL,
>>> 136: "Only one LOAD_INSTANCE allowed at a time");
>>> 137:
>>
>> Unclear why this is
On Sun, 6 Nov 2022 21:57:36 GMT, David Holmes wrote:
>> If we don't return we'll actually do a wait and will hang. Worse, we'll be
>> in a tight loop holding both the ClassLoader and SystemDictionary_lock, that
>> the other thread can't get.
>
>
On Sun, 6 Nov 2022 23:09:54 GMT, Coleen Phillimore wrote:
>> This change adds an option **EnableWaitForParallelLoad** to enable the
>> legacy behavior where the VM will manage synchronization for multiple
>> threads loading the same class using a non-parallel capable class loader
>> that have
On Mon, 7 Nov 2022 20:40:33 GMT, Coleen Phillimore wrote:
>> This patch moves the acquisition of the boot class loader lock out of the
>> JVM and into the Java function.
>> Tested with tier1-4, and jvmti and jdi tests locally.
>
> Coleen Phillimore has updated the pull request incrementally with
On Tue, 8 Nov 2022 00:58:44 GMT, Coleen Phillimore wrote:
> The JVM code took a ThreadGroup lock before poking into ThreadGroup fields.
> Call a method in the ThreadGroup to call the synchronized method instead.
> Tested with tier 1-4.
This is a nice simplification of the VM side of the code!
On Tue, 8 Nov 2022 14:55:17 GMT, Coleen Phillimore wrote:
>> The JVM code took a ThreadGroup lock before poking into ThreadGroup fields.
>> Call a method in the ThreadGroup to call the synchronized method instead.
>> Tested with tier 1-4.
>
> Coleen Phillimore has updated the pull request incre
On Tue, 8 Nov 2022 22:08:06 GMT, Coleen Phillimore wrote:
> in the custom class loader must synchronize appending to the class path
I would say:
"in the custom class loader must append to the class path in a thread-safe
manner."
-
PR: https://git.openjdk.org/jdk/pull/11023
On Thu, 10 Nov 2022 06:20:41 GMT, Julian Waters wrote:
> After [JDK-8292008](https://bugs.openjdk.org/browse/JDK-8292008) and
> [JDK-8247283](https://bugs.openjdk.org/browse/JDK-8247283), some C and C++
> code across the JDK can be replaced and simplified with cleaner language
> features that
On Mon, 14 Nov 2022 01:17:38 GMT, Julian Waters wrote:
>> src/hotspot/os/windows/os_windows.hpp line 35:
>>
>>> 33: class Thread;
>>> 34:
>>> 35: static unsigned __stdcall thread_native_entry(Thread*);
>>
>> Why was this removed? This is needed to correctly specify the call sequence
>> for th
On Mon, 14 Nov 2022 01:39:17 GMT, Julian Waters wrote:
>> src/hotspot/share/utilities/debug.hpp line 172:
>>
>>> 170: int status, const char* detail);
>>> 171: ATTRIBUTE_PRINTF(4, 5)
>>> 172: void report_fatal(VMErrorType error_type, const char* file, int line,
>>> c
On Wed, 16 Nov 2022 12:34:29 GMT, Adam Sotona wrote:
> Option --disable-@files is not recognised as valid JVM option, however it is
> already implemented in the launcher.
> Proposed patch skips --disable-@files option in
> src/hotspot/share/runtime/arguments.cpp processing, so it does not fall
1 - 100 of 939 matches
Mail list logo
