On Wed, 22 May 2024 14:47:43 GMT, Yudi Zheng wrote:
>> Moving array construction within BigInteger.implMultiplyToLen intrinsic
>> candidate to its caller simplifies the intrinsic implementation in JIT
>> compiler.
>
> Yudi Zheng has updated the pull request incrementally with one additional
>
On Tue, 11 Jun 2024 18:07:10 GMT, Robert Toyonaga wrote:
>> ### Summary
>> This change ensures we don't get undefined behavior when
>> calling[`isspace`](https://pubs.opengroup.org/onlinepubs/007904975/functions/isspace.html).
>> `isspace` accepts an `int` argument that "the application shall
On Tue, 6 Aug 2024 17:26:55 GMT, Jorn Vernee wrote:
> As discussed in the JBS issue:
>
> FFM upcall stubs embed a `Method*` of the target method in the stub. This
> `Method*` is read from the `LambdaForm::vmentry` field associated with the
> target method handle at the time when the upcall stu
DeInflate.java test fails on s390x platform because size for out1 array which
is responsible for storing the compressed data is insufficient. And being
unable to write whole compressed data on array, on s390 whole data can't be
recovered after compression. So this fix increase Array size (for s3
On Mon, 30 Jan 2023 08:24:27 GMT, Jaikiran Pai wrote:
>> DeInflate.java test fails on s390x platform because size for out1 array
>> which is responsible for storing the compressed data is insufficient. And
>> being unable to write whole compressed data on array, on s390 whole data
>> can't be
On Tue, 31 Jan 2023 09:00:18 GMT, Alan Bateman wrote:
>> Hi @jaikiran ,
>> On my system OS's zlib is being used. and here is stack-trace.
>>
>> --System.out:(2/78)--
>> level:-1, strategy: 0, dowrap: false
>> m=525312, n=498060, len=524288, eq=false
>> --System.err:(11/58
On Mon, 30 Jan 2023 08:03:38 GMT, Amit Kumar wrote:
> DeInflate.java test fails on s390x platform because size for out1 array which
> is responsible for storing the compressed data is insufficient. And being
> unable to write whole compressed data on array, on s390 whole data
ix increase Array size (for s390).
Amit Kumar has updated the pull request incrementally with one additional
commit since the last revision:
change acc to Alan comments
-
Changes:
- all: https://git.openjdk.org/jdk/pull/12283/files
- new: https://git.openjdk.org/jdk/pull/122
On Wed, 1 Feb 2023 08:46:12 GMT, Alan Bateman wrote:
>> Hi Alan, here is output:
>>
>> level:0, strategy: 2, dowrap: true
>>
>> is finished: true
>> i
On Thu, 2 Feb 2023 08:27:55 GMT, Amit Kumar wrote:
>> DeInflate.java test fails on s390x platform because size for out1 array
>> which is responsible for storing the compressed data is insufficient. And
>> being unable to write whole compressed data on array, on s390 whole
On Thu, 2 Feb 2023 10:06:23 GMT, Alan Bateman wrote:
>>> level:1, strategy: 0, dowrap: false
>>> is finished: false
>>
>> Thanks for checking that. So "is finished: false" is telling us that not all
>> of the input was compressed. So I think the right thing is to do the defl
On Thu, 2 Feb 2023 08:27:55 GMT, Amit Kumar wrote:
>> DeInflate.java test fails on s390x platform because size for out1 array
>> which is responsible for storing the compressed data is insufficient. And
>> being unable to write whole compressed data on array, on s390 whole
On Thu, 2 Feb 2023 08:27:55 GMT, Amit Kumar wrote:
>> DeInflate.java test fails on s390x platform because size for out1 array
>> which is responsible for storing the compressed data is insufficient. And
>> being unable to write whole compressed data on array, on s390 whole
On Tue, 7 Feb 2023 07:07:54 GMT, Alan Bateman wrote:
>>> Hi @AlanBateman ,
>>> with latest changes (doing inflate/deinflate) test passes over s390 and x86
>>> as well. Please take a look now.
>>
>> Good. One thing to try is to just deflate/inflate into out1/out2, no need
>> for the intermediat
On Tue, 14 Feb 2023 20:08:47 GMT, Alan Bateman wrote:
>I don't think we have a good handle on the issue. It's clear that this zlib
>implementation is a bit different but I'm concerned that your proposed change
>to the test is masking an issue. I say this because the check method is
>changed to
On Wed, 15 Feb 2023 08:15:28 GMT, Alan Bateman wrote:
>I assume you can quickly check which loop, I suspect it's the deflate loop
>based of the previous comments/experiments.
Both of loop's are inf-loops with this change. If somehow I terminate the
first loop then second goes into infinite st
On Fri, 17 Feb 2023 09:01:23 GMT, Alan Bateman wrote:
>maybe change the loop to only test levels 0-9 and see if it passes?
`initial size: 525312`
error I'm facing is on level 1 not on -1.
level:1, strategy: 0, dowrap: false
required size: 553018 <- there is an issue
required size: 283432
This PR adds StressStackOverflow.java test to ProblemList. The feature Scope
Value is not yet implemented on s390x-arch which is Incubating state. Whenever
fix will be given to [JDK-8303498](https://bugs.openjdk.org/browse/JDK-8303498)
then we will remove it.
-
Commit messages:
-
On Thu, 2 Mar 2023 16:22:24 GMT, Amit Kumar wrote:
> This PR adds StressStackOverflow.java test to ProblemList. The feature Scope
> Value is not yet implemented on s390x-arch which is Incubating state.
> Whenever fix will be given to
> [JDK-8303498](https://bugs.openjdk.org/browse
On Thu, 2 Mar 2023 16:22:24 GMT, Amit Kumar wrote:
> This PR adds StressStackOverflow.java test to ProblemList. The feature Scope
> Value is not yet implemented on s390x-arch which is Incubating state.
> Whenever fix will be given to
> [JDK-8303498](https://bugs.openjdk.org/browse
On Thu, 2 Feb 2023 08:27:55 GMT, Amit Kumar wrote:
>> DeInflate.java test fails on s390x platform because size for out1 array
>> which is responsible for storing the compressed data is insufficient. And
>> being unable to write whole compressed data on array, on s390 whole
On Mon, 6 Mar 2023 06:54:27 GMT, Jaikiran Pai wrote:
>After running the test you can share with us the logs. We could provide more
>suggestions what to debug further, but I think you or someone with access to
>that system will have to do the actual investigation..
Output for above patch, I can
On Thu, 2 Feb 2023 08:27:55 GMT, Amit Kumar wrote:
>> DeInflate.java test fails on s390x platform because size for out1 array
>> which is responsible for storing the compressed data is insufficient. And
>> being unable to write whole compressed data on array, on s390 whole
On Thu, 2 Feb 2023 08:27:55 GMT, Amit Kumar wrote:
>> DeInflate.java test fails on s390x platform because size for out1 array
>> which is responsible for storing the compressed data is insufficient. And
>> being unable to write whole compressed data on array, on s390 whole
On Tue, 7 Mar 2023 02:23:52 GMT, David Holmes wrote:
>> This PR adds StressStackOverflow.java test to ProblemList. The feature Scope
>> Value is not yet implemented on s390x-arch which is Incubating state.
>> Whenever fix will be given to
>> [JDK-8303498](https://bugs.openjdk.org/browse/JDK-83
ix increase Array size (for s390).
Amit Kumar has updated the pull request incrementally with one additional
commit since the last revision:
removes out1,out2 parameters
-
Changes:
- all: https://git.openjdk.org/jdk/pull/12283/files
- new: https://git.openjdk.org/jdk/pull/122
On Mon, 6 Mar 2023 11:07:26 GMT, Jaikiran Pai wrote:
>Now coming to this proposed patch, now that you are using local
>ByteArrayOutputStream(s) for the deflate/inflate part in this check() method,
>I think the out1 and out2 should no longer be needed in this method and thus
>the method signatu
On Tue, 11 Apr 2023 18:07:41 GMT, Martin Doerr wrote:
> Another remark: Old JDK on s390 used "os.arch = zArch_64", current one
> "os.arch = s390x". @offamitkumar: You probably want to take a look.
Martin, only concern was that I didn't have a good experience with `s390x`
string in
[past](http
On Wed, 19 Apr 2023 13:22:54 GMT, Martin Doerr wrote:
>> Roger Riggs has updated the pull request with a new target base due to a
>> merge or a rebase. The pull request now contains 17 commits:
>>
>> - Merge branch 'master' into 8304915-arch-enum
>> - ArchTest on Debian RISC-V 64 confirmed by
On Mon, 17 Apr 2023 20:59:06 GMT, Roger Riggs wrote:
>> Define an internal jdk.internal.util.Architecture enumeration and static
>> methods to replace uses of the system property `os.arch`.
>> The enumeration values are defined to match those used in the build.
>> The initial values are: `X64, X
On Tue, 7 Mar 2023 05:57:34 GMT, Jaikiran Pai wrote:
>>> Finally, are you or someone in your team, in contact with the author(s) of
>>> the custom zlib implementation
>>> [iii-i/zlib@1132034](https://github.com/iii-i/zlib/commit/113203437eda67261848b14b6c80a33ff7e33d34)?
>>> Would you be able
On Wed, 26 Apr 2023 10:53:36 GMT, Jaikiran Pai wrote:
> These changes look fine to me.
Thanks @jaikiran for review and explanation. I'll update the PR description 🙃.
BTW these are not hotspot changes, So do we need 2 Reviewer for these as well ?
-
PR Comment: https://git.openjdk.
On Wed, 26 Apr 2023 20:29:41 GMT, Lance Andersen wrote:
>> Amit Kumar has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> removes out1,out2 parameters
>
> test/jdk/java/util/zip/DeInflate.java line 129:
>
On Thu, 27 Apr 2023 01:04:44 GMT, Jaikiran Pai wrote:
>> Amit Kumar has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> removes out1,out2 parameters
>
> Hello Lance,
>
>> Jai, have you run this across
a `ByteArrayOutputStream` to deflate into and then inflate
> from.
>
> Thanks to @jaikiran for amazing PR description.
Amit Kumar has updated the pull request incrementally with one additional
commit since the last revision:
comments from Lance
-
Changes:
- all: https:
On Thu, 27 Apr 2023 06:42:08 GMT, Jaikiran Pai wrote:
>> Amit Kumar has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> comments from Lance
>
> test/jdk/java/util/zip/DeInflate.java line 124:
>
>> 12
a `ByteArrayOutputStream` to deflate into and then inflate
> from.
>
> Thanks to @jaikiran for amazing PR description.
Amit Kumar has updated the pull request incrementally with one additional
commit since the last revision:
comment suggestion from @jaikiran
-
Changes:
-
On Thu, 27 Apr 2023 16:08:10 GMT, Andrey Turbanov wrote:
>> Amit Kumar has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> comment suggestion from @jaikiran
>
> test/jdk/java/util/zip/DeInflate.java line 146:
a `ByteArrayOutputStream` to deflate into and then inflate
> from.
>
> Thanks to @jaikiran for amazing PR description.
Amit Kumar has updated the pull request incrementally with one additional
commit since the last revision:
changes request by @turbanoff
-
Changes:
-
On Thu, 27 Apr 2023 01:04:44 GMT, Jaikiran Pai wrote:
>> Amit Kumar has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> removes out1,out2 parameters
>
> Hello Lance,
>
>> Jai, have you run this across
On Fri, 28 Apr 2023 08:31:05 GMT, Volker Simonis wrote:
>> Amit Kumar has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> changes request by @turbanoff
>
> test/jdk/java/util/zip/DeInflate.java line 16
a `ByteArrayOutputStream` to deflate into and then inflate
> from.
>
> Thanks to @jaikiran for amazing PR description.
Amit Kumar has updated the pull request incrementally with one additional
commit since the last revision:
suggestion from @simonis
-
Changes:
- all:
a `ByteArrayOutputStream` to deflate into and then inflate
> from.
>
> Thanks to @jaikiran for amazing PR description.
Amit Kumar has updated the pull request incrementally with one additional
commit since the last revision:
removes extra closing paren.
-
Changes:
-
On Fri, 28 Apr 2023 09:33:03 GMT, Volker Simonis wrote:
>> test/jdk/java/util/zip/DeInflate.java line 164:
>>
>>> 162: out2 = baos.toByteArray();
>>> 163: if (n != len ||
>>> 164: !Arrays.equals(in, 0, len, out2, 0, len)) ||
>>
>> There's a `)` too much.
a `ByteArrayOutputStream` to deflate into and then inflate
> from.
>
> Thanks to @jaikiran for amazing PR description.
Amit Kumar has updated the pull request incrementally with one additional
commit since the last revision:
changes from @LanceAndersen
-
Changes:
- all:
a `ByteArrayOutputStream` to deflate into and then inflate
> from.
>
> Thanks to @jaikiran for amazing PR description.
Amit Kumar has updated the pull request incrementally with one additional
commit since the last revision:
added space
-
Changes:
- all: https://git.op
On Fri, 28 Apr 2023 11:18:56 GMT, Amit Kumar wrote:
>> DeInflate.java test fails on s390x platform because size for out1 array
>> which is responsible for storing the compressed data is insufficient. And
>> being unable to write whole compressed data on array, on s390 whole
On Mon, 30 Jan 2023 08:03:38 GMT, Amit Kumar wrote:
> DeInflate.java test fails on s390x platform because size for out1 array which
> is responsible for storing the compressed data is insufficient. And being
> unable to write whole compressed data on array, on s390 whole data
This PR make s390x to adapt the changes done in
[JDK-8276901](https://bugs.openjdk.org/browse/JDK-8276901) OR implements
UseHeavyMonitors.
[JDK-8291555](https://bugs.openjdk.org/browse/JDK-8291555) still needs Porting
effort. As for `LM_LIGHTWEIGHT` locking mode, code is Unimplemented.
--
s390x needs to be recognised as `S390`. After
[JDK-8304913](https://bugs.openjdk.org/browse/JDK-8304913) during build I was
getting this PluginException:
jdk.tools.jlink.plugin.PluginException: ModuleTarget is malformed: No enum
constant jdk.internal.util.Architecture.S390X
at
jdk.jli
On Thu, 18 May 2023 06:12:19 GMT, Amit Kumar wrote:
> s390x needs to be recognised as `S390`. After
> [JDK-8304913](https://bugs.openjdk.org/browse/JDK-8304913) during build I was
> getting this PluginException:
>
> jdk.tools.jlink.plugin.PluginException: ModuleTarget is mal
On Thu, 18 May 2023 06:40:30 GMT, Thomas Stuefe wrote:
>> s390x needs to be recognised as `S390`. After
>> [JDK-8304913](https://bugs.openjdk.org/browse/JDK-8304913) during build I
>> was getting this PluginException:
>>
>> jdk.tools.jlink.plugin.PluginException: ModuleTarget is malformed: No
On Thu, 18 May 2023 06:12:19 GMT, Amit Kumar wrote:
> s390x needs to be recognised as `S390`. After
> [JDK-8304913](https://bugs.openjdk.org/browse/JDK-8304913) during build I was
> getting this PluginException:
>
> jdk.tools.jlink.plugin.PluginException: ModuleTarget is mal
On Fri, 9 Jun 2023 16:53:15 GMT, Andrew Haley wrote:
> Move `runWith()` from `VirtualThread` to `BaseVirtualThread`.
>
> `BoundVirtualThread` does not use `runWith()` to run its task, so when a VM
> error occurs it can not recover scoped values.
>
> Moving `runWith()` into the common subclass
On Mon, 26 Jun 2023 14:57:11 GMT, Roger Riggs wrote:
>> The internal enum jdk.internal.util.Architecture does not provide
>> information about the big or little endianness or the address size (64 or 32
>> bits). The endian-ness and address size are intrinsic to the architecture.
>>
>> The val
On Fri, 7 Jul 2023 07:55:03 GMT, sid8606 wrote:
> Implementation of "Foreign Function & Memory API" for s390x.
Will run test, maybe you want to adopt these changes. That's it for now.
src/hotspot/cpu/s390/downcallLinker_s390.cpp line 2:
> 1: /*
> 2: * Copyright (c) 2022, Oracle and/or its aff
On Sat, 22 Jul 2023 06:13:01 GMT, sid8606 wrote:
>> sid8606 has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Address suggestions from Jorn Vernee
>
> I have narrowed down the issue failing on glibc 2.31 but passes on glibc
> 2.35 on s39
Adds `classpath exception` in multiple files, affects copyright header only.
-
Commit messages:
- adds classpath exception
Changes: https://git.openjdk.org/jdk/pull/15070/files
Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=15070&range=00
Issue: https://bugs.openjdk.org/browse/
> Adds `classpath exception` in multiple files, affects copyright header only.
Amit Kumar has updated the pull request incrementally with one additional
commit since the last revision:
revert java.lang.foreign changes
-
Changes:
- all: https://git.openjdk.org/jdk/pull/15
On Wed, 26 Jul 2023 15:43:12 GMT, Per Minborg wrote:
> This PR suggests updating some of the ill-formed copyright headers in the FFM
> API and the implementation and test thereof.
>
> Some of the test files will have now the "classpath" exception. Is this
> correct?
Hi @minborg,
Would you a
On Mon, 31 Jul 2023 14:04:23 GMT, sid8606 wrote:
>> Implementation of "Foreign Function & Memory API" for s390x (Big Endian).
>
> sid8606 has updated the pull request incrementally with one additional commit
> since the last revision:
>
> List all the volatile regs in LinuxS390CallArranger ex
On Sat, 8 Jul 2023 10:48:15 GMT, sid8606 wrote:
>> Implementation of "Foreign Function & Memory API" for s390x (Big Endian).
>
> sid8606 has updated the pull request incrementally with one additional commit
> since the last revision:
>
> Address suggestions from Jorn Vernee
src/hotspot/cpu/s
On Thu, 13 Jul 2023 07:41:11 GMT, Amit Kumar wrote:
>> sid8606 has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Address suggestions from Jorn Vernee
>
> src/hotspot/cpu/s390/frame_s390.cpp line 228:
On Mon, 31 Jul 2023 18:13:07 GMT, Roger Riggs wrote:
>Please change the bug priority to P2; that is needed to be considered.
> Add a comment as described headlined with "Fix Request" and the described
> rationale and information.
Added comment and set priority to P2. This is low risk code chan
On Fri, 28 Jul 2023 17:39:18 GMT, Amit Kumar wrote:
>> Adds `classpath exception` in multiple files, affects copyright header only.
>
> Amit Kumar has updated the pull request incrementally with one additional
> commit since the last revision:
>
> revert java.lang.foreig
On Fri, 28 Jul 2023 13:02:20 GMT, Amit Kumar wrote:
> Adds `classpath exception` in multiple files, affects copyright header only.
This pull request has now been integrated.
Changeset: 53ca75b1
Author: Amit Kumar
URL:
https://git.openjdk.org/jdk/com
On Mon, 11 Sep 2023 14:24:31 GMT, Martin Doerr wrote:
>@offamitkumar, @deepa181, @JoKern65, @TOatGithub: You may want to check
>performance impact on s390x and AIX.
@TheRealMDoerr Testing on s390 is not possible for now, as build is broken due
to field resolution changes.
-
PR Co
On Thu, 9 Nov 2023 04:16:25 GMT, Roger Riggs wrote:
>> Strings, after construction, are immutable but may be constructed from
>> mutable arrays of bytes, characters, or integers.
>> The string constructors should guard against the effects of mutating the
>> arrays during construction that might
On Thu, 9 Nov 2023 09:22:45 GMT, suchismith1993 wrote:
> 1. use pragma directive to handle alignment.
>
> JBS Issue: [JDK-8318175](https://bugs.openjdk.org/browse/JDK-8318175)
LGTM
-
Marked as reviewed by amitkumar (Committer).
PR Review: https://git.openjdk.org/jdk/pull/16579#pu
On Tue, 21 Nov 2023 19:30:30 GMT, suchismith1993 wrote:
>> The math library in AIX specifically, is a static archive. Doing a -lm wont
>> suffice, because when the symbols are looked up using dlsym or accessing
>> native code through Java, it will lead to failures.
>> Hence we had to come up wi
On Wed, 4 Sep 2024 16:45:04 GMT, Amit Kumar wrote:
>> src/hotspot/cpu/s390/stubGenerator_s390.cpp line 3062:
>>
>>> 3060: StubCodeMark mark(this, "StubRoutines",
>>> "upcall_stub_load_target");
>>> 3061: address start = __ pc
On Wed, 4 Sep 2024 10:00:47 GMT, Martin Doerr wrote:
>> Jorn Vernee has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> add RISC-V as target platform
>
> src/hotspot/cpu/s390/stubGenerator_s390.cpp line 3062:
>
>> 3060: StubCodeMark mar
On Wed, 4 Sep 2024 17:03:32 GMT, Martin Doerr wrote:
>> Tier1 test are fine with/without "saving & restoring" return_pc;
>
> I found it:
> https://github.com/openjdk/jdk/blob/433f6d8a0643b59663bf76c0f3a2af27a6cc56b7/src/hotspot/cpu/s390/gc/g1/g1BarrierSetAssembler_s390.cpp#L238
> Called here:
>
This PR will ProblemList `jdk/java/util/zip/CloseInflaterDeflaterTest.java` on
s390x. This change should be reverted while fixing
[JDK-8339216](https://bugs.openjdk.org/browse/JDK-8339216).
-
Commit messages:
- problemlisted
Changes: https://git.openjdk.org/jdk/pull/20960/files
On Mon, 30 Sep 2024 09:19:21 GMT, Per Minborg wrote:
> This PR suggests fixing a problem on big-endian platforms.
Ran tier1 and got no regression for s390x. LGTM
-
Marked as reviewed by amitkumar (Committer).
PR Review: https://git.openjdk.org/jdk/pull/21258#pullrequestreview-2368
On Mon, 30 Sep 2024 09:19:21 GMT, Per Minborg wrote:
> This PR suggests fixing a problem on big-endian platforms.
@minborg , I am still getting error on s390x (big endian):
STDOUT:
test TestMismatch.random(): failure [197ms]
java.lang.AssertionError: expected [1] but found [0]
at org.t
On Tue, 5 Nov 2024 01:40:15 GMT, Patricio Chilano Mateo
wrote:
>> This is the implementation of JEP 491: Synchronize Virtual Threads without
>> Pinning. See [JEP 491](https://bugs.openjdk.org/browse/JDK-8337395) for
>> further details.
>>
>> In order to make the code review easier the changes
On Thu, 12 Sep 2024 05:12:18 GMT, Amit Kumar wrote:
> This PR will ProblemList `jdk/java/util/zip/CloseInflaterDeflaterTest.java`
> on s390x. This change should be reverted while fixing
> [JDK-8339216](https://bugs.openjdk.org/browse/JDK-8339216).
This pull request has now been i
On Wed, 18 Sep 2024 13:42:10 GMT, Lutz Schmidt wrote:
>> This PR will ProblemList `jdk/java/util/zip/CloseInflaterDeflaterTest.java`
>> on s390x. This change should be reverted while fixing
>> [JDK-8339216](https://bugs.openjdk.org/browse/JDK-8339216).
>
> Looks good. And trivial.
Thank you @R
On Fri, 6 Sep 2024 17:51:15 GMT, Jorn Vernee wrote:
>> As discussed in the JBS issue:
>>
>> FFM upcall stubs embed a `Method*` of the target method in the stub. This
>> `Method*` is read from the `LambdaForm::vmentry` field associated with the
>> target method handle at the time when the upcal
On Tue, 24 Sep 2024 04:49:51 GMT, Jaikiran Pai wrote:
>> This PR will ProblemList `jdk/java/util/zip/CloseInflaterDeflaterTest.java`
>> on s390x. This change should be reverted while fixing
>> [JDK-8339216](https://bugs.openjdk.org/browse/JDK-8339216).
>
> Hello Amit, following the process note
On Thu, 19 Sep 2024 12:20:13 GMT, Jorn Vernee wrote:
>> As discussed in the JBS issue:
>>
>> FFM upcall stubs embed a `Method*` of the target method in the stub. This
>> `Method*` is read from the `LambdaForm::vmentry` field associated with the
>> target method handle at the time when the upca
On Thu, 12 Sep 2024 05:12:18 GMT, Amit Kumar wrote:
> This PR will ProblemList `jdk/java/util/zip/CloseInflaterDeflaterTest.java`
> on s390x. This change should be reverted while fixing
> [JDK-8339216](https://bugs.openjdk.org/browse/JDK-8339216).
@RealLucy can you have a quick loo
On Thu, 7 Nov 2024 09:40:19 GMT, Alan Bateman wrote:
>I think we can add @requires vm.continuations to this test. It's not useful to
>run with the alternative virtual thread implementation.
Sure, that sounds ok. Thanks.
-
PR Comment: https://git.openjdk.org/jdk/pull/21565#issuecom
On Thu, 17 Oct 2024 14:28:30 GMT, Patricio Chilano Mateo
wrote:
> This is the implementation of JEP 491: Synchronize Virtual Threads without
> Pinning. See [JEP 491](https://bugs.openjdk.org/browse/JDK-8337395) for
> further details.
>
> In order to make the code review easier the changes hav
On Wed, 6 Nov 2024 17:38:59 GMT, Patricio Chilano Mateo
wrote:
>> Good work! I'll approve the GC related changes.
>>
>> There are some simplifications I think can be done in the ObjectMonitor
>> layer, but nothing that should go into this PR.
>>
>> Similarly, (even if some of this is preexist
On Wed, 20 Nov 2024 10:46:54 GMT, Sorna Sarathi wrote:
> This PR adds missing Classpath exception in several files.
>
> JBS Issue: [JDK-8334611](https://bugs.openjdk.org/browse/JDK-8344611)
This only adds information about the classpath exception copyright. So can't we
consider it trivial ? As
On Wed, 20 Nov 2024 10:46:54 GMT, Sorna Sarathi wrote:
> This PR adds missing Classpath exception in several files.
>
> JBS Issue: [JDK-8334611](https://bugs.openjdk.org/browse/JDK-8344611)
@jerboaa can we get one more approval ?
-
PR Comment: https://git.openjdk.org/jdk/pull/2227
On Wed, 20 Nov 2024 10:46:54 GMT, Sorna Sarathi wrote:
> This PR adds missing Classpath exception in several files.
>
> JBS Issue: [JDK-8334611](https://bugs.openjdk.org/browse/JDK-8344611)
Do similar change for:
src/java.base/share/native/libjava/ub.h
src/jdk.jlink/share/classes/jdk/tools/jl
On Mon, 2 Dec 2024 13:10:54 GMT, Per Minborg wrote:
>> This PR proposes to rewrite the `StringSupport::chunkedStrlen*` methods,
>> fixing a bug in the `short_strlen` variant for odd offsets (`offset % 2 !=
>> 0`).
>>
>> This PR also improves performance on modern hardware, as there is no need
On Mon, 25 Nov 2024 14:42:14 GMT, Per Minborg wrote:
> This PR proposes to fix some tests that fails on big-endian platforms.
fixes the issue for s390x as well.
-
Marked as reviewed by amitkumar (Committer).
PR Review: https://git.openjdk.org/jdk/pull/22362#pullrequestreview-24602
On Tue, 17 Dec 2024 08:04:25 GMT, Sorna Sarathi N wrote:
> Hi all,
>
> This pull request contains a backport of
> [openjdk/jdk#22704](https://github.com/openjdk/jdk/pull/22704.)
>
> The commit being backported was authored by Sorna Sarathi on 13 Dec 2024 and
> was r
java/lang/Thread/virtual/Starvation.java is failing on s390x with Timeout error
as continuations support is not there for s390x.
-
Commit messages:
- mandate continuations
Changes: https://git.openjdk.org/jdk/pull/22702/files
Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=22702
On Thu, 12 Dec 2024 09:08:14 GMT, Alan Bateman wrote:
> This looks okay. Would it be possible to change the PR title to match the JBS
> issue as this issue isn't specific to s390x.
Done.
-
PR Comment: https://git.openjdk.org/jdk/pull/22702#issuecomment-2538335448
On Thu, 12 Dec 2024 04:33:59 GMT, Amit Kumar wrote:
> java/lang/Thread/virtual/Starvation.java is failing on s390x with Timeout
> error as continuations support is not there for s390x.
Can we consider this trivial ? It's not hotspot change as well.
-
PR Com
On Thu, 12 Dec 2024 04:33:59 GMT, Amit Kumar wrote:
> java/lang/Thread/virtual/Starvation.java is failing on s390x with Timeout
> error as continuations support is not there for s390x.
This pull request has now been integrated.
Changeset: 68aa4d44
Author: Amit Kumar
URL:
On Thu, 12 Dec 2024 04:33:59 GMT, Amit Kumar wrote:
> java/lang/Thread/virtual/Starvation.java is failing on s390x with Timeout
> error as continuations support is not there for s390x.
Thanks Alan, Viktor for the reviews.
-
PR Comment: https://git.openjdk.org/jdk/pull
On Thu, 12 Dec 2024 08:04:38 GMT, Sorna Sarathi wrote:
> This PR adds missing Classpath exception statements in several files.
>
> JDK Issue: [JDK-8346069](https://bugs.openjdk.org/browse/JDK-8346069)
@irisclark can we get review for this change.
-
PR Comment: https://git.openjdk.
On Thu, 12 Dec 2024 08:04:38 GMT, Sorna Sarathi wrote:
> This PR adds missing Classpath exception statements in several files.
>
> JDK Issue: [JDK-8346069](https://bugs.openjdk.org/browse/JDK-8346069)
LGTM
-
Marked as reviewed by amitkumar (Committer).
PR Review: https://git.open
(refer
above link for more information about raising the PR)
- Amit
On 4 Jan 2025, at 8:33 PM, Amit Kumar wrote:
 There exist a dedicated page for this kind of information, please go through
it: https://openjdk.org/guide/#contributing-to-an-openjdk-project
Moreover you can’t create issue
1 - 100 of 101 matches
Mail list logo
