This issue is reproducible with and without `--mac-sign`. jpackage will
"_ad-hoc_" sign application bundle when `--mac-sign` is not specified by using
pseudo-identity "_-_". This is why jpackage tries to sign added files and this
is expected behavior by jpackage. "codesign" fails since added con
?
Yes, you already suggested it. See https://bugs.openjdk.org/browse/JDK-8318063
and it was closed as won’t fix because such verification is redundant.
Thanks,
Alexander
From: Michael Hall
Date: Friday, May 24, 2024 at 1:47 AM
To: Alexander Matveev
Cc: core-libs-dev
Subject: Re: RFR: 8332110
On Fri, 24 May 2024 01:08:03 GMT, Alexander Matveev
wrote:
> This issue is reproducible with and without `--mac-sign`. jpackage will
> "_ad-hoc_" sign application bundle when `--mac-sign` is not specified by
> using pseudo-identity "_-_". This is why jpackage tri
On Tue, 28 May 2024 20:13:24 GMT, Alexey Semenyuk wrote:
> Add missing "--add-opens jdk.jpackage/jdk.jpackage.internal=ALL-UNNAMED" to
> the test descriptor
Looks good.
-
Marked as reviewed by almatvee (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/19436#pullrequestrevie
On Thu, 30 May 2024 20:26:02 GMT, Alexey Semenyuk wrote:
> Change jpackage tests output from:
>
>
> [19:16:29.586] Create: SimplePackageTest.test
> [19:16:29.587] [ RUN ] SimplePackageTest.test
> [19:16:29.663] TRACE: Bundler rpm supported
> [19:16:29.674] TRACE: Actions: [[initialize], [create
he application bundle and caused the failure. Ensure content
> supplied via the "--app-content" parameter does not break the integrity of
> the application bundle, or add it in the post-processing step.
> Error: "codesign" failed with following output:
> Test.app:
On Thu, 30 May 2024 22:54:12 GMT, Alexander Matveev
wrote:
>> This issue is reproducible with and without `--mac-sign`. jpackage will
>> "_ad-hoc_" sign application bundle when `--mac-sign` is not specified by
>> using pseudo-identity "_-_". This is
On Thu, 30 May 2024 20:26:02 GMT, Alexey Semenyuk wrote:
> Change jpackage tests output from:
>
>
> [19:16:29.586] Create: SimplePackageTest.test
> [19:16:29.587] [ RUN ] SimplePackageTest.test
> [19:16:29.663] TRACE: Bundler rpm supported
> [19:16:29.674] TRACE: Actions: [[initialize], [create
On Thu, 30 May 2024 20:10:05 GMT, Alexey Semenyuk wrote:
> - Get rid of DottedVersion#greedy field.
> - Add support to save the unrecognizable remainder of the version string
> (required to handle Wix4 version string).
> - Implement DottedVersion#equals().
> - add DottedVersion#compareCompone
On Thu, 30 May 2024 14:21:51 GMT, Alexey Semenyuk wrote:
>> Alexander Matveev has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> 8332110: jpackage tries to sign added files without the --mac-sign option
>> [v
On Fri, 24 May 2024 01:08:03 GMT, Alexander Matveev
wrote:
> This issue is reproducible with and without `--mac-sign`. jpackage will
> "_ad-hoc_" sign application bundle when `--mac-sign` is not specified by
> using pseudo-identity "_-_". This is why jpackage tri
On Fri, 31 May 2024 20:43:45 GMT, Nir Lisker wrote:
> > > For your example. This almost seems like an Apple bug if you can add a
> > > directory to the Contents directory but not a file?
> >
> >
> > Not sure if it is an Apple bug.
>
> Can this be reported to Apple somehow?
I do not think tha
On Fri, 31 May 2024 21:36:56 GMT, Nir Lisker wrote:
> I see, but it doesn't say where to put license files, which are usually in
> the root. Do you know where these belong?
No idea.
-
PR Comment: https://git.openjdk.org/jdk/pull/19377#issuecomment-2143025767
On Fri, 31 May 2024 14:05:07 GMT, Alexey Semenyuk wrote:
> Fix MainClassTest class to use HelloApp.AppOutputVerifier class to run app
> launcher instead of raw Executor. This makes MainClassTest test run app
> launchers with retries. This change addresses the primary issue.
>
> Fix inconsisten
On Mon, 3 Jun 2024 20:29:47 GMT, Alexey Semenyuk wrote:
> 8333452: Make logging in jdk.jpackage.internal.OverridableResource class
> configurable
OverridableResource uses Log.verbose, which will log if -verbose is specified.
What do you mean by "OverridableResource class unconditionally writes
On Tue, 4 Jun 2024 01:29:15 GMT, Alexey Semenyuk wrote:
> > Is there plan to add support for WiX 5?
>
> This patch supports WiX5 as well. There is not much difference between WiX4
> and WiX5 from jpackage perspective. I'll update the description
I assume WiX5 will just work if installed instea
On Wed, 5 Jun 2024 14:53:09 GMT, Alexey Semenyuk wrote:
>> src/jdk.jpackage/windows/classes/jdk/jpackage/internal/resources/WinResources.properties
>> line 44:
>>
>>> 42: resource.installdirnotemptydlg-wix-file=Not empty install directory
>>> dialog WiX project file
>>> 43: resource.launcher-a
On Tue, 4 Jun 2024 12:37:03 GMT, Alexey Semenyuk wrote:
> > I assume WiX5 will just work if installed instead of WiX4?
>
> Correct.
>
> > Do you think it will make sense to introduce Wix5 ToolsetType in case if we
> > need to do something different between 4 and 5?
>
> They claim WiX5 is back
On Wed, 3 Jul 2024 04:11:40 GMT, Vanitha B P wrote:
>> Created jtreg test case for
>> [JDK-8325203](https://bugs.openjdk.org/browse/JDK-8325203) issue.
>>
>> The JpackageTest created tests that the child process started from the app
>> launched by jpackage launcher is not automatically termina
On Tue, 9 Jul 2024 16:12:58 GMT, Vanitha B P wrote:
>> Created jtreg test case for
>> [JDK-8325203](https://bugs.openjdk.org/browse/JDK-8325203) issue.
>>
>> The JpackageTest created tests that the child process started from the app
>> launched by jpackage launcher is not automatically termina
On Wed, 24 Jul 2024 12:20:05 GMT, Vanitha B P wrote:
> tools/jpackage/windows/WinChildProcessTest.java was failing intermittently,
> fixed the issue and changes are tested.
Looks good. I will approve once comments from Alexey are resolved.
-
PR Comment: https://git.openjdk.org/jdk
On Thu, 25 Jul 2024 08:40:44 GMT, Vanitha B P wrote:
>> tools/jpackage/windows/WinChildProcessTest.java was failing intermittently,
>> fixed the issue and changes are tested.
>
> Vanitha B P has updated the pull request incrementally with one additional
> commit since the last revision:
>
>
Hi Michael,
It is not possible to provide a unique or hashed CFBundleIdentifier. We already
implemented to throw error if —strip-native-commands are not provided to jlink
or if provided runtime contain bin directory.
Look at https://github.com/openjdk/jdk/pull/8666
Thanks,
Alexander
On Sep 27,
On Wed, 28 Sep 2022 09:45:32 GMT, KIRIYAMA Takuya wrote:
>> Could you please review the JDK-8293579 bug fixes?
>>
>> tools/jpackage/share/jdk/jpackage/tests/UnicodeArgsTest.java attempts to
>> give
>> the launcher the character which is encoded by Windows API
>> WideCharToMultiByte()
>> from
Hi Michael,
If I understood correctly you asking for several things:
1) Change “/Applications” to “Applications”. I agree and we should fix it if
possible. Did you file a bug for it? If not I can file.
2) Resize DMG window to show additional content which was added via
--mac-dmg-content, so us
Hi Michael,
On Oct 31, 2022, at 2:40 PM, Michael Hall
mailto:mik3h...@gmail.com>> wrote:
On Oct 31, 2022, at 4:17 PM, Alexander Matveev
mailto:alexander.matv...@oracle.com>> wrote:
Hi Michael,
Hello Alexander,
If I understood correctly you asking for several things
Hi Michael.
If you mean http://mikehall.pairserver.com/DMG_windows.dmg, then I cannot open
this link. It says file not found.
Thanks,
Alexander
On Oct 31, 2022, at 4:21 PM, Michael Hall
mailto:mik3h...@gmail.com>> wrote:
On Oct 31, 2022, at 5:56 PM, Alexander Matveev
mailto:alexande
Changed names of symbolic links for drag and drop location in DMG image. See
attached images in JBS.
"/Applications" -> "Applications" for app DMG image.
"/Library/Java/JavaVirtualMachines" -> "JavaVirtualMachines" for runtime DMG
image.
Automated test was not added, since DMGsetup.scpt is not g
ime DMG
> image.
>
> Automated test was not added, since DMGsetup.scpt is not getting executed in
> headless environment and thus symbolic links are not created during automated
> testing.
Alexander Matveev has updated the pull request incrementally with one
additional commit since th
On Fri, 4 Nov 2022 23:44:15 GMT, Alexey Semenyuk wrote:
>> Alexander Matveev has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> 8296154: [macos] Change /Applications to Applications in DMG image [v2]
>
> src/j
On Fri, 4 Nov 2022 23:26:00 GMT, Alexander Matveev wrote:
> Changed names of symbolic links for drag and drop location in DMG image. See
> attached images in JBS.
> "/Applications" -> "Applications" for app DMG image.
> "/Library/Java/JavaVirtualMachin
Additional DMG content will be arranged in raws with 3 items per raw. DMG
windows will be resized to show one or two raws without any scrolling required.
To see any additional content after two raws (7 or more items) user will need
to use vertical scroll bar. See JBS for screen shots.
-
On Wed, 9 Nov 2022 20:02:05 GMT, Alexander Matveev wrote:
> Additional DMG content will be arranged in raws with 3 items per raw. DMG
> windows will be resized to show one or two raws without any scrolling
> required. To see any additional content after two raws (7 or more items) use
On Mon, 5 Dec 2022 22:20:19 GMT, Alexey Semenyuk wrote:
> Simply increase timeout limit to make test pass on slower/loaded hosts
Marked as reviewed by almatvee (Reviewer).
-
PR: https://git.openjdk.org/jdk/pull/11522
On Mon, 5 Dec 2022 22:14:50 GMT, Alexey Semenyuk wrote:
> - throw an exception if icon swap fails with the corresponding l10n message;
> - add retries to the jpackage test routine that extracts an icon from a
> launcher
Marked as reviewed by almatvee (Reviewer).
-
PR: https://git.
This issue is similar to JDK-8277493. Looks like macOS 13 cannot execute
unsigned code and code should be at least ad hoc signed. Same as for macOS
aarch64. Fixed by enabling ad hoc signing for macOS platform for both x64 and
aarch64.
-
Commit messages:
- 8298488: [macos13] tools/
On Mon, 12 Dec 2022 21:23:50 GMT, Alexander Matveev
wrote:
> This issue is similar to JDK-8277493. Looks like macOS 13 cannot execute
> unsigned code and code should be at least ad hoc signed. Same as for macOS
> aarch64. Fixed by enabling ad hoc signing for macOS platform for bot
On Thu, 15 Dec 2022 20:43:42 GMT, Damon Nguyen wrote:
>> Open l10n drop
>> All tests passed
>
> Damon Nguyen has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Fix https and changed URL back
src/jdk.jpackage/share/classes/jdk/jpackage/interna
On Thu, 15 Dec 2022 23:01:35 GMT, Damon Nguyen wrote:
>> Open l10n drop
>> All tests passed
>
> Damon Nguyen has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Revert double quote as well
src/jdk.jpackage/windows/classes/jdk/jpackage/internal
On Fri, 16 Dec 2022 00:15:51 GMT, Damon Nguyen wrote:
>> src/jdk.jpackage/share/classes/jdk/jpackage/internal/resources/MainResources_de.properties
>> line 82:
>>
>>> 80:
>>> 81: error.foreign-app-image=Fehler: .jpackage.xml-Datei fehlt in
>>> app-image-Verzeichnis ({0})
>>> 82: error.invalid
On Fri, 16 Dec 2022 00:24:26 GMT, Damon Nguyen wrote:
>> src/jdk.jpackage/windows/classes/jdk/jpackage/internal/resources/WinResources_ja.properties
>> line 37:
>>
>>> 35:
>>> resource.post-app-image-script=\u30A2\u30D7\u30EA\u30B1\u30FC\u30B7\u30E7\u30F3\u30FB\u30A4\u30E1\u30FC\u30B8\u3092\u7
On Fri, 16 Dec 2022 03:38:54 GMT, Damon Nguyen wrote:
>> Open l10n drop
>> All tests passed
>
> Damon Nguyen has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Revert old translation. Fix lang codes
jpackage changes looks good.
-
On Thu, 5 Jan 2023 20:10:45 GMT, Alexey Semenyuk wrote:
> 8299278: tools/jpackage/share/AddLauncherTest.java#id1 failed
> AddLauncherTest.bug8230933
Marked as reviewed by almatvee (Reviewer).
-
PR: https://git.openjdk.org/jdk/pull/11868
On Mon, 9 Jan 2023 22:53:18 GMT, Alexey Semenyuk wrote:
> Increase failed test timeouts.
> Simple tests got an x1.5 increase and parametrized tests got an x2 increase
Marked as reviewed by almatvee (Reviewer).
-
PR: https://git.openjdk.org/jdk/pull/11914
- Fixed by increasing test timeout. Fix verified on host which reproduced issue.
-
Commit messages:
- 8299779: Test tools/jpackage/share/jdk/jpackage/tests/MainClassTest.java
timed out
Changes: https://git.openjdk.org/jdk/pull/12896/files
Webrev: https://webrevs.openjdk.org/?repo=
On Tue, 7 Mar 2023 00:56:02 GMT, Alexander Matveev wrote:
> - Fixed by increasing test timeout. Fix verified on host which reproduced
> issue.
This pull request has now been integrated.
Changeset: 0a4d54f7
Author:Alexander Matveev
URL:
https://git.openjdk.org/jdk/
On Thu, 16 Mar 2023 09:08:08 GMT, Matthias Baesken wrote:
>> The test fails on Alpine Linux 3.17, when checking the environment variable
>> LD_LIBRARY_PATH; looks like the actual env variable is much longer than the
>> test expects. It turned out that at least on Linux (probably also on other
This is similar to many other issues we had with `hdiutil` failures. Fixed in
similar way by repeating `hdiutil` command. Cannot confirm that it will resolve
this issue, but similar issues got resolved by repeating command. Also,
switched writing output from `hdiutil` to file. It is known issue
On Mon, 13 Mar 2023 16:50:51 GMT, Alexander Matveev
wrote:
> This is similar to many other issues we had with `hdiutil` failures. Fixed in
> similar way by repeating `hdiutil` command. Cannot confirm that it will
> resolve this issue, but similar issues got resolved by repeatin
On Mon, 10 Apr 2023 21:16:19 GMT, Alexey Semenyuk wrote:
> When `--main-jar` is specified and the name of the main class is picked from
> the jar's manifest, set `app.jarfile` property in launcher cfg file instead
> of `app.mainclass` and `app.classpath` properties to make app launcher run
> t
On Fri, 5 May 2023 14:12:21 GMT, Roger Riggs wrote:
>> Refactor the Platform class in jdk.jpackage to use the internal
>> OperatingSystem, Architecture, and Version classes.
>> The OperatingSystem.isXXX() and Architecture.isYYY() methods replace
>> comparisons in the Platform class.
>> The chec
On Mon, 15 May 2023 20:10:38 GMT, Roger Riggs wrote:
>> src/jdk.jpackage/share/classes/jdk/jpackage/internal/CLIHelp.java line 51:
>>
>>> 49: Log.info(I18N.getString("MSG_Help_no_args"));
>>> 50: } else {
>>> 51: OperatingSystem platform = OperatingSystem.current(
On Mon, 15 May 2023 22:51:52 GMT, Roger Riggs wrote:
>> Refactor the Platform class in jdk.jpackage to use the internal
>> OperatingSystem, Architecture, and Version classes.
>> The OperatingSystem.isXXX() and Architecture.isYYY() methods replace
>> comparisons in the Platform class.
>> The che
qXNrWDeLTm0q-Z69dZ98EP_SNaNq4XEfm_LtGBAUzlzYWY5RAtroQ$
> .
Alexander Matveev has updated the pull request incrementally with one
additional commit since the last revision:
8287971: Throw exception for missing values in .jpackage.xml [v2]
-
Changes:
- all: https://git.openjdk.org/jdk
On Tue, 14 Jun 2022 18:07:12 GMT, Alexey Semenyuk wrote:
>> Alexander Matveev has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> 8287971: Throw exception for missing values in .jpackage.xml [v2]
>
> src/
On Thu, 16 Jun 2022 05:15:27 GMT, Alexey Semenyuk wrote:
> Run a script extracting icons from executables as PowerShell command line
> rather than a script
Marked as reviewed by almatvee (Reviewer).
-
PR: https://git.openjdk.org/jdk19/pull/26
fed1_edIOYL5-MqdziwEb_3iNi3T8oFSoldnyr3Gbz_8xPC-of21OjvRc3oLJ-J5w6V0Lpkng$
> .
Alexander Matveev has updated the pull request incrementally with one
additional commit since the last revision:
8287971: Throw exception for missing values in .jpackage.xml [v3]
-
Changes:
- all: https://git.openjdk.org/jdk
On Thu, 16 Jun 2022 18:21:02 GMT, Alexander Matveev
wrote:
>> - Error will be thrown if app image is generated with another JDK version or
>> has malformed .jpackage.xml.
>> - Re-fixed as Alexey suggested in
>> https://urldefense.com/v3/__https://github.com
P1nBOzWYLKB3-vd2Kai_PP_xq482TZ8ZfXiUEmg2xwSLTYQF3Bw$
> .
Alexander Matveev has updated the pull request incrementally with one
additional commit since the last revision:
8287971: Throw exception for missing values in .jpackage.xml [v4]
-
Changes:
- all: https://git.openjdk.org/jdk
On Fri, 17 Jun 2022 17:01:10 GMT, Alexey Semenyuk wrote:
>> Alexander Matveev has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> 8287971: Throw exception for missing values in .jpackage.xml [v3]
>
> test/
On Mon, 13 Jun 2022 17:01:48 GMT, Alexander Matveev
wrote:
> - Error will be thrown if app image is generated with another JDK version or
> has malformed .jpackage.xml.
> - Re-fixed as Alexey suggested in
> https://urldefense.com/v3/__https://github.com/openjdk/jdk
Hi Michael,
Did you modified app image after it was signed and before DMG was created? If
yes, it is expected behavior and we will not sign app image when generating DMG.
Can you provide all steps you did to get to issue below?
Thanks,
Alexander
> On Jun 22, 2022, at 1:51 PM, Michael Hall wro
;
>>
>>> On Jun 22, 2022, at 6:57 PM, Alexander Matveev
>>> wrote:
>>>
>>> Hi Michael,
>>>
>>> Did you modified app image after it was signed and before DMG was created?
>>> If yes, it is expected behavior and we will not
Hi Michael,
I filed it as https://bugs.openjdk.org/browse/JDK-8289030
Thanks,
Alexander
On Jun 22, 2022, at 5:40 PM, Michael Hall
mailto:mik3h...@gmail.com>> wrote:
On Jun 22, 2022, at 7:36 PM, Alexander Matveev
mailto:alexander.matv...@oracle.com>> wrote:
Hi Michael,
I
On Wed, 22 Jun 2022 11:53:39 GMT, Alex Kasko wrote:
> Please review this minor fix to the jpackage test suite.
>
> When `INSTALL` and `UNINSTALL` actions are enabled for jpackage test suite
> runs (disabled by default), installation of `EXE` and `MSI` packages is
> performed. `EXE` package is
On Wed, 8 Jun 2022 11:46:42 GMT, Alex Kasko wrote:
> In jpackage test suite there is a test utility
> WindowsHelper.queryRegistryValue . It is used to verify changes to Windows
> registry that can be done by installer packages. It spawns `reg.exe query`
> process and parses its output. This pa
Fixed 3 issues which made signature invalid:
- We should not remove .jpackage.xml from signed app image when creating DMG or
PKG otherwise it invalidates signature.
- .package should be created when app image is generated, so this file can be
signed.
- Copying predefine app image for DMG and PKG
On Wed, 29 Jun 2022 03:03:15 GMT, Alexander Matveev
wrote:
> Fixed 3 issues which made signature invalid:
> - We should not remove .jpackage.xml from signed app image when creating DMG
> or PKG otherwise it invalidates signature.
> - .package should be created when app image is g
when DMG or PKG is generated from
> predefined app image.
Alexander Matveev has updated the pull request with a new target base due to a
merge or a rebase. The incremental webrev excludes the unrelated changes
brought in by the merge/rebase. The pull request contains three additional
commit
On Mon, 4 Jul 2022 23:38:08 GMT, Alex Kasko wrote:
>> jpackage implementation of file association on Windows currently passes a
>> selected filename as an only argument to associated executable.
>>
>> It is proposed to introduce additional option in file association property
>> file to allow o
On Thu, 7 Jul 2022 17:07:51 GMT, Alexey Semenyuk wrote:
>> Alexander Matveev has updated the pull request with a new target base due to
>> a merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contain
On Thu, 7 Jul 2022 17:11:23 GMT, Alexey Semenyuk wrote:
>> Alexander Matveev has updated the pull request with a new target base due to
>> a merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contain
when DMG or PKG is generated from
> predefined app image.
Alexander Matveev has updated the pull request incrementally with one
additional commit since the last revision:
8289030: [macos] app image signature invalid when creating DMG or PKG [v3]
-
Changes:
- all: https://git.ope
On Wed, 29 Jun 2022 03:03:15 GMT, Alexander Matveev
wrote:
> Fixed 3 issues which made signature invalid:
> - We should not remove .jpackage.xml from signed app image when creating DMG
> or PKG otherwise it invalidates signature.
> - .package should be created when app image is g
On Thu, 7 Jul 2022 19:52:57 GMT, Alexey Semenyuk wrote:
>> We need to add `.package` file during app image creation, since we need to
>> sign it. With your proposed change we will add `.package` file to already
>> signed app image.
>
> Oh, right.
> Anyways let's keep `.package`-related stuff aw
On Sat, 16 Jul 2022 22:08:12 GMT, Alexey Semenyuk wrote:
>> 8283707: Support version format on Windows
>
> Alexey Semenyuk has updated the pull request incrementally with one
> additional commit since the last revision:
>
> Comments fixed and better naming in the code.
Marked as reviewed by
On Sat, 16 Jul 2022 21:22:46 GMT, Alexey Semenyuk wrote:
> 8290398: jpackage exe instellers are not installed in jtreg tests
Marked as reviewed by almatvee (Reviewer).
-
PR: https://git.openjdk.org/jdk/pull/9530
On Sat, 16 Jul 2022 21:32:07 GMT, Alexey Semenyuk wrote:
> 8290400: Must run exe installers in jpackage jtreg tests without UI
Marked as reviewed by almatvee (Reviewer).
-
PR: https://git.openjdk.org/jdk/pull/9531
On Sat, 16 Jul 2022 21:47:43 GMT, Alexey Semenyuk wrote:
> 8290402: jpackage exe uninstallers don't return correct exit code in case of
> failure
src/jdk.jpackage/windows/native/msiwrapper/MsiWrapper.cpp line 53:
> 51:
> 52: // Uninstall product.
> 53: msi::SuppressUI suppress
On Sat, 16 Jul 2022 21:47:43 GMT, Alexey Semenyuk wrote:
> 8290402: jpackage exe uninstallers don't return correct exit code in case of
> failure
Marked as reviewed by almatvee (Reviewer).
-
PR: https://git.openjdk.org/jdk/pull/9532
On Fri, 22 Jul 2022 20:21:57 GMT, Alexey Semenyuk wrote:
> 8290557: tools/jpackage/share/AddLauncherTest.java#id1 failed with "ERROR:
> Failed: Check icon file"
Marked as reviewed by almatvee (Reviewer).
-
PR: https://git.openjdk.org/jdk/pull/9618
On Fri, 5 Aug 2022 16:14:35 GMT, Alex Kasko wrote:
> This change is a follow-up to [this
> comment](https://bugs.openjdk.org/browse/JDK-8290519?focusedCommentId=14512038&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-14512038).
>
> Override implementation is based
On Fri, 5 Aug 2022 16:14:35 GMT, Alex Kasko wrote:
> This change is a follow-up to [this
> comment](https://bugs.openjdk.org/browse/JDK-8290519?focusedCommentId=14512038&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-14512038).
>
> Override implementation is based
On Mon, 8 Aug 2022 19:52:41 GMT, Alex Kasko wrote:
>> This change adds `ContextMenuCommandLabel` l10n property for file
>> association context menu label. It is a follow-up to [this PR
>> comment](https://github.com/openjdk/jdk/pull/9224#issuecomment-1169286082).
>>
>> Note, non-EN l10n values
On Fri, 19 Aug 2022 15:41:47 GMT, Alexey Semenyuk wrote:
> Get rid of dependencies on specific jtreg's jars from jpackage junit tests.
>
> The troublesome statement was `* @library ${jtreg.home}/lib/junit.jar
> ${jtreg.home}/lib/hamcrest.jar` in "junit.java". The fix removes "junit.java"
> and
Hi Michael,
Did you generate application image with same JDK version (19+36-2238)? With
latest JDK version .jpackage.xml file should be present. We do not support
signing of application images generate by another versions of JDK. It should be
same JDK.
Thanks,
Alexander
> On Sep 5, 2022, at 4
ander
On Sep 7, 2022, at 6:28 AM, Michael Hall
mailto:mik3h...@gmail.com>> wrote:
On Sep 6, 2022, at 8:00 PM, Michael Hall
mailto:mik3h...@gmail.com>> wrote:
On Sep 6, 2022, at 4:52 PM, Michael Hall
mailto:mik3h...@gmail.com>> wrote:
On Sep 6, 2022, at 4:48 PM, Alexand
Problem is that [JDK-8286850](https://bugs.openjdk.org/browse/JDK-8286850)
never set correct value in .jpackage.xml to mark image as signed.
[JDK-8289030](https://bugs.openjdk.org/browse/JDK-8289030) reads this value to
check if we can add per-user and system wide configuration to packaged app.
On Fri, 9 Sep 2022 13:38:14 GMT, Julian Waters wrote:
> tstrings::any() has an overload for std::wstring (if required) but is missing
> the corresponding operator overload for std::string, leaving only the
> templated one as a fallback, which will expand into a std::wostringstream <<
> std::st
iguration to packaged
> app. Fixed by setting correct value in .jpackage.xml when we signing
> predefine application image.
>
> Added tests to cover this case and added check for values inside
> .jpackage.xml to validate signed and Mac App Store values.
Alexander Matveev h
On Mon, 19 Sep 2022 18:51:30 GMT, Alexey Semenyuk wrote:
>> Alexander Matveev has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> 8293462: [macos] app image signature invalid when creating DMG or PKG from
>> p
Hi Michael,
On Sep 16, 2022, at 6:19 PM, Michael Hall
mailto:mik3h...@gmail.com>> wrote:
On Sep 16, 2022, at 6:02 PM, Alexander Matveev
mailto:almat...@openjdk.org>> wrote:
Problem is that [JDK-8286850](https://bugs.openjdk.org/browse/JDK-8286850)
never set correct value in .
On Fri, 23 Sep 2022 20:40:29 GMT, Alexey Semenyuk wrote:
>> Alexander Matveev has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> 8293462: [macos] app image signature invalid when creating DMG or PKG from
>> p
iguration to packaged
> app. Fixed by setting correct value in .jpackage.xml when we signing
> predefine application image.
>
> Added tests to cover this case and added check for values inside
> .jpackage.xml to validate signed and Mac App Store values.
Alexander Matveev h
On Fri, 16 Sep 2022 22:55:52 GMT, Alexander Matveev
wrote:
> Problem is that [JDK-8286850](https://bugs.openjdk.org/browse/JDK-8286850)
> never set correct value in .jpackage.xml to mark image as signed.
> [JDK-8289030](https://bugs.openjdk.org/browse/JDK-8289030) reads this value
&
On Thu, 13 Jul 2023 07:27:22 GMT, yaqsun wrote:
>> The prerequisite is to install the rpmbuild command, when multiple users
>> switch to write /var/tmp/*.files will have the permission forbidden.
>
> yaqsun has updated the pull request incrementally with one additional commit
> since the last r
On Tue, 11 Jul 2023 23:47:30 GMT, airsquared wrote:
> [JDK-8309032](https://bugs.openjdk.org/browse/JDK-8309032),
> [JDK-8306488](https://bugs.openjdk.org/browse/JDK-8306488)
Marked as reviewed by almatvee (Reviewer).
-
PR Review: https://git.openjdk.org/jdk/pull/14840#pullrequest
On Thu, 20 Jul 2023 02:04:53 GMT, Alexey Semenyuk wrote:
>> [JDK-8309032](https://bugs.openjdk.org/browse/JDK-8309032),
>> [JDK-8306488](https://bugs.openjdk.org/browse/JDK-8306488)
>
> @sashamatveev would you like to review the change before I sponsor it?
@alexeysemenyukoracle Looks good.
---
On Fri, 21 Jul 2023 10:55:13 GMT, Vladimir Petko wrote:
> Use the same approach as Logger::defaultLogger() to ensure that the appender
> is not destroyed before shared object destructor function is executed.
>
> The alternative is to delete dcon() function, but we might run into a
> similiar
On Sat, 22 Jul 2023 21:41:06 GMT, Vladimir Petko wrote:
>> Use the same approach as Logger::defaultLogger() to ensure that the
>> appender is not destroyed before shared object destructor function is
>> executed.
>>
>> The alternative is to delete dcon() function, but we might run into a
>>
1 - 100 of 369 matches
Mail list logo
