Re: RFR: 8357919: Arena::allocate returns segments with address zero if the segment length is zero after JDK-8345687

2025-05-28 Thread Maurizio Cimadamore
On Wed, 28 May 2025 09:06:57 GMT, Per Minborg wrote: > After https://bugs.openjdk.org/browse/JDK-8345687 was integrated, zero-length > segments always have an address of zero. This may cause problems in certain > native methods that can receive segments and/or buffers derived from segments. >

Re: RFR: 8356553 : Incorrect uses of {@link} in AbstractQueuedLongSynchronizer and AbstractQueuedSynchronizer

2025-05-28 Thread Viktor Klang
On Tue, 27 May 2025 15:51:34 GMT, Nizar Benalla wrote: >> I had to tweak the language a bit to better reflect the intent of the text. > > Thanks for doing this! There are no longer any links to private types in > `java.util.concurrent` Thanks @nizarbenalla ! @DougLea Do you think this modifica

Re: RFR: 8357919: Arena::allocate returns segments with address zero if the segment length is zero after JDK-8345687

2025-05-28 Thread Maurizio Cimadamore
On Wed, 28 May 2025 09:06:57 GMT, Per Minborg wrote: > After https://bugs.openjdk.org/browse/JDK-8345687 was integrated, zero-length > segments always have an address of zero. This may cause problems in certain > native methods that can receive segments and/or buffers derived from segments. >

Re: RFR: 8356553 : Incorrect uses of {@link} in AbstractQueuedLongSynchronizer and AbstractQueuedSynchronizer

2025-05-28 Thread Doug Lea
On Tue, 27 May 2025 09:35:51 GMT, Viktor Klang wrote: > I had to tweak the language a bit to better reflect the intent of the text. This seems OK. Maybe needlessly pedantic, but OK :-) - PR Comment: https://git.openjdk.org/jdk/pull/25462#issuecomment-2915821182

Integrated: 8357919: Arena::allocate returns segments with address zero if the segment length is zero after JDK-8345687

2025-05-28 Thread Per Minborg
On Wed, 28 May 2025 09:06:57 GMT, Per Minborg wrote: > After https://bugs.openjdk.org/browse/JDK-8345687 was integrated, zero-length > segments always have an address of zero. This may cause problems in certain > native methods that can receive segments and/or buffers derived from segments. >

Re: RFR: 8357919: Arena::allocate returns segments with address zero if the segment length is zero after JDK-8345687

2025-05-28 Thread Jaikiran Pai
On Wed, 28 May 2025 09:06:57 GMT, Per Minborg wrote: > After https://bugs.openjdk.org/browse/JDK-8345687 was integrated, zero-length > segments always have an address of zero. This may cause problems in certain > native methods that can receive segments and/or buffers derived from segments. >

Re: RFR: 8348986: Improve coverage of enhanced exception messages [v12]

2025-05-28 Thread Michael McMahon
> Hi, > > Enhanced exception messages are designed to hide sensitive information such > as hostnames, IP > addresses from exception message strings, unless the enhanced mode for the > specific category > has been explicitly enabled. Enhanced exceptions were first introduced in > 8204233 in JD

Re: RFR: 8355746: Start of release updates for JDK 26 [v4]

2025-05-28 Thread Nizar Benalla
On Thu, 8 May 2025 13:15:35 GMT, Nizar Benalla wrote: >> It is to accommodate the now longer list of --release values in the javac >> help output,the addition of ", 26". >> >> Splitting the list of releases over two lines would be a better solution, >> but I didn't take that one when initially

RFR: 8357919: Arena::allocate returns segments with address zero if the segment length is zero after JDK-8345687

2025-05-28 Thread Per Minborg
After https://bugs.openjdk.org/browse/JDK-8345687 was integrated, zero-length segments always have an address of zero. This may cause problems in certain native methods that can receive segments and/or buffers derived from segments. This PR also guards for overflow for extremely large allocation

Integrated: 8355022: Implement JEP 506: Scoped Values

2025-05-28 Thread Andrew Haley
On Mon, 28 Apr 2025 14:32:04 GMT, Andrew Haley wrote: > Propose to finalize scoped values. > The only functional change is that the orElse() method no longer accepts a > null argument. This pull request has now been integrated. Changeset: 4e1878ca Author:Andrew Haley URL: https://g

Re: RFR: 8356891: Some code simplifications in BigInteger [v25]

2025-05-28 Thread Raffaello Giulietti
On Tue, 27 May 2025 21:42:37 GMT, fabioromano1 wrote: >> Some changes in `Biginteger`s' bit operations that increase the code >> readability and slightly optimize the execution time. > > fabioromano1 has updated the pull request incrementally with one additional > commit since the last revision

Re: RFR: 8345431: Improve jar --validate to detect duplicate or invalid entries [v15]

2025-05-28 Thread Jaikiran Pai
On Tue, 27 May 2025 16:23:47 GMT, Henry Jen wrote: >> This PR check the jar file to ensure entries are consistent from the central >> directory and local file header. Also check there is no duplicate entry >> names that could override the desired content by accident. > > Henry Jen has updated t

Re: RFR: 8348986: Improve coverage of enhanced exception messages [v11]

2025-05-28 Thread Michael McMahon
On Mon, 26 May 2025 17:07:45 GMT, Mark Sheppard wrote: >> Michael McMahon has updated the pull request with a new target base due to a >> merge or a rebase. The pull request now contains 28 commits: >> >> - Merge branch 'master' into 8348986-exceptions >> - update >> - reduced number of new

Re: RFR: 8348986: Improve coverage of enhanced exception messages [v11]

2025-05-28 Thread Michael McMahon
On Mon, 26 May 2025 17:40:39 GMT, Mark Sheppard wrote: >> Michael McMahon has updated the pull request with a new target base due to a >> merge or a rebase. The pull request now contains 28 commits: >> >> - Merge branch 'master' into 8348986-exceptions >> - update >> - reduced number of new

Re: RFR: 8345431: Improve jar --validate to detect duplicate or invalid entries [v15]

2025-05-28 Thread Jaikiran Pai
On Tue, 27 May 2025 16:23:47 GMT, Henry Jen wrote: >> This PR check the jar file to ensure entries are consistent from the central >> directory and local file header. Also check there is no duplicate entry >> names that could override the desired content by accident. > > Henry Jen has updated t

Re: RFR: 8357930: Amendment for JDK-8333664

2025-05-28 Thread Alexander Matveev
On Wed, 28 May 2025 02:52:57 GMT, Alexey Semenyuk wrote: > - Extract ExternalApplication interface from AppImageFile and add it to the > model; > - Move LauncherData.ModuleInfo class to the top level; > - Add parent interface BundleSpec for Application and Package interfaces in > the model; >

Integrated: 8357808: Add a command line option for specifying a counter in TestRandomFloatingDecimal

2025-05-28 Thread Raffaello Giulietti
On Mon, 26 May 2025 18:44:58 GMT, Raffaello Giulietti wrote: > Add a `-Dcount=N` command line option to specify the number of random samples > per test (default is 10'000). This pull request has now been integrated. Changeset: efeb050e Author:Raffaello Giulietti URL: https://git.o

Re: [External] : Re: mapConcurrent() with InterruptedException

2025-05-28 Thread Viktor Klang
It would seem to require a change to the Java Language Specification section 17.2.4 Cheers, √ Viktor Klang Software Architect, Java Platform Group Oracle From: Jige Yu Sent: Wednesday, 28 May 2025 00:35 To: Viktor Klang Cc: core-libs-dev@openjdk.org Subject:

RFR: 8351369: [macos] Use --install-dir option with DMG packaging

2025-05-28 Thread Alexander Matveev
- `--install-dir` option in DMG packaging is no longer ignored. - Defaults are still the same: `/Applications` and `/Library/Java/JavaVirtualMachines`. - If the installation directory doesn't exist, jpackage will try to create and delete it right after the DMG package is created. - If jpackage wa

Re: RFR: 8355746: Start of release updates for JDK 26 [v4]

2025-05-28 Thread Christian Stein
On Wed, 28 May 2025 11:14:22 GMT, Nizar Benalla wrote: >> I'll split the releases over two lines in the next update. The line is a >> little too long. > > Thinking about this again, could we represent the supported versions more > concisely? like `8-26` or `from 8 to 26`. Another variant:

Re: RFR: 8357913: Add `@Stable` to BigInteger and BigDecimal

2025-05-28 Thread Per Minborg
On Sun, 25 May 2025 22:35:56 GMT, Shaojin Wen wrote: > Some static final arrays of BigInteger and BigDecimal are stable and > immutable. We should add `@Stable` to give the optimizer more information src/java.base/share/classes/java/math/BigDecimal.java line 4317: > 4315: }; > 4316: > 431

Re: RFR: 8356553 : Incorrect uses of {@link} in AbstractQueuedLongSynchronizer and AbstractQueuedSynchronizer

2025-05-28 Thread Viktor Klang
On Wed, 28 May 2025 10:33:12 GMT, Doug Lea wrote: >> I had to tweak the language a bit to better reflect the intent of the text. > > This seems OK. Maybe needlessly pedantic, but OK :-) @DougLea You know me. :) Thanks for having a look! :) - PR Comment: https://git.openjdk.org/jdk/

Re: RFR: 8357930: Amendment for JDK-8333664 [v2]

2025-05-28 Thread Alexey Semenyuk
> - Extract ExternalApplication interface from AppImageFile and add it to the > model; > - Move LauncherData.ModuleInfo class to the top level; > - Add parent interface BundleSpec for Application and Package interfaces in > the model; > - Merge PackageWriter and ApplicationWriter into BundleCr

Re: RFR: 8357930: Amendment for JDK-8333664 [v2]

2025-05-28 Thread Alexey Semenyuk
On Wed, 28 May 2025 06:57:15 GMT, Alexander Matveev wrote: >> Alexey Semenyuk has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Fix typo > > src/jdk.jpackage/share/classes/jdk/jpackage/internal/FromParams.java line 106: > >> 104:

Re: RFR: 8354724: Methods in java.io.Reader to read all characters and all lines [v26]

2025-05-28 Thread Roger Riggs
On Fri, 23 May 2025 18:44:42 GMT, Brian Burkhalter wrote: >> Implement the requested methods and add a test thereof. > > Brian Burkhalter has updated the pull request incrementally with one > additional commit since the last revision: > > 8354724: "input reader specific" -> "reader specific"

Re: RFR: 8354242: VectorAPI: combine vector not operation with compare [v6]

2025-05-28 Thread Emanuel Peter
On Wed, 28 May 2025 12:14:56 GMT, Emanuel Peter wrote: >> erifan has updated the pull request with a new target base due to a merge or >> a rebase. The incremental webrev excludes the unrelated changes brought in >> by the merge/rebase. The pull request contains 10 additional commits since >>

Re: RFR: 8354242: VectorAPI: combine vector not operation with compare [v6]

2025-05-28 Thread Emanuel Peter
On Wed, 14 May 2025 02:44:14 GMT, erifan wrote: >> This patch optimizes the following patterns: >> For integer types: >> >> (XorV (VectorMaskCmp src1 src2 cond) (Replicate -1)) >> => (VectorMaskCmp src1 src2 ncond) >> (XorVMask (VectorMaskCmp src1 src2 cond) (MaskAll m1)) >> => (VectorMa

Re: RFR: 8348328: Update IANA Language Subtag Registry to Version 2025-05-15

2025-05-28 Thread Iris Clark
On Wed, 28 May 2025 17:00:22 GMT, Justin Lu wrote: > Please review this PR which updates the language subtag registry to Version > 2025-05-15. > > LanguageSubtagRegistryTest.java was updated with the preferred-values: `hnm`, > `eko`, `luh`,`sjc`, `sqm`. A small change was also made to the test

Re: RFR: 8353686: Optimize Math.cbrt for x86 64 bit platforms [v4]

2025-05-28 Thread Sandhya Viswanathan
On Wed, 28 May 2025 18:36:38 GMT, Mohamed Issa wrote: >> The goal of this PR is to implement an x86_64 intrinsic for >> java.lang.Math.cbrt() using libm. There is a new set of micro-benchmarks are >> included to check the performance of specific input value ranges to help >> prevent regression

Re: RFR: 8353686: Optimize Math.cbrt for x86 64 bit platforms [v4]

2025-05-28 Thread Mohamed Issa
> The goal of this PR is to implement an x86_64 intrinsic for > java.lang.Math.cbrt() using libm. There is a new set of micro-benchmarks are > included to check the performance of specific input value ranges to help > prevent regressions in the future. > > The command to run all range specific

Re: RFR: 8353686: Optimize Math.cbrt for x86 64 bit platforms [v3]

2025-05-28 Thread Mohamed Issa
On Tue, 27 May 2025 22:30:17 GMT, Sandhya Viswanathan wrote: >> Mohamed Issa has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Add new set of cbrt micro-benchmarks > > src/hotspot/cpu/x86/macroAssembler_x86.hpp line 1251: > >> 1249: vo

Re: RFR: 8357690: Add @Stable and final to java.lang.CharacterDataLatin1 and other CharacterData classes [v3]

2025-05-28 Thread Naoto Sato
On Tue, 27 May 2025 19:32:33 GMT, Shaojin Wen wrote: >> Classes such as java.lang.CharacterDataXXX have multiple static final >> arrays, these are immutable, We should add `@Stable` and final to provide >> information to the optimizer. > > Shaojin Wen has updated the pull request incrementally

Re: [External] : Re: mapConcurrent() with InterruptedException

2025-05-28 Thread Jige Yu
17.2.4 is specifically about the Object wait()/notify() API, yeah? I've always had this confusion in my mind that I couldn't find an authoritative source for: what was the point of checked InterruptedException? My naive observation has been two fold: 1. In most cases, when possible, applicati

Re: RFR: 8357955: java.lang.classfile.Signature.ArrayTypeSig.of IAE not thrown for dims > 255

2025-05-28 Thread Jan Lahoda
On Wed, 28 May 2025 17:56:07 GMT, Adam Sotona wrote: > java.lang.classfile.Signature.ArrayTypeSig.of constraint check did not > include dimensions of the given component if the component is an array. > > This patch fixes the constraint check, corrects the @throws description and > adds test of

Re: RFR: 8357690: Add @Stable and final to java.lang.CharacterDataLatin1 and other CharacterData classes [v3]

2025-05-28 Thread ExE Boss
On Tue, 27 May 2025 19:32:33 GMT, Shaojin Wen wrote: >> Classes such as java.lang.CharacterDataXXX have multiple static final >> arrays, these are immutable, We should add `@Stable` and final to provide >> information to the optimizer. > > Shaojin Wen has updated the pull request incrementally

RFR: 8356047: [macos] jpackage produces confusing post- and pre- installation PKG scripts

2025-05-28 Thread Alexander Matveev
- Removed all code from pre- and post- installation PKG scripts. - This code is not needed and PKG should create destination folder and set correct permissions. - If for some reason it is not happens, permissions issues should be fixed when jpackage prepares application bundle. PKG should keep al

Integrated: 8356891: Some code simplifications in BigInteger

2025-05-28 Thread fabioromano1
On Sat, 10 May 2025 16:41:17 GMT, fabioromano1 wrote: > Some changes in `Biginteger`s' bit operations that increase the code > readability and slightly optimize the execution time. This pull request has now been integrated. Changeset: c9e6c4d0 Author:Fabio Romano Committer: Raffaello Giul

Re: RFR: 8345431: Improve jar --validate to detect duplicate or invalid entries [v16]

2025-05-28 Thread Henry Jen
> This PR check the jar file to ensure entries are consistent from the central > directory and local file header. Also check there is no duplicate entry names > that could override the desired content by accident. Henry Jen has updated the pull request with a new target base due to a merge or a

Integrated: 8354475: TestDockerMemoryMetricsSubgroup.java fails with exitValue = 1

2025-05-28 Thread PAWAN CHAWDHARY
On Mon, 28 Apr 2025 15:51:44 GMT, PAWAN CHAWDHARY wrote: > 8354475: TestDockerMemoryMetricsSubgroup.java fails with exitValue = 1 This pull request has now been integrated. Changeset: e579cca6 Author:PAWAN CHAWDHARY Committer: Leonid Mesnik URL: https://git.openjdk.org/jdk/commit/e

Re: RFR: 8357930: Amendment for JDK-8333664 [v2]

2025-05-28 Thread Alexander Matveev
On Wed, 28 May 2025 12:24:48 GMT, Alexey Semenyuk wrote: >> - Extract ExternalApplication interface from AppImageFile and add it to the >> model; >> - Move LauncherData.ModuleInfo class to the top level; >> - Add parent interface BundleSpec for Application and Package interfaces in >> the mod

Re: RFR: 8356047: [macos] jpackage produces confusing post- and pre- installation PKG scripts

2025-05-28 Thread Alexey Semenyuk
On Wed, 28 May 2025 19:32:47 GMT, Alexander Matveev wrote: > - Removed all code from pre- and post- installation PKG scripts. > - This code is not needed and PKG should create destination folder and set > correct permissions. > - If for some reason it is not happens, permissions issues should b

Re: RFR: 8348328: Update IANA Language Subtag Registry to Version 2025-05-15

2025-05-28 Thread Naoto Sato
On Wed, 28 May 2025 17:00:22 GMT, Justin Lu wrote: > Please review this PR which updates the language subtag registry to Version > 2025-05-15. > > LanguageSubtagRegistryTest.java was updated with the preferred-values: `hnm`, > `eko`, `luh`,`sjc`, `sqm`. A small change was also made to the test

Integrated: 8357681: Fixed the DigitList::toString method causing incorrect results during debugging

2025-05-28 Thread Shaojin Wen
On Sun, 18 May 2025 11:11:32 GMT, Shaojin Wen wrote: > When debugging getLong/getDouble/getDecimal of DigitList, the debugger will > call the DigitList::toString method. At this time, DigitList::toString will > modify tempBuilder, which will cause incorrect results. This pull request has now b

Re: RFR: 8356977: UTF-8 cleanups [v2]

2025-05-28 Thread Phil Race
On Mon, 26 May 2025 07:55:52 GMT, Magnus Ihse Bursie wrote: >> Magnus Ihse Bursie has updated the pull request incrementally with two >> additional commits since the last revision: >> >> - Restore MenuShortcut.java >> - Restore LocaleDataTest.java > > test/jdk/java/awt/event/KeyEvent/KeyTyped

Re: RFR: 8357275: Locale.Builder.setLanguageTag should mention conversions made on language tag [v4]

2025-05-28 Thread Naoto Sato
On Wed, 21 May 2025 20:41:43 GMT, Justin Lu wrote: >> It is not clear that `Locale.Builder.setLanguageTag(String)` accepts >> _extlang_ subtags in the input as well as what behavior occurs. >> Additionally, both this method and `Locale.forLanguageTag(String)` should >> mention their behavior w

Re: RFR: 8356977: UTF-8 cleanups [v2]

2025-05-28 Thread Phil Race
On Mon, 26 May 2025 08:07:19 GMT, Magnus Ihse Bursie wrote: >> test/jdk/java/awt/font/TextLayout/RotFontBoundsTest.java line 63: >> >>> 61: >>> 62: private static final String INSTRUCTIONS = >>> 63: "A string \u201C" + TEXT + "\u201D is drawn at eight >>> different " >> >> I r

Re: RFR: 8334015: Add Support for UUID Version 7 (UUIDv7) defined in RFC 9562 [v3]

2025-05-28 Thread Roger Riggs
On Wed, 28 May 2025 17:11:31 GMT, kieran-farrell wrote: >> The `timestamp` method may mislead an app developer thinking its the time >> from the version 7 timestamp. >> The first-line comment might make it more obvious if it says: >> `The timestamp value associated with a version 1 UUID.` >> >>

Re: RFR: 8354242: VectorAPI: combine vector not operation with compare [v6]

2025-05-28 Thread Xiaohong Gong
On Wed, 28 May 2025 12:26:31 GMT, Emanuel Peter wrote: >> erifan has updated the pull request with a new target base due to a merge or >> a rebase. The incremental webrev excludes the unrelated changes brought in >> by the merge/rebase. The pull request contains 10 additional commits since >>

Re: [External] : Re: mapConcurrent() with InterruptedException

2025-05-28 Thread David Holmes
On 29/05/2025 3:45 am, Jige Yu wrote: 17.2.4 is specifically about the Object wait()/notify() API, yeah? I've always had this confusion in my mind that I couldn't find an authoritative source for: what was the point of checked InterruptedException? Interruption and IE provide a limited capab

Re: RFR: 8351369: [macos] Use --install-dir option with DMG packaging

2025-05-28 Thread Alexey Semenyuk
On Wed, 28 May 2025 22:30:25 GMT, Alexey Semenyuk wrote: >> - `--install-dir` option in DMG packaging is no longer ignored. >> - Defaults are still the same: `/Applications` and >> `/Library/Java/JavaVirtualMachines`. >> - If the installation directory doesn't exist, jpackage will try to create

Integrated: 8357930: Amendment for JDK-8333664

2025-05-28 Thread Alexey Semenyuk
On Wed, 28 May 2025 02:52:57 GMT, Alexey Semenyuk wrote: > - Extract ExternalApplication interface from AppImageFile and add it to the > model; > - Move LauncherData.ModuleInfo class to the top level; > - Add parent interface BundleSpec for Application and Package interfaces in > the model; >

Integrated: 8356985: Use "stdin.encoding" in Console's read*() methods

2025-05-28 Thread Naoto Sato
On Fri, 16 May 2025 18:11:39 GMT, Naoto Sato wrote: > `java.io.Console` uses the charset specified by the `stdout.encoding` system > property for both input and output. While this is generally sufficient, since > Console is intended for interactive terminal use, some platforms allow > differen

Re: RFR: 8356985: Use "stdin.encoding" in Console's read*() methods [v5]

2025-05-28 Thread Naoto Sato
On Thu, 22 May 2025 17:46:33 GMT, Naoto Sato wrote: >> `java.io.Console` uses the charset specified by the `stdout.encoding` system >> property for both input and output. While this is generally sufficient, >> since Console is intended for interactive terminal use, some platforms allow >> diff

Re: RFR: 8355798: Implement JEP 514: Ahead-of-Time Command Line Ergonomics [v13]

2025-05-28 Thread Ioi Lam
> This is the implementation of the draft [JEP: Ahead-of-time Command Line > Ergonomics](https://bugs.openjdk.org/browse/JDK-8350022) > > - Implemented new flag `AOTCacheOutput`, which can be used to create an AOT > cache using the "one-command workflow" > - Added processing of the `JDK_AOT_VM_O

RFR: 8348328: Update IANA Language Subtag Registry to Version 2025-05-15

2025-05-28 Thread Justin Lu
Please review this PR which updates the language subtag registry to Version 2025-05-15. LanguageSubtagRegistryTest.java was updated with the preferred-values: `hnm`, `eko`, `luh`,`sjc`, `sqm`. A small change was also made to the test to improve the output as well. - Commit message

Re: RFR: 8334015: Add Support for UUID Version 7 (UUIDv7) defined in RFC 9562 [v3]

2025-05-28 Thread kieran-farrell
On Tue, 27 May 2025 21:59:55 GMT, Roger Riggs wrote: >> I'd say "create" instead of "retrieve" in the first line comment. (Though >> that word is used in the other static factories). >> >> The "sub-millisecond precision" can't be relied upon. Its the precision that >> gives the impression that

Re: RFR: 8328821: Map.of() derived view collection mutators should throw UnsupportedOperationException [v11]

2025-05-28 Thread Liam Miller-Cushon
> This change overrides mutator methods in the implementation returned by > `Map.of().entrySet()` to throw `UnsupportedOperationException`. Liam Miller-Cushon has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 15 commits: - Merge remot

Re: RFR: 8344332: (bf) Migrate DirectByteBuffer away from jdk.internal.ref.Cleaner [v4]

2025-05-28 Thread Kim Barrett
> This change makes java.nio no longer use jdk.internal.ref.Cleaner to manage > native memory for Direct-X-Buffers. Instead it uses bespoke PhantomReferences > and a dedicated ReferenceQueue. This differs from PR 22165, which proposed to > use java.lang.ref.Cleaner. > > This change is algorithmica

Re: RFR: 8357913: Add `@Stable` to BigInteger and BigDecimal [v2]

2025-05-28 Thread Shaojin Wen
> Some static final arrays of BigInteger and BigDecimal are stable and > immutable. We should add `@Stable` to give the optimizer more information Shaojin Wen has updated the pull request incrementally with one additional commit since the last revision: bug fix, from @minborg -

Re: RFR: 8345431: Improve jar --validate to detect duplicate or invalid entries [v15]

2025-05-28 Thread Lance Andersen
On Tue, 27 May 2025 16:23:47 GMT, Henry Jen wrote: >> This PR check the jar file to ensure entries are consistent from the central >> directory and local file header. Also check there is no duplicate entry >> names that could override the desired content by accident. > > Henry Jen has updated t

Re: RFR: 8345431: Improve jar --validate to detect duplicate or invalid entries [v16]

2025-05-28 Thread Lance Andersen
On Wed, 28 May 2025 14:53:39 GMT, Henry Jen wrote: >> This PR check the jar file to ensure entries are consistent from the central >> directory and local file header. Also check there is no duplicate entry >> names that could override the desired content by accident. > > Henry Jen has updated t

Re: RFR: 8354475: TestDockerMemoryMetricsSubgroup.java fails with exitValue = 1 [v3]

2025-05-28 Thread Leonid Mesnik
On Fri, 23 May 2025 04:33:36 GMT, PAWAN CHAWDHARY wrote: >> 8354475: TestDockerMemoryMetricsSubgroup.java fails with exitValue = 1 > > PAWAN CHAWDHARY has updated the pull request with a new target base due to a > merge or a rebase. The pull request now contains three commits: > > - Merge bran

Re: RFR: 8350880: (zipfs) Add support for read-only zip file systems [v15]

2025-05-28 Thread Lance Andersen
On Tue, 27 May 2025 19:21:45 GMT, David Beaumont wrote: >> Adding read-only support to ZipFileSystem. >> >> The new `accessMode` environment property allows for readOnly and readWrite >> values, and ensures that the requested mode is consistent with what's >> returned. >> >> This involved a l

Re: RFR: 8354724: Methods in java.io.Reader to read all characters and all lines [v26]

2025-05-28 Thread Brian Burkhalter
On Wed, 28 May 2025 14:23:07 GMT, Jaikiran Pai wrote: >> Brian Burkhalter has updated the pull request incrementally with one >> additional commit since the last revision: >> >> 8354724: "input reader specific" -> "reader specific" > > test/jdk/java/io/Reader/ReadAll.java line 54: > >> 52: p

Re: RFR: 8334742: Change java.time month/day field types to 'byte' [v2]

2025-05-28 Thread duke
On Wed, 30 Apr 2025 20:38:59 GMT, Gautham Krishnan wrote: >> In the following classes, month and day values are stored in fields of type >> 'int' or 'short'. The range of allowed values is small enough that the type >> can be 'byte' instead. >> >> java.time.YearMonth >> java.time.MonthDay >> j

Re: RFR: 8354724: Methods in java.io.Reader to read all characters and all lines [v22]

2025-05-28 Thread Jaikiran Pai
On Tue, 20 May 2025 17:32:03 GMT, Brian Burkhalter wrote: >> I see this has been changed to "then some characters, but not all" but it >> doesn't flow very well. The original sentence, which was copied/modified >> from InputStream.readAllBytes, is much cleaner and I think I would prefer to >>

Re: RFR: 8356553 : Incorrect uses of {@link} in AbstractQueuedLongSynchronizer and AbstractQueuedSynchronizer

2025-05-28 Thread Alan Bateman
On Tue, 27 May 2025 09:35:51 GMT, Viktor Klang wrote: > I had to tweak the language a bit to better reflect the intent of the text. Marked as reviewed by alanb (Reviewer). - PR Review: https://git.openjdk.org/jdk/pull/25462#pullrequestreview-2875304114

Integrated: 8356553 : Incorrect uses of {@link} in AbstractQueuedLongSynchronizer and AbstractQueuedSynchronizer

2025-05-28 Thread Viktor Klang
On Tue, 27 May 2025 09:35:51 GMT, Viktor Klang wrote: > I had to tweak the language a bit to better reflect the intent of the text. This pull request has now been integrated. Changeset: 18285fc1 Author:Viktor Klang URL: https://git.openjdk.org/jdk/commit/18285fc136e1a892ab54a705c1fa

Re: RFR: 8354724: Methods in java.io.Reader to read all characters and all lines [v26]

2025-05-28 Thread Jaikiran Pai
On Fri, 23 May 2025 18:44:42 GMT, Brian Burkhalter wrote: >> Implement the requested methods and add a test thereof. > > Brian Burkhalter has updated the pull request incrementally with one > additional commit since the last revision: > > 8354724: "input reader specific" -> "reader specific"

Re: RFR: 8354724: Methods in java.io.Reader to read all characters and all lines [v26]

2025-05-28 Thread Alan Bateman
On Fri, 23 May 2025 18:44:42 GMT, Brian Burkhalter wrote: >> Implement the requested methods and add a test thereof. > > Brian Burkhalter has updated the pull request incrementally with one > additional commit since the last revision: > > 8354724: "input reader specific" -> "reader specific"

Integrated: 8334742: Change java.time month/day field types to 'byte'

2025-05-28 Thread Gautham Krishnan
On Wed, 30 Apr 2025 20:30:59 GMT, Gautham Krishnan wrote: > In the following classes, month and day values are stored in fields of type > 'int' or 'short'. The range of allowed values is small enough that the type > can be 'byte' instead. > > java.time.YearMonth > java.time.MonthDay > java.tim

Re: RFR: 8345431: Improve jar --validate to detect duplicate or invalid entries [v16]

2025-05-28 Thread Jaikiran Pai
On Wed, 28 May 2025 14:53:39 GMT, Henry Jen wrote: >> This PR check the jar file to ensure entries are consistent from the central >> directory and local file header. Also check there is no duplicate entry >> names that could override the desired content by accident. > > Henry Jen has updated t

Re: RFR: 8354724: Methods in java.io.Reader to read all characters and all lines [v26]

2025-05-28 Thread Jaikiran Pai
On Wed, 28 May 2025 15:23:58 GMT, Brian Burkhalter wrote: >> test/jdk/java/io/Reader/ReadAll.java line 54: >> >>> 52: public class ReadAll { >>> 53: private static final String PHRASE = >>> 54: "Ange plein de gaieté, connaissez-vous l'angoisse"; >> >> Would it be useful to have this

Integrated: 8345431: Improve jar --validate to detect duplicate or invalid entries

2025-05-28 Thread Henry Jen
On Fri, 4 Apr 2025 00:39:04 GMT, Henry Jen wrote: > This PR check the jar file to ensure entries are consistent from the central > directory and local file header. Also check there is no duplicate entry names > that could override the desired content by accident. This pull request has now been

RFR: 8356634: VectorShape#largestShapeFor should have public access

2025-05-28 Thread Ian Graves
VectorShape#largestShapeFor is referenced in existing JavaDoc but has been package-private. This propose change makes it public and adds documentation for it. - Commit messages: - Making VectorShape.largestShapeFor public and documenting Changes: https://git.openjdk.org/jdk/pull/2

Integrated: 8355798: Implement JEP 514: Ahead-of-Time Command Line Ergonomics

2025-05-28 Thread Ioi Lam
On Tue, 29 Apr 2025 04:50:42 GMT, Ioi Lam wrote: > This is the implementation of the draft [JEP: Ahead-of-time Command Line > Ergonomics](https://bugs.openjdk.org/browse/JDK-8350022) > > - Implemented new flag `AOTCacheOutput`, which can be used to create an AOT > cache using the "one-command

Re: RFR: 8356047: [macos] jpackage produces confusing post- and pre- installation PKG scripts

2025-05-28 Thread Alexander Matveev
On Wed, 28 May 2025 20:00:20 GMT, Alexey Semenyuk wrote: > Why do we need empty scripts? It doesn't make sense. I'd remove them. If we do not have empty scripts how user will override it? https://docs.oracle.com/en/java/javase/24/jpackage/override-jpackage-resources.html#GUID-62412365-821D-4736-

Re: RFR: 8351369: [macos] Use --install-dir option with DMG packaging

2025-05-28 Thread Alexey Semenyuk
On Wed, 28 May 2025 07:11:36 GMT, Alexander Matveev wrote: > - `--install-dir` option in DMG packaging is no longer ignored. > - Defaults are still the same: `/Applications` and > `/Library/Java/JavaVirtualMachines`. > - If the installation directory doesn't exist, jpackage will try to create

Re: RFR: 8356634: VectorShape#largestShapeFor should have public access

2025-05-28 Thread Paul Sandoz
On Wed, 28 May 2025 21:22:30 GMT, Ian Graves wrote: > VectorShape#largestShapeFor is referenced in existing JavaDoc but has been > package-private. This propose change makes it public and adds documentation > for it. Can you add something to the method testVectorShape in test/jdk/jdk/incubato

Re: RFR: 8351369: [macos] Use --install-dir option with DMG packaging

2025-05-28 Thread Alexey Semenyuk
On Wed, 28 May 2025 07:11:36 GMT, Alexander Matveev wrote: > If the installation directory doesn't exist, jpackage will try to create and > delete it right after the DMG package is created. Is this absolutely necessary? Is there a better way? It looks like you removed DMG-specific runtime ins

Re: RFR: 8356047: [macos] jpackage produces confusing post- and pre- installation PKG scripts

2025-05-28 Thread Alexey Semenyuk
On Wed, 28 May 2025 21:40:08 GMT, Alexander Matveev wrote: > If we do not have empty scripts how user will override it? What is the problem with this? By default, PKG will not have scripts. If they place them in the resource directory, jpackage will use them. - PR Comment: https:

Re: RFR: 8348986: Improve coverage of enhanced exception messages [v12]

2025-05-28 Thread Mark Sheppard
On Wed, 28 May 2025 11:13:12 GMT, Michael McMahon wrote: >> Hi, >> >> Enhanced exception messages are designed to hide sensitive information such >> as hostnames, IP >> addresses from exception message strings, unless the enhanced mode for the >> specific category >> has been explicitly enab

Re: RFR: 8357690: Add @Stable and final to java.lang.CharacterDataLatin1 and other CharacterData classes [v3]

2025-05-28 Thread Shaojin Wen
On Wed, 28 May 2025 19:20:08 GMT, ExE Boss wrote: >> Shaojin Wen has updated the pull request incrementally with one additional >> commit since the last revision: >> >> fix comments, from @natoj > > src/java.base/share/classes/java/lang/CharacterData00.java.template line 36: > >> 34: >> 35:

Re: RFR: 8352565: Add native method implementation of Reference.get() [v6]

2025-05-28 Thread Vladimir Ivanov
On Sat, 24 May 2025 04:57:39 GMT, Kim Barrett wrote: >> As I understand, `JDK-8271862` was about migrating to non-virtual intrinsic >> method. >> In case of `Reference::get()`, you already have a virtual public method >> marked as `@IntrinsicCandidate`. And the patch doesn't change anything >>