Withdrawn: 8347009: Speed ​​up parseInt and parseLong

2025-04-23 Thread duke
On Sat, 4 Jan 2025 10:24:15 GMT, Shaojin Wen wrote: > This is an optimization for decimal Integer.parseInt and Long.parseLong, > which improves performance by about 10%. The optimization includes: > 1. Improve performance by parsing 2 numbers at a time, which has performance > improvements for

Re: RFR: 8351565: Implement JEP 502: Stable Values (Preview) [v73]

2025-04-23 Thread Per Minborg
> Implement JEP 502. > > The PR passes tier1-tier3 tests. Per Minborg has updated the pull request incrementally with one additional commit since the last revision: Remove section on fun/coll sync - Changes: - all: https://git.openjdk.org/jdk/pull/23972/files - new: https://

Re: RFR: 8351565: Implement JEP 502: Stable Values (Preview) [v33]

2025-04-23 Thread Viktor Klang
On Fri, 18 Apr 2025 14:17:37 GMT, Jorn Vernee wrote: >> I'm definitely not an expert here, so I'll defer to someone more >> knowledgable :) > > I asked around/looked this up, and it seems 'contents' would be more correct > here, since a StableValue is primarily a container of things (you put th

Re: RFR: 8353786: Migrate Vector API math library support to FFM API [v13]

2025-04-23 Thread Vladimir Ivanov
> Migrate Vector API math library (SVML and SLEEF) linkage from native code (in > JVM) to Java FFM API. > > Since FFM API doesn't support vector calling conventions yet, migration > affects only symbol lookup for now. But it still enables significant > simplifications on JVM side. > > The patc

Re: RFR: 8353786: Migrate Vector API math library support to FFM API [v10]

2025-04-23 Thread Vladimir Ivanov
On Wed, 23 Apr 2025 08:54:23 GMT, Hamlin Li wrote: >> The intention is to align `_features_string` with `_features` which >> enumerates well-known CPU capabilities JVM manages. As of now, >> `_features_string` contains more information, so I introduced >> `_cpu_info_string` to keep it. >> >>

Re: RFR: 8353786: Migrate Vector API math library support to FFM API [v12]

2025-04-23 Thread Vladimir Ivanov
On Wed, 23 Apr 2025 18:11:42 GMT, Vladimir Ivanov wrote: >> In previous code, we use `UseRVV` to detect if rvv extension is supported. >> >> On the other hand, user can choose to disable UseRVV if they want even if >> rvv extension is supported on the running machine. In this sense, there >> c

Re: RFR: 8351565: Implement JEP 502: Stable Values (Preview) [v53]

2025-04-23 Thread Chen Liang
On Thu, 10 Apr 2025 12:31:04 GMT, Viktor Klang wrote: >> Per Minborg has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Improve docs as per comments > > src/java.base/share/classes/java/lang/StableValue.java line 357: > >> 355: * >> 356:

Re: RFR: 8351565: Implement JEP 502: Stable Values (Preview) [v76]

2025-04-23 Thread Chen Liang
On Wed, 23 Apr 2025 12:12:26 GMT, Per Minborg wrote: >> Implement JEP 502. >> >> The PR passes tier1-tier3 tests. > > Per Minborg has updated the pull request incrementally with one additional > commit since the last revision: > > Replace 'contents' with 'result' in the docs src/java.base/s

Re: RFR: 8350703: Add standard system property stdin.encoding [v3]

2025-04-23 Thread Stuart Marks
> * Windows and Unix: set sprops.stdin_encoding if connected to a console > * Add specs for stdin.encoding > * Adjust specs to change "undefined" to "unspecified" > * Rewrite System.in spec to refer to new property and to clarify usage with > classes that perform encoding > * Update property test

Re: RFR: 8350703: Add standard system property stdin.encoding [v3]

2025-04-23 Thread Alan Bateman
On Wed, 23 Apr 2025 18:02:56 GMT, Stuart Marks wrote: >> * Windows and Unix: set sprops.stdin_encoding if connected to a console >> * Add specs for stdin.encoding >> * Adjust specs to change "undefined" to "unspecified" >> * Rewrite System.in spec to refer to new property and to clarify usage wit

Re: RFR: 8305186: Reference.waitForReferenceProcessing should be more accessible to tests [v8]

2025-04-23 Thread Brent Christian
On Wed, 23 Apr 2025 06:08:59 GMT, Kim Barrett wrote: >> Brent Christian has updated the pull request incrementally with one >> additional commit since the last revision: >> >> make waitForReferenceProcessingMethod volatile > > test/lib/jdk/test/whitebox/WhiteBox.java line 605: > >> 603:

Re: RFR: 8354724: BufferedReader readAllLines and readString methods [v13]

2025-04-23 Thread Brian Burkhalter
On Wed, 23 Apr 2025 18:06:27 GMT, Johannes Graham wrote: >> Brian Burkhalter has updated the pull request incrementally with one >> additional commit since the last revision: >> >> 8354724: Improve test per reviewer comments > > src/java.base/share/classes/java/io/Reader.java line 212: > >>

Integrated: 8355215: Add @spec tags to Emoji related methods

2025-04-23 Thread Naoto Sato
On Mon, 21 Apr 2025 20:11:47 GMT, Naoto Sato wrote: > Adding @spec tags to Emoji related methods in the Character class. A CSR has > also been drafted. This pull request has now been integrated. Changeset: f097aa90 Author:Naoto Sato URL: https://git.openjdk.org/jdk/commit/f097aa90c

Re: RFR: 8355335: Avoid pattern matching switches in core ClassFile API

2025-04-23 Thread Chen Liang
On Tue, 22 Apr 2025 23:28:38 GMT, Chen Liang wrote: > A few pattern matching switches exist in the core parts of ClassFile API > responsible for transformations and parsing. They are likely to be used in > early bootstrap, and pattern matching switches require bootstrap methods, > which depend

Integrated: 8355335: Avoid pattern matching switches in core ClassFile API

2025-04-23 Thread Chen Liang
On Tue, 22 Apr 2025 23:28:38 GMT, Chen Liang wrote: > A few pattern matching switches exist in the core parts of ClassFile API > responsible for transformations and parsing. They are likely to be used in > early bootstrap, and pattern matching switches require bootstrap methods, > which depend

Re: RFR: 8333377: Migrate Generic Signature parsing to ClassFile API [v6]

2025-04-23 Thread Chen Liang
On Wed, 23 Apr 2025 13:39:40 GMT, ExE Boss wrote: >> Chen Liang has updated the pull request with a new target base due to a >> merge or a rebase. The pull request now contains five commits: >> >> - Merge branch 'master' of https://github.com/openjdk/jdk into >> feature/new-generic-info >> -

Re: RFR: 8354724: BufferedReader readAllLines and readString methods [v13]

2025-04-23 Thread Johannes Graham
On Wed, 23 Apr 2025 16:52:29 GMT, Brian Burkhalter wrote: >> Implement the requested methods and add a test thereof. > > Brian Burkhalter has updated the pull request incrementally with one > additional commit since the last revision: > > 8354724: Improve test per reviewer comments src/java.

Re: RFR: 8355328: Improve negative tests coverage for jpackage signing [v2]

2025-04-23 Thread Alexander Matveev
On Wed, 23 Apr 2025 02:30:59 GMT, Alexey Semenyuk wrote: >> Add tests covering `error.explicit-sign-no-cert` error ID to ErrorTest. >> >> If signing identity validation fails, jpackage outputs three messages >> constructed from the following string IDs: `error.cert.not.found`, >> `error.explic

Integrated: 8355328: Improve negative tests coverage for jpackage signing

2025-04-23 Thread Alexey Semenyuk
On Tue, 22 Apr 2025 00:43:24 GMT, Alexey Semenyuk wrote: > Add tests covering `error.explicit-sign-no-cert` error ID to ErrorTest. > > If signing identity validation fails, jpackage outputs three messages > constructed from the following string IDs: `error.cert.not.found`, > `error.explicit-si

RFR: 8297727: Forcing LF interpretation lead to StackOverflowError in reflection code

2025-04-23 Thread Chen Liang
When LambdaForms are interpreted, so are field lambda forms. When this happens, we may get into an infinite recursion due to field lambda forms using `MethodHandleStatics.UNSAFE` via field lambda form. I think the best solution here is to always eagerly compile field DMH forms - we already do s

Re: RFR: 8351623: VectorAPI: Refactor subword gather load and add SVE implementation

2025-04-23 Thread Xiaohong Gong
On Thu, 17 Apr 2025 01:42:22 GMT, Xiaohong Gong wrote: >> ### Summary: >> [JDK-8318650](http://java-service.client.nvidia.com/?q=8318650) added the >> hotspot intrinsifying of subword gather load APIs for X86 platforms [1]. >> This patch aims at implementing the equivalent functionality for AAr

Re: RFR: 8351565: Implement JEP 502: Stable Values (Preview) [v72]

2025-04-23 Thread Viktor Klang
On Tue, 22 Apr 2025 15:09:49 GMT, Per Minborg wrote: >> Implement JEP 502. >> >> The PR passes tier1-tier3 tests. > > Per Minborg has updated the pull request incrementally with one additional > commit since the last revision: > > Reformat docs src/java.base/share/classes/java/lang/StableVa

Re: RFR: 8349910: Implement HTTP/3 for the HTTP Client API

2025-04-23 Thread Jaikiran Pai
On Tue, 22 Apr 2025 18:56:19 GMT, Artur Barashev wrote: >> Hi, >> >> Please find here a PR for the implementation of JEP [JDK-8291976: HTTP/3 for >> the HTTP Client API](https://bugs.openjdk.org/browse/JDK-8291976). >> >> The CSR can be viewed at [JDK-8350588: Implement HTTP/3 for the HTTP Cli

JDK-8355338: ZIP and non-compliant entry names

2025-04-23 Thread Lars Bruun-Hansen
I would like to propose a strengthening of the security posture of the ZIP file implementation. The java.util.zip implementation is, according to the package docs, based on the Info-ZIP specification [1] which itself states to be based on PKWARE's appnote.txt [2]. The latter is probably considered

Re: RFR: 8351565: Implement JEP 502: Stable Values (Preview) [v73]

2025-04-23 Thread Per Minborg
On Wed, 23 Apr 2025 07:41:36 GMT, Per Minborg wrote: >> Implement JEP 502. >> >> The PR passes tier1-tier3 tests. > > Per Minborg has updated the pull request incrementally with one additional > commit since the last revision: > > Remove section on fun/coll sync Here is a PR update applicab

Re: JDK-8355338: ZIP and non-compliant entry names

2025-04-23 Thread Alan Bateman
On 23/04/2025 09:24, Lars Bruun-Hansen wrote: : There is also a security angle: Spoofing file names in ZIP files is a common technique. Some implementations takes cautionary steps on this. For example, the Windows Explorer's ZIP reader simply will not show entries which start with ".." or ".". W

RFR: 8355369: Remove setAccessible usage for setting final fields in java.util.concurrent

2025-04-23 Thread Viktor Klang
This Pull Request replaces the uses of Field + setAccessible to modify final fields in java.util.concurrent with Unsafe. - Commit messages: - Update ConcurrentSkipListSet, CopyOnWriteArrayList, and AtomicReferenceArray to use Unsafe rather than Field.setAccessible Changes: https:/

Re: RFR: 8355278: Improve debuggability of com/sun/jndi/ldap/LdapPoolTimeoutTest.java test [v2]

2025-04-23 Thread Mikhail Yankelevich
On Tue, 22 Apr 2025 11:08:15 GMT, Jaikiran Pai wrote: >> Can I please get a review of this test only change which proposes to improve >> the debuggability of `com/sun/jndi/ldap/LdapPoolTimeoutTest.java`? >> >> This test has been failing intermittently in our CI for several years. >> Detailed a

Re: RFR: 8351623: VectorAPI: Refactor subword gather load and add SVE implementation

2025-04-23 Thread Emanuel Peter
On Thu, 17 Apr 2025 01:42:22 GMT, Xiaohong Gong wrote: >> ### Summary: >> [JDK-8318650](http://java-service.client.nvidia.com/?q=8318650) added the >> hotspot intrinsifying of subword gather load APIs for X86 platforms [1]. >> This patch aims at implementing the equivalent functionality for AAr

Integrated: 8355300: Add final to BitSieve

2025-04-23 Thread Shaojin Wen
On Tue, 22 Apr 2025 11:10:46 GMT, Shaojin Wen wrote: > As the title says, adding final to fields that do not change and BitSieve > that will not be inherited will make C2 optimization more friendly. This pull request has now been integrated. Changeset: c873837d Author:Shaojin Wen URL:

Re: RFR: 8354724: BufferedReader readAllLines and readString methods [v12]

2025-04-23 Thread Johannes Döbler
On Wed, 23 Apr 2025 15:39:35 GMT, Brian Burkhalter wrote: >> test/jdk/java/io/BufferedReader/ReadAll.java line 83: >> >>> 81: int toIndex = rnd.nextInt(fromIndex, plen); >>> 82: String str = PHRASE.substring(fromIndex, toIndex); >>> 83: byte[] strB

Re: RFR: 8354724: BufferedReader readAllLines and readString methods [v12]

2025-04-23 Thread Johannes Döbler
On Tue, 22 Apr 2025 17:12:52 GMT, Brian Burkhalter wrote: >> Implement the requested methods and add a test thereof. > > Brian Burkhalter has updated the pull request incrementally with one > additional commit since the last revision: > > 8354724: Add missing toList(), tweak verbiage; update

Integrated: 8353214: Add testing with --enable-preview

2025-04-23 Thread Leonid Mesnik
On Thu, 17 Apr 2025 00:24:50 GMT, Leonid Mesnik wrote: > Added problemlists and and requires for execution tests with --enable-preview. > > The --enable-preview features might significantly change VM/JDK behavior and > sometimes it is useful to run tests with preview features enabled. Eventuall

Re: RFR: 8342382: Implementation of JEP G1: Improve Application Throughput with a More Efficient Write-Barrier [v35]

2025-04-23 Thread Thomas Schatzl
> Hi all, > > please review this change that implements (currently Draft) JEP: G1: > Improve Application Throughput with a More Efficient Write-Barrier. > > The reason for posting this early is that this is a large change, and the JEP > process is already taking very long with no end in sight

Re: RFR: 8349146: [REDO] Implement a better allocator for downcalls

2025-04-23 Thread Per Minborg
On Wed, 23 Apr 2025 14:05:58 GMT, Per Minborg wrote: > This PR is based on the work of @mernst-github and aims to implement an > _internal_ thread-local 'stack' allocator, which works like a dynamically > sized arena, but with reset functionality to reset the allocated size back to > a certain

Re: RFR: 8349146: [REDO] Implement a better allocator for downcalls

2025-04-23 Thread Chen Liang
On Wed, 23 Apr 2025 14:05:58 GMT, Per Minborg wrote: > This PR is based on the work of @mernst-github and aims to implement an > _internal_ thread-local 'stack' allocator, which works like a dynamically > sized arena, but with reset functionality to reset the allocated size back to > a certain

RFR: 8349146: [REDO] Implement a better allocator for downcalls

2025-04-23 Thread Per Minborg
This PR is based on the work of @mernst-github and aims to implement an _internal_ thread-local 'stack' allocator, which works like a dynamically sized arena, but with reset functionality to reset the allocated size back to a certain level. The underlying memory could stay around between calls,

Re: RFR: 8350703: Add standard system property stdin.encoding [v2]

2025-04-23 Thread Stuart Marks
On Wed, 23 Apr 2025 01:34:42 GMT, Naoto Sato wrote: >> Stuart Marks has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Update sun.stdout/err.encoding comments; tweak Windows file handle >> variable name. > > src/java.base/windows/native/li

Re: RFR: 8350703: Add standard system property stdin.encoding [v2]

2025-04-23 Thread Stuart Marks
On Wed, 23 Apr 2025 12:54:29 GMT, Alan Bateman wrote: >> src/java.base/share/classes/jdk/internal/util/SystemProps.java line 92: >> >>> 90: >>> 91: // Encoding properties for stdin, stdout, and stderr. For >>> stdout and stderr, >>> 92: // check "sun.*.encoding" properties befo

Re: RFR: 8355249: Remove the use of WMIC from the entire source code [v2]

2025-04-23 Thread Erik Joelsson
On Tue, 22 Apr 2025 07:41:43 GMT, Daishi Tabata wrote: >> After searching the entire JDK source code, I found that WMIC is only used >> in four files. These WMIC calls can be replaced with PowerShell for WMI. >> >> The primary challenge in this replacement is to make it work the same as >> bef

Re: RFR: 8350703: Add standard system property stdin.encoding [v2]

2025-04-23 Thread Stuart Marks
> * Windows and Unix: set sprops.stdin_encoding if connected to a console > * Add specs for stdin.encoding > * Adjust specs to change "undefined" to "unspecified" > * Rewrite System.in spec to refer to new property and to clarify usage with > classes that perform encoding > * Update property test

Re: RFR: 8350703: Add standard system property stdin.encoding

2025-04-23 Thread Stuart Marks
On Thu, 17 Apr 2025 18:59:33 GMT, Stuart Marks wrote: > * Windows and Unix: set sprops.stdin_encoding if connected to a console > * Add specs for stdin.encoding > * Adjust specs to change "undefined" to "unspecified" > * Rewrite System.in spec to refer to new property and to clarify usage with >

Re: RFR: 8355335: Avoid pattern matching switches in core ClassFile API

2025-04-23 Thread Adam Sotona
On Tue, 22 Apr 2025 23:28:38 GMT, Chen Liang wrote: > A few pattern matching switches exist in the core parts of ClassFile API > responsible for transformations and parsing. They are likely to be used in > early bootstrap, and pattern matching switches require bootstrap methods, > which depend

Re: RFR: 8354242: VectorAPI: combine vector not operation with compare [v2]

2025-04-23 Thread Jatin Bhateja
On Fri, 18 Apr 2025 01:36:10 GMT, erifan wrote: >> This patch optimizes the following patterns: >> For integer types: >> >> (XorV (VectorMaskCmp src1 src2 cond) (Replicate -1)) >> => (VectorMaskCmp src1 src2 ncond) >> (XorVMask (VectorMaskCmp src1 src2 cond) (MaskAll m1)) >> => (VectorMa

Re: RFR: 8351565: Implement JEP 502: Stable Values (Preview) [v76]

2025-04-23 Thread Viktor Klang
On Wed, 23 Apr 2025 12:12:26 GMT, Per Minborg wrote: >> Implement JEP 502. >> >> The PR passes tier1-tier3 tests. > > Per Minborg has updated the pull request incrementally with one additional > commit since the last revision: > > Replace 'contents' with 'result' in the docs Thanks for all

Re: RFR: 8355369: Remove setAccessible usage for setting final fields in java.util.concurrent

2025-04-23 Thread Raffaello Giulietti
On Wed, 23 Apr 2025 14:11:59 GMT, Viktor Klang wrote: >> Seems these are used mainly for cloning: is it possible for us to just use >> `readResolve` to resolve an alternative object? > > @liach Not sure I understand, could you elaborate a bit? @viktorklang-ora Before approving, what is the stat

Re: RFR: 8355369: Remove setAccessible usage for setting final fields in java.util.concurrent [v2]

2025-04-23 Thread Viktor Klang
> This Pull Request replaces the uses of Field + setAccessible to modify final > fields in java.util.concurrent with Unsafe. Viktor Klang has updated the pull request incrementally with one additional commit since the last revision: Adding a releaseFence() to ConcurrentskipListSet.clone() --

Re: RFR: 8355369: Remove setAccessible usage for setting final fields in java.util.concurrent [v2]

2025-04-23 Thread Viktor Klang
On Wed, 23 Apr 2025 15:18:49 GMT, Viktor Klang wrote: >> This Pull Request replaces the uses of Field + setAccessible to modify final >> fields in java.util.concurrent with Unsafe. > > Viktor Klang has updated the pull request incrementally with one additional > commit since the last revision:

Re: RFR: 8344706: Compiler Implementation of Compact Source Files and Instance Main Methods [v4]

2025-04-23 Thread Jan Lahoda
On Tue, 22 Apr 2025 10:14:44 GMT, Jan Lahoda wrote: >> src/java.base/share/classes/jdk/internal/misc/MethodFinder.java line 89: >> >>> 87: if (mainMethod == null) { >>> 88: //if not public method, try to lookup a non-public one >>> 89: mainMethod = JLA.findMethod(

Re: RFR: 8354724: BufferedReader readAllLines and readString methods [v12]

2025-04-23 Thread Brian Burkhalter
On Tue, 22 Apr 2025 17:12:52 GMT, Brian Burkhalter wrote: >> Implement the requested methods and add a test thereof. > > Brian Burkhalter has updated the pull request incrementally with one > additional commit since the last revision: > > 8354724: Add missing toList(), tweak verbiage; update

Re: RFR: 8355369: Remove setAccessible usage for setting final fields in java.util.concurrent

2025-04-23 Thread Alan Bateman
On Wed, 23 Apr 2025 12:21:21 GMT, Viktor Klang wrote: >> src/java.base/share/classes/java/util/concurrent/ConcurrentSkipListSet.java >> line 534: >> >>> 532: U.putReference( >>> 533: this, >>> 534: U.objectFieldOffset(ConcurrentSkipListSet.class, "m"), >> >> Wou

Re: RFR: 8350703: Add standard system property stdin.encoding

2025-04-23 Thread Alan Bateman
On Thu, 17 Apr 2025 18:59:33 GMT, Stuart Marks wrote: > * Windows and Unix: set sprops.stdin_encoding if connected to a console > * Add specs for stdin.encoding > * Adjust specs to change "undefined" to "unspecified" > * Rewrite System.in spec to refer to new property and to clarify usage with >

Re: RFR: 8350703: Add standard system property stdin.encoding

2025-04-23 Thread Alan Bateman
On Wed, 23 Apr 2025 01:33:39 GMT, Naoto Sato wrote: >> * Windows and Unix: set sprops.stdin_encoding if connected to a console >> * Add specs for stdin.encoding >> * Adjust specs to change "undefined" to "unspecified" >> * Rewrite System.in spec to refer to new property and to clarify usage with

Re: RFR: 8355301: Simplify Throwable::printStackTrace by replacing inner class with static method [v4]

2025-04-23 Thread Shaojin Wen
On Wed, 23 Apr 2025 09:05:07 GMT, Alan Bateman wrote: >>> Ugh, hopefully this will be replaced in the next iteration. >> >> What should we replace it with? Do you have any suggestions? > >> What should we replace it with? Do you have any suggestions? > > The wrapper classes were needed when the

Withdrawn: 8347408: Create an internal method handle adapter for system calls with errno

2025-04-23 Thread duke
On Tue, 25 Feb 2025 08:27:26 GMT, Per Minborg wrote: > As we advance, converting older JDK code to use the relatively new FFM API > requires system calls that can provide `errno` and the likes to explicitly > allocate a `MemorySegment` to capture potential error states. This can lead > to nega

Re: RFR: 8355223: Improve documentation on @IntrinsicCandidate [v5]

2025-04-23 Thread Chen Liang
> In offline discussion, we noted that the documentation on this annotation > does not recommend minimizing the intrinsified section and moving whatever > can be done in Java to Java; thus I prepared this documentation update, to > shrink a "TLDR" essay to something concise for readers, such as

Re: RFR: 8355369: Remove setAccessible usage for setting final fields in java.util.concurrent

2025-04-23 Thread Raffaello Giulietti
On Wed, 23 Apr 2025 10:10:54 GMT, Viktor Klang wrote: > This Pull Request replaces the uses of Field + setAccessible to modify final > fields in java.util.concurrent with Unsafe. I guess the intent is just to have the minimal patch to come away from `setAccessible()`. - PR Commen

Re: RFR: 8355369: Remove setAccessible usage for setting final fields in java.util.concurrent

2025-04-23 Thread Viktor Klang
On Wed, 23 Apr 2025 14:06:27 GMT, Chen Liang wrote: >> This Pull Request replaces the uses of Field + setAccessible to modify final >> fields in java.util.concurrent with Unsafe. > > Seems these are used mainly for cloning: is it possible for us to just use > `readResolve` to resolve an alterna

Re: RFR: 8355215: Add @spec tags to Emoji related methods

2025-04-23 Thread Naoto Sato
On Mon, 21 Apr 2025 20:11:47 GMT, Naoto Sato wrote: > Adding @spec tags to Emoji related methods in the Character class. A CSR has > also been drafted. Thanks for the reviews! - PR Comment: https://git.openjdk.org/jdk/pull/24779#issuecomment-2824812290

Re: RFR: 8354724: BufferedReader readAllLines and readString methods [v12]

2025-04-23 Thread Brian Burkhalter
On Wed, 23 Apr 2025 16:06:54 GMT, Johannes Döbler wrote: >> Brian Burkhalter has updated the pull request incrementally with one >> additional commit since the last revision: >> >> 8354724: Add missing toList(), tweak verbiage; update test > > test/jdk/java/io/BufferedReader/ReadAll.java line

Re: RFR: 8354724: BufferedReader readAllLines and readString methods [v13]

2025-04-23 Thread Brian Burkhalter
> Implement the requested methods and add a test thereof. Brian Burkhalter has updated the pull request incrementally with one additional commit since the last revision: 8354724: Improve test per reviewer comments - Changes: - all: https://git.openjdk.org/jdk/pull/24728/files

Re: RFR: 8351565: Implement JEP 502: Stable Values (Preview) [v75]

2025-04-23 Thread Per Minborg
> Implement JEP 502. > > The PR passes tier1-tier3 tests. Per Minborg has updated the pull request incrementally with one additional commit since the last revision: Rephrase happens-before clause - Changes: - all: https://git.openjdk.org/jdk/pull/23972/files - new: https://g

Re: RFR: 8354242: VectorAPI: combine vector not operation with compare [v2]

2025-04-23 Thread Jatin Bhateja
On Fri, 18 Apr 2025 01:36:10 GMT, erifan wrote: >> This patch optimizes the following patterns: >> For integer types: >> >> (XorV (VectorMaskCmp src1 src2 cond) (Replicate -1)) >> => (VectorMaskCmp src1 src2 ncond) >> (XorVMask (VectorMaskCmp src1 src2 cond) (MaskAll m1)) >> => (VectorMa

Re: RFR: 8349910: Implement HTTP/3 for the HTTP Client API

2025-04-23 Thread Artur Barashev
On Wed, 23 Apr 2025 08:03:02 GMT, Jaikiran Pai wrote: >> `MD5NotAllowedInTLS13CertificateSignature` contains an example. > > A lot of (existing) HttpClient tests in `test/jdk/java/net/httpclient` > currently use this `SimpleSSLContext` construct to read the `testkeys` > keystore that's availabl

Re: RFR: 8355223: Improve documentation on @IntrinsicCandidate [v4]

2025-04-23 Thread Raffaello Giulietti
On Tue, 22 Apr 2025 21:57:19 GMT, Chen Liang wrote: >> In offline discussion, we noted that the documentation on this annotation >> does not recommend minimizing the intrinsified section and moving whatever >> can be done in Java to Java; thus I prepared this documentation update, to >> shrink

Re: RFR: 8355369: Remove setAccessible usage for setting final fields in java.util.concurrent [v2]

2025-04-23 Thread Chen Liang
On Wed, 23 Apr 2025 15:22:37 GMT, Viktor Klang wrote: >> This Pull Request replaces the uses of Field + setAccessible to modify final >> fields in java.util.concurrent with Unsafe. > > Viktor Klang has updated the pull request incrementally with one additional > commit since the last revision:

Re: RFR: 8354724: BufferedReader readAllLines and readString methods [v12]

2025-04-23 Thread Brian Burkhalter
On Wed, 23 Apr 2025 15:58:41 GMT, Johannes Döbler wrote: >>> The test will fail if the default Charset is not UTF-8 >> >> When does that happen (cf. [JEP 400)](https://openjdk.org/jeps/400)? > > The default charset is not UTF-8 when you specify JVM param -Dfile.encoding, > which of course is un

Re: RFR: 8354899: Reduce overhead associated with type switches [v2]

2025-04-23 Thread Adam Sotona
On Tue, 22 Apr 2025 17:20:15 GMT, Chen Liang wrote: >> The downcallHandle method in Linker has a complex implementation, and type >> switches is triggered in multiple places in that handle. >> >> After bytestacks analysis of a simple program that links the native >> implementation of Class::fo

Re: RFR: 8355278: Improve debuggability of com/sun/jndi/ldap/LdapPoolTimeoutTest.java test [v2]

2025-04-23 Thread Aleksei Efimov
On Tue, 22 Apr 2025 11:08:15 GMT, Jaikiran Pai wrote: >> Can I please get a review of this test only change which proposes to improve >> the debuggability of `com/sun/jndi/ldap/LdapPoolTimeoutTest.java`? >> >> This test has been failing intermittently in our CI for several years. >> Detailed a

Re: RFR: 8354724: BufferedReader readAllLines and readString methods [v12]

2025-04-23 Thread Johannes Döbler
On Tue, 22 Apr 2025 17:12:52 GMT, Brian Burkhalter wrote: >> Implement the requested methods and add a test thereof. > > Brian Burkhalter has updated the pull request incrementally with one > additional commit since the last revision: > > 8354724: Add missing toList(), tweak verbiage; update

Re: RFR: 8355369: Remove setAccessible usage for setting final fields in java.util.concurrent

2025-04-23 Thread Viktor Klang
On Wed, 23 Apr 2025 15:07:33 GMT, Raffaello Giulietti wrote: >> @liach Not sure I understand, could you elaborate a bit? > > @viktorklang-ora Before approving, what is the status of the copyright > notices? There seem to be no years to update... @rgiulietti These are the JSR166 files, so I did

Re: RFR: 8355369: Remove setAccessible usage for setting final fields in java.util.concurrent

2025-04-23 Thread Alan Bateman
On Wed, 23 Apr 2025 14:06:27 GMT, Chen Liang wrote: > Seems these are used mainly for cloning: is it possible for us to just use > `readResolve` to resolve an alternative object? Potentially AtomicReferenceArray.readObject could be replaced, the others are clone methods. - PR Com

Re: RFR: 8354724: BufferedReader readAllLines and readString methods [v12]

2025-04-23 Thread Brian Burkhalter
On Wed, 23 Apr 2025 14:58:16 GMT, Johannes Döbler wrote: > The test will fail if the default Charset is not UTF-8 When does that happen (cf. [JEP 400)](https://openjdk.org/jeps/400)? - PR Review Comment: https://git.openjdk.org/jdk/pull/24728#discussion_r2056340354

Re: RFR: 8355369: Remove setAccessible usage for setting final fields in java.util.concurrent

2025-04-23 Thread Per Minborg
On Wed, 23 Apr 2025 10:10:54 GMT, Viktor Klang wrote: > This Pull Request replaces the uses of Field + setAccessible to modify final > fields in java.util.concurrent with Unsafe. src/java.base/share/classes/java/util/concurrent/ConcurrentSkipListSet.java line 534: > 532: U.putReferenc

Re: RFR: 8351565: Implement JEP 502: Stable Values (Preview) [v74]

2025-04-23 Thread Per Minborg
> Implement JEP 502. > > The PR passes tier1-tier3 tests. Per Minborg has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 365 commits: - Replace 'content' with 'contents' and doc updates - Merge branch 'master' into implement-jep502 -

Re: RFR: 8355369: Remove setAccessible usage for setting final fields in java.util.concurrent

2025-04-23 Thread Viktor Klang
On Wed, 23 Apr 2025 10:44:05 GMT, Per Minborg wrote: >> This Pull Request replaces the uses of Field + setAccessible to modify final >> fields in java.util.concurrent with Unsafe. > > src/java.base/share/classes/java/util/concurrent/ConcurrentSkipListSet.java > line 534: > >> 532: U.pu

Re: RFR: 8349910: Implement HTTP/3 for the HTTP Client API

2025-04-23 Thread Jaikiran Pai
On Tue, 22 Apr 2025 18:55:28 GMT, Artur Barashev wrote: >> Hi, >> >> Please find here a PR for the implementation of JEP [JDK-8291976: HTTP/3 for >> the HTTP Client API](https://bugs.openjdk.org/browse/JDK-8291976). >> >> The CSR can be viewed at [JDK-8350588: Implement HTTP/3 for the HTTP Cli

Re: RFR: 8355369: Remove setAccessible usage for setting final fields in java.util.concurrent

2025-04-23 Thread Alan Bateman
On Wed, 23 Apr 2025 14:11:59 GMT, Raffaello Giulietti wrote: > I guess the intent is just to have the minimal patch to come away from > `setAccessible()`. It's to move away from using Field.set to mutate non-static final fields. Viktor offered to get this done before the "prepare for final me

Re: RFR: 8355278: Improve debuggability of com/sun/jndi/ldap/LdapPoolTimeoutTest.java test [v2]

2025-04-23 Thread Jaikiran Pai
On Tue, 22 Apr 2025 11:08:15 GMT, Jaikiran Pai wrote: >> Can I please get a review of this test only change which proposes to improve >> the debuggability of `com/sun/jndi/ldap/LdapPoolTimeoutTest.java`? >> >> This test has been failing intermittently in our CI for several years. >> Detailed a

Integrated: 8355278: Improve debuggability of com/sun/jndi/ldap/LdapPoolTimeoutTest.java test

2025-04-23 Thread Jaikiran Pai
On Tue, 22 Apr 2025 09:05:09 GMT, Jaikiran Pai wrote: > Can I please get a review of this test only change which proposes to improve > the debuggability of `com/sun/jndi/ldap/LdapPoolTimeoutTest.java`? > > This test has been failing intermittently in our CI for several years. > Detailed are no

Re: RFR: 8355369: Remove setAccessible usage for setting final fields in java.util.concurrent

2025-04-23 Thread Chen Liang
On Wed, 23 Apr 2025 14:06:27 GMT, Chen Liang wrote: >> This Pull Request replaces the uses of Field + setAccessible to modify final >> fields in java.util.concurrent with Unsafe. > > Seems these are used mainly for cloning: is it possible for us to just use > `readResolve` to resolve an alterna

Re: RFR: 8354898: jdk/internal/loader/NativeLibraries/Main.java fails on static JDK

2025-04-23 Thread Jiangli Zhou
On Wed, 23 Apr 2025 01:11:24 GMT, Jaikiran Pai wrote: >>> Hello Jiangli, can you add a few more details to the linked JBS issue? If I >>> understand this change correctly, then what's being proposed in this PR >>> seems to indicate that the `jdk.internal.loader.RawNativeLibraries` is >>> unabl

Integrated: 8354898: jdk/internal/loader/NativeLibraries/Main.java fails on static JDK

2025-04-23 Thread Jiangli Zhou
On Wed, 16 Apr 2025 23:41:40 GMT, Jiangli Zhou wrote: > Please review this simple test change that skips the test case loading using > JDK `libzip.so` on static JDK in > test/jdk/jdk/internal/loader/NativeLibraries/Main.java. AFAICT, the test case > using `NativeLibrariesTest.LIB_NAME` (`libna

Re: JDK-8355338: ZIP and non-compliant entry names

2025-04-23 Thread Lars Bruun-Hansen
Agreed, too early.  No need to make it more complex: Suggestion: - First phase: put some notes in Javadoc about this. I'll be happy to suggest / draft a PR. Adding to javadoc should be uncontroversial and immediately implementable. Right? - Second phase:  More thorough analysis: How can the JD

Re: RFR: 8349910: Implement HTTP/3 for the HTTP Client API

2025-04-23 Thread Michael McMahon
On Fri, 18 Apr 2025 18:47:52 GMT, Chen Liang wrote: >> Hi, >> >> Please find here a PR for the implementation of JEP [JDK-8291976: HTTP/3 for >> the HTTP Client API](https://bugs.openjdk.org/browse/JDK-8291976). >> >> The CSR can be viewed at [JDK-8350588: Implement HTTP/3 for the HTTP Client

Re: RFR: 8351565: Implement JEP 502: Stable Values (Preview) [v76]

2025-04-23 Thread Per Minborg
> Implement JEP 502. > > The PR passes tier1-tier3 tests. Per Minborg has updated the pull request incrementally with one additional commit since the last revision: Replace 'contents' with 'result' in the docs - Changes: - all: https://git.openjdk.org/jdk/pull/23972/files -

Re: RFR: 8351565: Implement JEP 502: Stable Values (Preview) [v74]

2025-04-23 Thread Viktor Klang
On Wed, 23 Apr 2025 10:38:22 GMT, Per Minborg wrote: >> Implement JEP 502. >> >> The PR passes tier1-tier3 tests. > > Per Minborg has updated the pull request with a new target base due to a > merge or a rebase. The pull request now contains 365 commits: > > - Replace 'content' with 'contents

Re: RFR: 8351565: Implement JEP 502: Stable Values (Preview) [v74]

2025-04-23 Thread Per Minborg
On Wed, 23 Apr 2025 12:04:45 GMT, Viktor Klang wrote: >> Per Minborg has updated the pull request with a new target base due to a >> merge or a rebase. The pull request now contains 365 commits: >> >> - Replace 'content' with 'contents' and doc updates >> - Merge branch 'master' into implemen

Namespace Prefix Issue in XML to XSL Transformation

2025-04-23 Thread Hempushpa Sahu
Problem Description : XSLT transformation creating unique namespace prefixes. Analysis & Observation : The XSLT transformation is generating a new namespace prefix for every XML element, even when the namespace value matches that of the parent element. This leads to large XML file transformation

Integrated: 8354343: Hardening of Currency tests for not yet defined future ISO 4217 currency

2025-04-23 Thread Justin Lu
On Mon, 21 Apr 2025 21:51:35 GMT, Justin Lu wrote: > Please review this PR which improves future currency checking for ISO 4217 > currencies. > > Checking for a currency that should not yet exist in the set of available > currencies is already done. > It should also be explicitly checked that

Re: RFR: 8355369: Remove setAccessible usage for setting final fields in java.util.concurrent [v2]

2025-04-23 Thread Alan Bateman
On Wed, 23 Apr 2025 15:18:49 GMT, Viktor Klang wrote: >> Viktor Klang has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Adding a releaseFence() to ConcurrentskipListSet.clone() > > src/java.base/share/classes/java/util/concurrent/Concurren

Re: RFR: 8351623: VectorAPI: Refactor subword gather load and add SVE implementation

2025-04-23 Thread Emanuel Peter
On Wed, 23 Apr 2025 13:02:31 GMT, Emanuel Peter wrote: >> Hi @jatin-bhateja , could you please help take a look at this PR especially >> the X86 part? Thanks a lot! >> Hi @RealFYang , could you please help review the RVV part? Thanks a lot! > > @XiaohongGong I had a quick look at your changes an

Re: RFR: 8349910: Implement HTTP/3 for the HTTP Client API

2025-04-23 Thread Jaikiran Pai
On Tue, 22 Apr 2025 16:10:19 GMT, Artur Barashev wrote: >> Hi, >> >> Please find here a PR for the implementation of JEP [JDK-8291976: HTTP/3 for >> the HTTP Client API](https://bugs.openjdk.org/browse/JDK-8291976). >> >> The CSR can be viewed at [JDK-8350588: Implement HTTP/3 for the HTTP Cli

Re: RFR: 8349910: Implement HTTP/3 for the HTTP Client API

2025-04-23 Thread Jaikiran Pai
On Tue, 22 Apr 2025 19:11:24 GMT, Artur Barashev wrote: >> test/jdk/java/net/httpclient/http3/H3QuicTLSConnection.java line 96: >> >>> 94: //System.setProperty("javax.net.ssl.trustStore", KEYSTORE); >>> 95: //System.setProperty("javax.net.ssl.trustStorePassword", >>> PASSWORD);

Re: RFR: 8355301: Simplify Throwable::printStackTrace by replacing inner class with static method [v4]

2025-04-23 Thread Shaojin Wen
On Wed, 23 Apr 2025 06:44:32 GMT, Alan Bateman wrote: > Ugh, hopefully this will be replaced in the next iteration. What should we replace it with? Do you have any suggestions? - PR Review Comment: https://git.openjdk.org/jdk/pull/24795#discussion_r2055549921

Re: RFR: 8353786: Migrate Vector API math library support to FFM API [v12]

2025-04-23 Thread Hamlin Li
On Wed, 23 Apr 2025 01:02:19 GMT, Vladimir Ivanov wrote: >> Migrate Vector API math library (SVML and SLEEF) linkage from native code >> (in JVM) to Java FFM API. >> >> Since FFM API doesn't support vector calling conventions yet, migration >> affects only symbol lookup for now. But it still e

Re: RFR: 8353786: Migrate Vector API math library support to FFM API [v12]

2025-04-23 Thread Hamlin Li
On Wed, 23 Apr 2025 08:40:44 GMT, Hamlin Li wrote: >> Vladimir Ivanov has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Avoid thread state transition in VectorSupport_GetCPUFeatures > > src/jdk.incubator.vector/share/classes/jdk/incubator/

Re: RFR: 8353786: Migrate Vector API math library support to FFM API [v10]

2025-04-23 Thread Hamlin Li
On Wed, 23 Apr 2025 00:23:46 GMT, Vladimir Ivanov wrote: >> A simple fix could be: >> >> diff --git a/src/hotspot/os_cpu/linux_riscv/vm_version_linux_riscv.cpp >> b/src/hotspot/os_cpu/linux_riscv/vm_version_linux_riscv.cpp >> index 484a2a645aa..a785dc65c9e 100644 >> --- a/src/hotspot/os_cpu/lin

Re: RFR: 8355301: Simplify Throwable::printStackTrace by replacing inner class with static method [v4]

2025-04-23 Thread Alan Bateman
On Wed, 23 Apr 2025 08:40:04 GMT, Shaojin Wen wrote: > What should we replace it with? Do you have any suggestions? The wrapper classes were needed when there were was a mix of synchronized and j.u.concurrent locks in use. With JEP 491 integrated it meant that the java.io classes could be chan

Re: RFR: 8355369: Remove setAccessible usage for setting final fields in java.util.concurrent [v2]

2025-04-23 Thread Chen Liang
On Wed, 23 Apr 2025 17:36:25 GMT, Alan Bateman wrote: >> src/java.base/share/classes/java/util/concurrent/ConcurrentSkipListSet.java >> line 182: >> >>> 180: clone.setMap(new ConcurrentSkipListMap(m)); >>> 181: // Needed to ensure safe publication of setMap() >>> 182:

  1   2   >