Re: RFR: 8301991: Convert l10n properties resource bundles to UTF-8 native [v6]

2025-04-10 Thread Magnus Ihse Bursie
On Thu, 10 Apr 2025 07:31:37 GMT, Magnus Ihse Bursie wrote: >> Right, that `å` looks to have been incorrectly converted during the >> ISO-8859-1 to UTF-8 conversion. (I can't find the script used for conversion >> as this change is from some time ago.) >> >> Since the change occurs in a commen

Re: RFR: 8351565: Implement JEP 502: Stable Values (Preview) [v51]

2025-04-10 Thread Per Minborg
On Wed, 9 Apr 2025 17:25:02 GMT, Rémi Forax wrote: >> Per Minborg has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Fix typo in return type > > Hello, > I do not know if you know but StableValue.map() does not seems to be > optimized corr

Re: RFR: 8351565: Implement JEP 502: Stable Values (Preview) [v53]

2025-04-10 Thread Viktor Klang
On Thu, 10 Apr 2025 10:26:36 GMT, Per Minborg wrote: >> Implement JEP 502. >> >> The PR passes tier1-tier3 tests. > > Per Minborg has updated the pull request incrementally with one additional > commit since the last revision: > > Improve docs as per comments src/java.base/share/classes/jav

Re: RFR: 8341402: BigDecimal's square root optimization [v32]

2025-04-10 Thread duke
On Fri, 28 Mar 2025 18:24:49 GMT, fabioromano1 wrote: >> After changing `BigInteger.sqrt()` algorithm, this can be also used to speed >> up `BigDecimal.sqrt()` implementation. Here is how I made it. >> >> The main steps of the algorithm are as follows: >> first argument reduce the value to an i

Re: RFR: 8353683: [REDO] j.u.l.Handler classes create deadlock risk via synchronized publish() method

2025-04-10 Thread Daniel Fuchs
On Tue, 8 Apr 2025 11:03:39 GMT, David Beaumont wrote: >> 8353683: j.u.l.Handler classes create deadlock risk via synchronized >> publish() method. >> >> 1. Remove synchronization of calls to publish() in Handlers in >> java.util.logging package. >> 2. Add explanatory comments to various affec

Integrated: 8341402: BigDecimal's square root optimization

2025-04-10 Thread fabioromano1
On Wed, 2 Oct 2024 10:31:09 GMT, fabioromano1 wrote: > After changing `BigInteger.sqrt()` algorithm, this can be also used to speed > up `BigDecimal.sqrt()` implementation. Here is how I made it. > > The main steps of the algorithm are as follows: > first argument reduce the value to an integer

Re: RFR: 8341641: Make %APPDATA% and %LOCALAPPDATA% env variables available in *.cfg files [v10]

2025-04-10 Thread Magnus Ihse Bursie
On Wed, 9 Apr 2025 20:56:03 GMT, Alexey Semenyuk wrote: >> jpackage app laucnher will expand environment variables in .cfg files. >> >> Previously jpackage app launcher only replaced `$APPDIR`, `$BINDIR`, and >> `$ROOTDIR` tokens with the corresponding path values. With this patch, any >> envi

Re: RFR: 8341641: Make %APPDATA% and %LOCALAPPDATA% env variables available in *.cfg files [v10]

2025-04-10 Thread Magnus Ihse Bursie
On Thu, 10 Apr 2025 14:42:26 GMT, Magnus Ihse Bursie wrote: >> Alexey Semenyuk has refreshed the contents of this pull request, and >> previous commits have been removed. The incremental views will show >> differences compared to the previous content of the PR. The pull request >> contains one

RE: JDK-8352891 Performance improvements to ByteArrayOutputStream

2025-04-10 Thread Engebretson, John
Thank you Archie and Chen! Chen - I’m prototyping the generic allocator you describe and it’s extremely effective for Objects – but I’m hamstrung by trying to use generics on primitive byte. I’m not aware of a way to work around that, and changing the array from byte[] to Byte[] would be a

Re: RFR: 8351565: Implement JEP 502: Stable Values (Preview) [v51]

2025-04-10 Thread Rémi Forax
On Thu, 10 Apr 2025 12:51:43 GMT, Per Minborg wrote: > > ``` > > I will take a look at it. As i said in another mail to core-lib this morning, it seems that the field storing the hashcode of String is not marked with @Stable. That's may be the issue. - PR Comment: h

Re: RFR: 8351565: Implement JEP 502: Stable Values (Preview) [v55]

2025-04-10 Thread Per Minborg
> Implement JEP 502. > > The PR passes tier1-tier3 tests. Per Minborg has updated the pull request incrementally with 20 additional commits since the last revision: - Update test/jdk/java/lang/StableValue/StableValueFactoriesTest.java Co-authored-by: Viktor Klang - Update test/jdk/jav

Re: RFR: 8351565: Implement JEP 502: Stable Values (Preview) [v56]

2025-04-10 Thread Per Minborg
> Implement JEP 502. > > The PR passes tier1-tier3 tests. Per Minborg has updated the pull request incrementally with one additional commit since the last revision: Address comments on original vs underlying - Changes: - all: https://git.openjdk.org/jdk/pull/23972/files - ne

Re: RFR: 8353641: Deprecate core library permission classes for removal [v8]

2025-04-10 Thread Sean Mullan
On Mon, 7 Apr 2025 18:40:35 GMT, Roger Riggs wrote: >> Now that the Security Manager is permanently disabled, the following >> permission classes in the core libraries area can be deprecated for removal >> as they are no longer useful: FilePermission, LinkPermission, >> LoggingPermission, Prop

Re: RFR: 8354189: Remove JLI_ReportErrorMessageSys on Windows

2025-04-10 Thread Julian Waters
On Thu, 10 Apr 2025 08:03:58 GMT, Matthias Baesken wrote: > JLI_ReportErrorMessageSys is not used any more on Windows, so we can remove > it and make it UNIX-only (there a still a few remaining usages). I was hoping to get around to using it on Windows, but oh well. I think the remaining usage

Re: RFR: 8342682: Errors related to unused code on Windows after 8339120 in dt_shmem jdwp security and jpackage [v7]

2025-04-10 Thread Julian Waters
On Mon, 11 Nov 2024 09:51:35 GMT, Julian Waters wrote: >> After 8339120, gcc began catching many different instances of unused code in >> the Windows specific codebase. Some of these seem to be bugs. I've taken the >> effort to mark out all the relevant globals and locals that trigger the >> u

Re: RFR: 8350462: MethodTypeForm.LF_INTERPRET can cache the MemberName instead [v2]

2025-04-10 Thread duke
On Sun, 6 Apr 2025 08:09:27 GMT, Zihao Lin wrote: >> Modify the cache in MethodTypeForm that currently stores the LF_INTERPRET >> Lambda form. Instead of caching the entire LambdaForm, change it to store a >> SoftReference. This will avoid unnecessary memory usage. > > Zihao Lin has updated the

Re: RFR: 8315130: java.lang.IllegalAccessError when processing classlist to create CDS archive [v6]

2025-04-10 Thread Ioi Lam
On Wed, 9 Apr 2025 18:37:15 GMT, Timofei Pushkin wrote: >> If a base class is package-private then its subclasses should have the same >> package name and defining class loader, otherwise `IllegalAccessError` is >> thrown when linking a subclass. Currently when dumping a static archive >> sepa

Re: RFR: 8348556: Inlining fails earlier for MemorySegment::reinterpret [v6]

2025-04-10 Thread Maurizio Cimadamore
On Thu, 10 Apr 2025 15:52:38 GMT, Maurizio Cimadamore wrote: > > Baseline: > > ``` > > Benchmark(offsetCount) (segmentSize) Mode > > CntScore Error Units > > FFMVarHandleInlineTest.t0_reference 2048 1024 thrpt > > 25 155261

Re: RFR: 8350462: MethodTypeForm.LF_INTERPRET can cache the MemberName instead [v2]

2025-04-10 Thread Chen Liang
On Sun, 6 Apr 2025 08:09:27 GMT, Zihao Lin wrote: >> Modify the cache in MethodTypeForm that currently stores the LF_INTERPRET >> Lambda form. Instead of caching the entire LambdaForm, change it to store a >> SoftReference. This will avoid unnecessary memory usage. > > Zihao Lin has updated the

Integrated: 8353683: [REDO] j.u.l.Handler classes create deadlock risk via synchronized publish() method

2025-04-10 Thread David Beaumont
On Tue, 8 Apr 2025 11:00:27 GMT, David Beaumont wrote: > 8353683: j.u.l.Handler classes create deadlock risk via synchronized > publish() method. > > 1. Remove synchronization of calls to publish() in Handlers in > java.util.logging package. > 2. Add explanatory comments to various affected me

Re: RFR: 8315130: java.lang.IllegalAccessError when processing classlist to create CDS archive [v5]

2025-04-10 Thread Ioi Lam
On Thu, 10 Apr 2025 15:50:56 GMT, Ioi Lam wrote: >> I've realized that my example cannot be expressed in the current class list >> format since the format doesn't distinguish between and , >> only that S is not unregistered. The existing implementation will always use >> as will the new one.

Re: RFR: 8353683: [REDO] j.u.l.Handler classes create deadlock risk via synchronized publish() method

2025-04-10 Thread duke
On Tue, 8 Apr 2025 11:00:27 GMT, David Beaumont wrote: > 8353683: j.u.l.Handler classes create deadlock risk via synchronized > publish() method. > > 1. Remove synchronization of calls to publish() in Handlers in > java.util.logging package. > 2. Add explanatory comments to various affected me

Re: RFR: 8351565: Implement JEP 502: Stable Values (Preview) [v53]

2025-04-10 Thread Per Minborg
On Thu, 10 Apr 2025 12:43:30 GMT, Viktor Klang wrote: >> Per Minborg has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Improve docs as per comments > > src/java.base/share/classes/java/lang/StableValue.java line 582: > >> 580: static

Re: RFR: 8350075: Performance difference between SegmentAllocator methods [v2]

2025-04-10 Thread Maurizio Cimadamore
On Thu, 10 Apr 2025 06:00:48 GMT, Per Minborg wrote: >> This PR proposes to add `@ForceInline` to the `default` methods in >> `SegmentAllocator` that do not already have it. > > Per Minborg has updated the pull request with a new target base due to a > merge or a rebase. The incremental webrev

Re: RFR: 8354189: Remove JLI_ReportErrorMessageSys on Windows

2025-04-10 Thread Alan Bateman
On Thu, 10 Apr 2025 08:03:58 GMT, Matthias Baesken wrote: > JLI_ReportErrorMessageSys is not used any more on Windows, so we can remove > it and make it UNIX-only (there a still a few remaining usages). I think this looks okay, can you update the copyright header dates before you integrate. -

Re: RFR: 8315130: java.lang.IllegalAccessError when processing classlist to create CDS archive [v5]

2025-04-10 Thread Ioi Lam
On Wed, 9 Apr 2025 16:43:39 GMT, Timofei Pushkin wrote: >> I've actually noticed a problem here. I assumed that registered classes are >> always loaded by JDK's built-in class loaders (bootstrap, >> `jdk.internal.loader.ClassLoaders$PlatformClassLoader` or >> `jdk.internal.loader.ClassLoaders$

Re: RFR: 8348556: Inlining fails earlier for MemorySegment::reinterpret [v6]

2025-04-10 Thread Maurizio Cimadamore
On Tue, 8 Apr 2025 12:13:25 GMT, Per Minborg wrote: > Baseline: > > ``` > Benchmark(offsetCount) (segmentSize) Mode Cnt >Score Error Units > FFMVarHandleInlineTest.t0_reference 2048 1024 thrpt 25 > 1552613.262 ? 14295.035

Re: RFR: 8351565: Implement JEP 502: Stable Values (Preview) [v53]

2025-04-10 Thread Rémi Forax
On Thu, 10 Apr 2025 13:46:17 GMT, Per Minborg wrote: > > > ``` > > > > > > I will take a look at it. > > > ``` > > > > > > As i said in another mail to core-lib this morning, it seems that the field > > storing the hashcode of String is not marked with @stable. That's may be > > the issue. >

Re: RFR: 8342382: Implementation of JEP G1: Improve Application Throughput with a More Efficient Write-Barrier [v31]

2025-04-10 Thread Thomas Schatzl
> Hi all, > > please review this change that implements (currently Draft) JEP: G1: > Improve Application Throughput with a More Efficient Write-Barrier. > > The reason for posting this early is that this is a large change, and the JEP > process is already taking very long with no end in sight

RFR: 8305186: Reference.waitForReferenceProcessing should be more accessible to tests

2025-04-10 Thread Brent Christian
Certain specific types of tests involving GC and reference processing need to account for the delay between a GC completing (during which the GC clears a Reference), and the Reference being added to its associated queue. At present, ad hoc mechanisms (with delays/timeout) are used, but can lead

Re: RFR: 8342382: Implementation of JEP G1: Improve Application Throughput with a More Efficient Write-Barrier [v30]

2025-04-10 Thread Roberto Castañeda Lozano
On Thu, 10 Apr 2025 10:58:24 GMT, Thomas Schatzl wrote: >> I remember significant impact in some microbenchmark. It's also inlined in >> Parallel GC. I do not consider it a big issue wrt to maintenance - these >> things never really change, and the method is small and contained. >> I will try t

Re: RFR: 8354266: Fix non-UTF-8 text encoding

2025-04-10 Thread Magnus Ihse Bursie
On Thu, 10 Apr 2025 11:46:45 GMT, Raffaello Giulietti wrote: > I guess the difference at L.1 in the various files is just the BOM? Yes. - PR Review Comment: https://git.openjdk.org/jdk/pull/24566#discussion_r2037357899

Re: RFR: 8341641: Make %APPDATA% and %LOCALAPPDATA% env variables available in *.cfg files [v10]

2025-04-10 Thread Alexey Semenyuk
On Thu, 10 Apr 2025 14:44:06 GMT, Magnus Ihse Bursie wrote: >> src/jdk.jpackage/share/man/jpackage.md line 228: >> >>> 226: An expandable substring should be enclosed between the dollar >>> 227: sign character ($) and the first following non-alphanumeric >>> 228: character. Alternati

Re: RFR: 8351740: Clean up some code around initialization of encoding properties [v2]

2025-04-10 Thread Roger Riggs
On Mon, 7 Apr 2025 23:43:29 GMT, Stuart Marks wrote: >> Some of the code that creates various encoding properties at JVM >> initialization time, such as file.encoding and native.encoding, could use >> some cleaning up. Cleanup is fairly minimal and should be mostly >> behavior-preserving. Chan

Re: RFR: 8351565: Implement JEP 502: Stable Values (Preview) [v54]

2025-04-10 Thread Per Minborg
> Implement JEP 502. > > The PR passes tier1-tier3 tests. Per Minborg has updated the pull request incrementally with one additional commit since the last revision: Remove support function and clean up benchmark - Changes: - all: https://git.openjdk.org/jdk/pull/23972/files

Re: RFR: 8353185: Introduce the concept of upgradeable files in context of JEP 493 [v5]

2025-04-10 Thread Alan Bateman
On Wed, 9 Apr 2025 16:10:20 GMT, Severin Gehwolf wrote: >> For JEP 493-enabled builds there are no JMODs. Certain files come from the >> installed JDK image when a user creates a custom run-time from it. This is >> problematic for example for files that often come from a different package >> (

Re: RFR: 8341402: BigDecimal's square root optimization [v32]

2025-04-10 Thread Raffaello Giulietti
On Fri, 28 Mar 2025 18:24:49 GMT, fabioromano1 wrote: >> After changing `BigInteger.sqrt()` algorithm, this can be also used to speed >> up `BigDecimal.sqrt()` implementation. Here is how I made it. >> >> The main steps of the algorithm are as follows: >> first argument reduce the value to an i

Re: RFR: 8354266: Fix non-UTF-8 text encoding

2025-04-10 Thread Raffaello Giulietti
On Thu, 10 Apr 2025 10:10:49 GMT, Magnus Ihse Bursie wrote: > I have checked the entire code base for incorrect encodings, but luckily > enough these were the only remaining problems I found. > > BOM (byte-order mark) is a method used for distinguishing big and little > endian UTF-16 encoding

Re: RFR: 8353917: jnativescan: Simplify ClassResolver [v2]

2025-04-10 Thread Maurizio Cimadamore
On Wed, 9 Apr 2025 16:00:52 GMT, Jorn Vernee wrote: >> `jnativescan` uses the `ClassResolver` class to find both system classes, as >> well as application classes. In principle, a class resolver supports both >> iterating over all classes from that particular source, as well as looking >> up c

Re: RFR: 8353917: jnativescan: Simplify ClassResolver [v2]

2025-04-10 Thread Maurizio Cimadamore
On Thu, 10 Apr 2025 14:43:20 GMT, Maurizio Cimadamore wrote: > Very nice simplification! This seems to take advantage of the fact that, for the restricted method analysis, we only need to look at method reference entries whose owner is a system class -- because we know restricted methods are

RFR: 8354273: Restore even more pointless unicode characters to ASCII

2025-04-10 Thread Magnus Ihse Bursie
As a follow-up to [JDK-8354213](https://bugs.openjdk.org/browse/JDK-8354213), I found some additional places where unicode characters are unnecessarily used instead of pure ASCII. - Commit messages: - 8354273: Restore even more pointless unicode characters to ASCII Changes: https:

Re: RFR: 8353185: Introduce the concept of upgradeable files in context of JEP 493 [v4]

2025-04-10 Thread Alan Bateman
On Tue, 8 Apr 2025 13:31:10 GMT, Severin Gehwolf wrote: >> src/jdk.jlink/share/classes/jdk/tools/jlink/internal/LinkableRuntimeImage.java >> line 71: >> >>> 69: private static InputStream getDiffInputStream(String module) throws >>> IOException { >>> 70: String resourceName = Strin

Re: RFR: 8342382: Implementation of JEP G1: Improve Application Throughput with a More Efficient Write-Barrier [v32]

2025-04-10 Thread Thomas Schatzl
> Hi all, > > please review this change that implements (currently Draft) JEP: G1: > Improve Application Throughput with a More Efficient Write-Barrier. > > The reason for posting this early is that this is a large change, and the JEP > process is already taking very long with no end in sight

Re: RFR: 8353185: Introduce the concept of upgradeable files in context of JEP 493 [v2]

2025-04-10 Thread Severin Gehwolf
On Sat, 5 Apr 2025 04:49:03 GMT, Christoph Langer wrote: >> Severin Gehwolf has updated the pull request with a new target base due to a >> merge or a rebase. The incremental webrev excludes the unrelated changes >> brought in by the merge/rebase. The pull request contains four additional >> c

Re: RFR: 8353185: Introduce the concept of upgradeable files in context of JEP 493 [v4]

2025-04-10 Thread Severin Gehwolf
On Thu, 10 Apr 2025 09:03:36 GMT, Alan Bateman wrote: >> It's very odd, but when I attempt this then the resource is not found. It >> seems to fail on the module name verification. For example: `jlink --help | >> tail -n2` shows as `disabled` for an enabled linkable runtime image. > > Without r

Re: RFR: 8342382: Implementation of JEP G1: Improve Application Throughput with a More Efficient Write-Barrier [v33]

2025-04-10 Thread Thomas Schatzl
> Hi all, > > please review this change that implements (currently Draft) JEP: G1: > Improve Application Throughput with a More Efficient Write-Barrier. > > The reason for posting this early is that this is a large change, and the JEP > process is already taking very long with no end in sight

Re: RFR: 8342382: Implementation of JEP G1: Improve Application Throughput with a More Efficient Write-Barrier [v30]

2025-04-10 Thread Thomas Schatzl
On Thu, 10 Apr 2025 08:34:00 GMT, Aleksey Shipilev wrote: > > I fixed this for now, but it will be broken again in just a bit with > > Aleksey's ongoing removal of x86 32 bit platform efforts. > > I think all x86 cleanups related to GC and adjacent code have landed in > mainline now. So I expe

Re: RFR: 8301991: Convert l10n properties resource bundles to UTF-8 native [v2]

2025-04-10 Thread Magnus Ihse Bursie
On Wed, 13 Sep 2023 17:38:28 GMT, Justin Lu wrote: >> JDK .properties files still use ISO-8859-1 encoding with escape sequences. >> It would improve readability to see the native characters instead of escape >> sequences (especially for the L10n process). The majority of files changed >> are l

Re: RFR: 8351565: Implement JEP 502: Stable Values (Preview) [v52]

2025-04-10 Thread Viktor Klang
On Thu, 10 Apr 2025 06:34:24 GMT, Per Minborg wrote: >> Implement JEP 502. >> >> The PR passes tier1-tier3 tests. > > Per Minborg has updated the pull request with a new target base due to a > merge or a rebase. The pull request now contains 307 commits: > > - Fix typo > - Merge branch 'mast

java.lang.String hashCode and @Stable ?

2025-04-10 Thread Remi Forax
Question, why String.hash and String.hashIsZero are not declared @Stable ? regards, Rémi

Re: RFR: 8349944: [JMH] sun.misc.UnsafeOps cannot access class jdk.internal.misc.Unsafe [v2]

2025-04-10 Thread Nicole Xu
On Thu, 27 Feb 2025 03:22:27 GMT, Nicole Xu wrote: > Would it be possible to configure the build of the microbenchmarks to not > pass `-Werror`, so they don't break when sunapi diagnostics are emitted? > > > Note that even it will raise "proprietary API" warnings after this patch, > > it is ac

Re: RFR: 8342382: Implementation of JEP G1: Improve Application Throughput with a More Efficient Write-Barrier [v30]

2025-04-10 Thread Thomas Schatzl
On Wed, 9 Apr 2025 22:24:10 GMT, Martin Doerr wrote: > This PR needs an update for x86 platforms when merging: > g1BarrierSetAssembler_x86.cpp:117:6: error: 'class MacroAssembler' has no > member named 'get_thread' I fixed this for now, but it will be broken again in just a bit with Aleksey's

Re: RFR: 8354266: Fix non-UTF-8 text encoding

2025-04-10 Thread Magnus Ihse Bursie
On Thu, 10 Apr 2025 10:10:49 GMT, Magnus Ihse Bursie wrote: > I have checked the entire code base for incorrect encodings, but luckily > enough these were the only remaining problems I found. > > BOM (byte-order mark) is a method used for distinguishing big and little > endian UTF-16 encoding

RFR: 8354189: Remove JLI_ReportErrorMessageSys on Windows

2025-04-10 Thread Matthias Baesken
JLI_ReportErrorMessageSys is not used any more on Windows, so we can remove it and make it UNIX-only (there a still a few remaining usages). - Commit messages: - JDK-8354189 Changes: https://git.openjdk.org/jdk/pull/24563/files Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=245

Re: RFR: 8352504: RISC-V: implement and enable CMoveI/L [v3]

2025-04-10 Thread Hamlin Li
> Hi, > Can you help to review this patch? > On riscv, CMoveI/L already were implemented, but there are some gap: > 1. CMoveI/L does not support comparison with float/double, corresponding > tests are not turn on either. > 2. Some optimization of C2 is not turned on, e.g. `Phi -> CMove -> min_max`

Re: RFR: 8352504: RISC-V: implement and enable CMoveI/L [v3]

2025-04-10 Thread Hamlin Li
On Wed, 9 Apr 2025 06:52:26 GMT, Fei Yang wrote: >> This is to not enable Zicond automatically, but user can still turn it on >> manually if they want to try or make sure it bring benefit on the specific >> hardware. >> Currently it's based on bananapi result, so maybe in the future we should

Re: RFR: 8351565: Implement JEP 502: Stable Values (Preview) [v51]

2025-04-10 Thread Per Minborg
On Wed, 9 Apr 2025 17:17:01 GMT, Rémi Forax wrote: >> Per Minborg has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Fix typo in return type > > src/java.base/share/classes/java/lang/StableValue.java line 397: > >> 395: * collections are

Re: RFR: 8351565: Implement JEP 502: Stable Values (Preview) [v53]

2025-04-10 Thread Per Minborg
> Implement JEP 502. > > The PR passes tier1-tier3 tests. Per Minborg has updated the pull request incrementally with one additional commit since the last revision: Improve docs as per comments - Changes: - all: https://git.openjdk.org/jdk/pull/23972/files - new: https://git

Re: RFR: 8354273: Restore even more pointless unicode characters to ASCII [v2]

2025-04-10 Thread Magnus Ihse Bursie
> As a follow-up to [JDK-8354213](https://bugs.openjdk.org/browse/JDK-8354213), > I found some additional places where unicode characters are unnecessarily > used instead of pure ASCII. Magnus Ihse Bursie has updated the pull request incrementally with one additional commit since the last revis

Re: RFR: 8354273: Restore even more pointless unicode characters to ASCII [v2]

2025-04-10 Thread Magnus Ihse Bursie
On Thu, 10 Apr 2025 10:36:31 GMT, Magnus Ihse Bursie wrote: >> As a follow-up to >> [JDK-8354213](https://bugs.openjdk.org/browse/JDK-8354213), I found some >> additional places where unicode characters are unnecessarily used instead of >> pure ASCII. > > Magnus Ihse Bursie has updated the pul

Re: RFR: 8301991: Convert l10n properties resource bundles to UTF-8 native [v2]

2025-04-10 Thread Magnus Ihse Bursie
On Wed, 13 Sep 2023 17:38:28 GMT, Justin Lu wrote: >> JDK .properties files still use ISO-8859-1 encoding with escape sequences. >> It would improve readability to see the native characters instead of escape >> sequences (especially for the L10n process). The majority of files changed >> are l

Re: RFR: 8352504: RISC-V: implement and enable CMoveI/L [v6]

2025-04-10 Thread Hamlin Li
> Hi, > Can you help to review this patch? > On riscv, CMoveI/L already were implemented, but there are some gap: > 1. CMoveI/L does not support comparison with float/double, corresponding > tests are not turn on either. > 2. Some optimization of C2 is not turned on, e.g. `Phi -> CMove -> min_max`

Re: RFR: 8342382: Implementation of JEP G1: Improve Application Throughput with a More Efficient Write-Barrier [v30]

2025-04-10 Thread Thomas Schatzl
On Wed, 9 Apr 2025 12:48:10 GMT, Thomas Schatzl wrote: >> src/hotspot/cpu/x86/gc/g1/g1BarrierSetAssembler_x86.cpp line 101: >> >>> 99: } >>> 100: >>> 101: void >>> G1BarrierSetAssembler::gen_write_ref_array_post_barrier(MacroAssembler* >>> masm, DecoratorSet decorators, >> >> Have you measur

Re: RFR: 8352504: RISC-V: implement and enable CMoveI/L [v4]

2025-04-10 Thread Hamlin Li
> Hi, > Can you help to review this patch? > On riscv, CMoveI/L already were implemented, but there are some gap: > 1. CMoveI/L does not support comparison with float/double, corresponding > tests are not turn on either. > 2. Some optimization of C2 is not turned on, e.g. `Phi -> CMove -> min_max`

Re: RFR: 8354266: Fix non-UTF-8 text encoding

2025-04-10 Thread Raffaello Giulietti
On Thu, 10 Apr 2025 10:14:40 GMT, Magnus Ihse Bursie wrote: >> I have checked the entire code base for incorrect encodings, but luckily >> enough these were the only remaining problems I found. >> >> BOM (byte-order mark) is a method used for distinguishing big and little >> endian UTF-16 enc

Re: RFR: 8352504: RISC-V: implement and enable CMoveI/L [v7]

2025-04-10 Thread Hamlin Li
> Hi, > Can you help to review this patch? > On riscv, CMoveI/L already were implemented, but there are some gap: > 1. CMoveI/L does not support comparison with float/double, corresponding > tests are not turn on either. > 2. Some optimization of C2 is not turned on, e.g. `Phi -> CMove -> min_max`

Re: RFR: 8301991: Convert l10n properties resource bundles to UTF-8 native [v6]

2025-04-10 Thread Magnus Ihse Bursie
On Wed, 9 Apr 2025 21:26:15 GMT, Justin Lu wrote: >> src/java.xml/share/classes/com/sun/org/apache/xml/internal/serializer/Encodings.properties >> line 22: >> >>> 20: # Peter Smolik >>> 21: Cp1250 WINDOWS-1250 0x00FF >>> 22: # Patch attributed to hava...@underdusken.no (H�vard Wigtil) >> >> Th

Re: RFR: 8301991: Convert l10n properties resource bundles to UTF-8 native [v6]

2025-04-10 Thread Eirik Bjørsnøs
On Thu, 10 Apr 2025 07:32:18 GMT, Magnus Ihse Bursie wrote: >> You don't have to do that, I'm working on an omnibus UTF-8 fixing PR right >> now, where I will include a fix for this as well. > > If anything, I might be a bit worried that there are more incorrect > conversions stemming from this

Re: RFR: 8352565: Add native method implementation of Reference.get() [v4]

2025-04-10 Thread Aleksey Shipilev
On Wed, 2 Apr 2025 18:33:16 GMT, Kim Barrett wrote: >> Please review this change which adds a native method providing the >> implementation of Reference::get. Referece::get is an intrinsic candidate, >> so >> this native method implementation is only used when the intrinsic is not. >> >> Curre

Re: RFR: 8305186: Reference.waitForReferenceProcessing should be more accessible to tests [v3]

2025-04-10 Thread Kim Barrett
On Wed, 9 Apr 2025 23:12:00 GMT, Brent Christian wrote: >> Certain specific types of tests involving GC and reference processing need >> to account for the delay between a GC completing (during which the GC clears >> a Reference), and the Reference being added to its associated queue. At >> pr

Re: RFR: 8301991: Convert l10n properties resource bundles to UTF-8 native [v6]

2025-04-10 Thread Magnus Ihse Bursie
On Thu, 10 Apr 2025 08:08:02 GMT, Eirik Bjørsnøs wrote: >> If anything, I might be a bit worried that there are more incorrect >> conversions stemming from this PR, that my automated tools and manual >> scanning has not revealed. > > Some observations: > > 1: This PR seems to have been abondo

Re: RFR: 8353185: Introduce the concept of upgradeable files in context of JEP 493

2025-04-10 Thread Severin Gehwolf
On Fri, 4 Apr 2025 07:55:20 GMT, Alan Bateman wrote: >>> Part of me is concerned that the hidden option is a bit of an attractive >>> nuisance. What would you think about just having a fixed list in a >>> properties file in the repo, thus a resource in the jlink module. This >>> would avoid th

Re: RFR: 8351740: Clean up some code around initialization of encoding properties [v2]

2025-04-10 Thread Alan Bateman
On Mon, 7 Apr 2025 23:43:29 GMT, Stuart Marks wrote: >> Some of the code that creates various encoding properties at JVM >> initialization time, such as file.encoding and native.encoding, could use >> some cleaning up. Cleanup is fairly minimal and should be mostly >> behavior-preserving. Chan

Re: RFR: 8301991: Convert l10n properties resource bundles to UTF-8 native [v2]

2025-04-10 Thread Eirik Bjørsnøs
On Wed, 13 Sep 2023 17:38:28 GMT, Justin Lu wrote: >> JDK .properties files still use ISO-8859-1 encoding with escape sequences. >> It would improve readability to see the native characters instead of escape >> sequences (especially for the L10n process). The majority of files changed >> are l

Re: RFR: 8342382: Implementation of JEP G1: Improve Application Throughput with a More Efficient Write-Barrier [v30]

2025-04-10 Thread Aleksey Shipilev
On Thu, 10 Apr 2025 07:25:47 GMT, Thomas Schatzl wrote: > I fixed this for now, but it will be broken again in just a bit with > Aleksey's ongoing removal of x86 32 bit platform efforts. I think all x86 cleanups related to GC and adjacent code have landed in mainline now. So I expect no more m

Re: RFR: 8353787: Increased number of SHA-384-Digest java.util.jar.Attributes$Name instances leading to higher memory footprint

2025-04-10 Thread Sean Mullan
On Mon, 7 Apr 2025 06:34:11 GMT, Jaikiran Pai wrote: > Can I please get a review of this change which proposes to address the > increase in memory footprint of an application that uses signed JAR files, > signed with `SHA-384` digest algorithm? This addresses > https://bugs.openjdk.org/browse/

Re: RFR: 8353185: Introduce the concept of upgradeable files in context of JEP 493 [v5]

2025-04-10 Thread Severin Gehwolf
> For JEP 493-enabled builds there are no JMODs. Certain files come from the > installed JDK image when a user creates a custom run-time from it. This is > problematic for example for files that often come from a different package > (e.g. `cacerts` file for Linux distro builds of OpenJDK package

Re: RFR: 8341402: BigDecimal's square root optimization [v31]

2025-04-10 Thread Joe Darcy
On Tue, 18 Mar 2025 14:46:01 GMT, fabioromano1 wrote: >> fabioromano1 has updated the pull request incrementally with one additional >> commit since the last revision: >> >> An optimization > > This comment is to avoid closing this PR. > @fabioromano1 Thanks so much for your great work and p

RFR: 8354266: Fix non-UTF-8 text encoding

2025-04-10 Thread Magnus Ihse Bursie
I have checked the entire code base for incorrect encodings, but luckily enough these were the only remaining problems I found. BOM (byte-order mark) is a method used for distinguishing big and little endian UTF-16 encodings. There is a special UTF-8 BOM, but it is discouraged. In the words of

Re: RFR: 8315130: java.lang.IllegalAccessError when processing classlist to create CDS archive [v4]

2025-04-10 Thread Timofei Pushkin
On Mon, 7 Apr 2025 16:15:47 GMT, Ioi Lam wrote: >> Timofei Pushkin has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Don't use URLClassPath > > src/java.base/share/classes/jdk/internal/misc/CDS.java line 444: > >> 442: protected C

Re: RFR: 8351757: Test java/foreign/TestDeadlock.java#FileChannel_map timed out after passing

2025-04-10 Thread Per Minborg
On Tue, 8 Apr 2025 13:59:11 GMT, Per Minborg wrote: > This PR proposes to increase the timeout values for two tests. Thanks for the reviews! - PR Comment: https://git.openjdk.org/jdk/pull/24511#issuecomment-2789578764

Re: RFR: 8354266: Fix non-UTF-8 text encoding

2025-04-10 Thread Naoto Sato
On Thu, 10 Apr 2025 10:10:49 GMT, Magnus Ihse Bursie wrote: > I have checked the entire code base for incorrect encodings, but luckily > enough these were the only remaining problems I found. > > BOM (byte-order mark) is a method used for distinguishing big and little > endian UTF-16 encoding

Re: RFR: 8348556: Inlining fails earlier for MemorySegment::reinterpret [v7]

2025-04-10 Thread Maurizio Cimadamore
On Tue, 8 Apr 2025 12:24:41 GMT, Per Minborg wrote: >> This PR proposes to add some `@ForceInline` annotations in the `Module` >> class in order to assist inlining of FFM var/method handles. >> >> There are also some changes in other classes which, if implemented, can take >> us three addition

Re: RFR: 8354266: Fix non-UTF-8 text encoding

2025-04-10 Thread Erik Joelsson
On Thu, 10 Apr 2025 10:10:49 GMT, Magnus Ihse Bursie wrote: > I have checked the entire code base for incorrect encodings, but luckily > enough these were the only remaining problems I found. > > BOM (byte-order mark) is a method used for distinguishing big and little > endian UTF-16 encoding

Re: RFR: 8351462: Improve robustness of String concatenation [v2]

2025-04-10 Thread Roger Riggs
On Wed, 9 Apr 2025 13:32:00 GMT, Raffaello Giulietti wrote: >> Early detection of an `int` overflow in `StringConcatHelper` improves >> robustness of `StringConcatFactory`. > > Raffaello Giulietti has updated the pull request incrementally with one > additional commit since the last revision:

Re: RFR: 8353917: jnativescan: Simplify ClassResolver [v2]

2025-04-10 Thread Jorn Vernee
On Thu, 10 Apr 2025 14:48:59 GMT, Maurizio Cimadamore wrote: >> Jorn Vernee has updated the pull request with a new target base due to a >> merge or a rebase. The pull request now contains four commits: >> >> - Merge branch 'master' into jnativescan_Refactor >> - bump copyright years >> - m

Re: RFR: 8315130: java.lang.IllegalAccessError when processing classlist to create CDS archive [v4]

2025-04-10 Thread Ioi Lam
On Tue, 8 Apr 2025 11:46:27 GMT, Timofei Pushkin wrote: >> src/java.base/share/classes/jdk/internal/misc/CDS.java line 444: >> >>> 442: protected Class findClass(String name) throws >>> ClassNotFoundException { >>> 443: // Unregistered classes should be found in load(...),

RFR: 8354111: JavaDoc states that Iterator.remove() is linear in the LinkedBlockingDeque

2025-04-10 Thread kabutz
One of the features of the LinkedBlockingDeque is that it is a doubly-linked node queue, with pointers in each node to "prev" and "next", which allows remove() in the Iterator to remove the node in constant time. However, in the JavaDoc of the class, it lists Iterator.remove() as an example of a

Re: RFR: 8344706: Compiler Implementation of Compact Source Files and Instance Main Methods [v2]

2025-04-10 Thread Chen Liang
On Mon, 7 Apr 2025 18:08:29 GMT, Stuart Marks wrote: >> src/java.base/share/classes/java/lang/IO.java line 45: >> >>> 43: * UTF-8 is used instead. These internal objects are created upon the >>> first call to >>> 44: * either of the {@code readln} methods and are stored for subsequent >>> re

Re: RFR: 8303374: Implement JEP 455: Primitive Types in Patterns, instanceof, and switch (Preview) [v57]

2025-04-10 Thread Chen Liang
On Sun, 6 Apr 2025 10:50:50 GMT, Luca Kellermann wrote: >> Aggelos Biboudis has updated the pull request with a new target base due to >> a merge or a rebase. The pull request now contains 78 commits: >> >> - Merge branch 'master' into primitive-patterns >> - Update summary in ExactnessConver

Re: RFR: 8353917: jnativescan: Simplify ClassResolver [v3]

2025-04-10 Thread Jorn Vernee
> `jnativescan` uses the `ClassResolver` class to find both system classes, as > well as application classes. In principle, a class resolver supports both > iterating over all classes from that particular source, as well as looking up > classes by name. However, the `ClassResolver` for system cl

Re: RFR: 8353917: jnativescan: Simplify ClassResolver [v2]

2025-04-10 Thread Maurizio Cimadamore
On Wed, 9 Apr 2025 16:00:52 GMT, Jorn Vernee wrote: >> `jnativescan` uses the `ClassResolver` class to find both system classes, as >> well as application classes. In principle, a class resolver supports both >> iterating over all classes from that particular source, as well as looking >> up c

Re: RFR: 8354266: Fix non-UTF-8 text encoding

2025-04-10 Thread Raffaello Giulietti
On Thu, 10 Apr 2025 17:09:27 GMT, Naoto Sato wrote: >> I have checked the entire code base for incorrect encodings, but luckily >> enough these were the only remaining problems I found. >> >> BOM (byte-order mark) is a method used for distinguishing big and little >> endian UTF-16 encodings.

Re: RFR: 8350462: MethodTypeForm.LF_INTERPRET can cache the MemberName instead [v2]

2025-04-10 Thread Jorn Vernee
On Sun, 6 Apr 2025 08:09:27 GMT, Zihao Lin wrote: >> Modify the cache in MethodTypeForm that currently stores the LF_INTERPRET >> Lambda form. Instead of caching the entire LambdaForm, change it to store a >> SoftReference. This will avoid unnecessary memory usage. > > Zihao Lin has updated the

Re: RFR: 8350462: MethodTypeForm.LF_INTERPRET can cache the MemberName instead [v2]

2025-04-10 Thread Chen Liang
On Sun, 6 Apr 2025 08:09:27 GMT, Zihao Lin wrote: >> Modify the cache in MethodTypeForm that currently stores the LF_INTERPRET >> Lambda form. Instead of caching the entire LambdaForm, change it to store a >> SoftReference. This will avoid unnecessary memory usage. > > Zihao Lin has updated the

Integrated: 8350462: MethodTypeForm.LF_INTERPRET can cache the MemberName instead

2025-04-10 Thread Zihao Lin
On Sat, 5 Apr 2025 14:26:13 GMT, Zihao Lin wrote: > Modify the cache in MethodTypeForm that currently stores the LF_INTERPRET > Lambda form. Instead of caching the entire LambdaForm, change it to store a > SoftReference. This will avoid unnecessary memory usage. This pull request has now been

Re: RFR: 8351565: Implement JEP 502: Stable Values (Preview) [v53]

2025-04-10 Thread Per Minborg
On Thu, 10 Apr 2025 10:26:36 GMT, Per Minborg wrote: >> Implement JEP 502. >> >> The PR passes tier1-tier3 tests. > > Per Minborg has updated the pull request incrementally with one additional > commit since the last revision: > > Improve docs as per comments > > ``` > > > > I will take a

Re: RFR: 8354266: Fix non-UTF-8 text encoding

2025-04-10 Thread Naoto Sato
On Thu, 10 Apr 2025 10:10:49 GMT, Magnus Ihse Bursie wrote: > I have checked the entire code base for incorrect encodings, but luckily > enough these were the only remaining problems I found. > > BOM (byte-order mark) is a method used for distinguishing big and little > endian UTF-16 encoding

Re: RFR: 8344708: Compiler Implementation of Module Import Declarations [v5]

2025-04-10 Thread Jan Lahoda
> This is a patch to finalize the module imports feature. Please see: > https://bugs.openjdk.org/browse/JDK-8344700 Jan Lahoda has updated the pull request incrementally with one additional commit since the last revision: Reflecting review feedback: cleanup formatting in ModuleInfo. -

Re: RFR: 8344708: Compiler Implementation of Module Import Declarations [v4]

2025-04-10 Thread Jan Lahoda
On Wed, 9 Apr 2025 17:52:26 GMT, Alan Bateman wrote: >> Jan Lahoda has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Reflecting review feedback - avoiding hardcoded constants. > > src/java.base/share/classes/jdk/internal/module/ModuleInfo.

  1   2   >