On Wed, 26 Mar 2025 09:53:51 GMT, Severin Gehwolf wrote:
> The cacerts issue mentioned in the JBS issue relates to an RPM installation
> of the JDK where the cacerts file is a symlink to the distro provided one. So
> I think that's "use system" issue.
>
> TZ updates would potentially break thi
On Fri, 21 Mar 2025 18:50:40 GMT, Brent Christian wrote:
>> I propose some cleanups to `FinalizerHistogramTest.java` to hopefully clear
>> up the intermittent failures:
>>
>> * run with `othervm`: this test blocks the (global) finalizer thread, and
>> also requires the (global) finalizer threa
On Wed, 26 Mar 2025 13:11:40 GMT, Viktor Klang wrote:
>> Doug Lea has updated the pull request with a new target base due to a merge
>> or a rebase. The pull request now contains 49 commits:
>>
>> - Merge branch 'openjdk:master' into JDK-8319447
>> - Address review comments
>> - Merge branch
> Calling ThreadGroupReference.groups() from an event handler can cause a
> deadlock. Details in first comment. Tested with :jdk_lang on all supported
> platforms and tier1, tier2, tier3, and tier5 svc testing.
Chris Plummer has updated the pull request incrementally with one additional
commit
> Please review this enhancement which adds a hidden `jlink` option
> `--sha-overrides` that can be used to provide alternative hash sums for files
> in an image. Please see the bug for use-cases as to why this is needed. This
> patch allows for the `--sha-overrides` option to be either specifie
On Wed, 26 Mar 2025 16:39:27 GMT, Jaikiran Pai wrote:
>> Regarding adding a comment, I wasn't too sure what the comment should say
>> because once you start down that path, it's hard to not end up with too much
>> detail, and then things just get very wordy. Since we have a test that will
>> f
On Wed, 26 Mar 2025 06:02:42 GMT, David Holmes wrote:
>> Jiangli Zhou has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Address @dholmes-ora's comment: Use `strlen` to get the length for ",
>> static" and ", sharing".
>
> Thanks for the u
On Wed, 26 Mar 2025 14:50:11 GMT, Alan Bateman wrote:
> > I'll keep looking into this specific case. However, it sounds a bit
> > orthogonal to the patch at hand which I do believe we still need for the
> > original reasons mentioned (RPM changing binaries after the JDK build is
> > long done
On Wed, 26 Mar 2025 17:31:47 GMT, Aleksey Shipilev wrote:
>> When jspawnhelper fails for whatever reason, but more prominently due to
>> [JDK-8325621](https://bugs.openjdk.org/browse/JDK-8325621), it will report
>> the errors into stdout, but not to the relevant `IOException`. So, if the
>> ap
On Wed, 26 Mar 2025 17:47:07 GMT, Severin Gehwolf wrote:
> > Would it maybe make sense/be possible to offer some re-hash functionality
> > for using in 2nd step builds?
>
> What would that be? Right now linking from the run-time image doesn't allow
> for `jdk.jlink` to be included, which preve
On Wed, 26 Mar 2025 08:59:39 GMT, Alan Bateman wrote:
>> The `java.io.Console` has several backends: a simple on in `java.base`, a
>> more convenient one in `jdk.internal.le` (with line-reading based on JLine)
>> and one for JShell.
>>
>> The backend based on JLine is proving to be a somewhat
On Wed, 12 Mar 2025 17:02:01 GMT, Naoto Sato wrote:
>> JDK has been using JLine based Console implementation, in JDK20 as opt-in,
>> then in JDK22 as the default. While it has been providing rich functionality
>> for Console, it is increasingly difficult to maintain as a Console
>> implementat
On Tue, 25 Mar 2025 19:57:54 GMT, Doug Lea wrote:
>> (Copied from https://bugs.openjdk.org/browse/JDK-8319447)
>>
>> The problems addressed by this CR/PR are that ScheduledThreadPoolExecutor is
>> both ill-suited for many (if not most) of its applications, and is a
>> performance bottleneck (a
On Tue, 25 Feb 2025 22:41:07 GMT, Doug Lea wrote:
>>> @sunmisc You are right that it would be nice if there were a way to
>>> efficiently use getAndSet here because a failed reference CAS hits slow
>>> paths that vary across GCs. But all of the ways I know to do this are much
>>> worse.
>>
>>
On Wed, 26 Mar 2025 13:14:45 GMT, Alan Bateman wrote:
>> src/java.base/share/classes/java/util/concurrent/ForkJoinPool.java line 3743:
>>
>>> 3741: * @since 25
>>> 3742: */
>>> 3743: public void cancelDelayedTasksOnShutdown() {
>>
>> @DougLea Should this really be possible to enab
On Tue, 25 Mar 2025 19:57:54 GMT, Doug Lea wrote:
>> (Copied from https://bugs.openjdk.org/browse/JDK-8319447)
>>
>> The problems addressed by this CR/PR are that ScheduledThreadPoolExecutor is
>> both ill-suited for many (if not most) of its applications, and is a
>> performance bottleneck (a
On Mon, 17 Mar 2025 00:40:46 GMT, Chen Liang wrote:
>> src/java.base/share/classes/java/util/ImmutableCollections.java line 798:
>>
>>> 796: throw new IndexOutOfBoundsException(i);
>>> 797: }
>>> 798: }
>>
>> I think `orElseSet` should be outside of the `try`
On Wed, 26 Mar 2025 09:31:37 GMT, Alan Bateman wrote:
>> src/java.base/share/classes/java/lang/ThreadGroup.java line 664:
>>
>>> 662: private ThreadGroup[] subgroupsAsArray() {
>>> 663: List groups = synchronizedSubgroups();
>>> 664: return groups.toArray(new ThreadGroup[grou
> Implement JEP 502.
>
> The PR passes tier1-tier3 tests.
Per Minborg has updated the pull request incrementally with one additional
commit since the last revision:
Update src/java.base/share/classes/java/lang/StableValue.java
Co-authored-by: Paul Sandoz
-
Changes:
- all
On Mon, 24 Feb 2025 23:47:02 GMT, Chen Liang wrote:
> Use a thread-safe ReferencedKeySet instead of a WeakHashMap key set.
Hello Chen, going by what's documented in the
`jdk.internal.util.ReferencedKeySet`, the proposed change looks reasonable to
me. Someone more familiar with that class and t
On Wed, 26 Mar 2025 16:25:07 GMT, Chris Plummer wrote:
>> What would you think about using the simple code + loop from the JBS
>> comment? That would remove any discussion about toArray and any concerns
>> that it would load classes.
>
> Regarding adding a comment, I wasn't too sure what the co
On Wed, 26 Mar 2025 14:42:12 GMT, Severin Gehwolf wrote:
> I'll keep looking into this specific case. However, it sounds a bit
> orthogonal to the patch at hand which I do believe we still need for the
> original reasons mentioned (RPM changing binaries after the JDK build is long
> done and t
On Tue, 25 Mar 2025 23:58:36 GMT, Volker Simonis wrote:
>> Aleksey Shipilev has updated the pull request with a new target base due to
>> a merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contains three additional
>>
> When jspawnhelper fails for whatever reason, but more prominently due to
> [JDK-8325621](https://bugs.openjdk.org/browse/JDK-8325621), it will report
> the errors into stdout, but not to the relevant `IOException`. So, if the
> application is configured to only capture the exception logs (e.g.
On Wed, 26 Mar 2025 22:14:57 GMT, Justin Lu wrote:
>> src/java.base/share/classes/java/text/DecimalFormat.java line 4047:
>>
>>> 4045: * #setMaximumIntegerDigits(int)} or {@link
>>> #applyPattern(String)}.
>>> 4046: * See the {@link ##patterns Pattern Section} for comprehensive
>>> r
On Wed, 26 Mar 2025 21:41:02 GMT, Naoto Sato wrote:
>> Please review this PR which clarifies the behavior for integer and fraction
>> limits in NumberFormat and implementing classes. An associated CSR is filed.
>>
>> There have been a few bugs submitted which indicate a misconception that
>> t
> When jspawnhelper fails for whatever reason, but more prominently due to
> [JDK-8325621](https://bugs.openjdk.org/browse/JDK-8325621), it will report
> the errors into stdout, but not to the relevant `IOException`. So, if the
> application is configured to only capture the exception logs (e.g.
On Wed, 26 Mar 2025 19:52:46 GMT, Brent Christian wrote:
> But if there's concern that we won't reach the needed state during ForceGC's
> default timeout, I can call ForceGC.waitFor() with a longer timeout. 60s
> ought to be plenty.
I think using 60 seconds as a timeout for `ForceGC` would be
On Wed, 26 Mar 2025 20:50:36 GMT, Chris Plummer wrote:
>> Calling ThreadGroupReference.groups() from an event handler can cause a
>> deadlock. Details in first comment. Tested with :jdk_lang on all supported
>> platforms and tier1, tier2, tier3, and tier5 svc testing.
>
> Chris Plummer has upda
Davide,
I replied to your question in the core-libs-dev mailing list. See [1].
Please lets continue the discussion there.
[1] https://mail.openjdk.org/pipermail/core-libs-dev/2025-March/141394.html
- Alexey
On 3/26/2025 11:29 AM, Victor D'yakov wrote:
Alexey, could you reply on core-libs
On Wed, 19 Mar 2025 01:25:24 GMT, John R Rose wrote:
> Hi again Per!
>
> Here are some brief notes from our face-to-face chat at JavaOne.
>
> Debuggers want/need a "hook" for tentative evaluation of stables. It is an
> error for a debugger to trigger stable value decisions. This applies mainly
On Wed, 26 Mar 2025 18:57:37 GMT, Naoto Sato wrote:
> Those system property values on Windows were derived from Windows'
> `GetConsoleCP()` call, but they should have been taken from
> `GetConsoleOutputCP()`. Replacing the incorrect call with the correct one
> won't change any behavior, as bot
On Wed, 26 Mar 2025 19:11:01 GMT, Alan Bateman wrote:
>> Chris Plummer has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Use explicit array copying code. Better comment.
>
> test/jdk/com/sun/jdi/EarlyThreadGroupChildrenTest.java line 83:
>
On Wed, 26 Mar 2025 20:36:22 GMT, Chris Plummer wrote:
>> test/jdk/com/sun/jdi/EarlyThreadGroupChildrenTest.java line 83:
>>
>>> 81: public void classPrepared(ClassPrepareEvent event) {
>>> 82: try {
>>> 83: ++classPreparedCount;
>>
>> It's a long time since I looked at
On Wed, 26 Mar 2025 18:57:37 GMT, Naoto Sato wrote:
> Those system property values on Windows were derived from Windows'
> `GetConsoleCP()` call, but they should have been taken from
> `GetConsoleOutputCP()`. Replacing the incorrect call with the correct one
> won't change any behavior, as bot
On Fri, 21 Mar 2025 18:50:40 GMT, Brent Christian wrote:
>> I propose some cleanups to `FinalizerHistogramTest.java` to hopefully clear
>> up the intermittent failures:
>>
>> * run with `othervm`: this test blocks the (global) finalizer thread, and
>> also requires the (global) finalizer threa
> Please review following changes, thanks.
>
> - Add `static` to the vm_info for static JDK. The `-version` output now
> contains `static` on static JDK, e.g.:
>
>
> $ static-jdk/bin/java -version
> openjdk version "25-internal" 2025-09-16
> OpenJDK Runtime Environment (fastdebug build
> 25-in
On Wed, 26 Mar 2025 17:46:55 GMT, Aleksey Shipilev wrote:
>> Jiangli Zhou has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Address @dholmes-ora's comment: Use `strlen` to get the length for ",
>> static" and ", sharing".
>
> src/hotspot/
On Wed, 26 Mar 2025 23:05:46 GMT, Justin Lu wrote:
>> Please review this PR which clarifies the behavior for integer and fraction
>> limits in NumberFormat and implementing classes. An associated CSR is filed.
>>
>> There have been a few bugs submitted which indicate a misconception that
>> th
On Fri, 21 Mar 2025 14:24:13 GMT, Mikhail Yankelevich
wrote:
>> I propose some cleanups to `FinalizerHistogramTest.java` to hopefully clear
>> up the intermittent failures:
>>
>> * run with `othervm`: this test blocks the (global) finalizer thread, and
>> also requires the (global) finalizer
On Wed, 26 Mar 2025 14:49:23 GMT, Jaikiran Pai wrote:
>> Brent Christian has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> 'return' not needed in lambda
>
> test/jdk/java/lang/ref/FinalizerHistogramTest.java line 75:
>
>> 73:
> Calling ThreadGroupReference.groups() from an event handler can cause a
> deadlock. Details in first comment. Tested with :jdk_lang on all supported
> platforms and tier1, tier2, tier3, and tier5 svc testing.
Chris Plummer has updated the pull request incrementally with one additional
commit
On Wed, 26 Mar 2025 19:19:03 GMT, Alan Bateman wrote:
>> Naoto Sato has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Reflects the review comment
>
> src/java.base/windows/native/libjava/java_props_md.c line 131:
>
>> 129: }
>> 130:
>> 1
Those system property values on Windows were derived from Windows'
`GetConsoleCP()` call, but they should have been taken from
`GetConsoleOutputCP()`. Replacing the incorrect call with the correct one won't
change any behavior, as both calls return the same value by default
(`GetOEMCP()`). Howe
On Wed, 26 Mar 2025 20:57:47 GMT, Naoto Sato wrote:
>> Those system property values on Windows were derived from Windows'
>> `GetConsoleCP()` call, but they should have been taken from
>> `GetConsoleOutputCP()`. Replacing the incorrect call with the correct one
>> won't change any behavior, as
On Wed, 26 Mar 2025 18:22:00 GMT, Chris Plummer wrote:
>> Calling ThreadGroupReference.groups() from an event handler can cause a
>> deadlock. Details in first comment. Tested with :jdk_lang on all supported
>> platforms and tier1, tier2, tier3, and tier5 svc testing.
>
> Chris Plummer has upda
> Calling ThreadGroupReference.groups() from an event handler can cause a
> deadlock. Details in first comment. Tested with :jdk_lang on all supported
> platforms and tier1, tier2, tier3, and tier5 svc testing.
Chris Plummer has updated the pull request incrementally with one additional
commit
On Wed, 26 Mar 2025 13:05:46 GMT, Viktor Klang wrote:
>> Doug Lea has updated the pull request with a new target base due to a merge
>> or a rebase. The pull request now contains 49 commits:
>>
>> - Merge branch 'openjdk:master' into JDK-8319447
>> - Address review comments
>> - Merge branch
On Wed, 26 Mar 2025 19:28:24 GMT, Jiangli Zhou wrote:
>> Please review following changes, thanks.
>>
>> - Add `static` to the vm_info for static JDK. The `-version` output now
>> contains `static` on static JDK, e.g.:
>>
>>
>> $ static-jdk/bin/java -version
>> openjdk version "25-internal" 20
On Tue, 25 Mar 2025 03:19:39 GMT, Alexey Semenyuk wrote:
> Replace `error.invalid-value-for-package-name` and
> `error.invalid-value-for-package-name.advice` l10n keys with a pair for rpm
> packaging:
> - `error.rpm-invalid-value-for-package-name`
> - `error.rpm-invalid-value-for-package-name
On Wed, 26 Mar 2025 19:01:13 GMT, Alan Bateman wrote:
>> Chris Plummer has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Use explicit array copying code. Better comment.
>
> test/jdk/com/sun/jdi/EarlyThreadGroupChildrenTest.java line 55:
>
> Those system property values on Windows were derived from Windows'
> `GetConsoleCP()` call, but they should have been taken from
> `GetConsoleOutputCP()`. Replacing the incorrect call with the correct one
> won't change any behavior, as both calls return the same value by default
> (`GetOEMCP
Please review this PR which clarifies the behavior for integer and fraction
limits in NumberFormat and implementing classes. An associated CSR is filed.
There have been a few bugs submitted which indicate a misconception that these
limits impact parsing. The actual behavior is that these limits
On Wed, 26 Mar 2025 08:28:23 GMT, Christoph Langer wrote:
>> Severin Gehwolf has updated the pull request incrementally with two
>> additional commits since the last revision:
>>
>> - Copyright updates
>> - Allow for ${java.home} substitution when \@file is being passed
>>
>>Also refa
On Wed, 26 Mar 2025 17:47:46 GMT, Aleksey Shipilev wrote:
> Looks basically fine, just nits:
Thanks for reviewing, @shipilev!
Please help re-approve after update.
> test/hotspot/jtreg/runtime/CommandLine/OptionsValidation/common/optionsvalidation/JVMOptionsUtils.java
> line 56:
>
>> 54:
>>
On Wed, 26 Mar 2025 13:12:47 GMT, Viktor Klang wrote:
>> Doug Lea has updated the pull request with a new target base due to a merge
>> or a rebase. The pull request now contains 49 commits:
>>
>> - Merge branch 'openjdk:master' into JDK-8319447
>> - Address review comments
>> - Merge branch
On Wed, 26 Mar 2025 13:23:12 GMT, Viktor Klang wrote:
>> The commonPool can't be shutdown (both shutdown methods are specified to
>> have no effect on the common pool) so I suppose it doesn't really matter.
>
> Heh, that's a fair point, Alan. :)
Clarified:
* Arranges that scheduled tasks t
On Wed, 26 Mar 2025 20:31:07 GMT, Justin Lu wrote:
> Please review this PR which clarifies the behavior for integer and fraction
> limits in NumberFormat and implementing classes. An associated CSR is filed.
>
> There have been a few bugs submitted which indicate a misconception that
> these l
On Wed, 26 Mar 2025 22:35:25 GMT, Naoto Sato wrote:
>> That commentary is only in this method because of the non-obvious behavior
>> for the maximum integer digits. (The pattern does not change the
>> `maximumIntegerDigits`). Since not all users may read that section in the
>> class descriptio
> Please review this PR which clarifies the behavior for integer and fraction
> limits in NumberFormat and implementing classes. An associated CSR is filed.
>
> There have been a few bugs submitted which indicate a misconception that
> these limits impact parsing. The actual behavior is that the
On Wed, 26 Mar 2025 13:14:08 GMT, Viktor Klang wrote:
>> Doug Lea has updated the pull request with a new target base due to a merge
>> or a rebase. The pull request now contains 49 commits:
>>
>> - Merge branch 'openjdk:master' into JDK-8319447
>> - Address review comments
>> - Merge branch
On Wed, 26 Mar 2025 01:57:41 GMT, Jaikiran Pai wrote:
>> Calling ThreadGroupReference.groups() from an event handler can cause a
>> deadlock. Details in first comment. Tested with :jdk_lang on all supported
>> platforms and tier1, tier2, tier3, and tier5 svc testing.
>
> src/java.base/share/cla
The `java.io.Console` has several backends: a simple on in `java.base`, a more
convenient one in `jdk.internal.le` (with line-reading based on JLine) and one
for JShell.
The backend based on JLine is proving to be a somewhat problematic - JLine is
very powerful, possibly too powerful and comple
On Wed, 26 Mar 2025 08:55:09 GMT, Alan Bateman wrote:
> Can you coordinate with Naoto on this? There is a CSR in progress to switch
> Console back to using the java.base implementation by default.
Right - but that still keeps the existing JLine-based provider, and so the
problems it has still
On Tue, 25 Mar 2025 17:54:43 GMT, Severin Gehwolf wrote:
> @AlanBateman Would we need a CSR for this? This isn't any option that shows
> up anywhere user-visible, so I'm thinking not. Please let me know. Thanks!
There isn't any change to a supported interface so probably not. That said, I
don'
Hi David, what you suggested is already covered by StableValue.supplier.
You just need a Supplier instead of a micromanaged StableValue. StableValue
is a low level logic-free container but also has static methods for higher
level compositions, so it is easily confused like you did.
On Wed, Mar 26,
On Wed, 26 Mar 2025 07:54:48 GMT, Jan Lahoda wrote:
> The `java.io.Console` has several backends: a simple on in `java.base`, a
> more convenient one in `jdk.internal.le` (with line-reading based on JLine)
> and one for JShell.
>
> The backend based on JLine is proving to be a somewhat problem
On Tue, 25 Mar 2025 17:43:07 GMT, Severin Gehwolf wrote:
>> Please review this enhancement which adds a hidden `jlink` option
>> `--sha-overrides` that can be used to provide alternative hash sums for
>> files in an image. Please see the bug for use-cases as to why this is
>> needed. This patc
On Tue, 25 Mar 2025 13:33:15 GMT, Alan Bateman wrote:
>> Markus KARG has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Removed apiNote and implNote from CharBuffer, as suggested by Chen
>
> src/java.base/share/classes/java/lang/CharSequenc
On Tue, 25 Mar 2025 13:06:07 GMT, Alan Bateman wrote:
>> Markus KARG has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Removed apiNote and implNote from CharBuffer, as suggested by Chen
>
> src/java.base/share/classes/java/nio/X-Buffer.jav
On Wed, 26 Mar 2025 06:21:31 GMT, Robbin Ehn wrote:
> One issue with high timeout factor is that make+jtreg only can parallelize
> tests in the same directory. Which means you often end up with just waiting
> for one test to complete before anything else can happen.
jtreg doesn't require tests
> Hi all,
>
> please review this change that implements (currently Draft) JEP: G1:
> Improve Application Throughput with a More Efficient Write-Barrier.
>
> The reason for posting this early is that this is a large change, and the JEP
> process is already taking very long with no end in sight
On Wed, 26 Mar 2025 10:20:19 GMT, Alan Bateman wrote:
> > One issue with high timeout factor is that make+jtreg only can parallelize
> > tests in the same directory. Which means you often end up with just waiting
> > for one test to complete before anything else can happen.
>
> jtreg doesn't r
On Wed, 26 Mar 2025 08:53:21 GMT, Alan Bateman wrote:
> > @AlanBateman Would we need a CSR for this? This isn't any option that shows
> > up anywhere user-visible, so I'm thinking not. Please let me know. Thanks!
>
> There isn't any change to a supported interface so probably not.
Thanks.
> T
> The test `testEcoFriendly()` checks if the launcher pollutes the
> `LD_LIBRARY_PATH` environment variable.
> Because aix and musl intentionally pollute the `LD_LIBRARY_PATH`, it does not
> make sense to make this test somehow passing with crude workarounds, which
> even do not work in any case
> By using the Class File API to dynamically generate a CompositePrinterParser,
> and defining DateTimePrinterParser[] printerParsers as a specific field, C2
> can do TypeProfile optimization.
>
> Since the CompositePrinterParser is generated based on the pattern, we can
> make the following op
On Wed, 26 Mar 2025 19:28:24 GMT, Jiangli Zhou wrote:
>> Please review following changes, thanks.
>>
>> - Add `static` to the vm_info for static JDK. The `-version` output now
>> contains `static` on static JDK, e.g.:
>>
>>
>> $ static-jdk/bin/java -version
>> openjdk version "25-internal" 20
On Tue, 25 Mar 2025 15:27:05 GMT, David M. Lloyd wrote:
>> Provide method overloads to the ClassFile interface of the
>> java.lang.classfile API which allow parsing of classes found in memory
>> segments, as well as allowing built class files to be output to them.
>
> David M. Lloyd has updated
On Wed, 26 Mar 2025 09:52:27 GMT, Joachim Kern wrote:
>> The test `testEcoFriendly()` checks if the launcher pollutes the
>> `LD_LIBRARY_PATH` environment variable.
>> Because aix and musl intentionally pollute the `LD_LIBRARY_PATH`, it does
>> not make sense to make this test somehow passing w
79 matches
Mail list logo
