On Fri, 7 Mar 2025 17:38:13 GMT, Quan Anh Mai wrote:
>> Hi,
>>
>> This patch improves the performance of a typical `Arena::allocate` in
>> several ways:
>>
>> - Delay the creation of the NativeMemorySegmentImpl. This avoids the merge
>> of the instance with the one obtained from the call in t
On Wed, 12 Mar 2025 12:23:50 GMT, Albert Mingkun Yang wrote:
>> Thomas Schatzl has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contains 24 additional
>>
the test output was cleanup for common execution.
-
Commit messages:
- JDK-8351593 [JMH] test PhoneCode.Bulk reports NPE exception
Changes: https://git.openjdk.org/jdk/pull/24011/files
Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=24011&range=00
Issue: https://bugs.openjdk.or
> Can I please get a review of this change which proposes to fix an issue
> `java.util.zip.ZipFile` which would cause failures when multiple instances of
> `ZipFile` using non-UTF8 `Charset` were operating against the same underlying
> ZIP file? This addresses https://bugs.openjdk.org/browse/JDK
On Mon, 13 Jan 2025 16:28:52 GMT, Viktor Klang wrote:
> Seems sensible to improve this given that it can be tricky to figure out
> which parameter caused the exception to be thrown.
This pull request has been closed without being integrated.
-
PR: https://git.openjdk.org/jdk/pull/
> JDK has been using JLine based Console implementation, in JDK20 as opt-in,
> then in JDK22 as the default. While it has been providing rich functionality
> for Console, it is increasingly difficult to maintain as a Console
> implementation. In light of the on-ramp feature
> (https://bugs.open
> Hi all,
>
> please review this change that implements (currently Draft) JEP: G1:
> Improve Application Throughput with a More Efficient Write-Barrier.
>
> The reason for posting this early is that this is a large change, and the JEP
> process is already taking very long with no end in sight
On Wed, 12 Mar 2025 06:42:43 GMT, Jaikiran Pai wrote:
>> src/java.base/share/classes/java/util/zip/ZipFile.java line 376:
>>
>>> 374: * @param pos the entry position
>>> 375: */
>>> 376: private static boolean useUTF8Coder(final byte[] cen, final int
>>> pos) {
>>
>> This seems m
On Mon, 10 Mar 2025 23:14:23 GMT, Brent Christian wrote:
>> Please review this revision of a previously puzzling comment intending to
>> provide the rationale for a bit of non-obvious code.
>
> src/java.base/share/classes/jdk/internal/ref/CleanerImpl.java line 142:
>
>> 140: // w
On Wed, 12 Mar 2025 11:58:45 GMT, Thomas Schatzl wrote:
>> Hi all,
>>
>> please review this change that implements (currently Draft) JEP: G1:
>> Improve Application Throughput with a More Efficient Write-Barrier.
>>
>> The reason for posting this early is that this is a large change, and the
> Hi all,
>
> please review this change that implements (currently Draft) JEP: G1:
> Improve Application Throughput with a More Efficient Write-Barrier.
>
> The reason for posting this early is that this is a large change, and the JEP
> process is already taking very long with no end in sight
On Fri, 7 Mar 2025 13:14:02 GMT, Albert Mingkun Yang wrote:
>> Thomas Schatzl has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> * iwalulya review
>> * renaming
>> * fix some includes, forward declaration
>
> src/hotspot/share/gc/g1
On Wed, 12 Mar 2025 13:20:25 GMT, Albert Mingkun Yang wrote:
>> Thomas Schatzl has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contains 24 additional
>>
On Wed, 12 Mar 2025 07:13:19 GMT, Jaikiran Pai wrote:
>> Naoto Sato has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Reflects review comment
>
> test/jdk/java/io/Console/ConsolePromptTest.java line 77:
>
>> 75: var expect = Paths
On Thu, 20 Feb 2025 14:22:20 GMT, Severin Gehwolf wrote:
>> Please review this fix for cgroups-based metrics reporting in the
>> `jdk.internal.platform` package. This fix is supposed to address wrong
>> reporting of certain limits if the limits aren't set at the leaf nodes.
>>
>> For example,
On Tue, 11 Mar 2025 18:32:10 GMT, Naoto Sato wrote:
> JDK has been using JLine based Console implementation, in JDK20 as opt-in,
> then in JDK22 as the default. While it has been providing rich functionality
> for Console, it is increasingly difficult to maintain as a Console
> implementation.
On Tue, 11 Mar 2025 15:31:09 GMT, Eirik Bjørsnøs wrote:
> This seems mostly used to determine which ZipCoder to pick. Could we fold
> this into the method, calling it zipCoderForPos and make it just return the
> ZipCoder, like we had in Source?
I intentionally removed the `zipCoderForPos()` me
On Thu, 13 Mar 2025 01:21:54 GMT, Archie Cobbs wrote:
> This PR fixes minor Javadoc typos in a few `java.base` classes. Extra curly
> braces have been sneaking in.
src/java.base/share/classes/java/text/MessageFormat.java line 327:
> 325: * {@code unit}
> 326: * {@link ListFormat#
On Thu, 13 Mar 2025 01:21:54 GMT, Archie Cobbs wrote:
> This PR fixes minor Javadoc typos in a few `java.base` classes. Extra curly
> braces have been sneaking in.
The change in `MessageFormat.java` looks good
-
PR Review: https://git.openjdk.org/jdk/pull/24022#pullrequestreview-2
On Thu, 13 Mar 2025 01:46:53 GMT, Iris Clark wrote:
> Where's the matching `(`? I'm guessing that the IDE thinks it's the one
> immediately before the `getLocale()`, but I suspect that javadoc won't agree
> with that.
You are correct - the matching `(` is the one preceding `getLocale()`.
I'm
> Hi,
>
> This patch improves the performance of a typical `Arena::allocate` in several
> ways:
>
> - Delay the creation of the NativeMemorySegmentImpl. This avoids the merge of
> the instance with the one obtained from the call in the uncommon path,
> increasing the chance the object being sc
This PR fixes minor Javadoc typos in a few `java.base` classes. Extra curly
braces have been sneaking in.
-
Commit messages:
- Fix minor Javadoc typos.
Changes: https://git.openjdk.org/jdk/pull/24022/files
Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=24022&range=00
Issue: h
22 matches
Mail list logo
