Integrated: 8351567: Jar Manifest test ValueUtf8Coding produces misleading diagnostic output

2025-03-10 Thread Roger Riggs
On Mon, 10 Mar 2025 18:06:43 GMT, Roger Riggs wrote: > Remove misleading/invalid diagnostic output from the JAR manifest test > ValueUtf8Coding.java. > > The Manifest binary stream is not a well formed UTF-8 string due to the > inserted continuation characters used for lines longer than 70 cha

Re: RFR: 8351567: Jar Manifest test ValueUtf8Coding produces misleading diagnostic output

2025-03-10 Thread Iris Clark
On Mon, 10 Mar 2025 18:06:43 GMT, Roger Riggs wrote: > Remove misleading/invalid diagnostic output from the JAR manifest test > ValueUtf8Coding.java. > > The Manifest binary stream is not a well formed UTF-8 string due to the > inserted continuation characters used for lines longer than 70 cha

Re: RFR: 8342382: Implementation of JEP G1: Improve Application Throughput with a More Efficient Write-Barrier [v15]

2025-03-10 Thread Fei Yang
On Sat, 8 Mar 2025 19:32:54 GMT, Thomas Schatzl wrote: >> Hi all, >> >> please review this change that implements (currently Draft) JEP: G1: >> Improve Application Throughput with a More Efficient Write-Barrier. >> >> The reason for posting this early is that this is a large change, and the

RFR: 8351567: Jar Manifest test ValueUtf8Coding produces misleading diagnostic output

2025-03-10 Thread Roger Riggs
Remove misleading/invalid diagnostic output from the JAR manifest test ValueUtf8Coding.java. The Manifest binary stream is not a well formed UTF-8 string due to the inserted continuation characters used for lines longer than 70 characters.. - Commit messages: - 8351567: Jar Manife

Re: RFR: 8337279: Optimize format instant [v15]

2025-03-10 Thread Shaojin Wen
On Mon, 3 Feb 2025 22:31:10 GMT, Shaojin Wen wrote: >> By removing the redundant code logic in >> DateTimeFormatterBuilder$InstantPrinterParser#formatTo, the codeSize can be >> reduced and the performance can be improved. > > Shaojin Wen has updated the pull request incrementally with one addit

Re: RFR: 8307513: C2: intrinsify Math.max(long,long) and Math.min(long,long) [v14]

2025-03-10 Thread Christian Hagedorn
On Fri, 7 Mar 2025 06:19:03 GMT, Galder Zamarreño wrote: >> This patch intrinsifies `Math.max(long, long)` and `Math.min(long, long)` in >> order to help improve vectorization performance. >> >> Currently vectorization does not kick in for loops containing either of >> these calls because of t

Re: RFR: 8351374: Improve comment about queue.remove timeout in CleanerImpl.run

2025-03-10 Thread Brent Christian
On Fri, 7 Mar 2025 23:17:53 GMT, Kim Barrett wrote: > Please review this revision of a previously puzzling comment intending to > provide the rationale for a bit of non-obvious code. src/java.base/share/classes/jdk/internal/ref/CleanerImpl.java line 142: > 140: // while there ar

Re: RFR: 8351567: Jar Manifest test ValueUtf8Coding produces misleading diagnostic output

2025-03-10 Thread Lance Andersen
On Mon, 10 Mar 2025 18:06:43 GMT, Roger Riggs wrote: > Remove misleading/invalid diagnostic output from the JAR manifest test > ValueUtf8Coding.java. > > The Manifest binary stream is not a well formed UTF-8 string due to the > inserted continuation characters used for lines longer than 70 cha

Re: RFR: 8351374: Improve comment about queue.remove timeout in CleanerImpl.run

2025-03-10 Thread Aleksey Shipilev
On Fri, 7 Mar 2025 23:17:53 GMT, Kim Barrett wrote: > Please review this revision of a previously puzzling comment intending to > provide the rationale for a bit of non-obvious code. Marked as reviewed by shade (Reviewer). - PR Review: https://git.openjdk.org/jdk/pull/23952#pullreq

Re: RFR: 8266431: Dual-Pivot Quicksort improvements (Radix sort) [v11]

2025-03-10 Thread Vladimir Yaroslavskiy
On Mon, 10 Mar 2025 06:48:49 GMT, Per Minborg wrote: >> Laurent Bourgès has updated the pull request incrementally with one >> additional commit since the last revision: >> >> add @SuppressWarnings (serial) > > Hi. I've seen this PR being worked on for a long time. Did you discuss the > moti

Re: RFR: 8351372: Improve negative tests coverage of jpackage [v3]

2025-03-10 Thread Alexey Semenyuk
> Changes to tests: > - Added more test cases to ErrorTest. > - Added functionality to jpackage test lib to facilitate new ErrorTest test > cases. > - Make all other negative tests use the `CannedFormattedString` class to > validate error messages in jpackage output strictly. > - Removed redu

Re: RFR: 8351372: Improve negative tests coverage of jpackage [v3]

2025-03-10 Thread Alexander Matveev
On Mon, 10 Mar 2025 20:48:42 GMT, Alexey Semenyuk wrote: >> Changes to tests: >> - Added more test cases to ErrorTest. >> - Added functionality to jpackage test lib to facilitate new ErrorTest test >> cases. >> - Make all other negative tests use the `CannedFormattedString` class to >> valid

Re: RFR: 8340133: Add concise usage message to the java executable [v10]

2025-03-10 Thread Jaikiran Pai
On Fri, 29 Nov 2024 07:25:23 GMT, Jan Lahoda wrote: >> Currently, running `java` without any parameters will lead to an output that >> is a full `--help`, which is over 100 lines (on my computer at least), and >> it feels overwhelming. And many people might actually want to run >> JShell/REPL,