>>
>> Warning: "--install-dir" option is ignored for DMG packaging. The
>> installation directory will default to {0}.
>
> I like this one and yes lets change it: `Warning: "--install-dir" option is
> ignored for DMG packaging. The installation directory will default to {0}.`
>
I must be mi
On Mon, 24 Feb 2025 19:29:30 GMT, Chen Liang wrote:
>> Tagir F. Valeev has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Update copyright
>
> This file needs a copyright year update, from `(c) 2020, Oracle` to `(c)
> 2020, 2025, Oracle`.
> It appears that the benchmark was erroneous. The combination of "tailMap"
> mode and comparator = true didn't work correctly, as the comparator is
> descending. This PR changes the benchmark to use headMap instead of tailMap
> in comparator mode. The "tailMap" mode is renamed to "subMap". Now,
On Mon, 24 Feb 2025 19:46:52 GMT, Naoto Sato wrote:
> Removing the support for /etc/timezone file that is Debian distro specific.
> The file is no longer considered authoritative
> (https://wiki.debian.org/TimeZoneChanges#Check_Configured_Timezone), and in
> fact, it is now out of sync as the
On Mon, 24 Feb 2025 19:46:52 GMT, Naoto Sato wrote:
> Removing the support for /etc/timezone file that is Debian distro specific.
> The file is no longer considered authoritative
> (https://wiki.debian.org/TimeZoneChanges#Check_Configured_Timezone), and in
> fact, it is now out of sync as the
On Sat, 22 Feb 2025 14:49:38 GMT, Coleen Phillimore wrote:
>> Class.isInterface() can check modifier flags, Class.isArray() can check
>> whether component mirror is non-null and Class.isPrimitive() needs a new
>> final transient boolean in java.lang.Class that the JVM code initializes.
>> Teste
On Mon, 24 Feb 2025 15:37:29 GMT, Daniel Fuchs wrote:
>> Those read more like an @ApiNote, advice on how to use the API.
>
> @RogerRiggs - Is overriding a method and calling `super` considered a use of
> the API? Because these notes are only useful for people implemeting custom
> subclasses of
On Mon, 24 Feb 2025 11:34:15 GMT, Maurizio Cimadamore
wrote:
>> Chen Liang has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Review remarks, dates, some more simplifications
>
> src/java.base/share/classes/jdk/internal/foreign/Utils.java
On Sat, 22 Feb 2025 14:40:39 GMT, Alexey Semenyuk wrote:
>> Support the use of a custom msi wrapper executable when building an exe
>> installer.
>>
>> Put `installer.exe` file in the resource directory and jpackage will use it
>> instead of the default `msiwrapper.exe` resource for exe instal
On Mon, 24 Feb 2025 19:24:42 GMT, Roger Riggs wrote:
>> Yep, I think overriding methods are considered usages of API. Implementation
>> applies to the exact method implementation.
>
> There are elements of both implNote and ApiNote, maybe there is clarity in
> separating the descriptions into t
On Mon, 24 Feb 2025 19:30:41 GMT, Coleen Phillimore wrote:
>> Class.isInterface() can check modifier flags, Class.isArray() can check
>> whether component mirror is non-null and Class.isPrimitive() needs a new
>> final transient boolean in java.lang.Class that the JVM code initializes.
>> Teste
> Cgroup V1 subsustem fails to initialize mounted controllers properly in
> certain cases, that may lead to controllers left undetected/inactive. We
> observed the behavior in CloudFoundry deployments, it affects also host
> systems.
>
> The relevant /proc/self/mountinfo line is
>
>
> 2207 21
On Mon, 17 Feb 2025 14:04:03 GMT, Severin Gehwolf wrote:
> `CgroupV1Controller::set_subsystem_path` needs high level comment update to
> describe the logic happening.
>
Done, added
-
PR Comment: https://git.openjdk.org/jdk/pull/21808#issuecomment-2679664923
On Fri, 21 Feb 2025 20:05:07 GMT, Sergey Chernyshev
wrote:
>> Good catch, but as long as cgp#nameCount may change in the loop, this exact
>> patch i cannot take.
>
> How about this?
>
> int currentNameCount = cgp.getNameCount();
> cgp = (currentNameCount > 1) ? cgp.subpath(1, currentNameCount)
On Mon, 24 Feb 2025 19:46:52 GMT, Naoto Sato wrote:
> Removing the support for /etc/timezone file that is Debian distro specific.
> The file is no longer considered authoritative
> (https://wiki.debian.org/TimeZoneChanges#Check_Configured_Timezone), and in
> fact, it is now out of sync as the
On Sat, 22 Feb 2025 14:40:39 GMT, Alexey Semenyuk wrote:
>> Support the use of a custom msi wrapper executable when building an exe
>> installer.
>>
>> Put `installer.exe` file in the resource directory and jpackage will use it
>> instead of the default `msiwrapper.exe` resource for exe instal
- Unify TKit.createTempDirectory() and TKit.createTempFile() functions. Remove
`throws IOexception` from their signatures. Add relevant tests.
- JPackageCommand.java: remove try/catch(IOexception) around
`TKit.createTempDirectory()` call.
- AppImagePackageTest.java: replace `TKit.createTempDire
On Mon, 24 Feb 2025 19:18:27 GMT, Alexey Semenyuk wrote:
> - Unify TKit.createTempDirectory() and TKit.createTempFile() functions.
> Remove `throws IOexception` from their signatures. Add relevant tests.
> - JPackageCommand.java: remove try/catch(IOexception) around
> `TKit.createTempDirectory
On Mon, 24 Feb 2025 19:10:29 GMT, Chen Liang wrote:
>> @RogerRiggs - Is overriding a method and calling `super` considered a use of
>> the API? Because these notes are only useful for people implemeting custom
>> subclasses of Handler...
>
> Yep, I think overriding methods are considered usages
On Sat, 22 Feb 2025 14:49:38 GMT, Coleen Phillimore wrote:
>> Class.isInterface() can check modifier flags, Class.isArray() can check
>> whether component mirror is non-null and Class.isPrimitive() needs a new
>> final transient boolean in java.lang.Class that the JVM code initializes.
>> Teste
On Mon, 24 Feb 2025 19:06:30 GMT, Roger Riggs wrote:
>> Coleen Phillimore has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Use modifiers field directly in isInterface.
>
> src/java.base/share/classes/java/lang/Class.java line 241:
>
>> 2
> Class.isInterface() can check modifier flags, Class.isArray() can check
> whether component mirror is non-null and Class.isPrimitive() needs a new
> final transient boolean in java.lang.Class that the JVM code initializes.
> Tested with tier1-4 and performance tests.
Coleen Phillimore has upda
On Mon, 24 Feb 2025 08:44:00 GMT, Tagir F. Valeev wrote:
> It appears that the benchmark was erroneous. The combination of "tailMap"
> mode and comparator = true didn't work correctly, as the comparator is
> descending. This PR changes the benchmark to use headMap instead of tailMap
> in compa
Removing the support for /etc/timezone file that is Debian distro specific. The
file is no longer considered authoritative
(https://wiki.debian.org/TimeZoneChanges#Check_Configured_Timezone), and in
fact, it is now out of sync as the bug reports. The fix was confirmed manually
on a Ubuntu 25.04
> - Unify TKit.createTempDirectory() and TKit.createTempFile() functions.
> Remove `throws IOexception` from their signatures. Add relevant tests.
> - JPackageCommand.java: remove try/catch(IOexception) around
> `TKit.createTempDirectory()` call.
> - AppImagePackageTest.java: replace `TKit.crea
> - Fix the warning message about the custom installation directory location
> jpackage issues for DMG runtime packaging.
> - Don't issue the warning when the `-install-dir` value equals the default
> installation directory location.
Alexey Semenyuk has updated the pull request incrementally wi
> - Unify TKit.createTempDirectory() and TKit.createTempFile() functions.
> Remove `throws IOexception` from their signatures. Add relevant tests.
> - JPackageCommand.java: remove try/catch(IOexception) around
> `TKit.createTempDirectory()` call.
> - AppImagePackageTest.java: replace `TKit.crea
On Mon, 24 Feb 2025 18:19:12 GMT, Alexey Semenyuk wrote:
>> - Fix the warning message about the custom installation directory location
>> jpackage issues for DMG runtime packaging.
>> - Don't issue the warning when the `-install-dir` value equals the default
>> installation directory location.
On Mon, 17 Feb 2025 14:04:03 GMT, Severin Gehwolf wrote:
> The above case, doesn't seem to be reflected by any gtest test case (or
> others), please add those.
The subgroup path reduction is covered by
`TestMemoryWithSubgroups#testMemoryLimitSubgroupV1` (it wouldn't be possible in
gtests as i
On Thu, 20 Feb 2025 02:33:59 GMT, Chen Liang wrote:
> LF editor spins classes, this avoids the spinning overhead and should speed
> up non-capturing lambdas too.
>
> There may need to be additional intrinsic work for MH combinator lf bytecode
> generation.
I think this version should be fine:
On Mon, 17 Feb 2025 06:40:11 GMT, Nicole Xu wrote:
>> Please try with following command line
>> `java -jar target/benchmarks.jar -f 1 -i 2 -wi 1 -w 30 -p ARRAYLEN=30
>> MaskedLogic`
>
> Thanks for pointing that out. Typically, ARRAYLEN is almost always a POT
> value, which is also assumed by ma
> A couple adjustments to the specs for four methods of StringBuilder and
> StringBuffer so that they no longer require new Strings to be created, just a
> String with the right contents. No implementation changes. Note that the
> actual specs (and implementations) are actually in AbstractString
On Mon, 24 Feb 2025 22:20:27 GMT, Alexander Matveev
wrote:
> Currently it sounds that CLI option "--install-dir" is not supported, but it
> will work if it points to default location.
The warning will be shown only if `--install-dir` doesn't point to the default
location. This is the change f
On Mon, 24 Feb 2025 22:57:21 GMT, Alexander Matveev
wrote:
> This one is confusing. It will evaluate to true if both != null
Correct. They both shouldn't be `true`. One of them must be `true`, and another
one must be `false`.
> Did you mean "&&" instead of "=="?
No. I meant `==` :)
On Tue, 25 Feb 2025 01:00:31 GMT, Alexey Semenyuk wrote:
>> src/jdk.jpackage/macosx/classes/jdk/jpackage/internal/resources/MacResources.properties
>> line 94:
>>
>>> 92: message.signing.pkg=Warning: For signing PKG, you might need to set
>>> "Always Trust" for your certificate using "Keychain
On Tue, 25 Feb 2025 01:02:13 GMT, Alexey Semenyuk wrote:
>> test/jdk/tools/jpackage/helpers-test/jdk/jpackage/test/TKitTest.java line
>> 232:
>>
>>> 230: if ((expectedExceptionClass == null) == (expectedPath ==
>>> null)) {
>>> 231: throw new IllegalArgumentExceptio
On Mon, 24 Feb 2025 13:08:49 GMT, David Beaumont wrote:
>> 8349206: j.u.l.Handler classes create deadlock risk via synchronized
>> publish() method.
>>
>> 1. Remove synchronization of calls to publish() in Handlers in
>> java.util.logging package.
>> 2. Add explanatory comments to various affe
On Fri, 14 Feb 2025 15:07:58 GMT, David Beaumont wrote:
>> Well spotted :) Yes, it's a theoretical risk, but not at the same level as
>> that of log record formatting.
>>
>> My original draft push of this PR had comments about lock expectations here,
>> but I was asked to not change the JavaDo
Hi all,
The newly added JMH test
jdk.incubator.vector.VectorCommutativeOperSharingBenchmark run fails
"java.lang.NoClassDefFoundError: jdk/incubator/vector/Vector".
The `@Fork(jvmArgsPrepend = ..)` in microbenchmarks should replaced as
`@Fork(jvmArgs = ..)` after
[JDK-8343345](https://bugs.op
On Mon, 24 Feb 2025 20:29:09 GMT, Alexey Semenyuk wrote:
>> - Unify TKit.createTempDirectory() and TKit.createTempFile() functions.
>> Remove `throws IOexception` from their signatures. Add relevant tests.
>> - JPackageCommand.java: remove try/catch(IOexception) around
>> `TKit.createTempDirec
> LF editor spins classes, this avoids the spinning overhead and should speed
> up non-capturing lambdas too.
>
> There may need to be additional intrinsic work for MH combinator lf bytecode
> generation.
Chen Liang has updated the pull request incrementally with one additional
commit since th
On Fri, 21 Feb 2025 10:15:12 GMT, Maurizio Cimadamore
wrote:
>> Chen Liang has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Review remarks, dates, some more simplifications
>
> src/java.base/share/classes/java/lang/invoke/X-VarHandleSegm
On Fri, 21 Feb 2025 23:17:50 GMT, John R Rose wrote:
>> LF editor spins classes, this avoids the spinning overhead and should speed
>> up non-capturing lambdas too.
>>
>> There may need to be additional intrinsic work for MH combinator lf bytecode
>> generation.
>
> src/java.base/share/classes
On Thu, 20 Feb 2025 02:33:59 GMT, Chen Liang wrote:
> LF editor spins classes, this avoids the spinning overhead and should speed
> up non-capturing lambdas too.
>
> There may need to be additional intrinsic work for MH combinator lf bytecode
> generation.
You are on the right track. Some of
LF editor spins classes, this avoids the spinning overhead and should speed up
non-capturing lambdas too.
There may need to be additional intrinsic work for MH combinator lf bytecode
generation.
-
Commit messages:
- Years, roll back unrelated changes
- Simplify constant making
-
Use a thread-safe ReferencedKeySet instead of a WeakHashMap key set.
-
Commit messages:
- 8350549: MethodHandleProxies.WRAPPER_TYPES is not thread-safe
Changes: https://git.openjdk.org/jdk/pull/23757/files
Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=23757&range=00
Issue: ht
j.l.classfile package-summary contains many code snippets.
Some of the shorter snippets are embedded in the javadoc and therefore are not
validated by the tests.
One embedded code snippet contains a typo, and two snippets do not reflect the
actual API method name.
This patch fixes the code snipp
It appears that the benchmark was erroneous. The combination of "tailMap" mode
and comparator = true didn't work correctly, as the comparator is descending.
This PR changes the benchmark to use headMap instead of tailMap in comparator
mode. The "tailMap" mode is renamed to "subMap". Now, all par
On Mon, 24 Feb 2025 07:25:41 GMT, Alan Bateman wrote:
> If you are suggesting exposing this as a public API then I don't think we
> should do this,
Not at this time, quite possibly never. As mentioned, I made some things
public for ease of prototyping.
I even commented it as such.
> I actual
> Can I please get a review of this change, which simplifies the interaction
> between the `java` launcher's native code with the
> `sun.launcher.LauncherHelper`?
>
> As noted in https://bugs.openjdk.org/browse/JDK-8341184, this proposed change
> reduces the back and forth between the launcher
On Thu, 30 Jan 2025 14:20:56 GMT, Jaikiran Pai wrote:
>> Can I please get a review of this change, which simplifies the interaction
>> between the `java` launcher's native code with the
>> `sun.launcher.LauncherHelper`?
>>
>> As noted in https://bugs.openjdk.org/browse/JDK-8341184, this propo
On Fri, 21 Feb 2025 17:04:11 GMT, Brian Burkhalter wrote:
>> src/java.base/unix/classes/java/io/UnixFileSystem.java line 37:
>>
>>> 35:
>>> 36: private String getPathForSysCalls(String path) {
>>> 37: return path.isEmpty() ? getCWD().getPath() : path;
>>
>> The Windows implementati
On Sun, 23 Feb 2025 15:26:48 GMT, Doug Lea wrote:
>> (Copied from https://bugs.openjdk.org/browse/JDK-8319447)
>>
>> The problems addressed by this CR/PR are that ScheduledThreadPoolExecutor is
>> both ill-suited for many (if not most) of its applications, and is a
>> performance bottleneck (a
On Fri, 21 Feb 2025 22:12:43 GMT, Chen Liang wrote:
>> src/java.base/share/classes/jdk/internal/foreign/Utils.java line 120:
>>
>>> 118: * with a {@link ValueLayout#varHandle()} call is cached inside a
>>> stable field of the value layout implementation.
>>> 119: * This optimizes comm
On Fri, 21 Feb 2025 20:14:19 GMT, Chen Liang wrote:
>> Simplify the layout access var handles to be direct in some common cases.
>> Also made `VarHandle::isAccessModeSupported` report if an access mode is
>> supported for a VH.
>>
>> Reduces the instructions to execute this code in a simple ma
> 8349206: j.u.l.Handler classes create deadlock risk via synchronized
> publish() method.
>
> 1. Remove synchronization of calls to publish() in Handlers in
> java.util.logging package.
> 2. Add explanatory comments to various affected methods.
> 3. Add a test to ensure deadlocks no longer occu
On Mon, 24 Feb 2025 11:58:11 GMT, David Beaumont wrote:
>> 8349206: j.u.l.Handler classes create deadlock risk via synchronized
>> publish() method.
>>
>> 1. Remove synchronization of calls to publish() in Handlers in
>> java.util.logging package.
>> 2. Add explanatory comments to various affe
> 8349206: j.u.l.Handler classes create deadlock risk via synchronized
> publish() method.
>
> 1. Remove synchronization of calls to publish() in Handlers in
> java.util.logging package.
> 2. Add explanatory comments to various affected methods.
> 3. Add a test to ensure deadlocks no longer occu
On Mon, 24 Feb 2025 12:19:19 GMT, Daniel Fuchs wrote:
>> David Beaumont has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Adding @implNote to new JavaDoc.
>
> src/java.logging/share/classes/java/util/logging/Handler.java line 47:
>
>> 45:
On Mon, 24 Feb 2025 13:03:38 GMT, David Beaumont wrote:
>> src/java.logging/share/classes/java/util/logging/Handler.java line 47:
>>
>>> 45: *
>>> 46: * Subclass Implementation Notes
>>> 47: *
>>
>> Have you looked at how this is rendered in the generated API documentation
>> when loaded up
On Mon, 24 Feb 2025 08:09:00 GMT, Adam Sotona wrote:
> j.l.classfile package-summary contains many code snippets.
> Some of the shorter snippets are embedded in the javadoc and therefore are
> not validated by the tests.
> One embedded code snippet contains a typo, and two snippets do not reflec
On Mon, 24 Feb 2025 13:05:57 GMT, David Beaumont wrote:
>> You're right, it looks wrong with the `` and the @implNote. I'll just
>> remove the ``.
>> I hadn't appreciated that the note would have its own section. Thanks for
>> spotting.
>> It also seems that you can only add one annotation per
On Mon, 24 Feb 2025 15:20:13 GMT, Roger Riggs wrote:
>> I've asked on the CSR if this should be @implNote or @implSpec.
>
> Those read more like an @ApiNote, advice on how to use the API.
@RogerRiggs - Is overriding a method and calling `super` considered a use of
the API? Because these notes a
On Wed, 19 Feb 2025 05:12:38 GMT, David Holmes wrote:
> Does the SA not need any updates in relation to this?
No, the SA doesn't know about these compiler intrinsics.
-
PR Comment: https://git.openjdk.org/jdk/pull/23572#issuecomment-2678913119
> Motivation:
> When a user passes a wrong parameter, the current implementation throws an
> IllegalArgumentException with an error message `null`, which is not helpful.
>
> Modification:
> Add detail error messages.
>
> Result:
> Helpful messages.
He-Pin(kerr) has updated the pull request incr
On Thu, 20 Feb 2025 23:23:08 GMT, Coleen Phillimore wrote:
>>> ... but not in the return since the caller likely will fetch the klass
>>> pointer next.
>>
>> I notice that too. Callers are using is_primitive() to short-circuit calls
>> to as_Klass(), which means they seem to be aware of this
8350594: Misleading warning about install dir for DMG packaging
-
Commit messages:
- Update copyright year
- Remove redundant import changes
- Added tests for DMG install dir. Fixed DMG bundler to report warning only
when custom install dir differs from the default install dir.
C
On Mon, 24 Feb 2025 16:54:59 GMT, Alexey Semenyuk wrote:
> - Fix the warning message about the custom installation directory location
> jpackage issues for DMG runtime packaging.
> - Don't issue the warning when the `-install-dir` value equals the default
> installation directory location.
@s
On Mon, 24 Feb 2025 08:44:00 GMT, Tagir F. Valeev wrote:
> It appears that the benchmark was erroneous. The combination of "tailMap"
> mode and comparator = true didn't work correctly, as the comparator is
> descending. This PR changes the benchmark to use headMap instead of tailMap
> in compa
On Sat, 22 Feb 2025 14:49:38 GMT, Coleen Phillimore wrote:
>> Class.isInterface() can check modifier flags, Class.isArray() can check
>> whether component mirror is non-null and Class.isPrimitive() needs a new
>> final transient boolean in java.lang.Class that the JVM code initializes.
>> Teste
On Fri, 21 Feb 2025 18:54:24 GMT, Chen Liang wrote:
>> I'm not convinced about the one in ValueLayouts *e.g. where this comment was
>> added) -- if you agree that the other cache should already handle this --
>> then maybe we can only keep one
>
> Indeed, the other cache already handles this.
On Fri, 21 Feb 2025 18:37:47 GMT, Maurizio Cimadamore
wrote:
>> Now this will require code update to static import `offset` from
>> `VarHandleSegmentViewBase`. Is that acceptable?
>
> Maybe let's leave it, at least in this round
Done in latest update.
>> This is a one-time cold path initializ
72 matches
Mail list logo
