Re: RFR: 8349909: jdk.internal.jimage.decompressor.ZipDecompressor does not close the Inflater in exceptional cases

2025-02-16 Thread Jaikiran Pai
On Fri, 14 Feb 2025 07:41:26 GMT, Jaikiran Pai wrote: > Can I please get a review of this change which proposes to properly close the > `Inflater` instance used in > `jdk.internal.jimage.decompressor.ZipDecompressor.decompress()` method? This > addresses https://bugs.openjdk.org/browse/JDK-834

RFR: 8066583: DeflaterInput/OutputStream and InflaterInput/OutputStream should explain responsibility for freeing resources

2025-02-16 Thread Jaikiran Pai
Can I please get a review of this doc-only change which proposes to improve the API documentation of `DeflaterInputStream`, `DeflaterOutputStream`, `InflaterInputStream` and `InflaterOutputStream` classes? As noted in https://bugs.openjdk.org/browse/JDK-8066583 some of the constructors of these

Re: RFR: 8346954: [JMH] jdk.incubator.vector.MaskedLogicOpts fails due to IndexOutOfBoundsException

2025-02-16 Thread Nicole Xu
On Thu, 13 Feb 2025 11:51:53 GMT, Jatin Bhateja wrote: >> Suite MaskedLogicOpts.maskedLogicOperationsLong512() failed on both x86 and >> AArch64 with the following error: >> >> >> java.lang.IndexOutOfBoundsException: Index 252 out of bounds for length 249 >> >> >> The variable `long256_arr_i

Re: RFR: 8346954: [JMH] jdk.incubator.vector.MaskedLogicOpts fails due to IndexOutOfBoundsException

2025-02-16 Thread Nicole Xu
On Thu, 13 Feb 2025 12:09:43 GMT, Jatin Bhateja wrote: >> test/micro/org/openjdk/bench/jdk/incubator/vector/MaskedLogicOpts.java line >> 122: >> >>> 120: @Setup(Level.Invocation) >>> 121: public void init_per_invoc() { >>> 122: int512_arr_idx = (int512_arr_idx + 16) & (ARRAYLEN-

Re: RFR: 8066583: DeflaterInput/OutputStream and InflaterInput/OutputStream should explain responsibility for freeing resources [v2]

2025-02-16 Thread Jaikiran Pai
> Can I please get a review of this doc-only change which proposes to improve > the API documentation of `DeflaterInputStream`, `DeflaterOutputStream`, > `InflaterInputStream` and `InflaterOutputStream` classes? > > As noted in https://bugs.openjdk.org/browse/JDK-8066583 some of the > construct

Re: RFR: 8066583: DeflaterInput/OutputStream and InflaterInput/OutputStream should explain responsibility for freeing resources

2025-02-16 Thread Jaikiran Pai
On Sun, 16 Feb 2025 11:44:23 GMT, Jaikiran Pai wrote: > Can I please get a review of this doc-only change which proposes to improve > the API documentation of `DeflaterInputStream`, `DeflaterOutputStream`, > `InflaterInputStream` and `InflaterOutputStream` classes? > > As noted in https://bugs