Re: [External] : Re: jpackage: Support building native Windows MSIs

2025-07-01 Thread Alexey Semenyuk
Hi Armin, Create a PR. If you haven't signed the OCA yet, it will ask you to do so. After that, we will proceed with the review. - Alexey On 7/1/2025 2:46 PM, Armin Schrenk wrote: Great, thank you. I created a ticket in the issue tracker, see https://bugs.openjdk.org/browse/JDK-8361207

Re: [External] : Re: jpackage: Support building native Windows MSIs

2025-07-01 Thread Armin Schrenk
Great, thank you. I created a ticket in the issue tracker, see https://bugs.openjdk.org/browse/JDK-8361207 .  The sanity checks already finished with success. Are there more steps needed/any requirements or can i create the PR now (after a rebase (-;) ? Best regards, Armin Am Montag, Juni 30,

Re: [External] : Re: jpackage: Support building native Windows MSIs

2025-06-30 Thread Alexey Semenyuk
Armin, I will sponsor your patch. - Alexey On 6/30/2025 2:04 PM, Armin Schrenk wrote: Cool. The changes can be found in https://github.com/infeo/jdk/commit/77c50367e3fd7d677bfe2e805be2feafa30b0a37. Basically, the command line builder for wix3/wix4 is adjusted to set the arch flag to x64,

Re: jpackage: Support building native Windows MSIs

2025-06-30 Thread Armin Schrenk
Cool. The changes can be found in https://github.com/infeo/jdk/commit/77c50367e3fd7d677bfe2e805be2feafa30b0a37. Basically, the command line builder for wix3/wix4 is adjusted to set the arch flag to x64, x86 or arm64 depending on return values of some jdk.internal.util.Architecture::is[Architect

Re: jpackage: Support building native Windows MSIs

2025-06-30 Thread Alexey Semenyuk
Hi Armin, Your ARM64 MSI contribution/enhancement for the jpackage will be much appreciated. - Alexey On 6/30/2025 10:09 AM, Armin Schrenk wrote: Hello everyone, does jpackage support building native ARM64 MSI packages? Building an jpackage MSI on Windows ARM64, the resulting package cont

jpackage: Support building native Windows MSIs

2025-06-30 Thread Armin Schrenk
Hello everyone, does jpackage support building native ARM64 MSI packages? Building an jpackage MSI on Windows ARM64, the resulting package contains x64 DLLs. I looked further into the JDK code and apparently, the wix Command builder (WixPipeline.java) only supports x86 or x64  (see https://git