Re: java.util.zip.ZipError seems unused

2024-07-19 Thread Eirik Bjørsnøs
Thanks Lance, I have filed the following enhancement request to track this: https://bugs.openjdk.org/browse/JDK-8336843 Eirik. On Sun, Jun 30, 2024 at 2:54 PM Lance Andersen wrote: > Hi Eirik, > > The removal of ZipError from ZipFile/ZipFileSystem/ZipFileSystemProvider > occurred via 8145260

Re: java.util.zip.ZipError seems unused

2024-06-30 Thread Lance Andersen
The code you point to below is leveraging ZipFS, which provided as a demo in JDK 8 and was not a supported part of Java until JDK 9 at which point ZipFS did not use ZipError. So I understand your point but we also need to keep in mind that demo != supported as we consider the eventual removal

Re: java.util.zip.ZipError seems unused

2024-06-30 Thread Glavo
I am the maintainer of HMCL and we need to catch ZipError in our program because our program needs to be compatible with Java 8: https://github.com/HMCL-dev/HMCL/blob/85b68ad135267bc33e03c3624b1bced9b7804c39/HMCLCore/src/main/java/org/jackhuang/hmcl/util/io/CompressingUtils.java#L218-L220 I'd lov

Re: java.util.zip.ZipError seems unused

2024-06-30 Thread Lance Andersen
Hi Eirik, The removal of ZipError from ZipFile/ZipFileSystem/ZipFileSystemProvider occurred via 8145260 and 8037394 for JDK 9 The test should also be re-written at this point Jai or I can make a pass to see if there are any external usages via a corpus search but I tend to doubt it On Jun 30

java.util.zip.ZipError seems unused

2024-06-30 Thread Eirik Bjørsnøs
Hi! The java.util.zip.ZipError class seems unused in OpenJDK. I assume this is legacy from the native ZIP implementation in Java 8. This exception class extends InternalError and seems to have been added in Java 6 to help compatibility with existing code catching InternalError (JDK-4615343) This