Re: RFR: 8360122: Fix java.sql\Connection.java indentation [v2]

2025-07-02 Thread simon
On Mon, 23 Jun 2025 17:45:02 GMT, Lance Andersen wrote: >> simon has updated the pull request incrementally with one additional commit >> since the last revision: >> >> 8360122: refactor code formatting to enforce 100 chars line length limit >> for improved readability > > I might not have

Re: RFR: 8360122: Fix java.sql\Connection.java indentation [v2]

2025-07-01 Thread simon
On Mon, 23 Jun 2025 17:45:02 GMT, Lance Andersen wrote: >> simon has updated the pull request incrementally with one additional commit >> since the last revision: >> >> 8360122: refactor code formatting to enforce 100 chars line length limit >> for improved readability > > I might not have

Re: RFR: 8360122: Fix java.sql\Connection.java indentation [v2]

2025-06-23 Thread Lance Andersen
On Mon, 23 Jun 2025 17:18:13 GMT, simon wrote: >> 8360122: Refine formatting of Connection.java interface >> >> - >> ### Progress >> - [ ] Change must be properly reviewed (1 review required, with at least 1 >> [Reviewer](https://openjdk.org/bylaws#reviewer)) >> - [x] Change must not co

Re: RFR: 8360122: Fix java.sql\Connection.java indentation [v2]

2025-06-23 Thread simon
On Mon, 23 Jun 2025 19:54:24 GMT, Roger Riggs wrote: >> @RogerRiggs My preferred formatting style is like this: >> >> >> default boolean setShardingKeyIfValid(ShardingKey shardingKey, >> ShardingKey superShardingKey, >>

Re: RFR: 8360122: Fix java.sql\Connection.java indentation [v2]

2025-06-23 Thread Roger Riggs
On Mon, 23 Jun 2025 18:38:00 GMT, simon wrote: >> src/java.sql/share/classes/java/sql/Connection.java line 1597: >> >>> 1595: default boolean setShardingKeyIfValid(ShardingKey shardingKey, >>> 1596: ShardingKey >>> superShardingKey, >>> 1597:

Re: RFR: 8360122: Fix java.sql\Connection.java indentation [v2]

2025-06-23 Thread simon
On Mon, 23 Jun 2025 17:35:50 GMT, Roger Riggs wrote: >> simon has updated the pull request incrementally with one additional commit >> since the last revision: >> >> 8360122: refactor code formatting to enforce 100 chars line length limit >> for improved readability > > src/java.sql/share/cl

Re: RFR: 8360122: Fix java.sql\Connection.java indentation [v2]

2025-06-23 Thread Roger Riggs
On Mon, 23 Jun 2025 17:18:13 GMT, simon wrote: >> 8360122: Refine formatting of Connection.java interface >> >> - >> ### Progress >> - [ ] Change must be properly reviewed (1 review required, with at least 1 >> [Reviewer](https://openjdk.org/bylaws#reviewer)) >> - [x] Change must not co

Re: RFR: 8360122: Fix java.sql\Connection.java indentation [v2]

2025-06-23 Thread simon
On Mon, 23 Jun 2025 14:50:24 GMT, Roger Riggs wrote: >> simon has updated the pull request incrementally with one additional commit >> since the last revision: >> >> 8360122: refactor code formatting to enforce 100 chars line length limit >> for improved readability > > The indentation fixes

Re: RFR: 8360122: Fix java.sql\Connection.java indentation [v2]

2025-06-23 Thread simon
> 8360122: Refine formatting of Connection.java interface > > - > ### Progress > - [ ] Change must be properly reviewed (1 review required, with at least 1 > [Reviewer](https://openjdk.org/bylaws#reviewer)) > - [x] Change must not contain extraneous whitespace > - [x] Commit message must