Re: RFR: 8358533: Improve performance of java.io.Reader.readAllLines [v8]

2025-06-30 Thread Brian Burkhalter
On Mon, 30 Jun 2025 18:28:26 GMT, Xueming Shen wrote: > the throughput appears to back to normal with 'find term while loop' fast path This version passes the regression test and is a little faster than the latest PR version. I'll run it through the CI and probably use it in the next commit. T

Re: RFR: 8358533: Improve performance of java.io.Reader.readAllLines [v8]

2025-06-30 Thread Xueming Shen
On Fri, 27 Jun 2025 19:41:01 GMT, Brian Burkhalter wrote: >> Replaces the implementation `readAllCharsAsString().lines().toList()` with >> reading into a temporary `char` array which is then processed to detect line >> terminators and copy non-terminating characters into strings which are added

Re: RFR: 8358533: Improve performance of java.io.Reader.readAllLines [v8]

2025-06-30 Thread Brian Burkhalter
On Sat, 28 Jun 2025 08:41:27 GMT, Xueming Shen wrote: > The modified code below is a PoC for reference. It seems to work as expected, > though not fully tested. This looks like a nice reworking, and appears to pass the regression test, but its throughput is less than half that of the current v

Re: RFR: 8358533: Improve performance of java.io.Reader.readAllLines [v8]

2025-06-28 Thread Xueming Shen
On Fri, 27 Jun 2025 19:41:01 GMT, Brian Burkhalter wrote: >> Replaces the implementation `readAllCharsAsString().lines().toList()` with >> reading into a temporary `char` array which is then processed to detect line >> terminators and copy non-terminating characters into strings which are added

Re: RFR: 8358533: Improve performance of java.io.Reader.readAllLines [v8]

2025-06-27 Thread Brian Burkhalter
> Replaces the implementation `readAllCharsAsString().lines().toList()` with > reading into a temporary `char` array which is then processed to detect line > terminators and copy non-terminating characters into strings which are added > to the list. Brian Burkhalter has updated the pull request