Re: RFR: 8355391: Use Long::hashCode in java.time

2025-04-30 Thread Shaojin Wen
On Wed, 30 Apr 2025 15:01:08 GMT, Roger Riggs wrote: >> Replace manual bitwise operations in `hashCode` implementations of >> `java.time` with `Long::hashCode`. > > lgtm > @RogerRiggs, @minborg, @naotoj, thanks for the reviews. I've attached > successful `tier1,2` results to the ticket. I'd ap

Re: RFR: 8355391: Use Long::hashCode in java.time

2025-04-30 Thread Volkan Yazici
On Wed, 30 Apr 2025 15:01:08 GMT, Roger Riggs wrote: >> Replace manual bitwise operations in `hashCode` implementations of >> `java.time` with `Long::hashCode`. > > lgtm @RogerRiggs, @minborg, @naotoj, thanks for the reviews. I've attached successful `tier1,2` results to the ticket. I'd apprec

Re: RFR: 8355391: Use Long::hashCode in java.time

2025-04-30 Thread duke
On Wed, 30 Apr 2025 06:46:07 GMT, Volkan Yazici wrote: > Replace manual bitwise operations in `hashCode` implementations of > `java.time` with `Long::hashCode`. @vy Your change (at version 891d9ada7ce6860ea8e1253021f04053cc27090a) is now ready to be sponsored by a Committer. - P

Re: RFR: 8355391: Use Long::hashCode in java.time

2025-04-30 Thread Shaojin Wen
On Wed, 30 Apr 2025 06:46:07 GMT, Volkan Yazici wrote: > Replace manual bitwise operations in `hashCode` implementations of > `java.time` with `Long::hashCode`. There is a place in java.util.Locale::hashCode that can also be changed Current version long bitsWeight = Double.doubleToLongBits(wei

Re: RFR: 8355391: Use Long::hashCode in java.time

2025-04-30 Thread Naoto Sato
On Wed, 30 Apr 2025 06:46:07 GMT, Volkan Yazici wrote: > Replace manual bitwise operations in `hashCode` implementations of > `java.time` with `Long::hashCode`. LGTM. Thanks for the refactoring - Marked as reviewed by naoto (Reviewer). PR Review: https://git.openjdk.org/jdk/pull/

Re: RFR: 8355391: Use Long::hashCode in java.time

2025-04-30 Thread Per Minborg
On Wed, 30 Apr 2025 06:46:07 GMT, Volkan Yazici wrote: > Replace manual bitwise operations in `hashCode` implementations of > `java.time` with `Long::hashCode`. Looks fine! Thanks for this cleanup. - Marked as reviewed by pminborg (Reviewer). PR Review: https://git.openjdk.org/jd

Re: RFR: 8355391: Use Long::hashCode in java.time

2025-04-30 Thread Roger Riggs
On Wed, 30 Apr 2025 06:46:07 GMT, Volkan Yazici wrote: > Replace manual bitwise operations in `hashCode` implementations of > `java.time` with `Long::hashCode`. lgtm - Marked as reviewed by rriggs (Reviewer). PR Review: https://git.openjdk.org/jdk/pull/24959#pullrequestreview-280