Re: RFR: JDK-8325908: Finish removal of IntlTest and CollatorTest [v2]

2024-02-14 Thread Justin Lu
On Thu, 15 Feb 2024 00:13:28 GMT, Naoto Sato wrote: >> Justin Lu has updated the pull request incrementally with one additional >> commit since the last revision: >> >> improve method name as suggested, remove unusued clutter > > test/jdk/java/text/Format/NumberFormat/DFSExponential.java line

Re: RFR: JDK-8325908: Finish removal of IntlTest and CollatorTest [v2]

2024-02-14 Thread Justin Lu
> Please review this PR which fixes / finishes the rest of the IntlTest test > framework removal in java.text and java.util.i18n tests. > > For context, the IntlTest class only ran methods prefixed by _test_ or _Test_ > with public visibility and was originally removed due to some tests > spuri

Re: RFR: JDK-8325908: Finish removal of IntlTest and CollatorTest

2024-02-14 Thread Naoto Sato
On Wed, 14 Feb 2024 23:05:25 GMT, Justin Lu wrote: > Please review this PR which fixes / finishes the rest of the IntlTest test > framework removal in java.text and java.util.i18n tests. > > For context, the IntlTest class only ran methods prefixed by _test_ or _Test_ > with public visibility

RFR: JDK-8325908: Finish removal of IntlTest and CollatorTest

2024-02-14 Thread Justin Lu
Please review this PR which fixes / finishes the rest of the IntlTest test framework removal in java.text and java.util.i18n tests. For context, the IntlTest class only ran methods prefixed by _test_ or _Test_ with public visibility and was originally removed due to some tests spuriously passin