Re: RFR: JDK-8325255 jdk.internal.util.ReferencedKeySet::add using wrong test [v3]

2024-03-05 Thread Jim Laskey
On Sun, 11 Feb 2024 17:41:14 GMT, ExE Boss wrote: >> Jim Laskey has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Update ReferencedKeyTest.java > > src/java.base/share/classes/jdk/internal/util/ReferencedKeySet.java line 151: > >> 149:

Re: RFR: JDK-8325255 jdk.internal.util.ReferencedKeySet::add using wrong test [v3]

2024-02-11 Thread ExE Boss
On Tue, 6 Feb 2024 18:43:09 GMT, Jim Laskey wrote: >> Currently, add is returning intern(e) == null which will always be false. >> The correct test is intern(e) == e , that is, true when element is newly >> added. > > Jim Laskey has updated the pull request incrementally with one additional >

Re: RFR: JDK-8325255 jdk.internal.util.ReferencedKeySet::add using wrong test [v3]

2024-02-06 Thread Jim Laskey
> Currently, add is returning intern(e) == null which will always be false. The > correct test is intern(e) == e , that is, true when element is newly added. Jim Laskey has updated the pull request incrementally with one additional commit since the last revision: Update ReferencedKeyTest.java