The class is used in java.lang.invoke.MethodType but add is not used.
📱
> On Mar 9, 2024, at 11:42 AM, Chen Liang wrote:
>
> On Tue, 5 Mar 2024 20:23:56 GMT, Jim Laskey wrote:
>
>>> Currently, add is returning intern(e) == null which will always be false.
>>> The correct test is intern(e)
On Tue, 5 Mar 2024 20:23:56 GMT, Jim Laskey wrote:
>> Currently, add is returning intern(e) == null which will always be false.
>> The correct test is intern(e) == e , that is, true when element is newly
>> added.
>
> Jim Laskey has updated the pull request incrementally with one additional
>
On Tue, 5 Mar 2024 20:23:56 GMT, Jim Laskey wrote:
>> Currently, add is returning intern(e) == null which will always be false.
>> The correct test is intern(e) == e , that is, true when element is newly
>> added.
>
> Jim Laskey has updated the pull request incrementally with one additional
>
On Tue, 5 Mar 2024 20:23:56 GMT, Jim Laskey wrote:
>> Currently, add is returning intern(e) == null which will always be false.
>> The correct test is intern(e) == e , that is, true when element is newly
>> added.
>
> Jim Laskey has updated the pull request incrementally with one additional
>
On Tue, 5 Mar 2024 20:23:56 GMT, Jim Laskey wrote:
>> Currently, add is returning intern(e) == null which will always be false.
>> The correct test is intern(e) == e , that is, true when element is newly
>> added.
>
> Jim Laskey has updated the pull request incrementally with one additional
>
On Sun, 11 Feb 2024 17:41:14 GMT, ExE Boss wrote:
>> Jim Laskey has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Update ReferencedKeyTest.java
>
> src/java.base/share/classes/jdk/internal/util/ReferencedKeySet.java line 151:
>
>> 149:
> Currently, add is returning intern(e) == null which will always be false. The
> correct test is intern(e) == e , that is, true when element is newly added.
Jim Laskey has updated the pull request incrementally with one additional
commit since the last revision:
Fix ReferencedKeySet::add
--
On Tue, 6 Feb 2024 18:43:09 GMT, Jim Laskey wrote:
>> Currently, add is returning intern(e) == null which will always be false.
>> The correct test is intern(e) == e , that is, true when element is newly
>> added.
>
> Jim Laskey has updated the pull request incrementally with one additional
>
On Tue, 6 Feb 2024 18:29:17 GMT, Chen Liang wrote:
>> Jim Laskey has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contains two additional
>> commits since
> Currently, add is returning intern(e) == null which will always be false. The
> correct test is intern(e) == e , that is, true when element is newly added.
Jim Laskey has updated the pull request incrementally with one additional
commit since the last revision:
Update ReferencedKeyTest.java
On Tue, 6 Feb 2024 13:56:09 GMT, Jim Laskey wrote:
>> Currently, add is returning intern(e) == null which will always be false.
>> The correct test is intern(e) == e , that is, true when element is newly
>> added.
>
> Jim Laskey has updated the pull request with a new target base due to a merge
On Tue, 6 Feb 2024 13:56:09 GMT, Jim Laskey wrote:
>> Currently, add is returning intern(e) == null which will always be false.
>> The correct test is intern(e) == e , that is, true when element is newly
>> added.
>
> Jim Laskey has updated the pull request with a new target base due to a merge
> Currently, add is returning intern(e) == null which will always be false. The
> correct test is intern(e) == e , that is, true when element is newly added.
Jim Laskey has updated the pull request with a new target base due to a merge
or a rebase. The incremental webrev excludes the unrelated c
Currently, add is returning intern(e) == null which will always be false. The
correct test is intern(e) == e , that is, true when element is newly added.
-
Commit messages:
- Correct test
Changes: https://git.openjdk.org/jdk/pull/17732/files
Webrev: https://webrevs.openjdk.org/?re
14 matches
Mail list logo
