Re: RFR: JDK-8319662 ForkJoinPool trims worker threads too slowly [v8]

2024-01-15 Thread kerr
On Mon, 4 Dec 2023 13:56:55 GMT, Doug Lea wrote: >> This update cascades timeouts to trim subsequent workers after the first >> keepAlive inactive period. > > Doug Lea has updated the pull request with a new target base due to a merge > or a rebase. The incremental webrev excludes the unrelate

Re: RFR: JDK-8319662 ForkJoinPool trims worker threads too slowly [v8]

2024-01-15 Thread Viktor Klang
On Sat, 13 Jan 2024 19:46:05 GMT, He-Pin(kerr) wrote: >> Cool, I just encounter this problem, when I migrate to Virtual threads and >> set `jdk.virtualThreadScheduler.maxPoolSize` to 2500. >> >> Will this change backport to j21u, thanks. > >> @He-Pin I tried to backport this patch for you just

Re: RFR: JDK-8319662 ForkJoinPool trims worker threads too slowly [v8]

2024-01-15 Thread Alan Bateman
On Sat, 13 Jan 2024 19:46:05 GMT, He-Pin(kerr) wrote: > I think the related issue should be backported too. That update is a huge update to FJP that includes API and behavior changes, the CSR has details. Maybe the starting out here is to first see if running with the JDK 22 EA builds address

Re: RFR: JDK-8319662 ForkJoinPool trims worker threads too slowly [v8]

2024-01-13 Thread kerr
On Fri, 12 Jan 2024 13:41:39 GMT, kerr wrote: >> Doug Lea has updated the pull request with a new target base due to a merge >> or a rebase. The incremental webrev excludes the unrelated changes brought >> in by the merge/rebase. The pull request contains 10 additional commits >> since the las

Re: RFR: JDK-8319662 ForkJoinPool trims worker threads too slowly [v8]

2024-01-13 Thread Guoxiong Li
On Fri, 12 Jan 2024 13:41:39 GMT, kerr wrote: >> Doug Lea has updated the pull request with a new target base due to a merge >> or a rebase. The incremental webrev excludes the unrelated changes brought >> in by the merge/rebase. The pull request contains 10 additional commits >> since the las

Re: RFR: JDK-8319662 ForkJoinPool trims worker threads too slowly [v8]

2024-01-12 Thread kerr
On Mon, 4 Dec 2023 13:56:55 GMT, Doug Lea wrote: >> This update cascades timeouts to trim subsequent workers after the first >> keepAlive inactive period. > > Doug Lea has updated the pull request with a new target base due to a merge > or a rebase. The incremental webrev excludes the unrelate

Re: RFR: JDK-8319662 ForkJoinPool trims worker threads too slowly [v8]

2023-12-06 Thread Viktor Klang
On Mon, 4 Dec 2023 13:56:55 GMT, Doug Lea wrote: >> This update cascades timeouts to trim subsequent workers after the first >> keepAlive inactive period. > > Doug Lea has updated the pull request with a new target base due to a merge > or a rebase. The incremental webrev excludes the unrelate

Re: RFR: JDK-8319662 ForkJoinPool trims worker threads too slowly [v8]

2023-12-06 Thread Alan Bateman
On Mon, 4 Dec 2023 13:56:55 GMT, Doug Lea wrote: >> This update cascades timeouts to trim subsequent workers after the first >> keepAlive inactive period. > > Doug Lea has updated the pull request with a new target base due to a merge > or a rebase. The incremental webrev excludes the unrelate

Re: RFR: JDK-8319662 ForkJoinPool trims worker threads too slowly [v8]

2023-12-05 Thread Viktor Klang
On Mon, 4 Dec 2023 13:56:55 GMT, Doug Lea wrote: >> This update cascades timeouts to trim subsequent workers after the first >> keepAlive inactive period. > > Doug Lea has updated the pull request with a new target base due to a merge > or a rebase. The incremental webrev excludes the unrelate

Re: RFR: JDK-8319662 ForkJoinPool trims worker threads too slowly [v6]

2023-12-05 Thread Viktor Klang
On Tue, 5 Dec 2023 16:15:31 GMT, Viktor Klang wrote: >> Doug Lea has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Reduce oversignalling and contention; add test > > src/java.base/share/classes/java/util/concurrent/ForkJoinPool.java line 1

Re: RFR: JDK-8319662 ForkJoinPool trims worker threads too slowly [v8]

2023-12-05 Thread Viktor Klang
On Mon, 4 Dec 2023 13:56:55 GMT, Doug Lea wrote: >> This update cascades timeouts to trim subsequent workers after the first >> keepAlive inactive period. > > Doug Lea has updated the pull request with a new target base due to a merge > or a rebase. The incremental webrev excludes the unrelate

Re: RFR: JDK-8319662 ForkJoinPool trims worker threads too slowly [v6]

2023-12-05 Thread Viktor Klang
On Sun, 3 Dec 2023 17:13:49 GMT, Doug Lea wrote: >> This update cascades timeouts to trim subsequent workers after the first >> keepAlive inactive period. > > Doug Lea has updated the pull request incrementally with one additional > commit since the last revision: > > Reduce oversignalling

Re: RFR: JDK-8319662 ForkJoinPool trims worker threads too slowly [v6]

2023-12-05 Thread Viktor Klang
On Sun, 3 Dec 2023 17:13:49 GMT, Doug Lea wrote: >> This update cascades timeouts to trim subsequent workers after the first >> keepAlive inactive period. > > Doug Lea has updated the pull request incrementally with one additional > commit since the last revision: > > Reduce oversignalling

Re: RFR: JDK-8319662 ForkJoinPool trims worker threads too slowly [v8]

2023-12-04 Thread Doug Lea
> This update cascades timeouts to trim subsequent workers after the first > keepAlive inactive period. Doug Lea has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull reques

Re: RFR: JDK-8319662 ForkJoinPool trims worker threads too slowly [v7]

2023-12-03 Thread Doug Lea
> This update cascades timeouts to trim subsequent workers after the first > keepAlive inactive period. Doug Lea has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull reques

Re: RFR: JDK-8319662 ForkJoinPool trims worker threads too slowly [v6]

2023-12-03 Thread Doug Lea
> This update cascades timeouts to trim subsequent workers after the first > keepAlive inactive period. Doug Lea has updated the pull request incrementally with one additional commit since the last revision: Reduce oversignalling and contention; add test - Changes: - all: htt

Re: RFR: JDK-8319662 ForkJoinPool trims worker threads too slowly [v5]

2023-12-03 Thread Doug Lea
On Tue, 28 Nov 2023 14:04:13 GMT, Alan Bateman wrote: >> Doug Lea has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Revert 2 lines in method scan > > src/java.base/share/classes/java/util/concurrent/ForkJoinPool.java line 3123: > >> 3121:

Re: RFR: JDK-8319662 ForkJoinPool trims worker threads too slowly [v5]

2023-11-28 Thread Alan Bateman
On Mon, 27 Nov 2023 22:44:30 GMT, Doug Lea wrote: >> This update cascades timeouts to trim subsequent workers after the first >> keepAlive inactive period. > > Doug Lea has updated the pull request incrementally with one additional > commit since the last revision: > > Revert 2 lines in met

Re: RFR: JDK-8319662 ForkJoinPool trims worker threads too slowly [v5]

2023-11-27 Thread Doug Lea
> This update cascades timeouts to trim subsequent workers after the first > keepAlive inactive period. Doug Lea has updated the pull request incrementally with one additional commit since the last revision: Revert 2 lines in method scan - Changes: - all: https://git.openjdk.

Re: RFR: JDK-8319662 ForkJoinPool trims worker threads too slowly [v4]

2023-11-27 Thread Doug Lea
> This update cascades timeouts to trim subsequent workers after the first > keepAlive inactive period. Doug Lea has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull reques

Re: RFR: JDK-8319662 ForkJoinPool trims worker threads too slowly [v3]

2023-11-23 Thread Viktor Klang
On Tue, 21 Nov 2023 17:12:39 GMT, Doug Lea wrote: >> This update cascades timeouts to trim subsequent workers after the first >> keepAlive inactive period. > > Doug Lea has updated the pull request with a new target base due to a merge > or a rebase. The incremental webrev excludes the unrelat

Re: RFR: JDK-8319662 ForkJoinPool trims worker threads too slowly [v3]

2023-11-22 Thread Doug Lea
On Wed, 22 Nov 2023 08:07:00 GMT, Andrey Turbanov wrote: >> Doug Lea has updated the pull request with a new target base due to a merge >> or a rebase. The incremental webrev excludes the unrelated changes brought >> in by the merge/rebase. The pull request contains three additional commits >>

Re: RFR: JDK-8319662 ForkJoinPool trims worker threads too slowly [v3]

2023-11-22 Thread Doug Lea
On Tue, 21 Nov 2023 21:27:08 GMT, Viktor Klang wrote: >> Doug Lea has updated the pull request with a new target base due to a merge >> or a rebase. The incremental webrev excludes the unrelated changes brought >> in by the merge/rebase. The pull request contains three additional commits >> si

Re: RFR: JDK-8319662 ForkJoinPool trims worker threads too slowly [v3]

2023-11-22 Thread Andrey Turbanov
On Tue, 21 Nov 2023 17:12:39 GMT, Doug Lea wrote: >> This update cascades timeouts to trim subsequent workers after the first >> keepAlive inactive period. > > Doug Lea has updated the pull request with a new target base due to a merge > or a rebase. The incremental webrev excludes the unrelat

Re: RFR: JDK-8319662 ForkJoinPool trims worker threads too slowly [v3]

2023-11-21 Thread Viktor Klang
On Tue, 21 Nov 2023 17:12:39 GMT, Doug Lea wrote: >> This update cascades timeouts to trim subsequent workers after the first >> keepAlive inactive period. > > Doug Lea has updated the pull request with a new target base due to a merge > or a rebase. The incremental webrev excludes the unrelat

Re: RFR: JDK-8319662 ForkJoinPool trims worker threads too slowly [v3]

2023-11-21 Thread Doug Lea
> This update cascades timeouts to trim subsequent workers after the first > keepAlive inactive period. Doug Lea has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull reques

Re: RFR: JDK-8319662 ForkJoinPool trims worker threads too slowly [v2]

2023-11-21 Thread Doug Lea
On Mon, 20 Nov 2023 14:28:15 GMT, Viktor Klang wrote: >> It would be better, but absolute-time Unsafe.park only operates at >> millisecond accuracy (and even at that may misfire early, requiring >> TIMEOUT_SLOP.) > > I was thinking more about cases where system clock moves backwards in time. >

Re: RFR: JDK-8319662 ForkJoinPool trims worker threads too slowly [v2]

2023-11-21 Thread Doug Lea
> This update cascades timeouts to trim subsequent workers after the first > keepAlive inactive period. Doug Lea has updated the pull request incrementally with one additional commit since the last revision: tweak cascades; reinstate an @Contended; resolve JDK-8319498 - Changes

Re: RFR: JDK-8319662 ForkJoinPool trims worker threads too slowly

2023-11-20 Thread Viktor Klang
On Mon, 20 Nov 2023 13:31:42 GMT, Doug Lea wrote: >> src/java.base/share/classes/java/util/concurrent/ForkJoinPool.java line 2140: >> >>> 2138: Thread.interrupted(); // clear for next park >>> 2139: if (deadline != 0L && // try to trim on >>>

Re: RFR: JDK-8319662 ForkJoinPool trims worker threads too slowly

2023-11-20 Thread Doug Lea
On Mon, 20 Nov 2023 11:23:54 GMT, Viktor Klang wrote: >> This update cascades timeouts to trim subsequent workers after the first >> keepAlive inactive period. > > src/java.base/share/classes/java/util/concurrent/ForkJoinPool.java line 2140: > >> 2138: Thread.interrupted();

Re: RFR: JDK-8319662 ForkJoinPool trims worker threads too slowly

2023-11-20 Thread Viktor Klang
On Sun, 19 Nov 2023 17:36:01 GMT, Doug Lea wrote: > This update cascades timeouts to trim subsequent workers after the first > keepAlive inactive period. src/java.base/share/classes/java/util/concurrent/ForkJoinPool.java line 680: > 678: * time out and terminate if the pool has remained

Re: RFR: JDK-8319662 ForkJoinPool trims worker threads too slowly

2023-11-20 Thread Viktor Klang
On Sun, 19 Nov 2023 17:36:01 GMT, Doug Lea wrote: > This update cascades timeouts to trim subsequent workers after the first > keepAlive inactive period. src/java.base/share/classes/java/util/concurrent/ForkJoinPool.java line 2140: > 2138: Thread.interrupted(); // cl

RFR: JDK-8319662 ForkJoinPool trims worker threads too slowly

2023-11-19 Thread Doug Lea
This update cascades timeouts to trim subsequent workers after the first keepAlive inactive period. - Commit messages: - Support cascading idle timeouts Changes: https://git.openjdk.org/jdk/pull/16725/files Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=16725&range=00 Issue: