On Mon, 11 Dec 2023 05:47:33 GMT, Justin Lu wrote:
>> Please review this PR and [CSR](https://bugs.openjdk.org/browse/JDK-8319982)
>> which overrides and provides an implementation of `toString()` in
>> _java.util.zip.ZipFile_ (and by extension, _java.util.jar.JarFile_).
>
> Justin Lu has updat
On Mon, 11 Dec 2023 05:47:33 GMT, Justin Lu wrote:
>> Please review this PR and [CSR](https://bugs.openjdk.org/browse/JDK-8319982)
>> which overrides and provides an implementation of `toString()` in
>> _java.util.zip.ZipFile_ (and by extension, _java.util.jar.JarFile_).
>
> Justin Lu has updat
On Wed, 13 Dec 2023 20:53:17 GMT, Justin Lu wrote:
> > I'm seeing the `ZipSourceCache` fail on GHA on `windows-x64`:
>
> Hi Eirik,
>
> Please let me know if I'm misunderstanding,
I claim `TooManyOpenTabsException` :-) Sorry, this comment was for #16115
-
PR Comment: https://git.o
On Wed, 13 Dec 2023 18:35:40 GMT, Eirik Bjorsnos wrote:
> I'm seeing the `ZipSourceCache` fail on GHA on `windows-x64`:
Hi Eirik,
Please let me know if I'm misunderstanding,
But this change hasn't been integrated into the master branch yet. Your linked
PR does not appear to contain the conten
On Mon, 11 Dec 2023 05:47:33 GMT, Justin Lu wrote:
>> Please review this PR and [CSR](https://bugs.openjdk.org/browse/JDK-8319982)
>> which overrides and provides an implementation of `toString()` in
>> _java.util.zip.ZipFile_ (and by extension, _java.util.jar.JarFile_).
>
> Justin Lu has updat
On Mon, 11 Dec 2023 05:47:33 GMT, Justin Lu wrote:
>> Please review this PR and [CSR](https://bugs.openjdk.org/browse/JDK-8319982)
>> which overrides and provides an implementation of `toString()` in
>> _java.util.zip.ZipFile_ (and by extension, _java.util.jar.JarFile_).
>
> Justin Lu has updat
On Mon, 11 Dec 2023 05:44:38 GMT, Justin Lu wrote:
>> src/java.base/share/classes/java/util/zip/ZipFile.java line 494:
>>
>>> 492: @Override
>>> 493: public String toString() {
>>> 494: return res.zsrc.key.file.getName()
>>
>> Hello Justin, relying on `res.zsrc.key.file` to get
> Please review this PR and [CSR](https://bugs.openjdk.org/browse/JDK-8319982)
> which overrides and provides an implementation of `toString()` in
> _java.util.zip.ZipFile_ (and by extension, _java.util.jar.JarFile_).
Justin Lu has updated the pull request with a new target base due to a merge o
On Fri, 8 Dec 2023 10:18:18 GMT, Jaikiran Pai wrote:
>> Justin Lu has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> drop additional specification
>
> src/java.base/share/classes/java/util/zip/ZipFile.java line 494:
>
>> 492: @Override
On Fri, 1 Dec 2023 21:32:57 GMT, Justin Lu wrote:
>> Please review this PR and [CSR](https://bugs.openjdk.org/browse/JDK-8319982)
>> which overrides and provides an implementation of `toString()` in
>> _java.util.zip.ZipFile_ (and by extension, _java.util.jar.JarFile_).
>
> Justin Lu has update
> Please review this PR and [CSR](https://bugs.openjdk.org/browse/JDK-8319982)
> which overrides and provides an implementation of `toString()` in
> _java.util.zip.ZipFile_ (and by extension, _java.util.jar.JarFile_).
Justin Lu has updated the pull request incrementally with one additional commi
> Please review this PR and [CSR](https://bugs.openjdk.org/browse/JDK-8319982)
> which overrides and provides an implementation of `toString()` in
> _java.util.zip.ZipFile_ (and by extension, _java.util.jar.JarFile_).
Justin Lu has updated the pull request incrementally with one additional commi
On Fri, 1 Dec 2023 08:49:34 GMT, Alan Bateman wrote:
>> Thanks Jai, that makes sense. Replaced full path with just the base name in
>> latest commit.
>
> I think the second paragraph of the method description is problematic.
> Documenting the representation and then saying it is subject to chan
On Thu, 30 Nov 2023 21:08:35 GMT, Justin Lu wrote:
>> Hello Justin,
>>
>>> I am not sure if you have a preference one way or another regarding
>>> providing the full path versus just the file name, but I can switch the
>>> full path for just the file name if need be.
>>
>> My opinion is that
> Please review this PR and [CSR](https://bugs.openjdk.org/browse/JDK-8319982)
> which overrides and provides an implementation of `toString()` in
> _java.util.zip.ZipFile_ (and by extension, _java.util.jar.JarFile_).
Justin Lu has updated the pull request incrementally with one additional commi
On Thu, 30 Nov 2023 10:17:23 GMT, Jaikiran Pai wrote:
>> I like the new wording (have no oppinion if absolute path is better).
>
> Hello Justin,
>
>> I am not sure if you have a preference one way or another regarding
>> providing the full path versus just the file name, but I can switch the fu
On Wed, 29 Nov 2023 01:10:29 GMT, Bernd wrote:
>> Hi Alan,
>>
>> Thanks for taking a look. I updated the toString() value to the one you
>> suggested, and also dropped the specific aspects of the specification.
>>
>> I am not sure if you have a preference one way or another regarding
>> prov
On Wed, 15 Nov 2023 18:30:27 GMT, Justin Lu wrote:
>> src/java.base/share/classes/java/util/zip/ZipFile.java line 498:
>>
>>> 496: */
>>> 497: @Override
>>> 498: public String toString() {
>>
>> I don't think the file name on its own is very helpful as it may not be
>> unique or t
> Please review this PR and [CSR](https://bugs.openjdk.org/browse/JDK-8319982)
> which overrides and provides an implementation of `toString()` in
> _java.util.zip.ZipFile_ (and by extension, _java.util.jar.JarFile_).
>
> This change is primarily to provide a more informative String representati
> Please review this PR and [CSR](https://bugs.openjdk.org/browse/JDK-8319982)
> which overrides and provides an implementation of `toString()` in
> _java.util.zip.ZipFile_ (and by extension, _java.util.jar.JarFile_).
>
> This change is primarily to provide a more informative String representati
On Thu, 16 Nov 2023 11:22:36 GMT, Pavel Rappo wrote:
>> @justin-curtis-lu, for inspiration and consistency, you might want to have a
>> look at this implementation:
>> https://github.com/openjdk/jdk/blob/1d9688667e667dc710d64e52f1e918e047beaca3/src/java.base/share/classes/java/util/concurrent/C
On Wed, 15 Nov 2023 18:33:47 GMT, Justin Lu wrote:
>> Please review this PR and [CSR](https://bugs.openjdk.org/browse/JDK-8319982)
>> which overrides and provides an implementation of `toString()` in
>> _java.util.zip.ZipFile_ (and by extension, _java.util.jar.JarFile_).
>>
>> This change is p
On Thu, 16 Nov 2023 11:19:39 GMT, Pavel Rappo wrote:
>> src/java.base/share/classes/java/util/zip/ZipFile.java line 494:
>>
>>> 492: @Override
>>> 493: public String toString() {
>>> 494: return "" + name +
>>> Integer.toHexString(System.identityHashCode(this));
>>
>> This will
On Thu, 16 Nov 2023 11:03:30 GMT, Alan Bateman wrote:
>> Justin Lu has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> reflect review: change string value and drop spec
>
> src/java.base/share/classes/java/util/zip/ZipFile.java line 494:
>
On Wed, 15 Nov 2023 18:33:47 GMT, Justin Lu wrote:
>> Please review this PR and [CSR](https://bugs.openjdk.org/browse/JDK-8319982)
>> which overrides and provides an implementation of `toString()` in
>> _java.util.zip.ZipFile_ (and by extension, _java.util.jar.JarFile_).
>>
>> This change is p
> Please review this PR and [CSR](https://bugs.openjdk.org/browse/JDK-8319982)
> which overrides and provides an implementation of `toString()` in
> _java.util.zip.ZipFile_ (and by extension, _java.util.jar.JarFile_).
>
> This change is primarily to provide a more informative String representati
On Tue, 14 Nov 2023 07:13:41 GMT, Alan Bateman wrote:
>> Justin Lu has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> reflect review: change string value and drop spec
>
> src/java.base/share/classes/java/util/zip/ZipFile.java line 498:
>
On Mon, 13 Nov 2023 21:59:05 GMT, Justin Lu wrote:
> Please review this PR and [CSR](https://bugs.openjdk.org/browse/JDK-8319982)
> which overrides and provides an implementation of `toString()` in
> _java.util.zip.ZipFile_ (and by extension, _java.util.jar.JarFile_).
>
> This change is primar
Please review this PR and [CSR](https://bugs.openjdk.org/browse/JDK-8319982)
which overrides and provides an implementation of `toString()` in
_java.util.zip.ZipFile_ (and by extension, _java.util.jar.JarFile_).
This change is primarily to provide a more informative String representation of
the
29 matches
Mail list logo
