Re: RFR: JDK-8316696: Remove the testing base classes: IntlTest and CollatorTest [v6]

2023-10-03 Thread Justin Lu
> Please review this PR which removes the i18n related testing base classes > `IntlTest` and `CollatorTest` and converts all the tests that use them, > > IntlTest and CollatorTest are testing classes which are extended by tests in > `text/`, `util/Locale`, `util/TimeZone`, and `util/Calendar`. T

Re: RFR: JDK-8316696: Remove the testing base classes: IntlTest and CollatorTest [v5]

2023-09-29 Thread Naoto Sato
On Fri, 29 Sep 2023 23:24:13 GMT, Justin Lu wrote: >> Please review this PR which removes the i18n related testing base classes >> `IntlTest` and `CollatorTest` and converts all the tests that use them, >> >> IntlTest and CollatorTest are testing classes which are extended by tests in >> `text

Re: RFR: JDK-8316696: Remove the testing base classes: IntlTest and CollatorTest [v5]

2023-09-29 Thread Justin Lu
> Please review this PR which removes the i18n related testing base classes > `IntlTest` and `CollatorTest` and converts all the tests that use them, > > IntlTest and CollatorTest are testing classes which are extended by tests in > `text/`, `util/Locale`, `util/TimeZone`, and `util/Calendar`. T

Re: RFR: JDK-8316696: Remove the testing base classes: IntlTest and CollatorTest [v4]

2023-09-29 Thread Justin Lu
On Fri, 29 Sep 2023 22:00:23 GMT, Naoto Sato wrote: >> Justin Lu has updated the pull request with a new target base due to a merge >> or a rebase. The pull request now contains seven commits: >> >> - merge master and resolve conflicts >> - implement feedback >> - cleanup util classes in tex

Re: RFR: JDK-8316696: Remove the testing base classes: IntlTest and CollatorTest [v4]

2023-09-29 Thread Naoto Sato
On Fri, 29 Sep 2023 21:22:01 GMT, Justin Lu wrote: >> Please review this PR which removes the i18n related testing base classes >> `IntlTest` and `CollatorTest` and converts all the tests that use them, >> >> IntlTest and CollatorTest are testing classes which are extended by tests in >> `text

Re: RFR: JDK-8316696: Remove the testing base classes: IntlTest and CollatorTest [v3]

2023-09-29 Thread Justin Lu
On Fri, 29 Sep 2023 17:30:42 GMT, Naoto Sato wrote: >> Justin Lu has updated the pull request incrementally with one additional >> commit since the last revision: >> >> cleanup util classes in text/testlib > > test/jdk/java/text/BreakIterator/BreakIteratorTest.java line 112: > >> 110:

Re: RFR: JDK-8316696: Remove the testing base classes: IntlTest and CollatorTest [v4]

2023-09-29 Thread Justin Lu
> Please review this PR which removes the i18n related testing base classes > `IntlTest` and `CollatorTest` and converts all the tests that use them, > > IntlTest and CollatorTest are testing classes which are extended by tests in > `text/`, `util/Locale`, `util/TimeZone`, and `util/Calendar`. T

Re: RFR: JDK-8316696: Remove the testing base classes: IntlTest and CollatorTest [v3]

2023-09-29 Thread Naoto Sato
On Thu, 28 Sep 2023 18:13:12 GMT, Justin Lu wrote: >> Please review this PR which removes the i18n related testing base classes >> `IntlTest` and `CollatorTest` and converts all the tests that use them, >> >> IntlTest and CollatorTest are testing classes which are extended by tests in >> `text

Re: RFR: JDK-8316696: Remove the testing base classes: IntlTest and CollatorTest [v3]

2023-09-28 Thread Justin Lu
> Please review this PR which removes the i18n related testing base classes > `IntlTest` and `CollatorTest` and converts all the tests that use them, > > IntlTest and CollatorTest are testing classes which are extended by tests in > `text/`, `util/Locale`, `util/TimeZone`, and `util/Calendar`. T

Re: RFR: JDK-8316696: Remove the testing base classes: IntlTest and CollatorTest [v2]

2023-09-28 Thread Justin Lu
> Please review this PR which removes the i18n related testing base classes > `IntlTest` and `CollatorTest` and converts all the tests that use them, > > IntlTest and CollatorTest are testing classes which are extended by tests in > `text/`, `util/Locale`, `util/TimeZone`, and `util/Calendar`. T

RFR: JDK-8316696: Remove the testing base classes: IntlTest and CollatorTest

2023-09-27 Thread Justin Lu
Please review this PR which removes the i18n related testing base classes `IntlTest` and `CollatorTest` and converts all the tests that use them, IntlTest and CollatorTest are testing classes which are extended by tests in `text/`, `util/Locale`, `util/TimeZone`, and `util/Calendar`. The abstrac