On Wed, 20 Sep 2023 07:00:23 GMT, Justin Lu wrote:
>> Please review this PR which restricts sub-classing of the internal calendar
>> system in sun.util.calendar to only the existing implementations. Drive by
>> cleanup included.
>>
>> As the implementation is long-standing and complete with no
On Wed, 20 Sep 2023 08:54:55 GMT, Andrey Turbanov wrote:
>> Justin Lu has updated the pull request incrementally with two additional
>> commits since the last revision:
>>
>> - cleanup CalendarDate after revert
>> - Revert "Replace sprintf0d with Formatter"
>>
>>This reverts commit 84
On Wed, 20 Sep 2023 07:00:23 GMT, Justin Lu wrote:
>> Please review this PR which restricts sub-classing of the internal calendar
>> system in sun.util.calendar to only the existing implementations. Drive by
>> cleanup included.
>>
>> As the implementation is long-standing and complete with no
> Please review this PR which restricts sub-classing of the internal calendar
> system in sun.util.calendar to only the existing implementations. Drive by
> cleanup included.
>
> As the implementation is long-standing and complete with no intent for future
> sub-classing, the CalendarSystem sho
On Tue, 19 Sep 2023 21:10:18 GMT, Justin Lu wrote:
>> src/java.base/share/classes/sun/util/calendar/CalendarUtils.java line 132:
>>
>>> 130: * Mimics sprintf(buf, "%0*d", decaimal, width).
>>> 131: */
>>> 132: public static StringBuilder sprintf0d(StringBuilder sb, int value,
>>>
> Please review this PR which restricts sub-classing of the internal calendar
> system in sun.util.calendar to only the existing implementations. Drive by
> cleanup included.
>
> As the implementation is long-standing and complete with no intent for future
> sub-classing, the CalendarSystem sho
> Please review this PR which restricts sub-classing of the internal calendar
> system in sun.util.calendar to only the existing implementations. Drive by
> cleanup included.
>
> As the implementation is long-standing and complete with no intent for future
> sub-classing, the CalendarSystem sho
On Tue, 19 Sep 2023 16:48:54 GMT, Naoto Sato wrote:
>> Justin Lu has updated the pull request with a new target base due to a merge
>> or a rebase. The pull request now contains 15 commits:
>>
>> - Re-import Locale after merge for Formatter
>> - Merge master
>> - Replace sprintf0d with Forma
> Please review this PR which restricts sub-classing of the internal calendar
> system in sun.util.calendar to only the existing implementations. Drive by
> cleanup included.
>
> As the implementation is long-standing and complete with no intent for future
> sub-classing, the CalendarSystem sho
On Mon, 18 Sep 2023 22:42:09 GMT, Justin Lu wrote:
> Please review this PR which restricts sub-classing of the internal calendar
> system in sun.util.calendar to only the existing implementations.
>
> As the implementation is long-standing and complete with no intent for future
> sub-classing,
On Mon, 18 Sep 2023 22:42:09 GMT, Justin Lu wrote:
> Please review this PR which restricts sub-classing of the internal calendar
> system in sun.util.calendar to only the existing implementations.
>
> As the implementation is long-standing and complete with no intent for future
> sub-classing,
Please review this PR which restricts sub-classing of the internal calendar
system in sun.util.calendar to only the existing implementations.
As the implementation is long-standing and complete with no intent for future
sub-classing, the CalendarSystem should be made sealed. Modifiers adjusted
12 matches
Mail list logo
