> Please review this PR which updates some exceptions in j.util.Currency to
> have an explicit error message (as opposed to nothing).
>
> The exceptions are thrown when the ISO 4217/3166 currency/country codes are
> in an invalid form, or do not exist.
Justin Lu has updated the pull request inc
On Tue, 29 Aug 2023 16:40:07 GMT, Naoto Sato wrote:
> I think the same wording changes are needed in the test, as it checks the
> error messages word by word.
You're totally right, just fixed.
-
PR Comment: https://git.openjdk.org/jdk/pull/15458#issuecomment-1697803949
On Tue, 29 Aug 2023 16:48:27 GMT, Justin Lu wrote:
>> Please review this PR which updates some exceptions in j.util.Currency to
>> have an explicit error message (as opposed to nothing).
>>
>> The exceptions are thrown when the ISO 4217/3166 currency/country codes are
>> in an invalid form, or
On Mon, 28 Aug 2023 22:45:40 GMT, Justin Lu wrote:
>> Please review this PR which updates some exceptions in j.util.Currency to
>> have an explicit error message (as opposed to nothing).
>>
>> The exceptions are thrown when the ISO 4217/3166 currency/country codes are
>> in an invalid form, or
> Please review this PR which updates some exceptions in j.util.Currency to
> have an explicit error message (as opposed to nothing).
>
> The exceptions are thrown when the ISO 4217/3166 currency/country codes are
> in an invalid form, or do not exist.
Justin Lu has updated the pull request inc
On Mon, 28 Aug 2023 21:36:34 GMT, Justin Lu wrote:
>> Please review this PR which updates some exceptions in j.util.Currency to
>> have an explicit error message (as opposed to nothing).
>>
>> The exceptions are thrown when the ISO 4217/3166 currency/country codes are
>> in an invalid form, or
> Please review this PR which updates some exceptions in j.util.Currency to
> have an explicit error message (as opposed to nothing).
>
> The exceptions are thrown when the ISO 4217/3166 currency/country codes are
> in an invalid form, or do not exist.
Justin Lu has updated the pull request inc
Please review this PR which updates some exceptions in j.util.Currency to have
an explicit error message (as opposed to nothing).
The exceptions occur in the two static `getInstance()` methods. They are thrown
generally when the ISO 4217/3166 currency/country codes are in an invalid form,
or do