Re: RFR: JDK-8308049: Refactor nested class declarations in FdLibm.java

2023-05-15 Thread Stuart Marks
On Sun, 14 May 2023 23:00:14 GMT, Joe Darcy wrote: > Make the nested classes inside FdLibm.java consistently package-access, > static and final. Changes look good. - Marked as reviewed by smarks (Reviewer). PR Review: https://git.openjdk.org/jdk/pull/13972#pullrequestreview-14271

Re: RFR: JDK-8308049: Refactor nested class declarations in FdLibm.java

2023-05-15 Thread Raffaello Giulietti
On Sun, 14 May 2023 23:00:14 GMT, Joe Darcy wrote: > Make the nested classes inside FdLibm.java consistently package-access, > static and final. LGTM - PR Comment: https://git.openjdk.org/jdk/pull/13972#issuecomment-1547571116

RFR: JDK-8308049: Refactor nested class declarations in FdLibm.java

2023-05-14 Thread Joe Darcy
Make the nested classes inside FdLibm.java consistently package-access, static and final. - Commit messages: - JDK-8308049: Refactor nested class declarations in FdLibm.java Changes: https://git.openjdk.org/jdk/pull/13972/files Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=1397