On Thu, 27 Apr 2023 21:31:09 GMT, Erik Joelsson wrote:
>> Marked as reviewed by erikj (Reviewer).
>
>> @erikj79 Thanks! I assume the integrate command will actually squash the
>> three commits and rebase them on top of master as one commit?
>
> Yes, all you need to do is to issue the integrate
On Thu, 27 Apr 2023 21:04:42 GMT, Erik Joelsson wrote:
>> Antonios Printezis has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> updated
>
> Marked as reviewed by erikj (Reviewer).
> @erikj79 Thanks! I assume the integrate command will actu
On Thu, 27 Apr 2023 21:04:42 GMT, Erik Joelsson wrote:
>> Antonios Printezis has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> updated
>
> Marked as reviewed by erikj (Reviewer).
@erikj79 Thanks! I assume the integrate command will actual
On Thu, 27 Apr 2023 20:53:25 GMT, Antonios Printezis wrote:
>> Fix is to exclude hsdis when building the buildjdk.
>
> Antonios Printezis has updated the pull request incrementally with one
> additional commit since the last revision:
>
> updated
Marked as reviewed by erikj (Reviewer).
On Thu, 27 Apr 2023 20:37:11 GMT, Erik Joelsson wrote:
>> Antonios Printezis has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> changes based on Erik's feedback
>
> make/autoconf/buildjdk-spec.gmk.in line 109:
>
>> 107: # hsdis is not need
On Thu, 27 Apr 2023 20:08:29 GMT, Antonios Printezis wrote:
>> Fix is to exclude hsdis when building the buildjdk.
>
> Antonios Printezis has updated the pull request incrementally with one
> additional commit since the last revision:
>
> changes based on Erik's feedback
make/autoconf/buildj
> Fix is to exclude hsdis when building the buildjdk.
Antonios Printezis has updated the pull request incrementally with one
additional commit since the last revision:
updated
-
Changes:
- all: https://git.openjdk.org/jdk/pull/13697/files
- new: https://git.openjdk.org/jdk/pu
> Fix is to exclude hsdis when building the buildjdk.
Antonios Printezis has updated the pull request incrementally with one
additional commit since the last revision:
changes based on Erik's feedback
-
Changes:
- all: https://git.openjdk.org/jdk/pull/13697/files
- new: https
On Thu, 27 Apr 2023 18:19:49 GMT, Erik Joelsson wrote:
>> Antonios Printezis has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> changes based on Erik's feedback
>
> This looks like it should work, but I would like to avoid sprinkling any mo
On Thu, 27 Apr 2023 18:19:49 GMT, Erik Joelsson wrote:
> This looks like it should work, but I would like to avoid sprinkling any more
> CREATING_BUILDJDK conditionals throughout the build than absolutely
> necessary. I think it would be better to just override `HSDIS_BACKEND` and
> `ENABLE_HS
On Thu, 27 Apr 2023 17:57:05 GMT, Antonios Printezis wrote:
> Fix is to exclude hsdis when building the buildjdk.
This looks like it should work, but I would like to avoid sprinkling any more
CREATING_BUILDJDK conditionals throughout the build than absolutely necessary.
I think it would be bet
Fix is to exclude hsdis when building the buildjdk.
-
Commit messages:
- JDK-8307063: When cross-compiling with hsdis/binutils, buildjdk creation
fails
Changes: https://git.openjdk.org/jdk/pull/13697/files
Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=13697&range=00
Issue: ht
12 matches
Mail list logo
