On Mon, 27 Mar 2023 18:37:12 GMT, Jim Laskey wrote:
>> Add the ability to repeatedly append char and CharSequence data to
>> StringBuilder/StringBuffer.
>
> Jim Laskey has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Use Arrays.fill
Looks
On Mon, 27 Mar 2023 18:37:12 GMT, Jim Laskey wrote:
>> Add the ability to repeatedly append char and CharSequence data to
>> StringBuilder/StringBuffer.
>
> Jim Laskey has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Use Arrays.fill
test/j
> Add the ability to repeatedly append char and CharSequence data to
> StringBuilder/StringBuffer.
Jim Laskey has updated the pull request incrementally with one additional
commit since the last revision:
Use Arrays.fill
-
Changes:
- all: https://git.openjdk.org/jdk/pull/12728
On Tue, 14 Mar 2023 10:14:44 GMT, Claes Redestad wrote:
>> Jim Laskey has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Expand test for StringBuffer and illegal code points
>
> src/java.base/share/classes/java/lang/AbstractStringBuilder.ja
> Add the ability to repeatedly append char and CharSequence data to
> StringBuilder/StringBuffer.
Jim Laskey has updated the pull request with a new target base due to a merge
or a rebase. The incremental webrev excludes the unrelated changes brought in
by the merge/rebase. The pull request co
On Fri, 3 Mar 2023 19:04:22 GMT, Jim Laskey wrote:
>> Add the ability to repeatedly append char and CharSequence data to
>> StringBuilder/StringBuffer.
>
> Jim Laskey has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Expand test for StringBu
On Fri, 3 Mar 2023 19:04:22 GMT, Jim Laskey wrote:
>> Add the ability to repeatedly append char and CharSequence data to
>> StringBuilder/StringBuffer.
>
> Jim Laskey has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Expand test for StringBu
> Add the ability to repeatedly append char and CharSequence data to
> StringBuilder/StringBuffer.
Jim Laskey has updated the pull request incrementally with one additional
commit since the last revision:
Expand test for StringBuffer and illegal code points
-
Changes:
- all: h
On Thu, 2 Mar 2023 20:19:01 GMT, Jim Laskey wrote:
>> Add the ability to repeatedly append char and CharSequence data to
>> StringBuilder/StringBuffer.
>
> Jim Laskey has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Add snippet
I agree. Wi
On Thu, 2 Mar 2023 20:19:01 GMT, Jim Laskey wrote:
>> Add the ability to repeatedly append char and CharSequence data to
>> StringBuilder/StringBuffer.
>
> Jim Laskey has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Add snippet
The repeat
On Thu, 2 Mar 2023 20:19:01 GMT, Jim Laskey wrote:
>> Add the ability to repeatedly append char and CharSequence data to
>> StringBuilder/StringBuffer.
>
> Jim Laskey has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Add snippet
Marked as r
On Thu, 2 Mar 2023 20:19:01 GMT, Jim Laskey wrote:
>> Add the ability to repeatedly append char and CharSequence data to
>> StringBuilder/StringBuffer.
>
> Jim Laskey has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Add snippet
Can I get s
> Add the ability to repeatedly append char and CharSequence data to
> StringBuilder/StringBuffer.
Jim Laskey has updated the pull request incrementally with one additional
commit since the last revision:
Add snippet
-
Changes:
- all: https://git.openjdk.org/jdk/pull/12728/fil
On Thu, 2 Mar 2023 18:39:36 GMT, Andrey Turbanov wrote:
>> Jim Laskey has updated the pull request incrementally with two additional
>> commits since the last revision:
>>
>> - Move @since in subclasses
>> - Move @since
>
> src/java.base/share/classes/java/lang/AbstractStringBuilder.java line
> Add the ability to repeatedly append char and CharSequence data to
> StringBuilder/StringBuffer.
Jim Laskey has updated the pull request incrementally with one additional
commit since the last revision:
Support code points
-
Changes:
- all: https://git.openjdk.org/jdk/pull/1
On Wed, 1 Mar 2023 12:54:44 GMT, Jim Laskey wrote:
>> Add the ability to repeatedly append char and CharSequence data to
>> StringBuilder/StringBuffer.
>
> Jim Laskey has updated the pull request incrementally with two additional
> commits since the last revision:
>
> - Move @since in subclas
> Add the ability to repeatedly append char and CharSequence data to
> StringBuilder/StringBuffer.
Jim Laskey has updated the pull request incrementally with two additional
commits since the last revision:
- Move @since in subclasses
- Move @since
-
Changes:
- all: https://git
On Tue, 28 Feb 2023 22:08:34 GMT, Roger Riggs wrote:
>> Jim Laskey has updated the pull request incrementally with two additional
>> commits since the last revision:
>>
>> - Remove @throws IndexOutOfBoundsException
>> - Change error report to use "is negative"
>
> src/java.base/share/classes/
On Tue, 28 Feb 2023 13:29:49 GMT, Jim Laskey wrote:
>> Add the ability to repeatedly append char and CharSequence data to
>> StringBuilder/StringBuffer.
>
> Jim Laskey has updated the pull request incrementally with two additional
> commits since the last revision:
>
> - Remove @throws IndexO
On Tue, 28 Feb 2023 13:29:49 GMT, Jim Laskey wrote:
>> Add the ability to repeatedly append char and CharSequence data to
>> StringBuilder/StringBuffer.
>
> Jim Laskey has updated the pull request incrementally with two additional
> commits since the last revision:
>
> - Remove @throws IndexO
On Tue, 28 Feb 2023 09:05:44 GMT, John Hendrikx wrote:
>> src/java.base/share/classes/java/lang/AbstractStringBuilder.java line 1903:
>>
>>> 1901: throw new OutOfMemoryError("Required length exceeds
>>> implementation limit");
>>> 1902: }
>>> 1903: int total = count
On Tue, 28 Feb 2023 10:54:14 GMT, Alan Bateman wrote:
>> Jim Laskey has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Optimize for empty CharSequence
>
> src/java.base/share/classes/java/lang/AbstractStringBuilder.java line 1837:
>
>> 183
> Add the ability to repeatedly append char and CharSequence data to
> StringBuilder/StringBuffer.
Jim Laskey has updated the pull request incrementally with two additional
commits since the last revision:
- Remove @throws IndexOutOfBoundsException
- Change error report to use "is negative"
On Tue, 28 Feb 2023 07:50:18 GMT, Tagir F. Valeev wrote:
>> Jim Laskey has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Optimize for empty CharSequence
>
> src/java.base/share/classes/java/lang/AbstractStringBuilder.java line 1879:
>
>>
On Mon, 27 Feb 2023 13:30:47 GMT, Jim Laskey wrote:
>> Add the ability to repeatedly append char and CharSequence data to
>> StringBuilder/StringBuffer.
>
> Jim Laskey has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Optimize for empty Char
On Mon, 27 Feb 2023 13:30:47 GMT, Jim Laskey wrote:
>> Add the ability to repeatedly append char and CharSequence data to
>> StringBuilder/StringBuffer.
>
> Jim Laskey has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Optimize for empty Char
On Tue, 28 Feb 2023 07:43:13 GMT, Tagir F. Valeev wrote:
>> Jim Laskey has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Optimize for empty CharSequence
>
> src/java.base/share/classes/java/lang/AbstractStringBuilder.java line 1903:
>
>>
On Mon, 27 Feb 2023 13:30:47 GMT, Jim Laskey wrote:
>> Add the ability to repeatedly append char and CharSequence data to
>> StringBuilder/StringBuffer.
>
> Jim Laskey has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Optimize for empty Char
On Mon, 27 Feb 2023 13:20:48 GMT, Jim Laskey wrote:
>> src/java.base/share/classes/java/lang/AbstractStringBuilder.java line 1903:
>>
>>> 1901: int total = count * length;
>>> 1902: int limit = offset + total;
>>> 1903: ensureCapacityInternal(limit);
>>
>> If I understan
On Mon, 27 Feb 2023 13:30:47 GMT, Jim Laskey wrote:
>> Add the ability to repeatedly append char and CharSequence data to
>> StringBuilder/StringBuffer.
>
> Jim Laskey has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Optimize for empty Char
> Add the ability to repeatedly append char and CharSequence data to
> StringBuilder/StringBuffer.
Jim Laskey has updated the pull request incrementally with one additional
commit since the last revision:
Optimize for empty CharSequence
-
Changes:
- all: https://git.openjdk.or
On Sun, 26 Feb 2023 17:28:08 GMT, Tagir F. Valeev wrote:
>> Jim Laskey has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> PR Cleanup
>
> src/java.base/share/classes/java/lang/AbstractStringBuilder.java line 1903:
>
>> 1901: int tot
On Sun, 26 Feb 2023 17:29:09 GMT, Tagir F. Valeev wrote:
>> Jim Laskey has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> PR Cleanup
>
> src/java.base/share/classes/java/lang/AbstractStringBuilder.java line 1893:
>
>> 1891: }
>> 18
On Thu, 23 Feb 2023 17:39:10 GMT, Jim Laskey wrote:
>> Add the ability to repeatedly append char and CharSequence data to
>> StringBuilder/StringBuffer.
>
> Jim Laskey has updated the pull request incrementally with one additional
> commit since the last revision:
>
> PR Cleanup
src/java.ba
On Thu, 23 Feb 2023 16:17:00 GMT, Jim Laskey wrote:
>> src/java.base/share/classes/java/lang/AbstractStringBuilder.java line 1839:
>>
>>> 1837: * @throws StringIndexOutOfBoundsException if the result
>>> overflows the buffer
>>> 1838: */
>>> 1839: public AbstractStringBuilder rep
On Thu, 23 Feb 2023 17:39:10 GMT, Jim Laskey wrote:
>> Add the ability to repeatedly append char and CharSequence data to
>> StringBuilder/StringBuffer.
>
> Jim Laskey has updated the pull request incrementally with one additional
> commit since the last revision:
>
> PR Cleanup
src/java.ba
> Add the ability to repeatedly append char and CharSequence data to
> StringBuilder/StringBuffer.
Jim Laskey has updated the pull request incrementally with one additional
commit since the last revision:
PR Cleanup
-
Changes:
- all: https://git.openjdk.org/jdk/pull/12728/file
On Thu, 23 Feb 2023 16:54:10 GMT, Jim Laskey wrote:
>> src/java.base/share/classes/java/lang/AbstractStringBuilder.java line 1918:
>>
>>> 1916: }
>>> 1917: int valueLength = length << UTF16;
>>> 1918: if ((Integer.MAX_VALUE - this.count) / count < valueLength) {
>>
>> I
On Thu, 23 Feb 2023 16:40:32 GMT, Roger Riggs wrote:
>> Add the ability to repeatedly append char and CharSequence data to
>> StringBuilder/StringBuffer.
>
> src/java.base/share/classes/java/lang/AbstractStringBuilder.java line 1918:
>
>> 1916: }
>> 1917: int valueLength = lengt
On Thu, 23 Feb 2023 13:13:43 GMT, Jim Laskey wrote:
> Add the ability to repeatedly append char and CharSequence data to
> StringBuilder/StringBuffer.
src/java.base/share/classes/java/lang/AbstractStringBuilder.java line 1918:
> 1916: }
> 1917: int valueLength = length << UTF16
On Thu, 23 Feb 2023 13:13:43 GMT, Jim Laskey wrote:
> Add the ability to repeatedly append char and CharSequence data to
> StringBuilder/StringBuffer.
src/java.base/share/classes/java/lang/String.java line 4461:
> 4459:
> 4460: /**
> 4461: * Used to perform copying after the initial
On Thu, 23 Feb 2023 15:56:37 GMT, Roger Riggs wrote:
>> Add the ability to repeatedly append char and CharSequence data to
>> StringBuilder/StringBuffer.
>
> src/java.base/share/classes/java/lang/AbstractStringBuilder.java line 1876:
>
>> 1874: int length = this.count - offset;
>> 1875:
On Thu, 23 Feb 2023 16:20:59 GMT, Jim Laskey wrote:
>> src/java.base/share/classes/java/lang/AbstractStringBuilder.java line 1867:
>>
>>> 1865:
>>> 1866: private AbstractStringBuilder repeatNull(int count) {
>>> 1867: if (count < 0) {
>>
>> This could be implemented as `repeat("nul
On Thu, 23 Feb 2023 15:52:15 GMT, Roger Riggs wrote:
>> Add the ability to repeatedly append char and CharSequence data to
>> StringBuilder/StringBuffer.
>
> src/java.base/share/classes/java/lang/AbstractStringBuilder.java line 1839:
>
>> 1837: * @throws StringIndexOutOfBoundsException if
On Thu, 23 Feb 2023 13:13:43 GMT, Jim Laskey wrote:
> Add the ability to repeatedly append char and CharSequence data to
> StringBuilder/StringBuffer.
src/java.base/share/classes/java/lang/AbstractStringBuilder.java line 1839:
> 1837: * @throws StringIndexOutOfBoundsException if the resu
On Thu, 23 Feb 2023 15:32:36 GMT, Jim Laskey wrote:
>> src/java.base/share/classes/java/lang/AbstractStringBuilder.java line 1851:
>>
>>> 1849: while (count-- != 0) {
>>> 1850: value[index++] = (byte) c;
>>> 1851: }
>>
>> One could reduce to just one runn
On Thu, 23 Feb 2023 15:17:26 GMT, Raffaello Giulietti
wrote:
>> Add the ability to repeatedly append char and CharSequence data to
>> StringBuilder/StringBuffer.
>
> src/java.base/share/classes/java/lang/AbstractStringBuilder.java line 1851:
>
>> 1849: while (count-- != 0) {
>> 185
On Thu, 23 Feb 2023 13:13:43 GMT, Jim Laskey wrote:
> Add the ability to repeatedly append char and CharSequence data to
> StringBuilder/StringBuffer.
src/java.base/share/classes/java/lang/AbstractStringBuilder.java line 1851:
> 1849: while (count-- != 0) {
> 1850:
Add the ability to repeatedly append char and CharSequence data to
StringBuilder/StringBuffer.
-
Commit messages:
- Clean up fro CSR
- Add synchronized to StringBuffer repeats
- AbstractStringBuilder repeat
Changes: https://git.openjdk.org/jdk/pull/12728/files
Webrev: https://we
49 matches
Mail list logo
