Re: RFR: JDK-8302028: Port fdlibm atan2 to Java [v5]

2023-02-22 Thread Brian Burkhalter
On Tue, 21 Feb 2023 23:03:04 GMT, Joe Darcy wrote: >> Working down the porting list, next stop, atan2. > > Joe Darcy has updated the pull request incrementally with one additional > commit since the last revision: > > Respond to review feedback. Looks good. - Marked as reviewed

Re: RFR: JDK-8302028: Port fdlibm atan2 to Java [v2]

2023-02-21 Thread Joe Darcy
On Fri, 17 Feb 2023 19:33:07 GMT, Joe Darcy wrote: >> src/java.base/share/classes/java/lang/FdLibm.java line 458: >> >>> 456: case 0, 1 -> y; // atan(+/-0, +anything) >>> = +/-0 >>> 457: case 2-> Math.PI + tiny; // atan(+0, -anything) >>>

Re: RFR: JDK-8302028: Port fdlibm atan2 to Java [v2]

2023-02-21 Thread Joe Darcy
On Fri, 17 Feb 2023 14:18:25 GMT, Raffaello Giulietti wrote: >> Joe Darcy has updated the pull request with a new target base due to a merge >> or a rebase. The incremental webrev excludes the unrelated changes brought >> in by the merge/rebase. The pull request contains three additional commi

Re: RFR: JDK-8302028: Port fdlibm atan2 to Java [v5]

2023-02-21 Thread Joe Darcy
> Working down the porting list, next stop, atan2. Joe Darcy has updated the pull request incrementally with one additional commit since the last revision: Respond to review feedback. - Changes: - all: https://git.openjdk.org/jdk/pull/12608/files - new: https://git.openjdk.or

Re: RFR: JDK-8302028: Port fdlibm atan2 to Java [v4]

2023-02-21 Thread Joe Darcy
> Working down the porting list, next stop, atan2. Joe Darcy has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains six additional commits since the last revi

Re: RFR: JDK-8302028: Port fdlibm atan2 to Java [v2]

2023-02-17 Thread Joe Darcy
On Fri, 17 Feb 2023 21:12:25 GMT, Joe Darcy wrote: > Well spotted; corrected the code and added additional tests to catch that > case. Thanks. PS From some quick manual inspections, the other recent ports of FDLIBM methods don't look vulnerable to this kind of problem. However, as follow-up wo

Re: RFR: JDK-8302028: Port fdlibm atan2 to Java [v2]

2023-02-17 Thread Joe Darcy
On Fri, 17 Feb 2023 13:50:17 GMT, Raffaello Giulietti wrote: >> Joe Darcy has updated the pull request with a new target base due to a merge >> or a rebase. The incremental webrev excludes the unrelated changes brought >> in by the merge/rebase. The pull request contains three additional commi

Re: RFR: JDK-8302028: Port fdlibm atan2 to Java [v3]

2023-02-17 Thread Joe Darcy
> Working down the porting list, next stop, atan2. Joe Darcy has updated the pull request incrementally with one additional commit since the last revision: Correct and test for issue found in code review. - Changes: - all: https://git.openjdk.org/jdk/pull/12608/files - new: h

Re: RFR: JDK-8302028: Port fdlibm atan2 to Java [v2]

2023-02-17 Thread Joe Darcy
On Fri, 17 Feb 2023 14:02:35 GMT, Raffaello Giulietti wrote: >> Joe Darcy has updated the pull request with a new target base due to a merge >> or a rebase. The incremental webrev excludes the unrelated changes brought >> in by the merge/rebase. The pull request contains three additional commi

Re: RFR: JDK-8302028: Port fdlibm atan2 to Java [v2]

2023-02-17 Thread Joe Darcy
On Fri, 17 Feb 2023 13:48:32 GMT, Raffaello Giulietti wrote: >> Joe Darcy has updated the pull request with a new target base due to a merge >> or a rebase. The incremental webrev excludes the unrelated changes brought >> in by the merge/rebase. The pull request contains three additional commi

Re: RFR: JDK-8302028: Port fdlibm atan2 to Java [v2]

2023-02-17 Thread Raffaello Giulietti
On Fri, 17 Feb 2023 04:18:30 GMT, Joe Darcy wrote: >> Working down the porting list, next stop, atan2. > > Joe Darcy has updated the pull request with a new target base due to a merge > or a rebase. The incremental webrev excludes the unrelated changes brought in > by the merge/rebase. The pull

Re: RFR: JDK-8302028: Port fdlibm atan2 to Java [v2]

2023-02-16 Thread Joe Darcy
> Working down the porting list, next stop, atan2. Joe Darcy has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains three additional commits since the last re

Re: RFR: JDK-8302028: Port fdlibm atan2 to Java

2023-02-16 Thread Brian Burkhalter
On Thu, 16 Feb 2023 19:30:06 GMT, Joe Darcy wrote: > Working down the porting list, next stop, atan2. The port looks reasonable to me. - PR: https://git.openjdk.org/jdk/pull/12608

Re: RFR: JDK-8302028: Port fdlibm atan2 to Java

2023-02-16 Thread Joe Darcy
On Thu, 16 Feb 2023 19:30:06 GMT, Joe Darcy wrote: > Working down the porting list, next stop, atan2. Diffs of the various ports, starting with the original C vs the transliteration port: $ diff -w Atan2.c Atan2.translit.java 1c1,4 < /* __ieee754_atan2(y,x) --- > /** > * Returns the

RFR: JDK-8302028: Port fdlibm atan2 to Java

2023-02-16 Thread Joe Darcy
Working down the porting list, next stop, atan2. - Commit messages: - JDK-8302028: Port fdlibm atan2 to Java Changes: https://git.openjdk.org/jdk/pull/12608/files Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=12608&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8302028