On Tue, 29 Nov 2022 23:40:58 GMT, Brian Burkhalter wrote:
>> Markus KARG has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> fixed bug number
>
>> > Please take note of the changes proposed in #11403.
>>
>> It might make sense to merge _thi
On Tue, 29 Nov 2022 23:40:58 GMT, Brian Burkhalter wrote:
>> Markus KARG has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> fixed bug number
>
>> > Please take note of the changes proposed in #11403.
>>
>> It might make sense to merge _thi
On Wed, 7 Dec 2022 12:41:19 GMT, Markus KARG wrote:
>> Since JDK 18 some implementations of InputStream.transferTo, namely
>> FileInputStream and ChannelInputStream, offload work to lower layers using
>> NIO channels. This provides shorter execution time and reduced resource
>> consumption. Un
On Wed, 7 Dec 2022 12:41:19 GMT, Markus KARG wrote:
>> Since JDK 18 some implementations of InputStream.transferTo, namely
>> FileInputStream and ChannelInputStream, offload work to lower layers using
>> NIO channels. This provides shorter execution time and reduced resource
>> consumption. Un
On Tue, 6 Dec 2022 16:20:44 GMT, Brian Burkhalter wrote:
>> test/jdk/java/io/SequenceInputStream/TransferTo.java line 206:
>>
>>> 204: }
>>> 205:
>>> 206: }
>>
>> As auto-detected, there is no newline at the end of this file. Otherwise it
>> appears all right.
>
> @mkarg Please take accou
On Tue, 6 Dec 2022 16:20:44 GMT, Brian Burkhalter wrote:
>> test/jdk/java/io/SequenceInputStream/TransferTo.java line 206:
>>
>>> 204: }
>>> 205:
>>> 206: }
>>
>> As auto-detected, there is no newline at the end of this file. Otherwise it
>> appears all right.
>
> @mkarg Please take accou
> Since JDK 18 some implementations of InputStream.transferTo, namely
> FileInputStream and ChannelInputStream, offload work to lower layers using
> NIO channels. This provides shorter execution time and reduced resource
> consumption. Unfortunately, this effect is prevented once the input strea
On Mon, 5 Dec 2022 19:42:44 GMT, Brian Burkhalter wrote:
>> Markus KARG has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> fixed bug number
>
> test/jdk/java/io/SequenceInputStream/TransferTo.java line 206:
>
>> 204: }
>> 205:
>> 206:
On Sun, 20 Nov 2022 09:41:47 GMT, Markus KARG wrote:
>> Since JDK 18 some implementations of InputStream.transferTo, namely
>> FileInputStream and ChannelInputStream, offload work to lower layers using
>> NIO channels. This provides shorter execution time and reduced resource
>> consumption. U
On Tue, 29 Nov 2022 23:40:58 GMT, Brian Burkhalter wrote:
> > > Please take note of the changes proposed in #11403.
> >
> >
> > It might make sense to merge _this_ PR as-is _first_, but then add the
> > needed fix to #11403 afterwards?
>
> I concur. I will take a look at the test soon.
That
On Sun, 20 Nov 2022 09:41:47 GMT, Markus KARG wrote:
>> Since JDK 18 some implementations of InputStream.transferTo, namely
>> FileInputStream and ChannelInputStream, offload work to lower layers using
>> NIO channels. This provides shorter execution time and reduced resource
>> consumption. U
On Tue, 29 Nov 2022 19:39:49 GMT, Brian Burkhalter wrote:
> Please take note of the changes proposed in #11403.
It might make sense to merge *this* PR as-is *first*, but then add the needed
fix to #11403 afterwards? Otherwise it might be confusing for a reader, why
#11403 is not covering SIS w
On Sun, 20 Nov 2022 09:41:47 GMT, Markus KARG wrote:
>> Since JDK 18 some implementations of InputStream.transferTo, namely
>> FileInputStream and ChannelInputStream, offload work to lower layers using
>> NIO channels. This provides shorter execution time and reduced resource
>> consumption. U
On Thu, 24 Nov 2022 20:22:16 GMT, Markus KARG wrote:
> Kindly requesting review. :-)
The override looks fine. I think [bplb](https://github.com/bplb) plans to
review/sponsor it.
-
PR: https://git.openjdk.org/jdk/pull/11248
On Sun, 20 Nov 2022 09:41:47 GMT, Markus KARG wrote:
>> Since JDK 18 some implementations of InputStream.transferTo, namely
>> FileInputStream and ChannelInputStream, offload work to lower layers using
>> NIO channels. This provides shorter execution time and reduced resource
>> consumption. U
On Sun, 20 Nov 2022 07:30:15 GMT, Alan Bateman wrote:
> > I might be mistaken, but that vector is not temporary: the vector and the
> > enumeration produced from it seems to be reachable for as long as the
> > stream is. Both the enumeration and the vector are synchronized. That
> > synchroniz
On Sun, 20 Nov 2022 07:30:15 GMT, Alan Bateman wrote:
> I might be mistaken, but that vector is not temporary: the vector and the
> enumeration produced from it seems to be reachable for as long as the stream
> is. Both the enumeration and the vector are synchronized. That
> synchronization mi
> Since JDK 18 some implementations of InputStream.transferTo, namely
> FileInputStream and ChannelInputStream, offload work to lower layers using
> NIO channels. This provides shorter execution time and reduced resource
> consumption. Unfortunately, this effect is prevented once the input strea
On Sun, 20 Nov 2022 07:45:11 GMT, Alan Bateman wrote:
>> Since JDK 18 some implementations of InputStream.transferTo, namely
>> FileInputStream and ChannelInputStream, offload work to lower layers using
>> NIO channels. This provides shorter execution time and reduced resource
>> consumption.
On Sat, 19 Nov 2022 16:36:28 GMT, Markus KARG wrote:
> Since JDK 18 some implementations of InputStream.transferTo, namely
> FileInputStream and ChannelInputStream, offload work to lower layers using
> NIO channels. This provides shorter execution time and reduced resource
> consumption. Unfor
On Sat, 19 Nov 2022 23:23:07 GMT, Pavel Rappo wrote:
> I might be mistaken, but that vector is not temporary: the vector and the
> enumeration produced from it seems to be reachable for as long as the stream
> is. Both the enumeration and the vector are synchronized. That
> synchronization mig
On Sat, 19 Nov 2022 16:36:28 GMT, Markus KARG wrote:
> Since JDK 18 some implementations of InputStream.transferTo, namely
> FileInputStream and ChannelInputStream, offload work to lower layers using
> NIO channels. This provides shorter execution time and reduced resource
> consumption. Unfor
Since JDK 18 some implementations of InputStream.transferTo, namely
FileInputStream and ChannelInputStream, offload work to lower layers using NIO
channels. This provides shorter execution time and reduced resource
consumption. Unfortunately, this effect is prevented once the input stream
itsel
23 matches
Mail list logo
