Re: RFR: JDK-8297215: Update libs tests to use @enablePreview [v5]

2022-12-01 Thread Joe Darcy
> Similar to an update recently done for langtools tests, update the libraries > regression tests to take advantage of the @enablePreview jtreg feature. Joe Darcy has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes

Re: RFR: JDK-8297215: Update libs tests to use @enablePreview [v4]

2022-12-01 Thread Joe Darcy
On Thu, 1 Dec 2022 19:19:01 GMT, Erik Gahlin wrote: >> Joe Darcy has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Respond to review feedback. > > test/jdk/jdk/jfr/threading/TestDeepVirtualStackTrace.java line 46: > >> 44: * @modules jdk

Re: RFR: JDK-8297215: Update libs tests to use @enablePreview [v4]

2022-12-01 Thread Erik Gahlin
On Thu, 1 Dec 2022 18:00:11 GMT, Joe Darcy wrote: >> Similar to an update recently done for langtools tests, update the libraries >> regression tests to take advantage of the @enablePreview jtreg feature. > > Joe Darcy has updated the pull request incrementally with one additional > commit sinc

Re: RFR: JDK-8297215: Update libs tests to use @enablePreview [v4]

2022-12-01 Thread Joe Darcy
> Similar to an update recently done for langtools tests, update the libraries > regression tests to take advantage of the @enablePreview jtreg feature. Joe Darcy has updated the pull request incrementally with one additional commit since the last revision: Respond to review feedback. --

Re: RFR: JDK-8297215: Update libs tests to use @enablePreview [v3]

2022-12-01 Thread Serguei Spitsyn
On Thu, 1 Dec 2022 05:44:44 GMT, Joe Darcy wrote: >> Similar to an update recently done for langtools tests, update the libraries >> regression tests to take advantage of the @enablePreview jtreg feature. > > Joe Darcy has updated the pull request with a new target base due to a merge > or a re

Re: RFR: JDK-8297215: Update libs tests to use @enablePreview [v3]

2022-12-01 Thread Alan Bateman
On Thu, 1 Dec 2022 05:44:44 GMT, Joe Darcy wrote: >> Similar to an update recently done for langtools tests, update the libraries >> regression tests to take advantage of the @enablePreview jtreg feature. > > Joe Darcy has updated the pull request with a new target base due to a merge > or a re

Re: RFR: JDK-8297215: Update libs tests to use @enablePreview [v3]

2022-11-30 Thread Joe Darcy
> Similar to an update recently done for langtools tests, update the libraries > regression tests to take advantage of the @enablePreview jtreg feature. Joe Darcy has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes

Re: RFR: JDK-8297215: Update libs tests to use @enablePreview [v2]

2022-11-19 Thread Alan Bateman
On Fri, 18 Nov 2022 21:29:50 GMT, Joe Darcy wrote: >> `@enablePreview` wasn't available when most of these tests were initially >> created. I changed some of to use this tag as part of other changes but >> didn't cover over the remaining tests that still use `@compile >> --enable-preview -sour

Re: RFR: JDK-8297215: Update libs tests to use @enablePreview [v2]

2022-11-18 Thread Joe Darcy
On Fri, 18 Nov 2022 19:06:02 GMT, Alan Bateman wrote: >> Right; ideally when the feature becomes non-preview the test update would >> just be removing the "@enablePreview" line. I didn't author these tests so I >> initially left any "othervm" directives in place since they aren't >> incorrect,

Re: RFR: JDK-8297215: Update libs tests to use @enablePreview [v2]

2022-11-18 Thread Alan Bateman
On Fri, 18 Nov 2022 18:38:46 GMT, Joe Darcy wrote: >> test/jdk/java/lang/Thread/BuilderTest.java line 29: >> >>> 27: * @enablePreview >>> 28: * @compile BuilderTest.java >>> 29: * @run testng/othervm BuilderTest >> >> I assume `@compile` can be dropped from most of these tests now. Also I >

Re: RFR: JDK-8297215: Update libs tests to use @enablePreview [v2]

2022-11-18 Thread Joe Darcy
On Fri, 18 Nov 2022 08:28:22 GMT, Alan Bateman wrote: >> Joe Darcy has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Respond to review feedback. > > test/jdk/java/lang/Thread/BuilderTest.java line 29: > >> 27: * @enablePreview >> 28: *

Re: RFR: JDK-8297215: Update libs tests to use @enablePreview [v2]

2022-11-18 Thread Joe Darcy
> Similar to an update recently done for langtools tests, update the libraries > regression tests to take advantage of the @enablePreview jtreg feature. Joe Darcy has updated the pull request incrementally with one additional commit since the last revision: Respond to review feedback. --

Re: RFR: JDK-8297215: Update libs tests to use @enablePreview

2022-11-18 Thread Alan Bateman
On Thu, 17 Nov 2022 21:48:11 GMT, Joe Darcy wrote: > Similar to an update recently done for langtools tests, update the libraries > regression tests to take advantage of the @enablePreview jtreg feature. test/jdk/java/lang/Thread/BuilderTest.java line 29: > 27: * @enablePreview > 28: * @comp

RFR: JDK-8297215: Update libs tests to use @enablePreview

2022-11-17 Thread Joe Darcy
Similar to an update recently done for langtools tests, update the libraries regression tests to take advantage of the @enablePreview jtreg feature. - Commit messages: - JDK-8297215: Update libs tests to use @enablePreview Changes: https://git.openjdk.org/jdk/pull/11222/files Webr