> Add discussion of some of the common pitfalls related to decimal <-> binary
> conversion.
Joe Darcy has updated the pull request incrementally with one additional commit
since the last revision:
Fix link.
-
Changes:
- all: https://git.openjdk.org/jdk/pull/16566/files
- new
> Add discussion of some of the common pitfalls related to decimal <-> binary
> conversion.
Joe Darcy has updated the pull request incrementally with one additional commit
since the last revision:
Minor tweaks.
-
Changes:
- all: https://git.openjdk.org/jdk/pull/16566/files
-
On Wed, 8 Nov 2023 18:41:53 GMT, Eirik Bjorsnos wrote:
>> Joe Darcy has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Small clean ups.
>
> src/java.base/share/classes/java/lang/Double.java line 209:
>
>> 207: * decimal conversion. While
> Add discussion of some of the common pitfalls related to decimal <-> binary
> conversion.
Joe Darcy has updated the pull request incrementally with one additional commit
since the last revision:
Small clean ups.
-
Changes:
- all: https://git.openjdk.org/jdk/pull/16566/files
> Add discussion of some of the common pitfalls related to decimal <-> binary
> conversion.
Joe Darcy has updated the pull request incrementally with one additional commit
since the last revision:
Minor rewordings.
-
Changes:
- all: https://git.openjdk.org/jdk/pull/16566/files
> Add discussion of some of the common pitfalls related to decimal <-> binary
> conversion.
Joe Darcy has updated the pull request with a new target base due to a merge or
a rebase. The incremental webrev excludes the unrelated changes brought in by
the merge/rebase. The pull request contains e
> Add discussion of some of the common pitfalls related to decimal <-> binary
> conversion.
Joe Darcy has updated the pull request with a new target base due to a merge or
a rebase. The incremental webrev excludes the unrelated changes brought in by
the merge/rebase. The pull request contains s
> Add discussion of some of the common pitfalls related to decimal <-> binary
> conversion.
Joe Darcy has updated the pull request incrementally with one additional commit
since the last revision:
Fix typo.
-
Changes:
- all: https://git.openjdk.org/jdk/pull/16566/files
- new
On Wed, 8 Nov 2023 19:40:11 GMT, Brian Burkhalter wrote:
>> Joe Darcy has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Switch to parseFloat from valueOf, add links.
>
> src/java.base/share/classes/java/lang/Double.java line 752:
>
>> 750
On Wed, 8 Nov 2023 19:24:24 GMT, Joe Darcy wrote:
>> Add discussion of some of the common pitfalls related to decimal <-> binary
>> conversion.
>
> Joe Darcy has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Switch to parseFloat from valueOf
> Add discussion of some of the common pitfalls related to decimal <-> binary
> conversion.
Joe Darcy has updated the pull request incrementally with one additional commit
since the last revision:
Switch to parseFloat from valueOf, add links.
-
Changes:
- all: https://git.open
On Wed, 8 Nov 2023 19:24:24 GMT, Joe Darcy wrote:
>> Add discussion of some of the common pitfalls related to decimal <-> binary
>> conversion.
>
> Joe Darcy has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Switch to parseFloat from valueOf
On Wed, 8 Nov 2023 18:41:15 GMT, Joe Darcy wrote:
>> Add discussion of some of the common pitfalls related to decimal <-> binary
>> conversion.
>
> Joe Darcy has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Address issues found by reviewers
On Wed, 8 Nov 2023 18:41:15 GMT, Joe Darcy wrote:
>> Add discussion of some of the common pitfalls related to decimal <-> binary
>> conversion.
>
> Joe Darcy has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Address issues found by reviewers
On Wed, 8 Nov 2023 18:17:00 GMT, Raffaello Giulietti
wrote:
>> Joe Darcy has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Address issues found by reviewers.
>
> src/java.base/share/classes/java/lang/Double.java line 287:
>
>> 285: * le
On Wed, 8 Nov 2023 18:09:52 GMT, Raffaello Giulietti
wrote:
>> Joe Darcy has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Address issues found by reviewers.
>
> src/java.base/share/classes/java/lang/Double.java line 257:
>
>> 255: * //
On Wed, 8 Nov 2023 17:54:50 GMT, Brian Burkhalter wrote:
>> Joe Darcy has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Address issues found by reviewers.
>
> src/java.base/share/classes/java/lang/Double.java line 212:
>
>> 210: * fracti
> Add discussion of some of the common pitfalls related to decimal <-> binary
> conversion.
Joe Darcy has updated the pull request incrementally with one additional commit
since the last revision:
Address issues found by reviewers.
-
Changes:
- all: https://git.openjdk.org/jdk
On Wed, 8 Nov 2023 17:29:28 GMT, Joe Darcy wrote:
> Add discussion of some of the common pitfalls related to decimal <-> binary
> conversion.
src/java.base/share/classes/java/lang/Double.java line 257:
> 255: * // Numeric values listed are exact values
> 256: * oneTenthApproxAsFloat = 0.1000
On Wed, 8 Nov 2023 17:29:28 GMT, Joe Darcy wrote:
> Add discussion of some of the common pitfalls related to decimal <-> binary
> conversion.
src/java.base/share/classes/java/lang/Double.java line 212:
> 210: * fraction (0.3); but in base 3, 1/3 is exactly
> 211: * 0.1(3), that is 1
Add discussion of some of the common pitfalls related to decimal <-> binary
conversion.
-
Commit messages:
- Appease jcheck.
- JDK-8295391: Add discussion of binary <-> decimal conversion issues
Changes: https://git.openjdk.org/jdk/pull/16566/files
Webrev: https://webrevs.openjdk
21 matches
Mail list logo
