Re: RFR: JDK-8294702 - BufferedInputStream uses undefined value range for markpos [v2]

2022-10-11 Thread Markus KARG
On Tue, 11 Oct 2022 15:40:36 GMT, Brian Burkhalter wrote: >> Markus KARG has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Modified to < 0 as proposed by Alan Batement > > Marked as reviewed by bpb (Reviewer). @bplb Kindly requesting to r

Re: RFR: JDK-8294702 - BufferedInputStream uses undefined value range for markpos [v2]

2022-10-11 Thread Brian Burkhalter
On Tue, 4 Oct 2022 15:53:04 GMT, Alan Bateman wrote: >> This is true, but if a broken subclass sets markpos to less than -1 then >> lots of code lines will work incorrectly -- including `transferTo` which was >> the starting point of your change proposal. So do you really only want undo >> the

Re: RFR: JDK-8294702 - BufferedInputStream uses undefined value range for markpos [v2]

2022-10-11 Thread Brian Burkhalter
On Sun, 9 Oct 2022 14:08:40 GMT, Markus KARG wrote: >> Fixes JDK-8294702 > > Markus KARG has updated the pull request incrementally with one additional > commit since the last revision: > > Modified to < 0 as proposed by Alan Batement Marked as reviewed by bpb (Reviewer). - PR:

Re: RFR: JDK-8294702 - BufferedInputStream uses undefined value range for markpos [v2]

2022-10-11 Thread Markus KARG
On Tue, 4 Oct 2022 15:53:04 GMT, Alan Bateman wrote: >> This is true, but if a broken subclass sets markpos to less than -1 then >> lots of code lines will work incorrectly -- including `transferTo` which was >> the starting point of your change proposal. So do you really only want undo >> the

Re: RFR: JDK-8294702 - BufferedInputStream uses undefined value range for markpos [v2]

2022-10-10 Thread Brian Burkhalter
On Sun, 9 Oct 2022 14:04:45 GMT, Markus KARG wrote: >>> This is true, but if a broken subclass sets markpos to less than -1 then >>> lots of code lines will work incorrectly -- including `transferTo` which >>> was the starting point of your change proposal. So do you really only want >>> undo

Re: RFR: JDK-8294702 - BufferedInputStream uses undefined value range for markpos [v2]

2022-10-09 Thread Markus KARG
On Tue, 4 Oct 2022 15:53:04 GMT, Alan Bateman wrote: >> This is true, but if a broken subclass sets markpos to less than -1 then >> lots of code lines will work incorrectly -- including `transferTo` which was >> the starting point of your change proposal. So do you really only want undo >> the

Re: RFR: JDK-8294702 - BufferedInputStream uses undefined value range for markpos [v2]

2022-10-09 Thread Markus KARG
> Fixes JDK-8294702 Markus KARG has updated the pull request incrementally with one additional commit since the last revision: Modified to < 0 as proposed by Alan Batement - Changes: - all: https://git.openjdk.org/jdk/pull/10528/files - new: https://git.openjdk.org/jdk/pull/1

Re: RFR: JDK-8294702 - BufferedInputStream uses undefined value range for markpos

2022-10-04 Thread Alan Bateman
On Tue, 4 Oct 2022 15:44:48 GMT, Markus KARG wrote: >> src/java.base/share/classes/java/io/BufferedInputStream.java line 546: >> >>> 544: private void implReset() throws IOException { >>> 545: getBufIfOpen(); // Cause exception if closed >>> 546: if (markpos == -1) >> >> Jus

Re: RFR: JDK-8294702 - BufferedInputStream uses undefined value range for markpos

2022-10-04 Thread Markus KARG
On Tue, 4 Oct 2022 06:55:11 GMT, Alan Bateman wrote: >> Fixes JDK-8294702 > > src/java.base/share/classes/java/io/BufferedInputStream.java line 546: > >> 544: private void implReset() throws IOException { >> 545: getBufIfOpen(); // Cause exception if closed >> 546: if (markpo

Re: RFR: JDK-8294702 - BufferedInputStream uses undefined value range for markpos

2022-10-03 Thread Alan Bateman
On Mon, 3 Oct 2022 07:29:02 GMT, Markus KARG wrote: > Fixes JDK-8294702 src/java.base/share/classes/java/io/BufferedInputStream.java line 546: > 544: private void implReset() throws IOException { > 545: getBufIfOpen(); // Cause exception if closed > 546: if (markpos == -1)

Re: RFR: JDK-8294702 - BufferedInputStream uses undefined value range for markpos

2022-10-03 Thread Markus KARG
On Mon, 3 Oct 2022 08:26:00 GMT, Alan Bateman wrote: >> Fixes JDK-8294702 > > This looks fine, just change the description to "BufferedInputStream uses > undefined ..." as this issue is nothing to do with transferTo. @AlanBateman Kindly requesting `/sponsor`: -) - PR: https://git.

Re: RFR: JDK-8294702 - BufferedInputStream uses undefined value range for markpos

2022-10-03 Thread Markus KARG
On Mon, 3 Oct 2022 08:26:00 GMT, Alan Bateman wrote: > This looks fine, just change the description to "BufferedInputStream uses > undefined ..." as this issue is nothing to do with transferTo. Done. Thanks! :-) - PR: https://git.openjdk.org/jdk/pull/10528