Re: RFR: JDK-8293450 Convert test/closed/sun/management/ shell tests to Java version

2022-11-08 Thread Serguei Spitsyn
On Mon, 7 Nov 2022 19:23:05 GMT, Bill Huang wrote: > There is no new changes in the open portion of JDK, but extracting common > functionalities in bootstrap Utils to test/lib/Utils which can be used in the > closed part. test/lib/jdk/test/lib/Utils.java line 1007: > 1005:

Re: RFR: JDK-8293450 Convert test/closed/sun/management/ shell tests to Java version

2022-11-08 Thread Serguei Spitsyn
On Mon, 7 Nov 2022 19:23:05 GMT, Bill Huang wrote: > There is no new changes in the open portion of JDK, but extracting common > functionalities in bootstrap Utils to test/lib/Utils which can be used in the > closed part. I've placed a couple of comments. Otherwise, it looks okay to me. Thanks

Re: RFR: JDK-8293450 Convert test/closed/sun/management/ shell tests to Java version

2022-11-08 Thread Serguei Spitsyn
On Mon, 7 Nov 2022 19:23:05 GMT, Bill Huang wrote: > There is no new changes in the open portion of JDK, but extracting common > functionalities in bootstrap Utils to test/lib/Utils which can be used in the > closed part. test/lib/jdk/test/lib/Utils.java line 980: > 978:

Re: RFR: JDK-8293450 Convert test/closed/sun/management/ shell tests to Java version

2022-11-07 Thread Bill Huang
On Mon, 7 Nov 2022 23:20:15 GMT, Serguei Spitsyn wrote: >> There is no new changes in the open portion of JDK, but extracting common >> functionalities in bootstrap Utils to test/lib/Utils which can be used in >> the closed part. > > The refactoring looks pretty good. > But I have a couple of q

Re: RFR: JDK-8293450 Convert test/closed/sun/management/ shell tests to Java version

2022-11-07 Thread Serguei Spitsyn
On Mon, 7 Nov 2022 19:23:05 GMT, Bill Huang wrote: > There is no new changes in the open portion of JDK, but extracting common > functionalities in bootstrap Utils to test/lib/Utils which can be used in the > closed part. The refactoring looks pretty good. But I have a couple of questions. Q1:

RFR: JDK-8293450 Convert test/closed/sun/management/ shell tests to Java version

2022-11-07 Thread Bill Huang
There is no new changes in the open portion of JDK, but extracting common functionalities in bootstrap Utils to test/lib/Utils. - Commit messages: - JDK-8293450 Convert test/closed/sun/management/ shell tests to Java version Changes: https://git.openjdk.org/jdk/pull/11029/files We