Re: RFR: JDK-8292427: Improve specification of InflaterInputStream.fill() [v5]

2022-11-03 Thread Volker Simonis
On Wed, 2 Nov 2022 20:42:42 GMT, Lance Andersen wrote: >> Hi all, >> >> This PR will update the javadoc to clarify the existing behavior of >> InflaterInputStream::fill as it currently omits the possibility that a >> EOFException may be thrown and that the protected `len` field is also >> upd

Re: RFR: JDK-8292427: Improve specification of InflaterInputStream.fill() [v5]

2022-11-02 Thread Brian Burkhalter
On Wed, 2 Nov 2022 20:42:42 GMT, Lance Andersen wrote: >> Hi all, >> >> This PR will update the javadoc to clarify the existing behavior of >> InflaterInputStream::fill as it currently omits the possibility that a >> EOFException may be thrown and that the protected `len` field is also >> upd

Re: RFR: JDK-8292427: Improve specification of InflaterInputStream.fill() [v5]

2022-11-02 Thread Alan Bateman
On Wed, 2 Nov 2022 20:42:42 GMT, Lance Andersen wrote: >> Hi all, >> >> This PR will update the javadoc to clarify the existing behavior of >> InflaterInputStream::fill as it currently omits the possibility that a >> EOFException may be thrown and that the protected `len` field is also >> upd

Re: RFR: JDK-8292427: Improve specification of InflaterInputStream.fill() [v4]

2022-11-02 Thread Lance Andersen
On Wed, 2 Nov 2022 20:12:04 GMT, Alan Bateman wrote: > Thanks for the update, this wording looks okay, I'm just wondering if we > should add implSpec as "This method will read ..." is really "Implementation > Specification". Sure thing added the tag - PR: https://git.openjdk.org/

Re: RFR: JDK-8292427: Improve specification of InflaterInputStream.fill() [v5]

2022-11-02 Thread Lance Andersen
> Hi all, > > This PR will update the javadoc to clarify the existing behavior of > InflaterInputStream::fill as it currently omits the possibility that a > EOFException may be thrown and that the protected `len` field is also updated > by this method. Lance Andersen has updated the pull reque

Re: RFR: JDK-8292427: Improve specification of InflaterInputStream.fill() [v4]

2022-11-02 Thread Alan Bateman
On Wed, 2 Nov 2022 19:11:32 GMT, Lance Andersen wrote: >> Hi all, >> >> This PR will update the javadoc to clarify the existing behavior of >> InflaterInputStream::fill as it currently omits the possibility that a >> EOFException may be thrown and that the protected `len` field is also >> upd

Re: RFR: JDK-8292427: Improve specification of InflaterInputStream.fill() [v4]

2022-11-02 Thread Lance Andersen
> Hi all, > > This PR will update the javadoc to clarify the existing behavior of > InflaterInputStream::fill as it currently omits the possibility that a > EOFException may be thrown and that the protected `len` field is also updated > by this method. Lance Andersen has updated the pull reque

Re: RFR: JDK-8292427: Improve specification of InflaterInputStream.fill() [v3]

2022-11-02 Thread Lance Andersen
> Hi all, > > This PR will update the javadoc to clarify the existing behavior of > InflaterInputStream::fill as it currently omits the possibility that a > EOFException may be thrown and that the protected `len` field is also updated > by this method. Lance Andersen has updated the pull reque

Re: RFR: JDK-8292427: Improve specification of InflaterInputStream.fill() [v2]

2022-11-02 Thread Lance Andersen
On Wed, 2 Nov 2022 17:17:40 GMT, Alan Bateman wrote: > I don't think an apiNote will work here as it need to be normative text. I > suspect this issue will require specifying fill to read up to buf.length > bytes into buf starting at element 0 and setting len to the number of bytes. Revised pe

Re: RFR: JDK-8292427: Improve specification of InflaterInputStream.fill() [v2]

2022-11-02 Thread Lance Andersen
> Hi all, > > This PR will update the javadoc to clarify the existing behavior of > InflaterInputStream::fill as it currently omits the possibility that a > EOFException may be thrown and that the protected `len` field is also updated > by this method. Lance Andersen has updated the pull reque

Re: RFR: JDK-8292427: Improve specification of InflaterInputStream.fill()

2022-11-02 Thread Alan Bateman
On Wed, 2 Nov 2022 12:37:26 GMT, Lance Andersen wrote: > Hi all, > > This PR will update the javadoc to clarify the existing behavior of > InflaterInputStream::fill as it currently omits the possibility that a > EOFException may be thrown and that the protected `len` field is also updated > b

Re: RFR: JDK-8292427: Improve specification of InflaterInputStream.fill()

2022-11-02 Thread Brian Burkhalter
On Wed, 2 Nov 2022 12:37:26 GMT, Lance Andersen wrote: > Hi all, > > This PR will update the javadoc to clarify the existing behavior of > InflaterInputStream::fill as it currently omits the possibility that a > EOFException may be thrown and that the protected `len` field is also updated > b

RFR: JDK-8292427: Improve specification of InflaterInputStream.fill()

2022-11-02 Thread Lance Andersen
Hi all, This PR will update the javadoc to clarify the existing behavior of InflaterInputStream::fill as it currently omits the possibility that a EOFException may be thrown and that the protected `len` field is also updated by this method. - Commit messages: - Clarify the javado