Re: RFR: JDK-8262994: Refactor String.split to help method inlining [v2]

2023-01-29 Thread Christian Wimmer
On Sun, 29 Jan 2023 16:07:08 GMT, Peter Levart wrote: >> Christian Wimmer has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Add comment about method inlining > > Hi Christian, I can sponsor to pull this change if you like. @plevart yes p

Re: RFR: JDK-8262994: Refactor String.split to help method inlining [v2]

2023-01-29 Thread Peter Levart
On Mon, 9 Jan 2023 20:04:34 GMT, Christian Wimmer wrote: >> The method `String.split` contains a fast-path when the regular expression >> parameter is not really a regular expression, but just a single split >> character. >> This fast path vs. slow path check can be constant folded when the reg

Re: RFR: JDK-8262994: Refactor String.split to help method inlining [v2]

2023-01-23 Thread Naoto Sato
On Mon, 9 Jan 2023 20:04:34 GMT, Christian Wimmer wrote: >> The method `String.split` contains a fast-path when the regular expression >> parameter is not really a regular expression, but just a single split >> character. >> This fast path vs. slow path check can be constant folded when the reg

Re: RFR: JDK-8262994: Refactor String.split to help method inlining [v2]

2023-01-23 Thread Peter Levart
On Mon, 9 Jan 2023 20:04:34 GMT, Christian Wimmer wrote: >> The method `String.split` contains a fast-path when the regular expression >> parameter is not really a regular expression, but just a single split >> character. >> This fast path vs. slow path check can be constant folded when the reg

Re: RFR: JDK-8262994: Refactor String.split to help method inlining [v2]

2023-01-23 Thread Christian Wimmer
On Mon, 9 Jan 2023 20:04:34 GMT, Christian Wimmer wrote: >> The method `String.split` contains a fast-path when the regular expression >> parameter is not really a regular expression, but just a single split >> character. >> This fast path vs. slow path check can be constant folded when the reg

Re: RFR: JDK-8262994: Refactor String.split to help method inlining [v2]

2023-01-09 Thread Christian Wimmer
On Tue, 27 Dec 2022 23:36:52 GMT, Ismael Juma wrote: >> Christian Wimmer has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Add comment about method inlining > > src/java.base/share/classes/java/lang/String.java line 3133: > >> 3131:

Re: RFR: JDK-8262994: Refactor String.split to help method inlining [v2]

2023-01-09 Thread Christian Wimmer
> The method `String.split` contains a fast-path when the regular expression > parameter is not really a regular expression, but just a single split > character. > This fast path vs. slow path check can be constant folded when the regular > expression parameter is a literal constant - a quite fr