Re: RFR: JDK-8173605: Remove support for source and target 1.7 option in javac [v2]

2022-08-31 Thread Joe Darcy
> Update to remove support for -source/-target/--release 7 from javac. > > As seen in the PR, many test fails are affected. Further refactorings of > javac's implementation that can be made from dropping 7 support are left as > future work. Joe Darcy has updated the pull request with a new targ

Re: RFR: JDK-8173605: Remove support for source and target 1.7 option in javac

2022-08-31 Thread Joe Darcy
On Wed, 31 Aug 2022 17:13:04 GMT, Vicente Romero wrote: > the PR looks good to me. You have mentioned that further refactorings could > be done later on, I agree but you are already removing a lot of code, > although that could have been forced to make some tests pass. I would > recommend remo

Re: RFR: JDK-8173605: Remove support for source and target 1.7 option in javac

2022-08-31 Thread Vicente Romero
On Tue, 30 Aug 2022 00:04:03 GMT, Joe Darcy wrote: > Update to remove support for -source/-target/--release 7 from javac. > > As seen in the PR, many test fails are affected. Further refactorings of > javac's implementation that can be made from dropping 7 support are left as > future work. l

Re: RFR: JDK-8173605: Remove support for source and target 1.7 option in javac

2022-08-30 Thread Joe Darcy
On Tue, 30 Aug 2022 06:26:25 GMT, Alan Bateman wrote: >> Update to remove support for -source/-target/--release 7 from javac. >> >> As seen in the PR, many test fails are affected. Further refactorings of >> javac's implementation that can be made from dropping 7 support are left as >> future

Re: RFR: JDK-8173605: Remove support for source and target 1.7 option in javac

2022-08-29 Thread Alan Bateman
On Tue, 30 Aug 2022 00:04:03 GMT, Joe Darcy wrote: > Update to remove support for -source/-target/--release 7 from javac. > > As seen in the PR, many test fails are affected. Further refactorings of > javac's implementation that can be made from dropping 7 support are left as > future work. t

Re: RFR: JDK-8173605: Remove support for source and target 1.7 option in javac

2022-08-29 Thread Joe Darcy
On Tue, 30 Aug 2022 00:16:09 GMT, Joe Darcy wrote: > Please also review the accompanying CSR: > > https://bugs.openjdk.org/browse/JDK-8293047 > > Note that the DEFAULT_METHODS enum constant is used indirectly by a test to > force a class file's minor version bits to be set as if a preview feat

Re: RFR: JDK-8173605: Remove support for source and target 1.7 option in javac

2022-08-29 Thread Joe Darcy
On Tue, 30 Aug 2022 00:04:03 GMT, Joe Darcy wrote: > Update to remove support for -source/-target/--release 7 from javac. > > As seen in the PR, many test fails are affected. Further refactorings of > javac's implementation that can be made from dropping 7 support are left as > future work. P

RFR: JDK-8173605: Remove support for source and target 1.7 option in javac

2022-08-29 Thread Joe Darcy
Update to remove support for -source/-target/--release 7 from javac. As seen in the PR, many test fails are affected. Further refactorings of javac's implementation that can be made from dropping 7 support are left as future work. - Commit messages: - Small refactoring to remove m