On Thu, 19 Oct 2023 11:43:57 GMT, Mahendra Chhipa wrote:
>> Test is updated to create the binary files during test execution.
>
> Mahendra Chhipa has updated the pull request incrementally with one
> additional commit since the last revision:
>
> Added indentation to generate the properly ind
On Fri, 21 Apr 2023 13:33:37 GMT, Mahendra Chhipa wrote:
>> Mahendra Chhipa has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Implemented the review comment.
>
> Thanks for your review comments. I will implement them and push again.
> @ma
On Fri, 21 Apr 2023 13:33:37 GMT, Mahendra Chhipa wrote:
>> Mahendra Chhipa has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Implemented the review comment.
>
> Thanks for your review comments. I will implement them and push again.
@mahe
On Wed, 18 Oct 2023 14:55:13 GMT, Roger Riggs wrote:
>> Mahendra Chhipa has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Corrected use of whitespace in text block.
>
> test/jdk/javax/xml/jaxp/datatype/8033980/GregorianCalAndDurSerDataUtil
> Test is updated to create the binary files during test execution.
Mahendra Chhipa has updated the pull request incrementally with one additional
commit since the last revision:
Added indentation to generate the properly indented code.
Revert back to Formatter class from HexFormat class, so
On Sun, 15 Oct 2023 16:36:33 GMT, Mahendra Chhipa wrote:
>> Test is updated to create the binary files during test execution.
>
> Mahendra Chhipa has updated the pull request incrementally with one
> additional commit since the last revision:
>
> Corrected use of whitespace in text block.
Pl
> Test is updated to create the binary files during test execution.
Mahendra Chhipa has updated the pull request incrementally with one additional
commit since the last revision:
Corrected use of whitespace in text block.
-
Changes:
- all: https://git.openjdk.org/jdk/pull/13537
> Test is updated to create the binary files during test execution.
Mahendra Chhipa has updated the pull request incrementally with two additional
commits since the last revision:
- Removed commented code.
- Use of HexFormatter clas instead of Formatter.
Addition of copyright section in aut
On Fri, 13 Oct 2023 12:21:28 GMT, Mahendra Chhipa wrote:
>> Test is updated to create the binary files during test execution.
>
> Mahendra Chhipa has updated the pull request incrementally with one
> additional commit since the last revision:
>
> Tests with base64 input are removed.
test/jdk
On Fri, 13 Oct 2023 12:21:28 GMT, Mahendra Chhipa wrote:
>> Test is updated to create the binary files during test execution.
>
> Mahendra Chhipa has updated the pull request incrementally with one
> additional commit since the last revision:
>
> Tests with base64 input are removed.
test/jdk
> Test is updated to create the binary files during test execution.
Mahendra Chhipa has updated the pull request incrementally with one additional
commit since the last revision:
Tests with base64 input are removed.
-
Changes:
- all: https://git.openjdk.org/jdk/pull/13537/files
On Wed, 11 Oct 2023 19:27:46 GMT, Joe Wang wrote:
> Thanks for the update.
>
> I'm not sure it's necessary to repeat tests with Base64 input. I think
> Daniel's comment was that the data can be optionally base64-encoded into a
> string, not that the tests needed to be duplicated.
>
> The gene
On Mon, 9 Oct 2023 14:42:33 GMT, Mahendra Chhipa wrote:
>> Test is updated to create the binary files during test execution.
>
> Mahendra Chhipa has updated the pull request with a new target base due to a
> merge or a rebase. The incremental webrev excludes the unrelated changes
> brought in b
> Test is updated to create the binary files during test execution.
Mahendra Chhipa has updated the pull request with a new target base due to a
merge or a rebase. The incremental webrev excludes the unrelated changes
brought in by the merge/rebase. The pull request contains 10 additional commit
On Wed, 10 May 2023 14:52:58 GMT, Mahendra Chhipa wrote:
>> Test is updated to create the binary files during test execution.
>
> Mahendra Chhipa has updated the pull request incrementally with one
> additional commit since the last revision:
>
> Implemented the review comments.
Apologies fo
On Wed, 10 May 2023 14:41:02 GMT, Mahendra Chhipa wrote:
>> test/jdk/javax/xml/jaxp/datatype/8033980/SerializationTest.java line 232:
>>
>>> 230: * JDKGregorianCalendarAndDurationSerData.java files.
>>> 231: * @param baos
>>> 232: */
>>
>> I think there needs to be a general comm
> Test is updated to create the binary files during test execution.
Mahendra Chhipa has updated the pull request incrementally with one additional
commit since the last revision:
Implemented the review comments.
-
Changes:
- all: https://git.openjdk.org/jdk/pull/13537/files
-
On Fri, 5 May 2023 21:50:06 GMT, Lance Andersen wrote:
>> Mahendra Chhipa has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Move the pseudo code generation part from setup() to seperate methods.
>
> test/jdk/javax/xml/jaxp/datatype/8033980
On Wed, 3 May 2023 14:12:33 GMT, Mahendra Chhipa wrote:
>> Test is updated to create the binary files during test execution.
>
> Mahendra Chhipa has updated the pull request incrementally with one
> additional commit since the last revision:
>
> Move the pseudo code generation part from setup
On Tue, 2 May 2023 16:27:25 GMT, Lance Andersen wrote:
>> This is added in setup method to create the serialized data with current JDK
>> version (JDK under test). In addition to serialized data generated with old
>> JDK version.
>
> Sorry, I still disagree with this. Your comment in the test
> Test is updated to create the binary files during test execution.
Mahendra Chhipa has updated the pull request incrementally with one additional
commit since the last revision:
Move the pseudo code generation part from setup() to seperate methods.
-
Changes:
- all: https://gi
On Tue, 2 May 2023 14:05:03 GMT, Mahendra Chhipa wrote:
>> test/jdk/javax/xml/jaxp/datatype/8033980/SerializationTest.java line 85:
>>
>>> 83:
>>> 84: // Generates the Java Pseudo code for base64 encoded string
>>> that can be cut & pasted into the test
>>> 85: final StringBuil
> Test is updated to create the binary files during test execution.
Mahendra Chhipa has updated the pull request incrementally with one additional
commit since the last revision:
1. Added JDK version in Data files.
2. Updated copyright year.
-
Changes:
- all: https://git.open
On Fri, 28 Apr 2023 18:43:32 GMT, Joe Wang wrote:
>> Mahendra Chhipa has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Implemented the review comments.
>
> test/jdk/javax/xml/jaxp/datatype/8033980/SerializationTest.java line 2:
>
>> 1: /*
On Sat, 29 Apr 2023 16:15:58 GMT, Lance Andersen wrote:
>> Mahendra Chhipa has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Implemented the review comments.
>
> test/jdk/javax/xml/jaxp/datatype/8033980/SerializationTest.java line 85:
>
>
On Thu, 27 Apr 2023 17:35:12 GMT, Mahendra Chhipa wrote:
>> Test is updated to create the binary files during test execution.
>
> Mahendra Chhipa has updated the pull request incrementally with one
> additional commit since the last revision:
>
> Implemented the review comments.
test/jdk/jav
On Thu, 27 Apr 2023 17:35:12 GMT, Mahendra Chhipa wrote:
>> Test is updated to create the binary files during test execution.
>
> Mahendra Chhipa has updated the pull request incrementally with one
> additional commit since the last revision:
>
> Implemented the review comments.
Looks ok. Pr
> Test is updated to create the binary files during test execution.
Mahendra Chhipa has updated the pull request incrementally with one additional
commit since the last revision:
Implemented the review comments.
-
Changes:
- all: https://git.openjdk.org/jdk/pull/13537/files
-
On Thu, 20 Apr 2023 10:06:33 GMT, Mahendra Chhipa wrote:
>> Test is updated to create the binary files during test execution.
>
> Mahendra Chhipa has updated the pull request incrementally with one
> additional commit since the last revision:
>
> Implemented the review comment.
Thanks for yo
On Thu, 20 Apr 2023 16:20:18 GMT, Daniel Fuchs wrote:
> > The original version of this test was validating serialization
> > compatibility with previous releases.
> > The current changes seems to have removed that validation in the re-write
> > of the test
> > One option is to convert the vario
On Thu, 20 Apr 2023 16:06:36 GMT, Lance Andersen wrote:
> The original version of this test was validating serialization compatibility
> with previous releases.
>
> The current changes seems to have removed that validation in the re-write of
> the test
>
> One option is to convert the various
On Thu, 20 Apr 2023 10:06:33 GMT, Mahendra Chhipa wrote:
>> Test is updated to create the binary files during test execution.
>
> Mahendra Chhipa has updated the pull request incrementally with one
> additional commit since the last revision:
>
> Implemented the review comment.
The original
> Test is updated to create the binary files during test execution.
Mahendra Chhipa has updated the pull request incrementally with one additional
commit since the last revision:
Implemented the review comment.
-
Changes:
- all: https://git.openjdk.org/jdk/pull/13537/files
-
On Wed, 19 Apr 2023 17:32:49 GMT, Mahendra Chhipa wrote:
>> Test is updated to create the binary files during test execution.
>
> Mahendra Chhipa has updated the pull request incrementally with one
> additional commit since the last revision:
>
> closed file handlers.
Looks good overall
tes
> Test is updated to create the binary files during test execution.
Mahendra Chhipa has updated the pull request incrementally with one additional
commit since the last revision:
closed file handlers.
-
Changes:
- all: https://git.openjdk.org/jdk/pull/13537/files
- new: https
Test is updated to create the binary files during test execution.
-
Commit messages:
- JDK-8077371: Binary files in JAXP test should be removed
Changes: https://git.openjdk.org/jdk/pull/13537/files
Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=13537&range=00
Issue: https://bug
36 matches
Mail list logo
