Re: RFR: 8361076: Add benchmark for ImageReader in preparation for Valhalla changes [v4]

2025-07-16 Thread Chen Liang
On Tue, 1 Jul 2025 17:02:27 GMT, David Beaumont wrote: >> Initial benchmark to capture at least some comparative measures of >> ImageReader performance. >> >> Current results on my laptop: >> >> Benchmark Mode Cnt ScoreError >> Units >> NewImage

Re: RFR: 8361076: Add benchmark for ImageReader in preparation for Valhalla changes [v4]

2025-07-16 Thread Chen Liang
On Tue, 1 Jul 2025 17:02:27 GMT, David Beaumont wrote: >> Initial benchmark to capture at least some comparative measures of >> ImageReader performance. >> >> Current results on my laptop: >> >> Benchmark Mode Cnt ScoreError >> Units >> NewImage

Re: RFR: 8361076: Add benchmark for ImageReader in preparation for Valhalla changes [v4]

2025-07-16 Thread Severin Gehwolf
On Tue, 15 Jul 2025 21:27:16 GMT, David Beaumont wrote: > Oddly while the status at the bottom of the conversation says it has "2 > approvals", the tickbox: > > ``` > Change must be properly reviewed (2 reviews required, with at least 1 > Reviewer, 1 Author > ``` > > is not checked. I can try

Re: RFR: 8361076: Add benchmark for ImageReader in preparation for Valhalla changes [v3]

2025-07-16 Thread David Beaumont
On Wed, 16 Jul 2025 06:03:28 GMT, Alan Bateman wrote: >> Debatable. It's obviously going to scale any results somewhat based on the >> size of the resources and number of classes. It's kind nice to see "this >> change removes at least N micro/milli seconds of time spent" since that's a >> mini

Re: RFR: 8361076: Add benchmark for ImageReader in preparation for Valhalla changes [v3]

2025-07-15 Thread Alan Bateman
On Tue, 1 Jul 2025 16:50:09 GMT, David Beaumont wrote: >> test/micro/org/openjdk/bench/jdk/internal/jrtfs/ImageReaderBenchmark.java >> line 230: >> >>> 228: // Created by running "java -verbose:class", throwing away >>> anonymous inner >>> 229: // classes and anything without a reliabl

Re: RFR: 8361076: Add benchmark for ImageReader in preparation for Valhalla changes [v4]

2025-07-15 Thread David Beaumont
On Tue, 1 Jul 2025 17:02:27 GMT, David Beaumont wrote: >> Initial benchmark to capture at least some comparative measures of >> ImageReader performance. >> >> Current results on my laptop: >> >> Benchmark Mode Cnt ScoreError >> Units >> NewImage

Re: RFR: 8361076: Add benchmark for ImageReader in preparation for Valhalla changes [v4]

2025-07-14 Thread Roger Riggs
On Tue, 1 Jul 2025 17:02:27 GMT, David Beaumont wrote: >> Initial benchmark to capture at least some comparative measures of >> ImageReader performance. >> >> Current results on my laptop: >> >> Benchmark Mode Cnt ScoreError >> Units >> NewImage

Re: RFR: 8361076: Add benchmark for ImageReader in preparation for Valhalla changes [v4]

2025-07-01 Thread David Beaumont
> Initial benchmark to capture at least some comparative measures of > ImageReader performance. > > Current results on my laptop: > > Benchmark Mode Cnt ScoreError > Units > NewImageBenchmark.warmCache_CountAllNodes avgt5 0.785 ± 0.

Re: RFR: 8361076: Add benchmark for ImageReader in preparation for Valhalla changes [v3]

2025-07-01 Thread David Beaumont
On Tue, 1 Jul 2025 07:25:35 GMT, Alan Bateman wrote: >> David Beaumont has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Some tidying up relating to the state objects. > > test/micro/org/openjdk/bench/jdk/internal/jrtfs/ImageReaderBenchmar

Re: RFR: 8361076: Add benchmark for ImageReader in preparation for Valhalla changes [v3]

2025-07-01 Thread Alan Bateman
On Mon, 30 Jun 2025 15:08:25 GMT, David Beaumont wrote: >> Initial benchmark to capture at least some comparative measures of >> ImageReader performance. >> >> Current results on my laptop: >> >> Benchmark Mode Cnt ScoreError >> Units >> NewImag

Re: RFR: 8361076: Add benchmark for ImageReader in preparation for Valhalla changes [v3]

2025-06-30 Thread Magnus Ihse Bursie
On Mon, 30 Jun 2025 15:08:25 GMT, David Beaumont wrote: >> Initial benchmark to capture at least some comparative measures of >> ImageReader performance. >> >> Current results on my laptop: >> >> Benchmark Mode Cnt ScoreError >> Units >> NewImag

Re: RFR: 8361076: Add benchmark for ImageReader in preparation for Valhalla changes [v3]

2025-06-30 Thread David Beaumont
> Initial benchmark to capture at least some comparative measures of > ImageReader performance. > > Current results on my laptop: > > Benchmark Mode Cnt ScoreError > Units > NewImageBenchmark.warmCache_CountAllNodes avgt5 0.785 ± 0.

Re: RFR: 8361076: Add benchmark for ImageReader in preparation for Valhalla changes [v2]

2025-06-30 Thread David Beaumont
On Mon, 30 Jun 2025 13:18:19 GMT, David Beaumont wrote: >> Initial benchmark to capture at least some comparative measures of >> ImageReader performance. >> >> Current results on my laptop: >> >> Benchmark Mode Cnt ScoreError >> Units >> NewImag

Re: RFR: 8361076: Add benchmark for ImageReader in preparation for Valhalla changes [v2]

2025-06-30 Thread David Beaumont
> Initial benchmark to capture at least some comparative measures of > ImageReader performance. > > Current results on my laptop: > > Benchmark Mode Cnt ScoreError > Units > NewImageBenchmark.warmCache_CountAllNodes avgt5 0.785 ± 0.

Re: RFR: 8361076: Add benchmark for ImageReader in preparation for Valhalla changes

2025-06-30 Thread David Beaumont
On Mon, 30 Jun 2025 12:27:40 GMT, David Beaumont wrote: > Initial benchmark to capture at least some comparative measures of > ImageReader performance. > > Current results on my laptop: > > Benchmark Mode Cnt ScoreError > Units > NewImageBenchma

Re: RFR: 8361076: Add benchmark for ImageReader in preparation for Valhalla changes

2025-06-30 Thread David Beaumont
On Mon, 30 Jun 2025 12:27:40 GMT, David Beaumont wrote: > Initial benchmark to capture at least some comparative measures of > ImageReader performance. > > Current results on my laptop: > > Benchmark Mode Cnt ScoreError > Units > NewImageBenchma

RFR: 8361076: Add benchmark for ImageReader in preparation for Valhalla changes

2025-06-30 Thread David Beaumont
Initial benchmark to capture at least some comparative measures of ImageReader performance. Current results on my laptop: Benchmark Mode Cnt ScoreError Units NewImageBenchmark.warmCache_CountAllNodes avgt5 0.785 ± 0.140 ms/op NewI