Re: RFR: 8360122: Fix java.sql\Connection.java indentation [v6]

2025-07-09 Thread Chen Liang
On Tue, 8 Jul 2025 20:45:20 GMT, simon wrote: >> 8360122: Refine formatting of Connection.java interface >> >> - >> ### Progress >> - [x] Change must be properly reviewed (1 review required, with at least 1 >> [Reviewer](https://openjdk.org/bylaws#reviewer)) >> - [x] Change must not con

Re: RFR: 8360122: Fix java.sql\Connection.java indentation [v6]

2025-07-09 Thread duke
On Tue, 8 Jul 2025 20:45:20 GMT, simon wrote: >> 8360122: Refine formatting of Connection.java interface >> >> - >> ### Progress >> - [x] Change must be properly reviewed (1 review required, with at least 1 >> [Reviewer](https://openjdk.org/bylaws#reviewer)) >> - [x] Change must not con

Re: RFR: 8360122: Fix java.sql\Connection.java indentation [v6]

2025-07-09 Thread simon
On Wed, 9 Jul 2025 19:38:21 GMT, Chen Liang wrote: >>> The changes are OK. >> >> Great, @LanceAndersen! Thanks for reviewing. 😃 >> >> Can you integrate it when you think it is appropriate? I guess I do not have >> permission to do it. > >> Can you integrate it when you think it is appropriate

Re: RFR: 8360122: Fix java.sql\Connection.java indentation [v6]

2025-07-09 Thread Chen Liang
On Wed, 9 Jul 2025 19:35:54 GMT, simon wrote: > Can you integrate it when you think it is appropriate? I guess I do not have > permission to do it. They are done with GitHub comments parsed by bots, so if there is a line: > /integrate in a comment from you, the bot will integrate this patch (

Re: RFR: 8360122: Fix java.sql\Connection.java indentation [v6]

2025-07-09 Thread simon
On Wed, 9 Jul 2025 18:59:49 GMT, Lance Andersen wrote: > The changes are OK. Great, @LanceAndersen! Thanks for reviewing. 😃 Can you integrate it when you think it is appropriate? I guess I do not have permission to do it. - PR Comment: https://git.openjdk.org/jdk/pull/25925#issu

Re: RFR: 8360122: Fix java.sql\Connection.java indentation [v6]

2025-07-09 Thread Lance Andersen
On Tue, 8 Jul 2025 20:45:20 GMT, simon wrote: >> 8360122: Refine formatting of Connection.java interface >> >> - >> ### Progress >> - [x] Change must be properly reviewed (1 review required, with at least 1 >> [Reviewer](https://openjdk.org/bylaws#reviewer)) >> - [x] Change must not con

Re: RFR: 8360122: Fix java.sql\Connection.java indentation [v6]

2025-07-08 Thread simon
> 8360122: Refine formatting of Connection.java interface > > - > ### Progress > - [ ] Change must be properly reviewed (1 review required, with at least 1 > [Reviewer](https://openjdk.org/bylaws#reviewer)) > - [x] Change must not contain extraneous whitespace > - [x] Commit message must