Re: RFR: 8358804: Improve the API Note of BigDecimal.valueOf(double) [v2]

2025-06-14 Thread Iris Clark
On Fri, 13 Jun 2025 21:46:42 GMT, Raffaello Giulietti wrote: >> Documenting a suggestion for `float` arguments. > > Raffaello Giulietti has updated the pull request incrementally with one > additional commit since the last revision: > > Suggestion by reviewer. Marked as reviewed by iris (Re

Re: RFR: 8358804: Improve the API Note of BigDecimal.valueOf(double) [v2]

2025-06-13 Thread Joe Darcy
On Fri, 13 Jun 2025 21:46:42 GMT, Raffaello Giulietti wrote: >> Documenting a suggestion for `float` arguments. > > Raffaello Giulietti has updated the pull request incrementally with one > additional commit since the last revision: > > Suggestion by reviewer. Marked as reviewed by darcy (R

Re: RFR: 8358804: Improve the API Note of BigDecimal.valueOf(double) [v2]

2025-06-13 Thread Brian Burkhalter
On Fri, 13 Jun 2025 21:46:42 GMT, Raffaello Giulietti wrote: >> Documenting a suggestion for `float` arguments. > > Raffaello Giulietti has updated the pull request incrementally with one > additional commit since the last revision: > > Suggestion by reviewer. Marked as reviewed by bpb (Rev

Re: RFR: 8358804: Improve the API Note of BigDecimal.valueOf(double) [v2]

2025-06-13 Thread Raffaello Giulietti
> Documenting a suggestion for `float` arguments. Raffaello Giulietti has updated the pull request incrementally with one additional commit since the last revision: Suggestion by reviewer. - Changes: - all: https://git.openjdk.org/jdk/pull/25805/files - new: https://git.openj

Re: RFR: 8358804: Improve the API Note of BigDecimal.valueOf(double)

2025-06-13 Thread Joe Darcy
On Fri, 13 Jun 2025 15:21:38 GMT, Raffaello Giulietti wrote: > Documenting a suggestion for `float` arguments. src/java.base/share/classes/java/math/BigDecimal.java line 1380: > 1378: * Double#toString(double)}. > 1379: * > 1380: * While a {@code float} argument {@code v} can b

Re: RFR: 8358804: Improve the API Note of BigDecimal.valueOf(double)

2025-06-13 Thread Joe Darcy
On Fri, 13 Jun 2025 18:39:14 GMT, Brian Burkhalter wrote: >> I usually start a sentence on a new line because that generates less noise >> when diffing in the future. >> The HTML renders it in the same paragraph as the preceding text. > > Makes sense. > I usually start a sentence on a new line

Re: RFR: 8358804: Improve the API Note of BigDecimal.valueOf(double)

2025-06-13 Thread Brian Burkhalter
On Fri, 13 Jun 2025 18:10:03 GMT, Raffaello Giulietti wrote: >> src/java.base/share/classes/java/math/BigDecimal.java line 1383: >> >>> 1381: * the result usually contains too many trailing digits compared >>> 1382: * to the precision of a {@code float}. >>> 1383: * Consider usin

Re: RFR: 8358804: Improve the API Note of BigDecimal.valueOf(double)

2025-06-13 Thread Brian Burkhalter
On Fri, 13 Jun 2025 15:21:38 GMT, Raffaello Giulietti wrote: > Documenting a suggestion for `float` arguments. Marked as reviewed by bpb (Reviewer). - PR Review: https://git.openjdk.org/jdk/pull/25805#pullrequestreview-2925970196

Re: RFR: 8358804: Improve the API Note of BigDecimal.valueOf(double)

2025-06-13 Thread Raffaello Giulietti
On Fri, 13 Jun 2025 17:39:38 GMT, Brian Burkhalter wrote: >> Documenting a suggestion for `float` arguments. > > src/java.base/share/classes/java/math/BigDecimal.java line 1383: > >> 1381: * the result usually contains too many trailing digits compared >> 1382: * to the precision of a

Re: RFR: 8358804: Improve the API Note of BigDecimal.valueOf(double)

2025-06-13 Thread Brian Burkhalter
On Fri, 13 Jun 2025 15:21:38 GMT, Raffaello Giulietti wrote: > Documenting a suggestion for `float` arguments. src/java.base/share/classes/java/math/BigDecimal.java line 1383: > 1381: * the result usually contains too many trailing digits compared > 1382: * to the precision of a {@co

RFR: 8358804: Improve the API Note of BigDecimal.valueOf(double)

2025-06-13 Thread Raffaello Giulietti
Documenting a suggestion for `float` arguments. - Commit messages: - 8358804: Improve the API Note of BigDecimal.valueOf(double) Changes: https://git.openjdk.org/jdk/pull/25805/files Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=25805&range=00 Issue: https://bugs.openjdk.org/