Re: RFR: 8358533: Improve performance of java.io.Reader.readAllLines [v4]

2025-06-25 Thread Roger Riggs
On Wed, 25 Jun 2025 19:57:56 GMT, Xueming Shen wrote: >> Fixed in >> [d5abfa4](https://github.com/openjdk/jdk/pull/25863/commits/d5abfa450cb3fcd604560833038735e41952bce9 >> ). > > My apologies if this is a naive question :-) I'm sure this was discussed when > the method was added, so this is ju

Re: RFR: 8358533: Improve performance of java.io.Reader.readAllLines [v4]

2025-06-25 Thread Brian Burkhalter
> Replaces the implementation `readAllCharsAsString().lines().toList()` with > reading into a temporary `char` array which is then processed to detect line > terminators and copy non-terminating characters into strings which are added > to the list. Brian Burkhalter has updated the pull request

Re: RFR: 8358533: Improve performance of java.io.Reader.readAllLines [v4]

2025-06-25 Thread Xueming Shen
On Tue, 24 Jun 2025 18:51:04 GMT, Brian Burkhalter wrote: >> Right, the specification here requires an unmodifiable List, so an >> unmodifiable wrapper or a list from `List.copyOf()` is appropriate. > > Fixed in > [d5abfa4](https://github.com/openjdk/jdk/pull/25863/commits/d5abfa450cb3fcd604560