On Mon, 2 Jun 2025 20:06:34 GMT, Hannes Greule wrote:
>> This change addresses a NPE in javap when trying to print a class with
>> minorVersion != 0. With this change, we fall back to the methods that don't
>> take a `ClassFileFormatVersion` in such case.
>
> Hannes Greule has updated the pull
On Mon, 2 Jun 2025 20:06:34 GMT, Hannes Greule wrote:
>> This change addresses a NPE in javap when trying to print a class with
>> minorVersion != 0. With this change, we fall back to the methods that don't
>> take a `ClassFileFormatVersion` in such case.
>
> Hannes Greule has updated the pull
On Mon, 2 Jun 2025 20:06:34 GMT, Hannes Greule wrote:
>> This change addresses a NPE in javap when trying to print a class with
>> minorVersion != 0. With this change, we fall back to the methods that don't
>> take a `ClassFileFormatVersion` in such case.
>
> Hannes Greule has updated the pull
On Mon, 2 Jun 2025 20:06:34 GMT, Hannes Greule wrote:
>> This change addresses a NPE in javap when trying to print a class with
>> minorVersion != 0. With this change, we fall back to the methods that don't
>> take a `ClassFileFormatVersion` in such case.
>
> Hannes Greule has updated the pull
On Mon, 2 Jun 2025 12:58:15 GMT, Chen Liang wrote:
>> This change addresses a NPE in javap when trying to print a class with
>> minorVersion != 0. With this change, we fall back to the methods that don't
>> take a `ClassFileFormatVersion` in such case.
>
> That sounds right.
@liach is there an
On Mon, 2 Jun 2025 20:44:44 GMT, ExE Boss wrote:
>> Hannes Greule has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> make test failures easier to read
>
> src/jdk.jdeps/share/classes/com/sun/tools/javap/ClassWriter.java line 122:
>
>> 120:
> This change addresses a NPE in javap when trying to print a class with
> minorVersion != 0. With this change, we fall back to the methods that don't
> take a `ClassFileFormatVersion` in such case.
Hannes Greule has updated the pull request incrementally with one additional
commit since the la
On Mon, 2 Jun 2025 20:06:34 GMT, Hannes Greule wrote:
>> This change addresses a NPE in javap when trying to print a class with
>> minorVersion != 0. With this change, we fall back to the methods that don't
>> take a `ClassFileFormatVersion` in such case.
>
> Hannes Greule has updated the pull
On Mon, 2 Jun 2025 17:30:20 GMT, Chen Liang wrote:
>> Hannes Greule has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> don't return null but latest as fallback
>
> test/langtools/tools/javap/ClassFileVersionTest.java line 85:
>
>> 83:
> This change addresses a NPE in javap when trying to print a class with
> minorVersion != 0. With this change, we fall back to the methods that don't
> take a `ClassFileFormatVersion` in such case.
Hannes Greule has updated the pull request incrementally with one additional
commit since the la
On Mon, 2 Jun 2025 16:59:34 GMT, Hannes Greule wrote:
>> This change addresses a NPE in javap when trying to print a class with
>> minorVersion != 0. With this change, we fall back to the methods that don't
>> take a `ClassFileFormatVersion` in such case.
>
> Hannes Greule has updated the pull
On Sun, 1 Jun 2025 04:53:46 GMT, Hannes Greule wrote:
> This change addresses a NPE in javap when trying to print a class with
> minorVersion != 0. With this change, we fall back to the methods that don't
> take a `ClassFileFormatVersion` in such case.
That sounds right.
-
PR Com
On Mon, 2 Jun 2025 00:56:51 GMT, Chen Liang wrote:
> I recommend we fallback to use CFFV.latest() explicitly for now. FYI we will
> likely add a new CFFV for all preview features, which we will likely use as
> the default if we encounter an old preview class file. We can then swap
> latest() w
On Sun, 1 Jun 2025 04:53:46 GMT, Hannes Greule wrote:
> This change addresses a NPE in javap when trying to print a class with
> minorVersion != 0. With this change, we fall back to the methods that don't
> take a `ClassFileFormatVersion` in such case.
I recommend we fallback to use CFFV.lates
This change addresses a NPE in javap when trying to print a class with
minorVersion != 0. With this change, we fall back to the methods that don't
take a `ClassFileFormatVersion` in such case.
-
Commit messages:
- fix
- test
Changes: https://git.openjdk.org/jdk/pull/25569/files
15 matches
Mail list logo
