On Wed, 4 Jun 2025 16:50:15 GMT, Johannes Döbler wrote:
>> Interesting. This `@NoOverride` idea could be useful on a subclass that
>> wants to make sure it overrides everything. (Maybe `@NoInherit` would be a
>> better name.) Meanwhile for JDK-8357272 (PR
>> https://github.com/openjdk/jdk/pull
On Wed, 4 Jun 2025 16:19:23 GMT, Stuart Marks wrote:
>> It would be helpful in situations like this to have the inverse annotation
>> -- "All methods should be overridden, except the ones marked `@NoOverride`".
>
> Interesting. This `@NoOverride` idea could be useful on a subclass that wants
>
On Wed, 4 Jun 2025 04:08:36 GMT, Joe Darcy wrote:
>> The `@Override` annotation has been inconsistently applied in the
>> collections implementations. In practice since so many methods are
>> overridden, and some test would likely fail if a method weren't overridden
>> properly, the annotation
On Wed, 4 Jun 2025 06:24:57 GMT, Stuart Marks wrote:
>> For a full explanation, see the bug report
>> [JDK-8358015](https://bugs.openjdk.org/browse/JDK-8358015).
>>
>> This PR includes three related changes:
>> * New overrides in SequencedMap view collection implementations, which
>> improve t
> For a full explanation, see the bug report
> [JDK-8358015](https://bugs.openjdk.org/browse/JDK-8358015).
>
> This PR includes three related changes:
> * New overrides in SequencedMap view collection implementations, which
> improve their behavior.
> * Update to `@implSpec` clauses to reflect t
On Tue, 3 Jun 2025 20:14:13 GMT, Stuart Marks wrote:
>> src/java.base/share/classes/java/util/SequencedMap.java line 296:
>>
>>> 294: return view().hashCode();
>>> 295: }
>>> 296: public void addFirst(K k) { throw new
>>> UnsupportedOperationException();
On Mon, 2 Jun 2025 20:41:41 GMT, Joe Darcy wrote:
>> Stuart Marks has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Tweak nsee() declaration; adjust specs per suggestion; update copyrights.
>
> src/java.base/share/classes/java/util/Sequenc
On Sat, 31 May 2025 00:47:16 GMT, Stuart Marks wrote:
>> For a full explanation, see the bug report
>> [JDK-8358015](https://bugs.openjdk.org/browse/JDK-8358015).
>>
>> This PR includes three related changes:
>> * New overrides in SequencedMap view collection implementations, which
>> improve
On Sat, 31 May 2025 00:47:16 GMT, Stuart Marks wrote:
>> For a full explanation, see the bug report
>> [JDK-8358015](https://bugs.openjdk.org/browse/JDK-8358015).
>>
>> This PR includes three related changes:
>> * New overrides in SequencedMap view collection implementations, which
>> improve
On Sat, 31 May 2025 00:47:16 GMT, Stuart Marks wrote:
>> For a full explanation, see the bug report
>> [JDK-8358015](https://bugs.openjdk.org/browse/JDK-8358015).
>>
>> This PR includes three related changes:
>> * New overrides in SequencedMap view collection implementations, which
>> improve
> For a full explanation, see the bug report
> [JDK-8358015](https://bugs.openjdk.org/browse/JDK-8358015).
>
> This PR includes three related changes:
> * New overrides in SequencedMap view collection implementations, which
> improve their behavior.
> * Update to `@implSpec` clauses to reflect t
On Fri, 30 May 2025 14:38:19 GMT, Jaikiran Pai wrote:
>> Overall this looks good to me. I just have a small question about the newly
>> introduced text.
>>
>> The copyright years on BasicMap.java and SequencedMap.java will need a
>> update before integrating.
>
>> I just have a small question
On Fri, 30 May 2025 14:33:05 GMT, Jaikiran Pai wrote:
>> For a full explanation, see the bug report
>> [JDK-8358015](https://bugs.openjdk.org/browse/JDK-8358015).
>>
>> This PR includes three related changes:
>> * New overrides in SequencedMap view collection implementations, which
>> improve
On Thu, 29 May 2025 19:44:20 GMT, ExE Boss wrote:
>> For a full explanation, see the bug report
>> [JDK-8358015](https://bugs.openjdk.org/browse/JDK-8358015).
>>
>> This PR includes three related changes:
>> * New overrides in SequencedMap view collection implementations, which
>> improve thei
On Fri, 30 May 2025 02:33:27 GMT, Chen Liang wrote:
>> For a full explanation, see the bug report
>> [JDK-8358015](https://bugs.openjdk.org/browse/JDK-8358015).
>>
>> This PR includes three related changes:
>> * New overrides in SequencedMap view collection implementations, which
>> improve th
On Fri, 30 May 2025 14:35:00 GMT, Jaikiran Pai wrote:
> I just have a small question about the newly introduced text.
I just realized one other thing - the updated BasicMap.java fixes an issue in
an existing test. Do we already have tests that might cover the new proposed
semantics of these me
On Thu, 29 May 2025 00:21:35 GMT, Stuart Marks wrote:
> For a full explanation, see the bug report
> [JDK-8358015](https://bugs.openjdk.org/browse/JDK-8358015).
>
> This PR includes three related changes:
> * New overrides in SequencedMap view collection implementations, which
> improve their
On Thu, 29 May 2025 00:21:35 GMT, Stuart Marks wrote:
> For a full explanation, see the bug report
> [JDK-8358015](https://bugs.openjdk.org/browse/JDK-8358015).
>
> This PR includes three related changes:
> * New overrides in SequencedMap view collection implementations, which
> improve their
On Thu, 29 May 2025 00:21:35 GMT, Stuart Marks wrote:
> For a full explanation, see the bug report
> [JDK-8358015](https://bugs.openjdk.org/browse/JDK-8358015).
>
> This PR includes three related changes:
> * New overrides in SequencedMap view collection implementations, which
> improve their
For a full explanation, see the bug report
[JDK-8358015](https://bugs.openjdk.org/browse/JDK-8358015).
This PR includes three related changes:
* New overrides in SequencedMap view collection implementations, which improve
their behavior.
* Update to `@implSpec` clauses to reflect this behavior (
20 matches
Mail list logo
